treewide: cleanup unreachable breaks
Subsystems (100)
RFC 1/1 treewide: cleanup unreachable breaks
From: Tom Rix <[email protected]>
This is a upcoming change to clean up a new warning treewide.
I am wondering if the change could be one mega patch (see below) or normal patch per file about 100 patches or somewhere half way by collecting early acks.
clang has a number of useful, new warnings see
https://clang.llvm.org/docs/DiagnosticsReference.html
This change cleans up -Wunreachable-code-break
https://clang.llvm.org/docs/DiagnosticsReference.html#wunreachable-code-break
for 266 of 485 warnings in this week's linux-next, allyesconfig on x86_64.
The method of fixing was to look for warnings where the preceding statement was a simple statement and by inspection made the subsequent break unneeded. In order of frequency these look like
return and break
switch (c->x86_vendor) {
case X86_VENDOR_INTEL:
intel_p5_mcheck_init(c);
return 1;
- break;
goto and break
default:
operation = 0; /* make gcc happy */ goto fail_response;
- break;
break and break
case COLOR_SPACE_SRGB:
/* by pass */ REG_SET(OUTPUT_CSC_CONTROL, 0,
OUTPUT_CSC_GRPH_MODE, 0);
break;
- break;
The exception to the simple statement, is a switch case with a block and the end of block is a return
struct obj_buffer *buff = r->ptr; return scnprintf(str, PRIV_STR_SIZE,
"size=%u\naddr=0x%X\n", buff->size, buff->addr);
}
- break;
Not considered obvious and excluded, breaks after
multi level switches
complicated if-else if-else blockspanic() or similar calls
And there is an odd addition of a 'fallthrough' in drivers/tty/nozomi.c
Tom
---
arch/x86/kernel/cpu/mce/core.c +0 -2
@@ -1809,15 +1809,13 @@ static int __mcheck_cpu_ancient_init(struct cpuinfo_x86 *c)switch (c->x86_vendor) {case X86_VENDOR_INTEL :intel_p5_mcheck_init (c);return 1 ; -break ;case X86_VENDOR_CENTAUR :winchip_mcheck_init (c);return 1 ; -break ;default :return 0 ; }return 0 ;
arch/x86/kernel/cpu/microcode/amd.c +0 -1
@@ -213,11 +213,10 @@ static unsigned int __verify_patch_size(u8 family, u32 sh_psize, size_t buf_size max_size =F14H_MPB_MAX_SIZE ;break ;default :WARN (1 ,"%s: WTF family: 0x%x\n" , __func__, family);return 0 ; -break ; }if (sh_psize >min_t (u32, buf_size, max_size))return 0 ;
drivers/acpi/utils.c +0 -4
@@ -102,11 +102,10 @@ acpi_extract_package(union acpi_object *package, printk(KERN_WARNING PREFIX "Invalid package element"" [%d]: got number, expecting" " [%c]\n" , i, format_string[i]);return AE_BAD_DATA ; -break ; }break ;case ACPI_TYPE_STRING :case ACPI_TYPE_BUFFER :
@@ -127,11 +126,10 @@ acpi_extract_package(union acpi_object *package, printk(KERN_WARNING PREFIX "Invalid package element"" [%d] got string/buffer," " expecting [%c]\n" , i, format_string[i]);return AE_BAD_DATA ; -break ; }break ;case ACPI_TYPE_LOCAL_REFERENCE :switch (format_string[i]) {case 'R' :
@@ -142,22 +140,20 @@ acpi_extract_package(union acpi_object *package, printk(KERN_WARNING PREFIX "Invalid package element"" [%d] got reference," " expecting [%c]\n" , i, format_string[i]);return AE_BAD_DATA ; -break ; }break ;case ACPI_TYPE_PACKAGE :default :ACPI_DEBUG_PRINT ((ACPI_DB_INFO ,"Found unsupported element at index=%d\n" , i));/* TBD: handle nested packages... */ return AE_SUPPORT ; -break ; } }/* * Validate output buffer.
drivers/base/power/main.c +0 -1
@@ -361,11 +361,10 @@ static pm_callback_t pm_op(const struct dev_pm_ops *ops, pm_message_t state)case PM_EVENT_HIBERNATE :return ops->poweroff;case PM_EVENT_THAW :case PM_EVENT_RECOVER :return ops->thaw; -break ;case PM_EVENT_RESTORE :return ops->restore;#endif /* CONFIG_HIBERNATE_CALLBACKS */ }
drivers/block/xen-blkback/blkback.c +0 -1
@@ -1267,11 +1267,10 @@ static int dispatch_rw_block_io(struct xen_blkif_ring *ring, operation_flags =REQ_PREFLUSH ;break ;default : operation =0 ;/* make gcc happy */ goto fail_response; -break ; }/* Check that the number of segments is sane. */ nseg = req->operation ==BLKIF_OP_INDIRECT ? req->u.indirect.nr_segments : req->u.rw.nr_segments;
drivers/char/ipmi/ipmi_devintf.c +0 -1
@@ -488,11 +488,10 @@ static long ipmi_ioctl(struct file *file, rv = -EFAULT ;break ; }return ipmi_set_my_address (priv->user, val.channel, val.value); -break ; }case IPMICTL_GET_MY_CHANNEL_ADDRESS_CMD : {struct ipmi_channel_lun_address_set val;
drivers/char/lp.c +0 -1
@@ -620,11 +620,10 @@ static int lp_do_ioctl(unsigned int minor, unsigned int cmd,case LPWAIT :LP_WAIT (minor) = arg;break ;case LPSETIRQ :return -EINVAL ; -break ;case LPGETIRQ :if (copy_to_user (argp, &LP_IRQ (minor),sizeof (int )))return -EFAULT ;break ;
drivers/char/mwave/mwavedd.c +0 -1
@@ -401,11 +401,10 @@ static long mwave_ioctl(struct file *file, unsigned int iocmd, }break ;default :return -ENOTTY ; -break ; }/* switch */ PRINTK_2 (TRACE_MWAVE ,"mwavedd::mwave_ioctl, exit retval %x\n" , retval);return retval;
drivers/crypto/atmel-sha.c +0 -1
@@ -457,11 +457,10 @@ static int atmel_sha_init(struct ahash_request *req) ctx->flags |=SHA_FLAGS_SHA512 ; ctx->block_size =SHA512_BLOCK_SIZE ;break ;default :return -EINVAL ; -break ; } ctx->bufcnt =0 ; ctx->digcnt[0 ] =0 ; ctx->digcnt[1 ] =0 ;
drivers/edac/amd64_edac.c +0 -8
@@ -2459,38 +2459,30 @@ static int map_err_sym_to_channel(int err_sym, int sym_size)if (sym_size ==4 )switch (err_sym) {case 0x20 :case 0x21 :return 0 ; -break ;case 0x22 :case 0x23 :return 1 ; -break ;default :return err_sym >>4 ; -break ; }/* x8 symbols */ else switch (err_sym) {/* imaginary bits not in a DIMM */ case 0x10 :WARN (1 ,KERN_ERR "Invalid error symbol: 0x%x\n" , err_sym);return -1 ; -break ; -case 0x11 :return 0 ; -break ;case 0x12 :return 1 ; -break ;default :return err_sym >>3 ; -break ; }return -1 ; }static int get_channel_from_ecc_syndrome (struct mem_ctl_info *mci,u16 syndrome)
drivers/gpio/gpio-bd70528.c +0 -3
@@ -69,21 +69,18 @@ static int bd70528_gpio_set_config(struct gpio_chip *chip, unsigned int offset,case PIN_CONFIG_DRIVE_OPEN_DRAIN :return regmap_update_bits (bdgpio->chip.regmap,GPIO_OUT_REG (offset),BD70528_GPIO_DRIVE_MASK ,BD70528_GPIO_OPEN_DRAIN ); -break ;case PIN_CONFIG_DRIVE_PUSH_PULL :return regmap_update_bits (bdgpio->chip.regmap,GPIO_OUT_REG (offset),BD70528_GPIO_DRIVE_MASK ,BD70528_GPIO_PUSH_PULL ); -break ;case PIN_CONFIG_INPUT_DEBOUNCE :return bd70528_set_debounce (bdgpio, offset,pinconf_to_config_argument (config)); -break ;default :break ; }return -ENOTSUPP ; }
drivers/gpu/drm/amd/display/dc/dce/dce_transform.c +0 -1
@@ -1328,11 +1328,10 @@ static bool configure_graphics_mode(case COLOR_SPACE_SRGB :/* by pass */ REG_SET (OUTPUT_CSC_CONTROL ,0 ,OUTPUT_CSC_GRPH_MODE ,0 );break ; -break ;case COLOR_SPACE_SRGB_LIMITED :/* TV RGB */ REG_SET (OUTPUT_CSC_CONTROL ,0 ,OUTPUT_CSC_GRPH_MODE ,1 );break ;
drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c +0 -7
@@ -416,29 +416,22 @@ static int map_transmitter_id_to_phy_instance( enum transmitter transmitter) {switch (transmitter) {case TRANSMITTER_UNIPHY_A :return 0 ; -break ;case TRANSMITTER_UNIPHY_B :return 1 ; -break ;case TRANSMITTER_UNIPHY_C :return 2 ; -break ;case TRANSMITTER_UNIPHY_D :return 3 ; -break ;case TRANSMITTER_UNIPHY_E :return 4 ; -break ;case TRANSMITTER_UNIPHY_F :return 5 ; -break ;case TRANSMITTER_UNIPHY_G :return 6 ; -break ;default :ASSERT (0 );return 0 ; } }
drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c +0 -7
@@ -469,29 +469,22 @@ static int map_transmitter_id_to_phy_instance( enum transmitter transmitter) {switch (transmitter) {case TRANSMITTER_UNIPHY_A :return 0 ; -break ;case TRANSMITTER_UNIPHY_B :return 1 ; -break ;case TRANSMITTER_UNIPHY_C :return 2 ; -break ;case TRANSMITTER_UNIPHY_D :return 3 ; -break ;case TRANSMITTER_UNIPHY_E :return 4 ; -break ;case TRANSMITTER_UNIPHY_F :return 5 ; -break ;case TRANSMITTER_UNIPHY_G :return 6 ; -break ;default :ASSERT (0 );return 0 ; } }
drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c +0 -7
@@ -444,29 +444,22 @@ static int map_transmitter_id_to_phy_instance( enum transmitter transmitter) {switch (transmitter) {case TRANSMITTER_UNIPHY_A :return 0 ; -break ;case TRANSMITTER_UNIPHY_B :return 1 ; -break ;case TRANSMITTER_UNIPHY_C :return 2 ; -break ;case TRANSMITTER_UNIPHY_D :return 3 ; -break ;case TRANSMITTER_UNIPHY_E :return 4 ; -break ;case TRANSMITTER_UNIPHY_F :return 5 ; -break ;case TRANSMITTER_UNIPHY_G :return 6 ; -break ;default :ASSERT (0 );return 0 ; } }
drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +0 -7
@@ -381,29 +381,22 @@ static int map_transmitter_id_to_phy_instance( enum transmitter transmitter) {switch (transmitter) {case TRANSMITTER_UNIPHY_A :return 0 ; -break ;case TRANSMITTER_UNIPHY_B :return 1 ; -break ;case TRANSMITTER_UNIPHY_C :return 2 ; -break ;case TRANSMITTER_UNIPHY_D :return 3 ; -break ;case TRANSMITTER_UNIPHY_E :return 4 ; -break ;case TRANSMITTER_UNIPHY_F :return 5 ; -break ;case TRANSMITTER_UNIPHY_G :return 6 ; -break ;default :ASSERT (0 );return 0 ; } }
drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c +0 -7
@@ -451,29 +451,22 @@ static int map_transmitter_id_to_phy_instance( enum transmitter transmitter) {switch (transmitter) {case TRANSMITTER_UNIPHY_A :return 0 ; -break ;case TRANSMITTER_UNIPHY_B :return 1 ; -break ;case TRANSMITTER_UNIPHY_C :return 2 ; -break ;case TRANSMITTER_UNIPHY_D :return 3 ; -break ;case TRANSMITTER_UNIPHY_E :return 4 ; -break ;case TRANSMITTER_UNIPHY_F :return 5 ; -break ;case TRANSMITTER_UNIPHY_G :return 6 ; -break ;default :ASSERT (0 );return 0 ; } }
drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c +0 -7
@@ -456,29 +456,22 @@ static int map_transmitter_id_to_phy_instance( enum transmitter transmitter) {switch (transmitter) {case TRANSMITTER_UNIPHY_A :return 0 ; -break ;case TRANSMITTER_UNIPHY_B :return 1 ; -break ;case TRANSMITTER_UNIPHY_C :return 2 ; -break ;case TRANSMITTER_UNIPHY_D :return 3 ; -break ;case TRANSMITTER_UNIPHY_E :return 4 ; -break ;case TRANSMITTER_UNIPHY_F :return 5 ; -break ;case TRANSMITTER_UNIPHY_G :return 6 ; -break ;default :ASSERT (0 );return 0 ; } }
drivers/gpu/drm/mgag200/mgag200_mode.c +0 -5
@@ -792,25 +792,20 @@ static int mgag200_crtc_set_plls(struct mga_device *mdev, long clock)case G200_AGP :return mgag200_g200_set_plls (mdev, clock);case G200_SE_A :case G200_SE_B :return mga_g200se_set_plls (mdev, clock); -break ;case G200_WB :case G200_EW3 :return mga_g200wb_set_plls (mdev, clock); -break ;case G200_EV :return mga_g200ev_set_plls (mdev, clock); -break ;case G200_EH :case G200_EH3 :return mga_g200eh_set_plls (mdev, clock); -break ;case G200_ER :return mga_g200er_set_plls (mdev, clock); -break ; } misc =RREG8 (MGA_MISC_IN ); misc &= ~MGAREG_MISC_CLK_SEL_MASK ; misc |=MGAREG_MISC_CLK_SEL_MGA_MSK ;
drivers/gpu/drm/nouveau/nvkm/subdev/bios/pll.c +0 -1
@@ -121,11 +121,10 @@ pll_map(struct nvkm_bios *bios)case NV_10 :case NV_11 :case NV_20 :case NV_30 :return nv04_pll_mapping; -break ;case NV_40 :return nv40_pll_mapping;case NV_50 :if (device->chipset ==0x50 )return nv50_pll_mapping;
drivers/gpu/drm/nouveau/nvkm/subdev/clk/mcp77.c +0 -3
@@ -138,21 +138,18 @@ mcp77_clk_read(struct nvkm_clk *base, enum nv_clk_src src)case 0x00000030 :return read_pll (clk,0x004020 ) >>P ; }break ;case nv_clk_src_mem:return 0 ; -break ;case nv_clk_src_vdec:P = (read_div (clk) &0x00000700 ) >>8 ;switch (mast &0x00400000 ) {case 0x00400000 :return nvkm_clk_read (&clk->base, nv_clk_src_core) >>P ; -break ;default :return 500000 >>P ; -break ; }break ;default :break ; }
drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramnv50.c +0 -1
@@ -169,11 +169,10 @@ nv50_ram_timing_read(struct nv50_ram *ram, u32 *timing)case NVKM_RAM_TYPE_GDDR3 :T (CWL ) = ((timing[2 ] &0xff000000 ) >>24 ) +1 ;break ;default :return -ENOSYS ; -break ; }T (WR ) = ((timing[1 ] >>24 ) &0xff ) -1 -T (CWL );return 0 ;
drivers/gpu/drm/nouveau/nvkm/subdev/top/gk104.c +0 -1
@@ -88,11 +88,10 @@ gk104_top_oneinit(struct nvkm_top *top)case 0x0000000e :B_ (NVENC );break ;case 0x0000000f :A_ (NVENC1 );break ;case 0x00000010 :B_ (NVDEC );break ;case 0x00000013 :B_ (CE );break ;case 0x00000014 :C_ (GSP );break ; -break ;default :break ; } nvkm_debug(subdev, "%02x.%d (%8s): addr %06x fault %2d "
drivers/gpu/drm/qxl/qxl_ioctl.c +0 -1
@@ -158,11 +158,10 @@ static int qxl_process_single_command(struct qxl_device *qdev,case QXL_CMD_SURFACE :case QXL_CMD_CURSOR :default :DRM_DEBUG ("Only draw commands in execbuffers\n" );return -EINVAL ; -break ; }if (cmd->command_size >PAGE_SIZE -sizeof (union qxl_release_info ))return -EINVAL ;
drivers/iio/adc/meson_saradc.c +0 -2
@@ -591,17 +591,15 @@ static int meson_sar_adc_iio_info_read_raw(struct iio_dev *indio_dev,switch (mask) {case IIO_CHAN_INFO_RAW :return meson_sar_adc_get_sample (indio_dev, chan,NO_AVERAGING ,ONE_SAMPLE , val); -break ;case IIO_CHAN_INFO_AVERAGE_RAW :return meson_sar_adc_get_sample (indio_dev, chan,MEAN_AVERAGING ,EIGHT_SAMPLES , val); -break ;case IIO_CHAN_INFO_SCALE :if (chan->type ==IIO_VOLTAGE ) { ret =regulator_get_voltage (priv->vref);if (ret <0 ) {
drivers/iio/imu/bmi160/bmi160_core.c +0 -1
@@ -484,11 +484,10 @@ static int bmi160_write_raw(struct iio_dev *indio_dev,switch (mask) {case IIO_CHAN_INFO_SCALE :return bmi160_set_scale (data,bmi160_to_sensor (chan->type), val2); -break ;case IIO_CHAN_INFO_SAMP_FREQ :return bmi160_set_odr (data,bmi160_to_sensor (chan->type), val, val2);default :return -EINVAL ;
drivers/ipack/devices/ipoctal.c +0 -1
@@ -542,11 +542,10 @@ static void ipoctal_set_termios(struct tty_struct *tty, mr1 |= MR1_RxRTS_CONTROL_OFF; mr2 |= MR2_TxRTS_CONTROL_ON |MR2_CTS_ENABLE_TX_OFF ;break ;default :return ; -break ; } baud =tty_get_baud_rate (tty);tty_termios_encode_baud_rate (&tty->termios, baud, baud);
drivers/media/dvb-frontends/drx39xyj/drxj.c +0 -7
@@ -2323,11 +2323,10 @@ hi_command(struct i2c_device_addr *dev_addr, const struct drxj_hi_cmd *cmd, u16/* No parameters */ break ;default :return -EINVAL ; -break ; }/* Write command */ rc =drxj_dap_write_reg16 (dev_addr,SIO_HI_RA_RAM_CMD__A , cmd->cmd,0 );if (rc !=0 ) {
@@ -3592,11 +3591,10 @@ static int ctrl_set_uio_cfg(struct drx_demod_instance *demod, struct drxuio_cfg goto rw_error; }break ;default :return -EINVAL ; -break ; }/* switch ( uio_cfg->mode ) */ break ;/*====================================================================*/ case DRX_UIO3 :/* DRX_UIO3: GPIO UIO-3 */
@@ -3616,11 +3614,10 @@ static int ctrl_set_uio_cfg(struct drx_demod_instance *demod, struct drxuio_cfg goto rw_error; }break ;default :return -EINVAL ; -break ; }/* switch ( uio_cfg->mode ) */ break ;/*====================================================================*/ case DRX_UIO4 :/* DRX_UIO4: IRQN UIO-4 */
@@ -3640,11 +3637,10 @@ static int ctrl_set_uio_cfg(struct drx_demod_instance *demod, struct drxuio_cfg ext_attr->uio_irqn_mode = uio_cfg->mode;break ;case DRX_UIO_MODE_FIRMWARE0 :default :return -EINVAL ; -break ; }/* switch ( uio_cfg->mode ) */ break ;/*====================================================================*/ default :return -EINVAL ;
@@ -10951,11 +10947,10 @@ ctrl_set_standard(struct drx_demod_instance *demod, enum drx_standard *standard) }break ;default : ext_attr->standard =DRX_STANDARD_UNKNOWN ;return -EINVAL ; -break ; }return 0 ; rw_error:/* Don't know what the standard is now ... try again */
@@ -11072,11 +11067,10 @@ ctrl_power_mode(struct drx_demod_instance *demod, enum drx_power_mode *mode) sio_cc_pwd_mode =SIO_CC_PWD_MODE_LEVEL_OSC ;break ;default :/* Unknow sleep mode */ return -EINVAL ; -break ; }/* Check if device needs to be powered up */ if ((common_attr->current_power_mode !=DRX_POWER_UP )) { rc =power_up_device (demod);
@@ -11894,11 +11888,10 @@ static int drx_ctrl_u_code(struct drx_demod_instance *demod, }break ; }default :return -EINVAL ; -break ; } mc_data += mc_block_nr_bytes; }
drivers/media/dvb-frontends/drxd_hard.c +0 -1
@@ -1620,11 +1620,10 @@ static int CorrectSysClockDeviation(struct drxd_state *state)case 6000000 : bandwidth =DRXD_BANDWIDTH_6MHZ_IN_HZ ;break ;default :return -1 ; -break ; }/* Compute new sysclock value sysClockFreq = (((incr + 2^23)*bandwidth)/2^21)/1000 */ incr += (1 <<23 );
drivers/media/dvb-frontends/nxt200x.c +0 -16
@@ -166,11 +166,10 @@ static int nxt200x_writereg_multibyte (struct nxt200x_state* state, u8 reg, u8* len2 = ((attr <<4 ) |0x10 ) | len; buf =0x80 ;break ;default :return -EINVAL ; -break ; }/* set multi register length */ nxt200x_writebytes (state,0x34 , &len2,1 );
@@ -188,11 +187,10 @@ static int nxt200x_writereg_multibyte (struct nxt200x_state* state, u8 reg, u8*if (buf ==0 )return 0 ;break ;default :return -EINVAL ; -break ; }pr_warn ("Error writing multireg register 0x%02X\n" , reg);return 0 ;
@@ -214,11 +212,10 @@ static int nxt200x_readreg_multibyte (struct nxt200x_state* state, u8 reg, u8* dnxt200x_writebytes (state,0x34 , &len2,1 );/* read the actual data */ nxt200x_readbytes (state, reg, data, len);return 0 ; -break ;case NXT2004 :/* probably not right, but gives correct values */ attr =0x02 ;if (reg &0x80 ) { attr = attr <<1 ;
@@ -237,14 +234,12 @@ static int nxt200x_readreg_multibyte (struct nxt200x_state* state, u8 reg, u8* d/* read the actual data */ for (i =0 ; i < len; i++) {nxt200x_readbytes (state,0x36 + i, &data[i],1 ); }return 0 ; -break ;default :return -EINVAL ; -break ; } }static void nxt200x_microcontroller_stop (struct nxt200x_state * state) {
@@ -372,11 +367,10 @@ static int nxt200x_writetuner (struct nxt200x_state* state, u8* data) }pr_warn ("timeout error writing to tuner\n" );break ;default :return -EINVAL ; -break ; }return 0 ; }static void nxt200x_agc_reset (struct nxt200x_state * state)
@@ -553,11 +547,10 @@ static int nxt200x_setup_frontend_parameters(struct dvb_frontend *fe)if (state->config->set_ts_params) state->config->set_ts_params (fe,0 );break ;default :return -EINVAL ; -break ; }if (fe->ops.tuner_ops.calc_regs) {/* get tuning information */ fe->ops.tuner_ops.calc_regs (fe, buf,5 );
@@ -578,11 +571,10 @@ static int nxt200x_setup_frontend_parameters(struct dvb_frontend *fe)case VSB_8 : buf[0 ] =0x70 ;break ;default :return -EINVAL ; -break ; }nxt200x_writebytes (state,0x42 , buf,1 );/* configure sdm */ switch (state->demod_chip) {
@@ -592,11 +584,10 @@ static int nxt200x_setup_frontend_parameters(struct dvb_frontend *fe)case NXT2004 : buf[0 ] =0x07 ;break ;default :return -EINVAL ; -break ; }nxt200x_writebytes (state,0x57 , buf,1 );/* write sdm1 input */ buf[0 ] =0x10 ;
@@ -608,11 +599,10 @@ static int nxt200x_setup_frontend_parameters(struct dvb_frontend *fe)case NXT2004 :nxt200x_writebytes (state,0x58 , buf,2 );break ;default :return -EINVAL ; -break ; }/* write sdmx input */ switch (p->modulation) {case QAM_64 :
@@ -624,11 +614,10 @@ static int nxt200x_setup_frontend_parameters(struct dvb_frontend *fe)case VSB_8 : buf[0 ] =0x60 ;break ;default :return -EINVAL ; -break ; } buf[1 ] =0x00 ;switch (state->demod_chip) {case NXT2002 :nxt200x_writereg_multibyte (state,0x5C , buf,2 );
@@ -636,11 +625,10 @@ static int nxt200x_setup_frontend_parameters(struct dvb_frontend *fe)case NXT2004 :nxt200x_writebytes (state,0x5C , buf,2 );break ;default :return -EINVAL ; -break ; }/* write adc power lpf fc */ buf[0 ] =0x05 ;nxt200x_writebytes (state,0x43 , buf,1 );
@@ -662,11 +650,10 @@ static int nxt200x_setup_frontend_parameters(struct dvb_frontend *fe)case NXT2004 :nxt200x_writebytes (state,0x4B , buf,2 );break ;default :return -EINVAL ; -break ; }/* write kg1 */ buf[0 ] =0x00 ;nxt200x_writebytes (state,0x4D , buf,1 );
@@ -718,11 +705,10 @@ static int nxt200x_setup_frontend_parameters(struct dvb_frontend *fe)case VSB_8 : buf[0 ] =0x00 ;break ;default :return -EINVAL ; -break ; }nxt200x_writebytes (state,0x30 , buf,1 );/* write agc control reg */ buf[0 ] =0x00 ;
@@ -740,11 +726,10 @@ static int nxt200x_setup_frontend_parameters(struct dvb_frontend *fe)nxt200x_writebytes (state,0x49 , buf,2 );nxt200x_writebytes (state,0x4B , buf,2 );break ;default :return -EINVAL ; -break ; }/* write agc control reg */ buf[0 ] =0x04 ;nxt200x_writebytes (state,0x41 , buf,1 );
@@ -1112,11 +1097,10 @@ static int nxt200x_init(struct dvb_frontend* fe)case NXT2004 : ret =nxt2004_init (fe);break ;default :return -EINVAL ; -break ; } state->initialised =1 ; }return ret; }
drivers/media/dvb-frontends/si21xx.c +0 -2
@@ -462,14 +462,12 @@ static int si21xx_set_voltage(struct dvb_frontend *fe, enum fe_sec_voltage volt) val = (0x80 |si21_readreg (state,LNB_CTRL_REG_1 ));switch (volt) {case SEC_VOLTAGE_18 :return si21_writereg (state,LNB_CTRL_REG_1 , val |0x40 ); -break ;case SEC_VOLTAGE_13 :return si21_writereg (state,LNB_CTRL_REG_1 , (val & ~0x40 )); -break ;default :return -EINVAL ; } }
drivers/media/tuners/mt2063.c +0 -1
@@ -1847,11 +1847,10 @@ static int mt2063_init(struct dvb_frontend *fe) def = MT2063B0_defaults;break ;default :return -ENODEV ; -break ; }while (status >=0 && *def) {u8 reg = *def++;u8 val = *def++;
drivers/message/fusion/mptbase.c +0 -1
@@ -471,11 +471,10 @@ mpt_turbo_reply(MPT_ADAPTER *ioc, u32 pa) req_idx = pa &0x0000FFFF ; mf =MPT_INDEX_2_MFPTR (ioc, req_idx);mpt_free_msg_frame (ioc, mf);mb ();return ; -break ; } mr = (MPT_FRAME_HDR *)CAST_U32_TO_PTR (pa);break ;case MPI_CONTEXT_REPLY_TYPE_SCSI_TARGET : cb_idx =mpt_get_cb_idx (MPTSTM_DRIVER );
drivers/misc/mei/hbm.c +0 -1
@@ -1375,11 +1375,10 @@ int mei_hbm_dispatch(struct mei_device *dev, struct mei_msg_hdr *hdr) dev->dev_state =MEI_DEV_POWER_DOWN ;dev_info (dev->dev,"hbm: stop response: resetting.\n" );/* force the reset */ return -EPROTO ; -break ;case CLIENT_DISCONNECT_REQ_CMD :dev_dbg (dev->dev,"hbm: disconnect request: message received\n" ); disconnect_req = (struct hbm_client_connect_request *)mei_msg;
drivers/mtd/mtdchar.c +0 -2
@@ -879,21 +879,19 @@ static int mtdchar_ioctl(struct file *file, u_int cmd, u_long arg)loff_t offs;if (copy_from_user (&offs, argp,sizeof (loff_t)))return -EFAULT ;return mtd_block_isbad (mtd, offs); -break ; }case MEMSETBADBLOCK : {loff_t offs;if (copy_from_user (&offs, argp,sizeof (loff_t)))return -EFAULT ;return mtd_block_markbad (mtd, offs); -break ; }case OTPSELECT : {int mode;
drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c +11 -11
@@ -73,15 +73,15 @@ static const struct can_bittiming_const mcp251xfd_data_bittiming_const = {static const char *__mcp251xfd_get_model_str (enum mcp251xfd_model model) {switch (model) {case MCP251XFD_MODEL_MCP2517FD : -return "MCP2517FD" ;break ; +return "MCP2517FD" ;case MCP251XFD_MODEL_MCP2518FD : -return "MCP2518FD" ;break ; +return "MCP2518FD" ;case MCP251XFD_MODEL_MCP251XFD : -return "MCP251xFD" ;break ; +return "MCP251xFD" ; }return "<unknown>" ; }
@@ -93,25 +93,25 @@ mcp251xfd_get_model_str(const struct mcp251xfd_priv *priv)static const char *mcp251xfd_get_mode_str (const u8 mode) {switch (mode) {case MCP251XFD_REG_CON_MODE_MIXED : -return "Mixed (CAN FD/CAN 2.0)" ;break ; +return "Mixed (CAN FD/CAN 2.0)" ;case MCP251XFD_REG_CON_MODE_SLEEP : -return "Sleep" ;break ; +return "Sleep" ;case MCP251XFD_REG_CON_MODE_INT_LOOPBACK : -return "Internal Loopback" ;break ; +return "Internal Loopback" ;case MCP251XFD_REG_CON_MODE_LISTENONLY : -return "Listen Only" ;break ; +return "Listen Only" ;case MCP251XFD_REG_CON_MODE_CONFIG : -return "Configuration" ;break ; +return "Configuration" ;case MCP251XFD_REG_CON_MODE_EXT_LOOPBACK : -return "External Loopback" ;break ; +return "External Loopback" ;case MCP251XFD_REG_CON_MODE_CAN2_0 : -return "CAN 2.0" ;break ; +return "CAN 2.0" ;case MCP251XFD_REG_CON_MODE_RESTRICTED : -return "Restricted Operation" ;break ; +return "Restricted Operation" ; }return "<unknown>" ; }
drivers/net/ethernet/aquantia/atlantic/aq_nic.c +0 -1
@@ -1161,11 +1161,10 @@ int aq_nic_set_link_ksettings(struct aq_nic_s *self,break ;default : err =-1 ; goto err_exit; -break ; }if (!(self->aq_nic_cfg.aq_hw_caps->link_speed_msk & rate)) { err =-1 ; goto err_exit; }
drivers/net/ethernet/cisco/enic/enic_ethtool.c +0 -1
@@ -432,11 +432,10 @@ static int enic_grxclsrule(struct enic *enic, struct ethtool_rxnfc *cmd)case IPPROTO_UDP : fsp->flow_type =UDP_V4_FLOW ;break ;default :return -EINVAL ; -break ; } fsp->h_u.tcp_ip4_spec.ip4src =flow_get_u32_src (&n->keys); fsp->m_u.tcp_ip4_spec.ip4src = (__u32 )~0 ;
drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c +0 -1
@@ -348,11 +348,10 @@ static s32 ixgbe_calc_eeprom_checksum_X540(struct ixgbe_hw *hw)continue ;if (ixgbe_read_eerd_generic (hw, pointer, &length)) {hw_dbg (hw,"EEPROM read failed\n" );return IXGBE_ERR_EEPROM ; -break ; }/* Skip pointer section if length is invalid. */ if (length ==0xFFFF || length ==0 || (pointer + length) >= hw->eeprom.word_size)
drivers/net/wan/lmc/lmc_proto.c +0 -4
@@ -87,21 +87,17 @@ void lmc_proto_close(lmc_softc_t *sc)__be16 lmc_proto_type (lmc_softc_t *sc,struct sk_buff *skb)/*FOLD00*/ {switch (sc->if_type){case LMC_PPP :return hdlc_type_trans (skb, sc->lmc_device); -break ;case LMC_NET :return htons (ETH_P_802_2 ); -break ;case LMC_RAW :/* Packet type for skbuff kind of useless */ return htons (ETH_P_802_2 ); -break ;default :printk (KERN_WARNING "%s: No protocol set for this interface, assuming 802.2 (which is wrong!!)\n" , sc->name);return htons (ETH_P_802_2 ); -break ; } }void lmc_proto_netif (lmc_softc_t *sc,struct sk_buff *skb)/*FOLD00*/ {
drivers/net/wireless/ath/ath10k/htt_rx.c +0 -1
@@ -3876,11 +3876,10 @@ bool ath10k_htt_t2h_msg_handler(struct ath10k *ar, struct sk_buff *skb)atomic_inc (&htt->num_mpdus_ready);return ath10k_htt_rx_proc_rx_frag_ind (htt, &resp->rx_frag_ind, skb); -break ; }case HTT_T2H_MSG_TYPE_TEST :break ;case HTT_T2H_MSG_TYPE_STATS_CONF :trace_ath10k_htt_stats (ar, skb->data, skb->len);
drivers/net/wireless/ath/ath6kl/testmode.c +0 -1
@@ -92,11 +92,10 @@ int ath6kl_tm_cmd(struct wiphy *wiphy, struct wireless_dev *wdev,ath6kl_wmi_test_cmd (ar->wmi, buf, buf_len);return 0 ; -break ;case ATH6KL_TM_CMD_RX_REPORT :default :return -EOPNOTSUPP ; } }
drivers/net/wireless/ath/ath9k/hw.c +0 -1
@@ -2306,11 +2306,10 @@ void ath9k_hw_beaconinit(struct ath_hw *ah, u32 next_beacon, u32 beacon_period)break ;default :ath_dbg (ath9k_hw_common (ah),BEACON ,"%s: unsupported opmode: %d\n" , __func__, ah->opmode);return ; -break ; }REG_WRITE (ah,AR_BEACON_PERIOD , beacon_period);REG_WRITE (ah,AR_DMA_BEACON_PERIOD , beacon_period);REG_WRITE (ah,AR_SWBA_PERIOD , beacon_period);
drivers/net/wireless/intel/iwlwifi/mvm/mac-ctxt.c +0 -2
@@ -1200,17 +1200,15 @@ static int iwl_mvm_mac_ctx_send(struct iwl_mvm *mvm, struct ieee80211_vif *vif,switch (vif->type) {case NL80211_IFTYPE_STATION :return iwl_mvm_mac_ctxt_cmd_sta (mvm, vif, action, force_assoc_off, bssid_override); -break ;case NL80211_IFTYPE_AP :if (!vif->p2p)return iwl_mvm_mac_ctxt_cmd_ap (mvm, vif, action);else return iwl_mvm_mac_ctxt_cmd_go (mvm, vif, action); -break ;case NL80211_IFTYPE_MONITOR :return iwl_mvm_mac_ctxt_cmd_listener (mvm, vif, action);case NL80211_IFTYPE_P2P_DEVICE :return iwl_mvm_mac_ctxt_cmd_p2p_device (mvm, vif, action);case NL80211_IFTYPE_ADHOC :
drivers/net/wireless/intersil/p54/eeprom.c +0 -1
@@ -868,11 +868,10 @@ int p54_parse_eeprom(struct ieee80211_hw *dev, void *eeprom, int len) err = -ENOMSG ; goto err; }else { goto good_eeprom; } -break ;default :break ; } crc16 =crc_ccitt (crc16, (u8 *)entry, (entry_len +1 ) *2 );
drivers/net/wireless/intersil/prism54/oid_mgt.c +0 -10
@@ -785,21 +785,19 @@ mgt_response_to_str(enum oid_num_t n, union oid_res_t *r, char *str)struct obj_buffer *buff = r->ptr;return scnprintf (str,PRIV_STR_SIZE ,"size=%u\naddr=0x%X\n" , buff->size, buff->addr); } -break ;case OID_TYPE_BSS :{struct obj_bss *bss = r->ptr;return scnprintf (str,PRIV_STR_SIZE ,"age=%u\nchannel=%u\n" "capinfo=0x%X\nrates=0x%X\n" "basic_rates=0x%X\n" , bss->age, bss->channel, bss->capinfo, bss->rates, bss->basic_rates); } -break ;case OID_TYPE_BSSLIST :{struct obj_bsslist *list = r->ptr;int i, k; k =scnprintf (str,PRIV_STR_SIZE ,"nr=%u\n" , list->nr);for (i =0 ; i < list->nr; i++)
@@ -812,53 +810,47 @@ mgt_response_to_str(enum oid_num_t n, union oid_res_t *r, char *str) list->bsslist[i].capinfo, list->bsslist[i].rates, list->bsslist[i].basic_rates);return k; } -break ;case OID_TYPE_FREQUENCIES :{struct obj_frequencies *freq = r->ptr;int i, t;printk ("nr : %u\n" , freq->nr); t =scnprintf (str,PRIV_STR_SIZE ,"nr=%u\n" , freq->nr);for (i =0 ; i < freq->nr; i++) t +=scnprintf (str + t,PRIV_STR_SIZE - t,"mhz[%u]=%u\n" , i, freq->mhz[i]);return t; } -break ;case OID_TYPE_MLME :{struct obj_mlme *mlme = r->ptr;return scnprintf (str,PRIV_STR_SIZE ,"id=0x%X\nstate=0x%X\ncode=0x%X\n" , mlme->id, mlme->state, mlme->code); } -break ;case OID_TYPE_MLMEEX :{struct obj_mlmeex *mlme = r->ptr;return scnprintf (str,PRIV_STR_SIZE ,"id=0x%X\nstate=0x%X\n" "code=0x%X\nsize=0x%X\n" , mlme->id, mlme->state, mlme->code, mlme->size); } -break ;case OID_TYPE_ATTACH :{struct obj_attachment *attach = r->ptr;return scnprintf (str,PRIV_STR_SIZE ,"id=%d\nsize=%d\n" , attach->id, attach->size); } -break ;case OID_TYPE_SSID :{struct obj_ssid *ssid = r->ptr;return scnprintf (str,PRIV_STR_SIZE ,"length=%u\noctets=%.*s\n" , ssid->length, ssid->length, ssid->octets); } -break ;case OID_TYPE_KEY :{struct obj_key *key = r->ptr;int t, i; t = scnprintf(str, PRIV_STR_SIZE, "type=0x%X\nlength=0x%X\nkey=0x",
@@ -867,11 +859,10 @@ mgt_response_to_str(enum oid_num_t n, union oid_res_t *r, char *str) t +=scnprintf (str + t,PRIV_STR_SIZE - t,"%02X:" , key->key[i]); t +=scnprintf (str + t,PRIV_STR_SIZE - t,"\n" );return t; } -break ;case OID_TYPE_RAW :case OID_TYPE_ADDR :{unsigned char *buff = r->ptr;int t, i; t =scnprintf (str,PRIV_STR_SIZE ,"hex data=" );
@@ -879,11 +870,10 @@ mgt_response_to_str(enum oid_num_t n, union oid_res_t *r, char *str) t +=scnprintf (str + t,PRIV_STR_SIZE - t,"%02X:" , buff[i]); t +=scnprintf (str + t,PRIV_STR_SIZE - t,"\n" );return t; } -break ;default :BUG (); }return 0 ; }
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c +0 -1
@@ -1224,11 +1224,10 @@ static int _rtl88ee_set_media_status(struct ieee80211_hw *hw, "Set Network type to AP!\n");break ;default :pr_err ("Network type %d not support!\n" , type);return 1 ; -break ; }/* MSR_INFRA == Link in infrastructure network; * MSR_ADHOC == Link in ad hoc network; * Therefore, check link state is necessary.
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c +0 -1
@@ -1130,11 +1130,10 @@ static int _rtl8723e_set_media_status(struct ieee80211_hw *hw, "Set Network type to AP!\n");break ;default :pr_err ("Network type %d not support!\n" , type);return 1 ; -break ; }/* MSR_INFRA == Link in infrastructure network; * MSR_ADHOC == Link in ad hoc network; * Therefore, check link state is necessary.
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c +0 -3
@@ -2083,16 +2083,14 @@ bool rtl8812ae_phy_config_rf_with_headerfile(struct ieee80211_hw *hw,switch (rfpath) {case RF90_PATH_A :return __rtl8821ae_phy_config_with_headerfile (hw, radioa_array_table_a, radioa_arraylen_a, _rtl8821ae_config_rf_radio_a); -break ;case RF90_PATH_B :return __rtl8821ae_phy_config_with_headerfile (hw, radioa_array_table_b, radioa_arraylen_b, _rtl8821ae_config_rf_radio_b); -break ;case RF90_PATH_C :case RF90_PATH_D :pr_err ("switch case %#x not processed\n" , rfpath);break ; }
@@ -2114,11 +2112,10 @@ bool rtl8821ae_phy_config_rf_with_headerfile(struct ieee80211_hw *hw,switch (rfpath) {case RF90_PATH_A :return __rtl8821ae_phy_config_with_headerfile (hw, radioa_array_table, radioa_arraylen, _rtl8821ae_config_rf_radio_a); -break ;case RF90_PATH_B :case RF90_PATH_C :case RF90_PATH_D :pr_err ("switch case %#x not processed\n" , rfpath);
drivers/nfc/st21nfca/core.c +0 -1
@@ -792,11 +792,10 @@ static int st21nfca_hci_im_transceive(struct nfc_hci_dev *hdev,return nfc_hci_send_cmd_async (hdev, target->hci_reader_gate,ST21NFCA_WR_XCHG_DATA , skb->data, skb->len, st21nfca_hci_data_exchange_cb, info); -break ;default :return 1 ; } }
drivers/nfc/trf7970a.c +0 -1
@@ -1380,11 +1380,10 @@ static int trf7970a_is_iso15693_write_or_lock(u8 cmd)case ISO15693_CMD_WRITE_AFI :case ISO15693_CMD_LOCK_AFI :case ISO15693_CMD_WRITE_DSFID :case ISO15693_CMD_LOCK_DSFID :return 1 ; -break ;default :return 0 ; } }
drivers/nvdimm/claim.c +0 -1
@@ -200,11 +200,10 @@ ssize_t nd_namespace_store(struct device *dev, }break ;default : len = -EBUSY ; goto out_attach; -break ; }if (__nvdimm_namespace_capacity (ndns) <SZ_16M ) {dev_dbg (dev,"%s too small to host\n" , name); len = -ENXIO ;
drivers/pci/controller/pci-v3-semi.c +0 -1
@@ -656,11 +656,10 @@ static int v3_get_dma_range_config(struct v3_pci *v3, val |=V3_LB_BASE_ADR_SIZE_2GB ;break ;default :dev_err (v3->dev,"illegal dma memory chunk size\n" );return -EINVAL ; -break ; } val |=V3_PCI_MAP_M_REG_EN |V3_PCI_MAP_M_ENABLE ; *pci_map = val; dev_dbg(dev,
drivers/pinctrl/samsung/pinctrl-s3c24xx.c +0 -5
@@ -106,23 +106,18 @@ struct s3c24xx_eint_domain_data {static int s3c24xx_eint_get_trigger (unsigned int type) {switch (type) {case IRQ_TYPE_EDGE_RISING :return EINT_EDGE_RISING ; -break ;case IRQ_TYPE_EDGE_FALLING :return EINT_EDGE_FALLING ; -break ;case IRQ_TYPE_EDGE_BOTH :return EINT_EDGE_BOTH ; -break ;case IRQ_TYPE_LEVEL_HIGH :return EINT_LEVEL_HIGH ; -break ;case IRQ_TYPE_LEVEL_LOW :return EINT_LEVEL_LOW ; -break ;default :return -EINVAL ; } }
drivers/platform/x86/acer-wmi.c +0 -1
@@ -790,11 +790,10 @@ static acpi_status AMW0_set_u32(u32 value, u32 cap)if (value > max_brightness)return AE_BAD_PARAMETER ;switch (quirks->brightness) {default :return ec_write (0x83 , value); -break ; }default :return AE_ERROR ; }
drivers/platform/x86/sony-laptop.c +0 -3
@@ -2465,26 +2465,23 @@ static int __sony_nc_gfx_switch_status_get(void)case 0x0146 :/* 1: discrete GFX (speed) * 0: integrated GFX (stamina) */ return result &0x1 ?SPEED :STAMINA ; -break ;case 0x015B :/* 0: discrete GFX (speed) * 1: integrated GFX (stamina) */ return result &0x1 ?STAMINA :SPEED ; -break ;case 0x0128 :/* it's a more elaborated bitmask, for now: * 2: integrated GFX (stamina) * 0: discrete GFX (speed) */ dprintk ("GFX Status: 0x%x\n" , result);return result &0x80 ?AUTO : result &0x02 ?STAMINA :SPEED ; -break ; }return -EINVAL ; } static ssize_t sony_nc_gfx_switch_status_show(struct device *dev,
drivers/platform/x86/wmi.c +0 -3
@@ -1258,17 +1258,14 @@ acpi_wmi_ec_space_handler(u32 function, acpi_physical_address address, }switch (result) {case -EINVAL :return AE_BAD_PARAMETER ; -break ;case -ENODEV :return AE_NOT_FOUND ; -break ;case -ETIME :return AE_TIME ; -break ;default :return AE_OK ; } }
drivers/power/supply/wm831x_power.c +0 -1
@@ -666,11 +666,10 @@ static int wm831x_power_probe(struct platform_device *pdev)default :dev_err (&pdev->dev,"Failed to find USB phy: %d\n" , ret); fallthrough;case -EPROBE_DEFER : goto err_bat_irq; -break ; }return ret; err_bat_irq:
drivers/scsi/aic94xx/aic94xx_task.c +0 -1
@@ -267,11 +267,10 @@ static void asd_task_tasklet_complete(struct asd_ascb *ascb, ts->stat =SAS_NAK_R_ERR ;break ;case TA_I_T_NEXUS_LOSS : opcode = dl->status_block[0 ]; goto Again; -break ;case TF_INV_CONN_HANDLE : ts->resp =SAS_TASK_UNDELIVERED ; ts->stat =SAS_DEVICE_UNKNOWN ;break ;case TF_REQUESTED_N_PENDING :
drivers/scsi/be2iscsi/be_mgmt.c +0 -4
@@ -1242,22 +1242,18 @@ beiscsi_adap_family_disp(struct device *dev, struct device_attribute *attr,case BE_DEVICE_ID1 :case OC_DEVICE_ID1 :case OC_DEVICE_ID2 :return snprintf (buf,PAGE_SIZE ,"Obsolete/Unsupported BE2 Adapter Family\n" ); -break ;case BE_DEVICE_ID2 :case OC_DEVICE_ID3 :return snprintf (buf,PAGE_SIZE ,"BE3-R Adapter Family\n" ); -break ;case OC_SKH_ID1 :return snprintf (buf,PAGE_SIZE ,"Skyhawk-R Adapter Family\n" ); -break ;default :return snprintf (buf,PAGE_SIZE ,"Unknown Adapter Family: 0x%x\n" , dev_id); -break ; } }/** * beiscsi_phys_port()- Display Physical Port Identifier
drivers/scsi/bnx2fc/bnx2fc_hwi.c +0 -1
@@ -768,11 +768,10 @@ static void bnx2fc_process_unsol_compl(struct bnx2fc_rport *tgt, u16 wqe)if (rc) goto skip_rec; }else printk(KERN_ERR PFX "SRR in progress\n"); goto ret_err_rqe; -break ;default :break ; } skip_rec:
drivers/scsi/fcoe/fcoe.c +0 -1
@@ -1892,11 +1892,10 @@ static int fcoe_device_notification(struct notifier_block *notifier,fcoe_interface_remove (fcoe);fcoe_interface_cleanup (fcoe);mutex_unlock (&fcoe_config_mutex);fcoe_ctlr_device_delete (fcoe_ctlr_to_ctlr_dev (ctlr)); goto out; -break ;case NETDEV_FEAT_CHANGE :fcoe_netdev_features_change (lport, netdev);break ;default : FCOE_NETDEV_DBG(netdev, "Unknown event %ld "
drivers/scsi/hpsa.c +0 -1
@@ -7440,11 +7440,10 @@ static int find_PCI_BAR_index(struct pci_dev *pdev, unsigned long pci_bar_addr)break ;default :/* reserved in PCI 2.2 */ dev_warn (&pdev->dev,"base address is invalid\n" );return -1 ; -break ; } }if (offset == pci_bar_addr -PCI_BASE_ADDRESS_0 )return i +1 ; }
drivers/scsi/hptiop.c +0 -1
@@ -756,11 +756,10 @@ static void hptiop_finish_scsi_req(struct hptiop_hba *hba, u32 tag,scsi_set_resid (scp,scsi_bufflen (scp) -le32_to_cpu (req->dataxfer_length)); scp->result =SAM_STAT_CHECK_CONDITION ;memcpy (scp->sense_buffer, &req->sg_list,SCSI_SENSE_BUFFERSIZE ); goto skip_resid; -break ;default : scp->result =DRIVER_INVALID <<24 |DID_ABORT <<16 ;break ; }
drivers/scsi/ipr.c +0 -1
@@ -9485,11 +9485,10 @@ static pci_ers_result_t ipr_pci_error_detected(struct pci_dev *pdev,ipr_pci_frozen (pdev);return PCI_ERS_RESULT_CAN_RECOVER ;case pci_channel_io_perm_failure:ipr_pci_perm_failure (pdev);return PCI_ERS_RESULT_DISCONNECT ; -break ;default :break ; }return PCI_ERS_RESULT_NEED_RESET ; }
drivers/scsi/isci/phy.c +0 -2
@@ -751,11 +751,10 @@ enum sci_status sci_phy_event_handler(struct isci_phy *iphy, u32 event_code)sci_change_state (&iphy->sm,SCI_PHY_STARTING );break ;default :phy_event_warn (iphy, state, event_code);return SCI_FAILURE ; -break ; }return SCI_SUCCESS ;case SCI_PHY_SUB_AWAIT_IAF_UF :switch (scu_get_event_code (event_code)) {case SCU_EVENT_SAS_PHY_DETECTED :
@@ -956,11 +955,10 @@ enum sci_status sci_phy_event_handler(struct isci_phy *iphy, u32 event_code)sci_change_state (&iphy->sm,SCI_PHY_STARTING );break ;default :phy_event_warn (iphy, state, event_code);return SCI_FAILURE_INVALID_STATE ; -break ; }return SCI_SUCCESS ;default :dev_dbg (sciphy_to_dev (iphy),"%s: in wrong state: %s\n" , __func__,phy_state_name (state));
drivers/scsi/lpfc/lpfc_debugfs.c +4 -8
@@ -3339,11 +3339,10 @@ lpfc_idiag_pcicfg_read(struct file *file, char __user *buf, size_t nbytes, len +=scnprintf (pbuffer+len,LPFC_PCI_CFG_SIZE -len,"%03x: %08x\n" , where, u32val);break ;case LPFC_PCI_CFG_BROWSE :/* browse all */ goto pcicfg_browse; -break ;default :/* illegal count */ len =0 ;break ; }
@@ -4379,11 +4378,11 @@ lpfc_idiag_queacc_write(struct file *file, const char __user *buf, goto pass_check; } } } goto error_out; -break ; +case LPFC_IDIAG_CQ :/* MBX complete queue */ if (phba->sli4_hba.mbx_cq && phba->sli4_hba.mbx_cq->queue_id == queid) {/* Sanity check */
@@ -4431,11 +4430,11 @@ lpfc_idiag_queacc_write(struct file *file, const char __user *buf, goto pass_check; } } } goto error_out; -break ; +case LPFC_IDIAG_MQ :/* MBX work queue */ if (phba->sli4_hba.mbx_wq && phba->sli4_hba.mbx_wq->queue_id == queid) {/* Sanity check */
@@ -4445,11 +4444,11 @@ lpfc_idiag_queacc_write(struct file *file, const char __user *buf, goto error_out; idiag.ptr_private = phba->sli4_hba.mbx_wq; goto pass_check; } goto error_out; -break ; +case LPFC_IDIAG_WQ :/* ELS work queue */ if (phba->sli4_hba.els_wq && phba->sli4_hba.els_wq->queue_id == queid) {/* Sanity check */
@@ -4485,13 +4484,12 @@ lpfc_idiag_queacc_write(struct file *file, const char __user *buf, idiag.ptr_private = qp; goto pass_check; } } } - goto error_out; -break ; +case LPFC_IDIAG_RQ :/* HDR queue */ if (phba->sli4_hba.hdr_rq && phba->sli4_hba.hdr_rq->queue_id == queid) {/* Sanity check */
@@ -4512,14 +4510,12 @@ lpfc_idiag_queacc_write(struct file *file, const char __user *buf, goto error_out; idiag.ptr_private = phba->sli4_hba.dat_rq; goto pass_check; } goto error_out; -break ;default : goto error_out; -break ; } pass_check:if (idiag.cmd.opcode ==LPFC_IDIAG_CMD_QUEACC_RD ) {
drivers/scsi/lpfc/lpfc_init.c +0 -1
@@ -7194,11 +7194,10 @@ lpfc_init_api_table_setup(struct lpfc_hba *phba, uint8_t dev_grp)default :lpfc_printf_log (phba,KERN_ERR ,LOG_TRACE_EVENT ,"1431 Invalid HBA PCI-device group: 0x%x\n" , dev_grp);return -ENODEV ; -break ; }return 0 ; }/**
drivers/scsi/lpfc/lpfc_scsi.c +0 -1
@@ -4282,11 +4282,10 @@ lpfc_scsi_api_table_setup(struct lpfc_hba *phba, uint8_t dev_grp)default :lpfc_printf_log (phba,KERN_ERR ,LOG_TRACE_EVENT ,"1418 Invalid HBA PCI-device group: 0x%x\n" , dev_grp);return -ENODEV ; -break ; } phba->lpfc_rampdown_queue_depth = lpfc_rampdown_queue_depth; phba->lpfc_scsi_cmd_iocb_cmpl = lpfc_scsi_cmd_iocb_cmpl;return 0 ; }
drivers/scsi/lpfc/lpfc_sli.c +0 -3
@@ -9187,11 +9187,10 @@ lpfc_mbox_api_table_setup(struct lpfc_hba *phba, uint8_t dev_grp)default :lpfc_printf_log (phba,KERN_ERR ,LOG_TRACE_EVENT ,"1420 Invalid HBA PCI-device group: 0x%x\n" , dev_grp);return -ENODEV ; -break ; }return 0 ; }/**
@@ -10070,11 +10069,10 @@ lpfc_sli4_iocb2wqe(struct lpfc_hba *phba, struct lpfc_iocbq *iocbq,default :lpfc_printf_log (phba,KERN_ERR ,LOG_TRACE_EVENT ,"2014 Invalid command 0x%x\n" , iocbq->iocb.ulpCommand);return IOCB_ERROR ; -break ; }if (iocbq->iocb_flag &LPFC_IO_DIF_PASS )bf_set (wqe_dif, &wqe->generic.wqe_com,LPFC_WQE_DIF_PASSTHRU );else if (iocbq->iocb_flag &LPFC_IO_DIF_STRIP )
@@ -10232,11 +10230,10 @@ lpfc_sli_api_table_setup(struct lpfc_hba *phba, uint8_t dev_grp)default :lpfc_printf_log (phba,KERN_ERR ,LOG_TRACE_EVENT ,"1419 Invalid HBA PCI-device group: 0x%x\n" , dev_grp);return -ENODEV ; -break ; } phba->lpfc_get_iocb_from_iocbq = lpfc_get_iocb_from_iocbq;return 0 ; }
drivers/scsi/mvumi.c +0 -1
@@ -2294,11 +2294,10 @@ static int mvumi_cfg_hw_reg(struct mvumi_hba *mhba) regs->int_drbl_int_mask =0x3FFFFFFF ; regs->int_mu = regs->int_dl_cpu2pciea | regs->int_comaout;break ;default :return -1 ; -break ; }return 0 ; }
drivers/scsi/pcmcia/nsp_cs.c +0 -2
@@ -1100,12 +1100,10 @@ static irqreturn_t nspintr(int irq, void *dev_id)nsp_index_write (base,SCSIBUSCTRL ,SCSI_ATN );udelay (1 );nsp_index_write (base,SCSIBUSCTRL ,SCSI_ATN |AUTODIRECTION |ACKENB );return IRQ_HANDLED ; -break ; -case PH_RESELECT ://nsp_dbg(NSP_DEBUG_INTR, "phase reselect"); // *sync_neg = SYNC_NOT_YET; if ((phase &BUSMON_PHASE_MASK ) !=BUSPHASE_MESSAGE_IN ) {
drivers/scsi/qla2xxx/qla_mbx.c +0 -1
@@ -4028,11 +4028,10 @@ qla24xx_report_id_acquisition(scsi_qla_host_t *vha,/* if our portname is higher then initiate N2N login */ set_bit (N2N_LOGIN_NEEDED , &vha->dpc_flags);return ; -break ;case TOPO_FL : ha->current_topology =ISP_CFG_FL ;break ;case TOPO_F : ha->current_topology =ISP_CFG_F ;
drivers/scsi/st.c +0 -1
@@ -2844,11 +2844,10 @@ static int st_int_ioctl(struct scsi_tape *STp, unsigned int cmd_in, unsigned lon fileno = blkno = at_sm =0 ;break ;case MTNOP :DEBC_printk (STp,"No op on tape.\n" );return 0 ;/* Should do something ? */ -break ;case MTRETEN : cmd[0 ] =START_STOP ;if (STp->immediate) { cmd[1 ] =1 ;/* Don't wait for completion */ timeout = STp->device->request_queue->rq_timeout;
drivers/scsi/sym53c8xx_2/sym_hipd.c +0 -1
@@ -4594,11 +4594,10 @@ static void sym_int_sir(struct sym_hcb *np)sym_print_addr (cp->cmd,"M_REJECT received (%x:%x).\n" ,scr_to_cpu (np->lastmsg), np->msgout[0 ]); } goto out_clrack; -break ;default : goto out_reject; }break ;/*
drivers/staging/media/atomisp/pci/sh_css.c +0 -1
@@ -6284,11 +6284,10 @@ allocate_delay_frames(struct ia_css_pipe *pipe) {case IA_CSS_PIPE_ID_CAPTURE : {struct ia_css_capture_settings *mycs_capture = &pipe->pipe_settings.capture; (void )mycs_capture;return err; } -break ;case IA_CSS_PIPE_ID_VIDEO : {struct ia_css_video_settings *mycs_video = &pipe->pipe_settings.video; ref_info = mycs_video->video_binary.internal_frame_info;/*The ref frame expects
drivers/staging/rts5208/rtsx_scsi.c +0 -2
@@ -569,12 +569,10 @@ static int start_stop_unit(struct scsi_cmnd *srb, struct rtsx_chip *chip)case LOAD_MEDIUM :if (check_card_ready (chip, lun))return TRANSPORT_GOOD ;set_sense_type (chip, lun,SENSE_TYPE_MEDIA_NOT_PRESENT );return TRANSPORT_FAILED ; - -break ; }return TRANSPORT_ERROR ; }
drivers/staging/vme/devices/vme_user.c +0 -4
@@ -355,12 +355,10 @@ static int vme_user_ioctl(struct inode *inode, struct file *file,* to userspace as they are */ return vme_master_set (image[minor].resource, master.enable, master.vme_addr, master.size, master.aspace, master.cycle, master.dwidth); - -break ; }break ;case SLAVE_MINOR :switch (cmd) {case VME_GET_SLAVE :
@@ -396,12 +394,10 @@ static int vme_user_ioctl(struct inode *inode, struct file *file,*/ return vme_slave_set (image[minor].resource, slave.enable, slave.vme_addr, slave.size, image[minor].pci_buf, slave.aspace, slave.cycle); - -break ; }break ; }return -EINVAL ;
drivers/tty/nozomi.c +1 -4
@@ -412,15 +412,13 @@ static void read_mem32(u32 *buf, const void __iomem *mem_addr_start,switch (size_bytes) {case 2 :/* 2 bytes */ buf16 = (u16 *) buf; *buf16 =__le16_to_cpu (readw (ptr)); goto out; -break ;case 4 :/* 4 bytes */ *(buf) =__le32_to_cpu (readl (ptr)); goto out; -break ; }while (i < size_bytes) {if (size_bytes - i ==2 ) {/* Handle 2 bytes in the end */
@@ -458,19 +456,18 @@ static u32 write_mem32(void __iomem *mem_addr_start, const u32 *buf,switch (size_bytes) {case 2 :/* 2 bytes */ buf16 = (const u16 *)buf;writew (__cpu_to_le16 (*buf16), ptr);return 2 ; -break ;case 1 :/* * also needs to write 4 bytes in this case * so falling through.. */ + fallthrough;case 4 :/* 4 bytes */ writel (__cpu_to_le32 (*buf), ptr);return 4 ; -break ; }while (i < size_bytes) {if (size_bytes - i ==2 ) {/* 2 bytes */
drivers/tty/serial/imx.c +0 -5
@@ -318,31 +318,26 @@ static void imx_uart_writel(struct imx_port *sport, u32 val, u32 offset)static u32 imx_uart_readl (struct imx_port *sport,u32 offset) {switch (offset) {case UCR1 :return sport->ucr1; -break ;case UCR2 :/* * UCR2_SRST is the only bit in the cached registers that might * differ from the value that was last written. As it only * automatically becomes one after being cleared, reread * conditionally. */ if (!(sport->ucr2 &UCR2_SRST )) sport->ucr2 =readl (sport->port.membase + offset);return sport->ucr2; -break ;case UCR3 :return sport->ucr3; -break ;case UCR4 :return sport->ucr4; -break ;case UFCR :return sport->ufcr; -break ;default :return readl (sport->port.membase + offset); } }
drivers/usb/gadget/function/f_hid.c +0 -9
@@ -509,27 +509,23 @@ static int hidg_setup(struct usb_function *f,VDBG (cdev,"get_report\n" );/* send an empty report */ length =min_t (unsigned, length, hidg->report_length);memset (req->buf,0x0 , length); - goto respond; -break ;case ((USB_DIR_IN |USB_TYPE_CLASS |USB_RECIP_INTERFACE ) <<8 |HID_REQ_GET_PROTOCOL ):VDBG (cdev,"get_protocol\n" ); length = min_t(unsigned int, length, 1); ((u8 *) req->buf)[0 ] = hidg->protocol; goto respond; -break ;case ((USB_DIR_OUT |USB_TYPE_CLASS |USB_RECIP_INTERFACE ) <<8 |HID_REQ_SET_REPORT ):VDBG (cdev,"set_report | wLength=%d\n" , ctrl->wLength); goto stall; -break ;case ((USB_DIR_OUT |USB_TYPE_CLASS |USB_RECIP_INTERFACE ) <<8 |HID_REQ_SET_PROTOCOL ):VDBG (cdev,"set_protocol\n" );if (value >HID_REPORT_PROTOCOL )
@@ -542,11 +538,10 @@ static int hidg_setup(struct usb_function *f,if (hidg->bInterfaceSubClass ==USB_INTERFACE_SUBCLASS_BOOT ) { hidg->protocol = value; goto respond; } goto stall; -break ;case ((USB_DIR_IN |USB_TYPE_STANDARD |USB_RECIP_INTERFACE ) <<8 |USB_REQ_GET_DESCRIPTOR ):switch (value >>8 ) {case HID_DT_HID :
@@ -560,33 +555,29 @@ static int hidg_setup(struct usb_function *f, length = min_t(unsigned short, length, hidg_desc_copy.bLength);memcpy (req->buf, &hidg_desc_copy, length); goto respond; -break ; }case HID_DT_REPORT :VDBG (cdev,"USB_REQ_GET_DESCRIPTOR: REPORT\n" ); length = min_t(unsigned short, length, hidg->report_desc_length);memcpy (req->buf, hidg->report_desc, length); goto respond; -break ;default :VDBG (cdev,"Unknown descriptor request 0x%x\n" , value >>8 ); goto stall; -break ; }break ;default :VDBG (cdev,"Unknown request 0x%x\n" , ctrl->bRequest); goto stall; -break ; } stall:return -EOPNOTSUPP ;
drivers/usb/host/xhci-mem.c +0 -1
@@ -1142,11 +1142,10 @@ int xhci_setup_addressable_virt_dev(struct xhci_hcd *xhci, struct usb_device *ud max_packets =MAX_PACKET (8 );break ;case USB_SPEED_WIRELESS :xhci_dbg (xhci,"FIXME xHCI doesn't support wireless speeds\n" );return -EINVAL ; -break ;default :/* Speed was set earlier, this shouldn't happen. */ return -EINVAL ; }/* Find the root hub port this device is under */
drivers/usb/misc/iowarrior.c +0 -3
@@ -382,11 +382,10 @@ static ssize_t iowarrior_write(struct file *file, goto exit; } retval =usb_set_report (dev->interface,2 ,0 , buf, count);kfree (buf); goto exit; -break ;case USB_DEVICE_ID_CODEMERCS_IOW56 :case USB_DEVICE_ID_CODEMERCS_IOW56AM :case USB_DEVICE_ID_CODEMERCS_IOW28 :case USB_DEVICE_ID_CODEMERCS_IOW28L :case USB_DEVICE_ID_CODEMERCS_IOW100 :
@@ -452,18 +451,16 @@ static ssize_t iowarrior_write(struct file *file, }/* submit was ok */ retval = count;usb_free_urb (int_out_urb); goto exit; -break ;default :/* what do we have here ? An unsupported Product-ID ? */ dev_err (&dev->interface->dev,"%s - not supported for product=0x%x\n" , __func__, dev->product_id); retval = -EFAULT ; goto exit; -break ; } error:usb_free_coherent (dev->udev, dev->report_size, buf, int_out_urb->transfer_dma); error_no_buffer:
drivers/usb/serial/iuu_phoenix.c +0 -2
@@ -848,11 +848,10 @@ static int iuu_uart_baud(struct usb_serial_port *port, u32 baud_base, dataout[DataCount++] =0x04 ;break ;default :kfree (dataout);return IUU_INVALID_PARAMETER ; -break ; }switch (parity &0xF0 ) {case IUU_ONE_STOP_BIT : dataout[DataCount -1 ] |=IUU_ONE_STOP_BIT ;
@@ -862,11 +861,10 @@ static int iuu_uart_baud(struct usb_serial_port *port, u32 baud_base, dataout[DataCount -1 ] |=IUU_TWO_STOP_BITS ;break ;default :kfree (dataout);return IUU_INVALID_PARAMETER ; -break ; } status =bulk_immediate (port, dataout, DataCount);if (status !=IUU_OPERATION_OK )dev_dbg (&port->dev,"%s - uart_off error\n" , __func__);
drivers/usb/storage/freecom.c +0 -1
@@ -429,11 +429,10 @@ static int freecom_transport(struct scsi_cmnd *srb, struct us_data *us)/* should never hit here -- filtered in usb.c */ usb_stor_dbg (us,"freecom unimplemented direction: %d\n" , us->srb->sc_data_direction);/* Return fail, SCSI seems to handle this better. */ return USB_STOR_TRANSPORT_FAILED ; -break ; }return USB_STOR_TRANSPORT_GOOD ; }
drivers/vme/bridges/vme_tsi148.c +0 -7
@@ -504,11 +504,10 @@ static int tsi148_slave_set(struct vme_slave_resource *image, int enabled, addr |=TSI148_LCSR_ITAT_AS_A64 ;break ;default :dev_err (tsi148_bridge->parent,"Invalid address space\n" );return -EINVAL ; -break ; }/* Convert 64-bit variables to 2x 32-bit variables */ reg_split (vme_base, &vme_base_high, &vme_base_low);
@@ -993,11 +992,10 @@ static int tsi148_master_set(struct vme_master_resource *image, int enabled,default :spin_unlock (&image->lock);dev_err (tsi148_bridge->parent,"Invalid address space\n" ); retval = -EINVAL ; goto err_aspace; -break ; } temp_ctl &= ~(3 <<4 );if (cycle &VME_SUPER ) temp_ctl |=TSI148_LCSR_OTAT_SUP ;
@@ -1501,11 +1499,10 @@ static int tsi148_dma_set_vme_src_attributes(struct device *dev, __be32 *attr, val |=TSI148_LCSR_DSAT_AMODE_USER4 ;break ;default :dev_err (dev,"Invalid address space\n" );return -EINVAL ; -break ; }if (cycle &VME_SUPER ) val |=TSI148_LCSR_DSAT_SUP ;if (cycle &VME_PROG )
@@ -1601,11 +1598,10 @@ static int tsi148_dma_set_vme_dest_attributes(struct device *dev, __be32 *attr, val |=TSI148_LCSR_DDAT_AMODE_USER4 ;break ;default :dev_err (dev,"Invalid address space\n" );return -EINVAL ; -break ; }if (cycle &VME_SUPER ) val |=TSI148_LCSR_DDAT_SUP ;if (cycle &VME_PROG )
@@ -1699,11 +1695,10 @@ static int tsi148_dma_list_add(struct vme_dma_list *list,break ;default :dev_err (tsi148_bridge->parent,"Invalid source type\n" ); retval = -EINVAL ; goto err_source; -break ; }/* Assume last link - this will be over-written by adding another */ entry->descriptor.dnlau =cpu_to_be32 (0 ); entry->descriptor.dnlal =cpu_to_be32 (TSI148_LCSR_DNLAL_LLA );
@@ -1736,11 +1731,10 @@ static int tsi148_dma_list_add(struct vme_dma_list *list,break ;default :dev_err (tsi148_bridge->parent,"Invalid destination type\n" ); retval = -EINVAL ; goto err_dest; -break ; }/* Fill out count */ entry->descriptor.dcnt =cpu_to_be32 ((u32 )count);
@@ -1962,11 +1956,10 @@ static int tsi148_lm_set(struct vme_lm_resource *lm, unsigned long long lm_base,break ;default :mutex_unlock (&lm->mtx);dev_err (tsi148_bridge->parent,"Invalid address space\n" );return -EINVAL ; -break ; }if (cycle &VME_SUPER ) lm_ctl |=TSI148_LCSR_LMAT_SUPR ;if (cycle &VME_USER )
drivers/vme/vme.c +0 -9
@@ -50,27 +50,22 @@ static struct vme_bridge *find_bridge(struct vme_resource *resource)/* Get list to search */ switch (resource->type) {case VME_MASTER : return list_entry(resource->entry, struct vme_master_resource, list)->parent; -break ;case VME_SLAVE : return list_entry(resource->entry, struct vme_slave_resource, list)->parent; -break ;case VME_DMA : return list_entry(resource->entry, struct vme_dma_resource, list)->parent; -break ;case VME_LM : return list_entry(resource->entry, struct vme_lm_resource, list)->parent; -break ;default :printk (KERN_ERR "Unknown resource type\n" );return NULL ; -break ; } }/** * vme_free_consistent - Allocate contiguous memory.
@@ -177,26 +172,22 @@ size_t vme_get_size(struct vme_resource *resource) &aspace, &cycle, &dwidth);if (retval)return 0 ;return size; -break ;case VME_SLAVE : retval =vme_slave_get (resource, &enabled, &base, &size, &buf_base, &aspace, &cycle);if (retval)return 0 ;return size; -break ;case VME_DMA :return 0 ; -break ;default :printk (KERN_ERR "Unknown resource type\n" );return 0 ; -break ; } }EXPORT_SYMBOL (vme_get_size); int vme_check_window(u32 aspace, unsigned long long vme_base,
drivers/watchdog/geodewdt.c +0 -2
@@ -148,12 +148,10 @@ static long geodewdt_ioctl(struct file *file, unsigned int cmd,switch (cmd) {case WDIOC_GETSUPPORT :return copy_to_user (argp, &ident,sizeof (ident)) ? -EFAULT :0 ; -break ; -case WDIOC_GETSTATUS :case WDIOC_GETBOOTSTATUS :return put_user (0 , p);case WDIOC_SETOPTIONS :
fs/efs/inode.c +0 -1
@@ -161,11 +161,10 @@ struct inode *efs_iget(struct super_block *super, unsigned long ino)init_special_inode (inode, inode->i_mode, device);break ;default :pr_warn ("unsupported inode mode %o\n" , inode->i_mode); goto read_inode_error; -break ; }unlock_new_inode (inode);return inode;
fs/ocfs2/cluster/tcp.c +0 -1
@@ -1196,11 +1196,10 @@ static int o2net_process_message(struct o2net_sock_container *sc,break ;default :msglog (hdr,"bad magic\n" ); ret = -EINVAL ; goto out; -break ; }/* find a handler for it */ handler_status =0 ; nmh = o2net_handler_get(be16_to_cpu(hdr->msg_type),
kernel/bpf/syscall.c +0 -1
@@ -2911,11 +2911,10 @@ attach_type_to_prog_type(enum bpf_attach_type attach_type) {switch (attach_type) {case BPF_CGROUP_INET_INGRESS :case BPF_CGROUP_INET_EGRESS :return BPF_PROG_TYPE_CGROUP_SKB ; -break ;case BPF_CGROUP_INET_SOCK_CREATE :case BPF_CGROUP_INET_SOCK_RELEASE :case BPF_CGROUP_INET4_POST_BIND :case BPF_CGROUP_INET6_POST_BIND :return BPF_PROG_TYPE_CGROUP_SOCK ;
security/integrity/ima/ima_appraise.c +0 -1
@@ -179,11 +179,10 @@ enum hash_algo ima_get_hash_algo(struct evm_ima_xattr_data *xattr_value,case EVM_IMA_XATTR_DIGSIG : sig = (typeof (sig ))xattr_value;if (sig->version !=2 || xattr_len <=sizeof (*sig))return ima_hash_algo;return sig->hash_algo; -break ;case IMA_XATTR_DIGEST_NG :/* first byte contains algorithm id */ ret = xattr_value->data[0 ];if (ret <HASH_ALGO__LAST )return ret;
security/keys/trusted-keys/trusted_tpm1.c +0 -1
@@ -899,11 +899,10 @@ static int datablob_parse(char *datablob, struct trusted_key_payload *p,return ret; ret = Opt_update;break ;case Opt_err:return -EINVAL ; -break ; }return ret; }static struct trusted_key_options *trusted_options_alloc (void )
security/safesetid/lsm.c +0 -3
@@ -123,11 +123,10 @@ static int safesetid_security_capable(const struct cred *cred,* set*uid() (e.g. setting up userns uid mappings). */ pr_warn ("Operation requires CAP_SETUID, which is not available to UID %u for operations besides approved set*uid transitions\n" ,__kuid_val (cred->uid));return -EPERM ; -break ;case CAP_SETGID :/* * If no policy applies to this task, allow the use of CAP_SETGID for * other purposes. */
@@ -138,15 +137,13 @@ static int safesetid_security_capable(const struct cred *cred,* set*gid() (e.g. setting up userns gid mappings). */ pr_warn ("Operation requires CAP_SETGID, which is not available to GID %u for operations besides approved set*gid transitions\n" ,__kuid_val (cred->uid));return -EPERM ; -break ;default :/* Error, the only capabilities were checking for is CAP_SETUID/GID */ return 0 ; -break ; }return 0 ; }/*
sound/pci/rme32.c +0 -1
@@ -466,11 +466,10 @@ static int snd_rme32_capture_getrate(struct rme32 * rme32, int *is_adat)return 44100 ;case 7 :return 32000 ;default :return -1 ; -break ; }else switch (n) {/* supporting the CS8412 */ case 0 :return -1 ;
sound/pci/rme9652/hdspm.c +0 -8
@@ -2284,11 +2284,10 @@ static int hdspm_get_wc_sample_rate(struct hdspm *hdspm)switch (hdspm->io_type) {case RayDAT:case AIO : status =hdspm_read (hdspm,HDSPM_RD_STATUS_1 );return (status >>16 ) &0xF ; -break ;case AES32 : status =hdspm_read (hdspm, HDSPM_statusRegister);return (status >> HDSPM_AES32_wcFreq_bit) &0xF ;default :break ;
@@ -2310,11 +2309,10 @@ static int hdspm_get_tco_sample_rate(struct hdspm *hdspm)switch (hdspm->io_type) {case RayDAT:case AIO : status =hdspm_read (hdspm,HDSPM_RD_STATUS_1 );return (status >>20 ) &0xF ; -break ;case AES32 : status =hdspm_read (hdspm, HDSPM_statusRegister);return (status >>1 ) &0xF ;default :break ;
@@ -2336,11 +2334,10 @@ static int hdspm_get_sync_in_sample_rate(struct hdspm *hdspm)switch (hdspm->io_type) {case RayDAT:case AIO : status =hdspm_read (hdspm,HDSPM_RD_STATUS_2 );return (status >>12 ) &0xF ; -break ;default :break ; } }
@@ -2356,11 +2353,10 @@ static int hdspm_get_aes_sample_rate(struct hdspm *hdspm, int index)switch (hdspm->io_type) {case AES32 : timecode =hdspm_read (hdspm, HDSPM_timecodeRegister);return (timecode >> (4 *index)) &0xF ; -break ;default :break ; }return 0 ; }
@@ -3843,22 +3839,20 @@ static int hdspm_wc_sync_check(struct hdspm *hdspm)return 2 ; else return 1; }return 0 ; -break ;case MADI : status2 =hdspm_read (hdspm, HDSPM_statusRegister2);if (status2 & HDSPM_wcLock) {if (status2 & HDSPM_wcSync)return 2 ;else return 1 ; }return 0 ; -break ;case RayDAT:case AIO : status =hdspm_read (hdspm, HDSPM_statusRegister);
@@ -3866,12 +3860,10 @@ static int hdspm_wc_sync_check(struct hdspm *hdspm)return 2 ; else if (status & 0x1000000) return 1;return 0 ; -break ; -case MADIface:break ; }
sound/pci/rme9652/rme9652.c +0 -7
@@ -730,38 +730,31 @@ static inline int rme9652_spdif_sample_rate(struct snd_rme9652 *s) rate_bits =rme9652_read (s, RME9652_status_register) &RME9652_F ;switch (rme9652_decode_spdif_rate (rate_bits)) {case 0x7 :return 32000 ; -break ;case 0x6 :return 44100 ; -break ;case 0x5 :return 48000 ; -break ;case 0x4 :return 88200 ; -break ;case 0x3 :return 96000 ; -break ;case 0x0 :return 64000 ; -break ;default :dev_err (s->card->dev,"%s: unknown S/PDIF input rate (bits = 0x%x)\n" , s->card_name, rate_bits);return 0 ; -break ; } }/*----------------------------------------------------------------------------- Control Interface
sound/soc/codecs/wcd-clsh-v2.c +0 -1
@@ -478,11 +478,10 @@ static int _wcd_clsh_ctrl_set_state(struct wcd_clsh_ctrl *ctrl, int req_state,wcd_clsh_state_hph_l (ctrl, req_state, is_enable, mode);break ;case WCD_CLSH_STATE_HPHR :wcd_clsh_state_hph_r (ctrl, req_state, is_enable, mode);break ; -break ;case WCD_CLSH_STATE_LO :wcd_clsh_state_lo (ctrl, req_state, is_enable, mode);break ;default :break ;
sound/soc/codecs/wl1273.c +0 -1
@@ -309,11 +309,10 @@ static int wl1273_startup(struct snd_pcm_substream *substream,return -EINVAL ; }break ;default :return -EINVAL ; -break ; }return 0 ; }
sound/soc/intel/skylake/skl-pcm.c +0 -1
@@ -500,11 +500,10 @@ static int skl_pcm_trigger(struct snd_pcm_substream *substream, int cmd,*/ ret =skl_decoupled_trigger (substream, cmd);if (ret <0 )return ret;return skl_run_pipe (skl, mconfig->pipe); -break ;case SNDRV_PCM_TRIGGER_PAUSE_PUSH :case SNDRV_PCM_TRIGGER_SUSPEND :case SNDRV_PCM_TRIGGER_STOP :/*
sound/soc/ti/davinci-mcasp.c +0 -1
@@ -2383,11 +2383,10 @@ static int davinci_mcasp_probe(struct platform_device *pdev)break ;default :dev_err (&pdev->dev,"No DMA controller found (%d)\n" , ret);case -EPROBE_DEFER : goto err; -break ; }if (ret) {dev_err (&pdev->dev,"register PCM failed: %d\n" , ret); goto err;
Hi Tom,
(I removed what I believe are irrelevant recipients from this reply)
On Sat, Oct 17, 2020 at 6:10 PM <[email protected]> wrote:
[...]
Quoted 12 lines
drivers/iio/adc/meson_saradc.c +0
-1@@ -591,17 +591,15 @@ static int meson_sar_adc_iio_info_read_raw(struct iio_dev *indio_dev,switch (mask) {case IIO_CHAN_INFO_RAW :return meson_sar_adc_get_sample (indio_dev, chan,NO_AVERAGING ,ONE_SAMPLE , val); -break ;
drivers/iio/adc/meson_saradc.c static int meson_sar_adc_iio_info_read_raw(struct iio_dev *indio_dev, · line 605
Quoted 10 lines
drivers/iio/adc/meson_saradc.c +0
-1case IIO_CHAN_INFO_AVERAGE_RAW :return meson_sar_adc_get_sample (indio_dev, chan,MEAN_AVERAGING ,EIGHT_SAMPLES , val); -break ;case IIO_CHAN_INFO_SCALE :if (chan->type ==IIO_VOLTAGE ) { ret =regulator_get_voltage (priv->vref);if (ret <0 ) {
for drivers/iio/adc/meson_saradc.c:
Best regards,
Martin
Joe Perches
maintainerQuoted 7 lines · On Sat, 2020-10-17 at 09:09 -0700, [email protected] wrote:
From: Tom Rix <[email protected]>
This is a upcoming change to clean up a new warning treewide.
I am wondering if the change could be one mega patch (see below) or normal patch per file about 100 patches or somewhere half way by collecting early acks.
Quoted 6 lines
clang has a number of useful, new warnings see
https://clang.llvm.org/docs/DiagnosticsReference.htmlThis change cleans up -Wunreachable-code-break
https://clang.llvm.org/docs/DiagnosticsReference.html#wunreachable-code-break
for 266 of 485 warnings in this week's linux-next, allyesconfig onx86_64.
Early acks/individual patches by subsystem would be good. Better still would be an automated cocci script.
The existing checkpatch test for UNNECESSARY_BREAK has a few too many false positives.
From a script run on next on July 28th:
arch/arm/mach-s3c24xx/mach-rx1950.c:266: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return arch/arm/nwfpe/fpa11_cprt.c:38: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return arch/arm/nwfpe/fpa11_cprt.c:41: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return arch/mips/include/asm/mach-au1x00/au1000.h:684: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return arch/mips/include/asm/mach-au1x00/au1000.h:687: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return arch/mips/include/asm/mach-au1x00/au1000.h:690: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return arch/mips/include/asm/mach-au1x00/au1000.h:693: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return arch/mips/include/asm/mach-au1x00/au1000.h:697: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return arch/mips/include/asm/mach-au1x00/au1000.h:700: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return arch/mips/loongson2ef/common/cs5536/cs5536_isa.c:276: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return arch/mips/loongson2ef/common/cs5536/cs5536_isa.c:279: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return arch/mips/loongson2ef/common/cs5536/cs5536_isa.c:282: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return arch/mips/loongson2ef/common/cs5536/cs5536_isa.c:287: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return arch/mips/loongson2ef/common/cs5536/cs5536_isa.c:290: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return arch/mips/rb532/setup.c:76: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or returnarch/mips/rb532/setup.c:79: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return arch/powerpc/include/asm/kvm_book3s_64.h:231: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return arch/powerpc/include/asm/kvm_book3s_64.h:234: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return arch/powerpc/include/asm/kvm_book3s_64.h:237: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return arch/powerpc/include/asm/kvm_book3s_64.h:240: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return arch/powerpc/net/bpf_jit_comp.c:455: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return arch/powerpc/platforms/cell/spufs/switch.c:2047: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return arch/powerpc/platforms/cell/spufs/switch.c:2077: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return arch/sh/boards/mach-landisk/gio.c:111: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return arch/x86/kernel/cpu/mce/core.c:1734: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return arch/x86/kernel/cpu/mce/core.c:1738: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return arch/x86/kernel/cpu/microcode/amd.c:218: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/acpi/utils.c:107: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or returndrivers/acpi/utils.c:132: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or returndrivers/acpi/utils.c:147: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or returndrivers/acpi/utils.c:158: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/ata/libata-scsi.c:3973: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/base/power/main.c:366: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/block/xen-blkback/blkback.c:1272: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/char/ipmi/ipmi_devintf.c:493: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/char/lp.c:625: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/char/mwave/mwavedd.c:406: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/cpufreq/e_powersaver.c:226: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/cpufreq/longhaul.c:596: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/crypto/atmel-sha.c:462: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/edac/amd64_edac.c:2464: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/edac/amd64_edac.c:2468: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/edac/amd64_edac.c:2471: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/edac/amd64_edac.c:2481: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/edac/amd64_edac.c:2485: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/edac/amd64_edac.c:2488: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/edac/amd64_edac.c:2491: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/gpu/drm/amd/amdgpu/atombios_encoders.c:505: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/gpu/drm/amd/amdgpu/atombios_encoders.c:528: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/gpu/drm/amd/amdgpu/dce_v10_0.c:2220: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/gpu/drm/amd/amdgpu/dce_v11_0.c:2253: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/gpu/drm/amd/amdgpu/dce_v8_0.c:2110: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/gpu/drm/gma500/cdv_intel_hdmi.c:346: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/gpu/drm/mgag200/mgag200_mode.c:723: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/gpu/drm/mgag200/mgag200_mode.c:727: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/gpu/drm/mgag200/mgag200_mode.c:730: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/gpu/drm/mgag200/mgag200_mode.c:734: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/gpu/drm/mgag200/mgag200_mode.c:737: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/gpu/drm/nouveau/nvkm/subdev/bios/pll.c:126: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/gpu/drm/nouveau/nvkm/subdev/clk/mcp77.c:143: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/gpu/drm/nouveau/nvkm/subdev/clk/mcp77.c:150: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/gpu/drm/nouveau/nvkm/subdev/clk/mcp77.c:153: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramnv50.c:174: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/gpu/drm/qxl/qxl_ioctl.c:163: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/gpu/drm/radeon/atombios_encoders.c:749: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/gpu/drm/radeon/atombios_encoders.c:780: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/gpu/drm/radeon/r300.c:1160: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/gpu/drm/radeon/radeon_i2c.c:462: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/infiniband/hw/cxgb4/qp.c:1972: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/infiniband/hw/cxgb4/qp.c:2021: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/infiniband/hw/cxgb4/qp.c:2026: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/input/mouse/synaptics_usb.c:207: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/ipack/devices/ipoctal.c:547: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/irqchip/irq-crossbar.c:291: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/irqchip/irq-mips-gic.c:643: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/isdn/mISDN/dsp_dtmf.c:174: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/macintosh/via-pmu-led.c:65: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/cx24117.c:1175: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/dib0090.c:407: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/dib0090.c:497: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/drxd_hard.c:1625: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/drx39xyj/drxj.c:2328: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/drx39xyj/drxj.c:2655: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/drx39xyj/drxj.c:3597: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/drx39xyj/drxj.c:3621: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/drx39xyj/drxj.c:3645: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/drx39xyj/drxj.c:10947: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/drx39xyj/drxj.c:11068: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/drx39xyj/drxj.c:11890: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/nxt200x.c:171: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/nxt200x.c:193: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/nxt200x.c:219: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/nxt200x.c:242: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/nxt200x.c:245: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/nxt200x.c:377: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/nxt200x.c:558: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/nxt200x.c:583: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/nxt200x.c:597: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/nxt200x.c:613: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/nxt200x.c:629: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/nxt200x.c:641: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/nxt200x.c:667: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/nxt200x.c:723: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/nxt200x.c:745: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/nxt200x.c:1117: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/si21xx.c:467: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/si21xx.c:470: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/dvb-frontends/stv0900_core.c:1948: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/tuners/mt2063.c:1852: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/usb/b2c2/flexcop-usb.c:198: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/usb/b2c2/flexcop-usb.c:521: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/usb/gspca/pac_common.h:105: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/usb/pwc/pwc-if.c:860: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/usb/pwc/pwc-if.c:872: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/usb/pwc/pwc-if.c:931: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/usb/pwc/pwc-if.c:957: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/usb/pwc/pwc-if.c:976: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/usb/pwc/pwc-if.c:988: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/usb/pwc/pwc-if.c:1001: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/usb/pwc/pwc-if.c:1019: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/usb/tm6000/tm6000-core.c:674: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/usb/tm6000/tm6000-core.c:696: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/usb/tm6000/tm6000-core.c:761: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/usb/ttusb-dec/ttusb_dec.c:1105: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/usb/ttusb-dec/ttusb_dec.c:1109: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/usb/ttusb-dec/ttusb_dec.c:1160: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/media/usb/ttusb-dec/ttusb_dec.c:1164: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/message/fusion/mptbase.c:476: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/misc/mei/hbm.c:1307: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/mmc/host/atmel-mci.c:1919: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/mtd/devices/ms02-nv.c:289: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/mtd/mtdchar.c:884: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or returndrivers/mtd/mtdchar.c:894: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/net/ethernet/8390/mac8390.c:193: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/net/ethernet/8390/mac8390.c:206: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/net/ethernet/cisco/enic/enic_ethtool.c:437: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c:353: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/net/wireless/ath/ath9k/hw.c:2311: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c:1230: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c:1135: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/nfc/trf7970a.c:1385: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/nvdimm/claim.c:205: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/parport/parport_ip32.c:1862: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/pci/controller/pci-v3-semi.c:664: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/pci/hotplug/ibmphp_pci.c:297: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/pci/hotplug/ibmphp_pci.c:1512: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/pinctrl/pinctrl-rockchip.c:2718: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/pinctrl/pinctrl-rockchip.c:2788: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/pinctrl/samsung/pinctrl-s3c24xx.c:111: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/pinctrl/samsung/pinctrl-s3c24xx.c:114: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/pinctrl/samsung/pinctrl-s3c24xx.c:117: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/pinctrl/samsung/pinctrl-s3c24xx.c:120: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/pinctrl/samsung/pinctrl-s3c24xx.c:123: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/platform/x86/acer-wmi.c:795: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/platform/x86/sony-laptop.c:2470: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/platform/x86/sony-laptop.c:2476: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/platform/x86/wmi.c:1263: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/platform/x86/wmi.c:1266: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/platform/x86/wmi.c:1269: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/pnp/pnpbios/rsparser.c:192: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/pnp/pnpbios/rsparser.c:476: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/pnp/pnpbios/rsparser.c:745: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/power/supply/ipaq_micro_battery.c:98: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/power/supply/ipaq_micro_battery.c:101: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/power/supply/ipaq_micro_battery.c:104: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/power/supply/wm831x_power.c:671: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/s390/char/tape_34xx.c:654: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/s390/char/tape_3590.c:946: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/s390/scsi/zfcp_fc.c:980: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/s390/scsi/zfcp_fc.c:983: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/aic94xx/aic94xx_task.c:272: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/arcmsr/arcmsr_hba.c:2702: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/arcmsr/arcmsr_hba.c:2705: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/be2iscsi/be_mgmt.c:1251: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/be2iscsi/be_mgmt.c:1254: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/bfa/bfa_ioc.h:1001: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/bfa/bfa_ioc.h:1004: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/bfa/bfa_ioc.h:1007: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/bfa/bfa_ioc.h:1019: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/bfa/bfa_ioc.h:1022: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/bfa/bfa_ioc.h:1025: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/bnx2fc/bnx2fc_hwi.c:773: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/fcoe/fcoe.c:1897: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/hptiop.c:761: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or returndrivers/scsi/hpsa.c:7443: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or returndrivers/scsi/isci/phy.c:756: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/isci/phy.c:961: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or returndrivers/scsi/ipr.c:9490: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/lpfc/lpfc_debugfs.c:3347: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/lpfc/lpfc_debugfs.c:4387: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/lpfc/lpfc_debugfs.c:4439: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/lpfc/lpfc_debugfs.c:4453: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/lpfc/lpfc_debugfs.c:4495: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/lpfc/lpfc_debugfs.c:4520: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/lpfc/lpfc_debugfs.c:4523: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/lpfc/lpfc_scsi.c:4287: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/lpfc/lpfc_init.c:7189: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/lpfc/lpfc_sli.c:9192: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/lpfc/lpfc_sli.c:10075: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/lpfc/lpfc_sli.c:10237: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/mvumi.c:2299: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or returndrivers/scsi/nsp32.c:2114: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or returndrivers/scsi/nsp32.c:2125: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/qla2xxx/qla_mbx.c:4026: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/st.c:2849: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/scsi/sym53c8xx_2/sym_hipd.c:4599: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:907: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:910: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:913: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:916: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:998: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1035: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1322: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1699: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1702: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1705: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1708: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/tty/nozomi.c:417: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or returndrivers/tty/nozomi.c:421: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or returndrivers/tty/nozomi.c:463: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or returndrivers/tty/nozomi.c:471: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or returndrivers/tty/serial/imx.c:323: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/tty/serial/imx.c:334: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/tty/serial/imx.c:337: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/tty/serial/imx.c:340: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/tty/serial/imx.c:343: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/usb/gadget/function/f_hid.c:516: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/usb/gadget/function/f_hid.c:524: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/usb/gadget/function/f_hid.c:530: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/usb/gadget/function/f_hid.c:547: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/usb/gadget/function/f_hid.c:565: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/usb/gadget/function/f_hid.c:573: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/usb/gadget/function/f_hid.c:579: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/usb/gadget/function/f_hid.c:587: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/usb/host/xhci-mem.c:1147: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/usb/image/microtek.c:294: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/usb/misc/iowarrior.c:387: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/usb/misc/iowarrior.c:457: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/usb/misc/iowarrior.c:464: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/usb/misc/usblcd.c:190: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/usb/serial/iuu_phoenix.c:853: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/usb/serial/iuu_phoenix.c:867: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/usb/storage/freecom.c:434: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/video/fbdev/amifb.c:1212: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/video/fbdev/core/fbcon.c:1915: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/video/fbdev/core/fbcon.c:2006: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/vme/bridges/vme_ca91cx42.c:372: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/vme/bridges/vme_ca91cx42.c:681: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/vme/bridges/vme_ca91cx42.c:713: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/vme/bridges/vme_ca91cx42.c:1126: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/vme/bridges/vme_ca91cx42.c:1338: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/vme/bridges/vme_tsi148.c:509: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/vme/bridges/vme_tsi148.c:998: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/vme/bridges/vme_tsi148.c:1506: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/vme/bridges/vme_tsi148.c:1606: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/vme/bridges/vme_tsi148.c:1704: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/vme/bridges/vme_tsi148.c:1741: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/vme/bridges/vme_tsi148.c:1967: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return drivers/vme/vme.c:71: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or returndrivers/vme/vme.c:182: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or returndrivers/vme/vme.c:190: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or returndrivers/vme/vme.c:193: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or returndrivers/vme/vme.c:197: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or returnfs/efs/inode.c:166: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or returnfs/ocfs2/cluster/tcp.c:1201: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or returnkernel/bpf/syscall.c:2786: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return samples/hidraw/hid-example.c:168: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return samples/hidraw/hid-example.c:171: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return samples/hidraw/hid-example.c:174: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return samples/hidraw/hid-example.c:177: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return samples/hidraw/hid-example.c:180: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return security/integrity/ima/ima_appraise.c:173: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return security/keys/trusted-keys/trusted_tpm1.c:904: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return sound/oss/dmasound/dmasound_core.c:1002: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return sound/oss/dmasound/dmasound_core.c:1006: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return sound/oss/dmasound/dmasound_core.c:1023: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return sound/oss/dmasound/dmasound_core.c:1047: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return sound/oss/dmasound/dmasound_core.c:1126: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return sound/oss/dmasound/dmasound_core.c:1261: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return sound/pci/echoaudio/midi.c:100: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return sound/pci/echoaudio/midi.c:104: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or returnsound/pci/rme32.c:471: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or returnsound/pci/rme9652/rme9652.c:735: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return sound/pci/rme9652/rme9652.c:739: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return sound/pci/rme9652/rme9652.c:743: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return sound/pci/rme9652/rme9652.c:747: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return sound/pci/rme9652/rme9652.c:751: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return sound/pci/rme9652/rme9652.c:755: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return sound/pci/rme9652/rme9652.c:762: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return sound/pci/rme9652/hdspm.c:2289: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return sound/pci/rme9652/hdspm.c:2315: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return sound/pci/rme9652/hdspm.c:2341: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return sound/pci/rme9652/hdspm.c:2361: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return sound/pci/rme9652/hdspm.c:3848: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return sound/pci/rme9652/hdspm.c:3859: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return sound/soc/codecs/wl1273.c:314: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return sound/soc/intel/skylake/skl-pcm.c:505: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return sound/soc/sh/hac.c:254: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return sound/soc/ti/davinci-mcasp.c:2388: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return tools/perf/ui/stdio/hist.c:401: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return tools/perf/ui/stdio/hist.c:404: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return tools/perf/util/probe-event.c:1516: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return tools/power/acpi/tools/acpidbg/acpidbg.c:412: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return tools/power/acpi/tools/acpidbg/acpidbg.c:418: WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return
_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 11 lines · Joe Perches
Quoted 10 lines · On Sat, 2020-10-17 at 09:09 -0700, [email protected] wrote:
From: Tom Rix <[email protected]>
This is a upcoming change to clean up a new warning treewide.
I am wondering if the change could be one mega patch (see below) or normal patch per file about 100 patches or somewhere half way by collecting early acks.clang has a number of useful, new warnings see
https://clang.llvm.org/docs/DiagnosticsReference.html
Quoted 6 lines
Quoted 3 lines
This change cleans up -Wunreachable-code-break
https://clang.llvm.org/docs/DiagnosticsReference.html#wunreachable-code-break
for 266 of 485 warnings in this week's linux-next, allyesconfig onx86_64.Early acks/individual patches by subsystem would be good. Better still would be an automated cocci script.
Coccinelle is not especially good at this, because it is based on control flow, and a return or goto diverts the control flow away from the break. A hack to solve the problem is to put an if around the return or goto, but that gives the break a meaningless file name and line number. I collected the following list, but it only has 439 results, so fewer than clang. But maybe there are some files that are not considered by clang in the x86 allyesconfig configuration.
Probably checkpatch is the best solution here, since it is not configuration sensitive and doesn't care about control flow.
julia
drivers/scsi/mvumi.c: function mvumi_cfg_hw_reg line 114drivers/watchdog/geodewdt.c: function geodewdt_ioctl line 18drivers/media/usb/b2c2/flexcop-usb.c: function flexcop_usb_init line 21 drivers/media/usb/b2c2/flexcop-usb.c: function flexcop_usb_memory_req line 20drivers/tty/nozomi.c: function write_mem32 line 17drivers/tty/nozomi.c: function write_mem32 line 25drivers/tty/nozomi.c: function read_mem32 line 17drivers/tty/nozomi.c: function read_mem32 line 21sound/soc/codecs/wl1273.c: function wl1273_startup line 27drivers/iio/adc/meson_saradc.c: function meson_sar_adc_iio_info_read_raw line 12 drivers/iio/adc/meson_saradc.c: function meson_sar_adc_iio_info_read_raw line 19 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c: function map_transmitter_id_to_phy_instance line 6 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c: function map_transmitter_id_to_phy_instance line 9 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c: function map_transmitter_id_to_phy_instance line 12 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c: function map_transmitter_id_to_phy_instance line 15 drivers/media/tuners/mt2063.c: function mt2063_init line 81drivers/nfc/st21nfca/core.c: function st21nfca_hci_im_transceive line 46arch/sh/boards/mach-landisk/gio.c: function gio_ioctl line 53drivers/gpu/drm/mgag200/mgag200_mode.c: function mgag200_crtc_set_plls line 11 drivers/gpu/drm/mgag200/mgag200_mode.c: function mgag200_crtc_set_plls line 15 drivers/gpu/drm/mgag200/mgag200_mode.c: function mgag200_crtc_set_plls line 18 drivers/gpu/drm/mgag200/mgag200_mode.c: function mgag200_crtc_set_plls line 22 drivers/gpu/drm/mgag200/mgag200_mode.c: function mgag200_crtc_set_plls line 25 drivers/media/dvb-frontends/cx24117.c: function cx24117_attach line 16drivers/block/xen-blkback/blkback.c: function dispatch_rw_block_io line 48 drivers/platform/x86/sony-laptop.c: function __sony_nc_gfx_switch_status_get line 16 drivers/platform/x86/sony-laptop.c: function __sony_nc_gfx_switch_status_get line 22 drivers/platform/x86/sony-laptop.c: function __sony_nc_gfx_switch_status_get line 31 drivers/char/mwave/mwavedd.c: function mwave_ioctl line 288drivers/scsi/be2iscsi/be_mgmt.c: function beiscsi_adap_family_disp line 15drivers/scsi/be2iscsi/be_mgmt.c: function beiscsi_adap_family_disp line 19drivers/scsi/be2iscsi/be_mgmt.c: function beiscsi_adap_family_disp line 22drivers/scsi/be2iscsi/be_mgmt.c: function beiscsi_adap_family_disp line 27 drivers/iio/imu/bmi160/bmi160_core.c: function bmi160_write_raw line 11drivers/block/z2ram.c: function z2_open line 138drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c: function _rtl8723e_set_media_status line 38 samples/hidraw/hid-example.c: function bus_str line 6samples/hidraw/hid-example.c: function bus_str line 9samples/hidraw/hid-example.c: function bus_str line 12samples/hidraw/hid-example.c: function bus_str line 15samples/hidraw/hid-example.c: function bus_str line 18drivers/scsi/ipr.c: function ipr_pci_error_detected line 10drivers/gpio/gpio-bd70528.c: function bd70528_gpio_set_config line 11drivers/gpio/gpio-bd70528.c: function bd70528_gpio_set_config line 17drivers/gpio/gpio-bd70528.c: function bd70528_gpio_set_config line 21drivers/pinctrl/pinctrl-rockchip.c: function rockchip_pinconf_get line 71 drivers/pinctrl/pinctrl-rockchip.c: function rockchip_pinconf_set line 74 drivers/gpu/drm/amd/display/include/signal_types.h: function dc_is_dvi_signal line 6 security/keys/trusted-keys/trusted_tpm1.c: function datablob_parse line 63arch/x86/math-emu/fpu_trig.c: function fyl2xp1 line 71drivers/usb/gadget/function/f_hid.c: function hidg_setup line 26drivers/usb/gadget/function/f_hid.c: function hidg_setup line 34drivers/usb/gadget/function/f_hid.c: function hidg_setup line 40drivers/usb/gadget/function/f_hid.c: function hidg_setup line 58drivers/usb/gadget/function/f_hid.c: function hidg_setup line 76drivers/usb/gadget/function/f_hid.c: function hidg_setup line 84drivers/usb/gadget/function/f_hid.c: function hidg_setup line 90drivers/usb/gadget/function/f_hid.c: function hidg_setup line 98drivers/staging/rts5208/rtsx_scsi.c: function start_stop_unit line 29drivers/platform/x86/wmi.c: function acpi_wmi_ec_space_handler line 31drivers/platform/x86/wmi.c: function acpi_wmi_ec_space_handler line 34drivers/platform/x86/wmi.c: function acpi_wmi_ec_space_handler line 37drivers/nvdimm/claim.c: function nd_namespace_store line 72sound/soc/ti/davinci-mcasp.c: function davinci_mcasp_probe line 265 drivers/gpu/drm/nouveau/nvkm/subdev/clk/mcp77.c: function mcp77_clk_read line 66 drivers/gpu/drm/nouveau/nvkm/subdev/clk/mcp77.c: function mcp77_clk_read line 73 drivers/gpu/drm/nouveau/nvkm/subdev/clk/mcp77.c: function mcp77_clk_read line 76 tools/testing/selftests/powerpc/pmu/ebb/trace.c: function trace_decode_reg line 3 tools/testing/selftests/powerpc/pmu/ebb/trace.c: function trace_decode_reg line 4 tools/testing/selftests/powerpc/pmu/ebb/trace.c: function trace_decode_reg line 5 tools/testing/selftests/powerpc/pmu/ebb/trace.c: function trace_decode_reg line 6 tools/testing/selftests/powerpc/pmu/ebb/trace.c: function trace_decode_reg line 7 tools/testing/selftests/powerpc/pmu/ebb/trace.c: function trace_decode_reg line 8 tools/testing/selftests/powerpc/pmu/ebb/trace.c: function trace_decode_reg line 9 tools/testing/selftests/powerpc/pmu/ebb/trace.c: function trace_decode_reg line 10 tools/testing/selftests/powerpc/pmu/ebb/trace.c: function trace_decode_reg line 11 tools/testing/selftests/powerpc/pmu/ebb/trace.c: function trace_decode_reg line 12 tools/testing/selftests/powerpc/pmu/ebb/trace.c: function trace_decode_reg line 13 tools/testing/selftests/powerpc/pmu/ebb/trace.c: function trace_decode_reg line 14 tools/testing/selftests/powerpc/pmu/ebb/trace.c: function trace_decode_reg line 15 tools/testing/selftests/powerpc/pmu/ebb/trace.c: function trace_decode_reg line 16 tools/testing/selftests/powerpc/pmu/ebb/trace.c: function trace_decode_reg line 17 tools/testing/selftests/powerpc/pmu/ebb/trace.c: function trace_decode_reg line 18 tools/testing/selftests/powerpc/pmu/ebb/trace.c: function trace_decode_reg line 19 tools/testing/selftests/powerpc/pmu/ebb/trace.c: function trace_decode_reg line 20 tools/testing/selftests/powerpc/pmu/ebb/trace.c: function trace_decode_reg line 21 drivers/media/usb/pwc/pwc-if.c: function usb_pwc_probe line 91drivers/media/usb/pwc/pwc-if.c: function usb_pwc_probe line 103drivers/media/usb/pwc/pwc-if.c: function usb_pwc_probe line 162drivers/media/usb/pwc/pwc-if.c: function usb_pwc_probe line 188drivers/media/usb/pwc/pwc-if.c: function usb_pwc_probe line 207drivers/media/usb/pwc/pwc-if.c: function usb_pwc_probe line 219drivers/media/usb/pwc/pwc-if.c: function usb_pwc_probe line 232drivers/media/usb/pwc/pwc-if.c: function usb_pwc_probe line 250drivers/media/dvb-frontends/drx39xyj/drxj.c: function ctrl_set_standard line 76 drivers/media/dvb-frontends/drx39xyj/drxj.c: function ctrl_set_uio_cfg line 65 drivers/media/dvb-frontends/drx39xyj/drxj.c: function ctrl_set_uio_cfg line 90 drivers/media/dvb-frontends/drx39xyj/drxj.c: function ctrl_set_uio_cfg line 115 drivers/media/dvb-frontends/drx39xyj/drxj.c: function hi_command line 52 drivers/media/dvb-frontends/drx39xyj/drxj.c: function get_device_capabilities line 182 drivers/media/dvb-frontends/drx39xyj/drxj.c: function ctrl_power_mode line 40 drivers/media/dvb-frontends/drx39xyj/drxj.c: function drx_ctrl_u_code line 159 drivers/macintosh/via-pmu-led.c: function pmu_led_set line 15drivers/net/wan/lmc/lmc_proto.c: function lmc_proto_type line 5drivers/net/wan/lmc/lmc_proto.c: function lmc_proto_type line 8drivers/net/wan/lmc/lmc_proto.c: function lmc_proto_type line 11drivers/net/wan/lmc/lmc_proto.c: function lmc_proto_type line 15 drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c: function rtl8812ae_phy_config_rf_with_headerfile line 20 drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c: function rtl8812ae_phy_config_rf_with_headerfile line 26 drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c: function rtl8821ae_phy_config_rf_with_headerfile line 18 arch/mips/loongson2ef/common/cs5536/cs5536_isa.c: function pci_isa_read_reg line 48 arch/mips/loongson2ef/common/cs5536/cs5536_isa.c: function pci_isa_read_reg line 51 arch/mips/loongson2ef/common/cs5536/cs5536_isa.c: function pci_isa_read_reg line 54 arch/mips/loongson2ef/common/cs5536/cs5536_isa.c: function pci_isa_read_reg line 59 arch/mips/loongson2ef/common/cs5536/cs5536_isa.c: function pci_isa_read_reg line 62 arch/mips/include/asm/mach-au1x00/au1000.h: function alchemy_get_cputype line 5 arch/mips/include/asm/mach-au1x00/au1000.h: function alchemy_get_cputype line 8 arch/mips/include/asm/mach-au1x00/au1000.h: function alchemy_get_cputype line 11 arch/mips/include/asm/mach-au1x00/au1000.h: function alchemy_get_cputype line 14 arch/mips/include/asm/mach-au1x00/au1000.h: function alchemy_get_cputype line 18 arch/mips/include/asm/mach-au1x00/au1000.h: function alchemy_get_cputype line 21 arch/x86/kernel/cpu/microcode/amd.c: function __verify_patch_size line 21 drivers/scsi/aic94xx/aic94xx_task.c: function asd_task_tasklet_complete line 78 drivers/parport/parport_ip32.c: function parport_ip32_fifo_supported line 27 drivers/staging/comedi/drivers/ni_mio_common.c: function ni_serial_insn_config line 90 drivers/power/supply/ipaq_micro_battery.c: function get_capacity line 7 drivers/power/supply/ipaq_micro_battery.c: function get_capacity line 10 drivers/power/supply/ipaq_micro_battery.c: function get_capacity line 13 drivers/net/wireless/marvell/mwifiex/cfg80211.c: function mwifiex_cfg80211_change_virtual_intf line 95 drivers/net/wireless/marvell/mwifiex/cfg80211.c: function mwifiex_cfg80211_change_virtual_intf line 143 fs/ocfs2/cluster/tcp.c: function o2net_process_message line 33drivers/scsi/hpsa.c: function find_PCI_BAR_index line 27drivers/s390/char/tape_34xx.c: function tape_34xx_unit_check line 351drivers/scsi/nsp32.c: function nsp32_msgin_occur line 193drivers/scsi/nsp32.c: function nsp32_msgin_occur line 204drivers/scsi/nsp32.c: function nsp32_msgin_occur line 215drivers/scsi/nsp32.c: function nsp32_msgin_occur line 220drivers/usb/misc/iowarrior.c: function iowarrior_write line 44drivers/usb/misc/iowarrior.c: function iowarrior_write line 114drivers/usb/misc/iowarrior.c: function iowarrior_write line 121 drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c: function map_transmitter_id_to_phy_instance line 6 drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c: function map_transmitter_id_to_phy_instance line 9 drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c: function map_transmitter_id_to_phy_instance line 12 drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c: function map_transmitter_id_to_phy_instance line 15 drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c: function map_transmitter_id_to_phy_instance line 18 drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c: function map_transmitter_id_to_phy_instance line 21 drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c: function map_transmitter_id_to_phy_instance line 24 drivers/usb/image/microtek.c: function mts_show_command line 72security/safesetid/lsm.c: function safesetid_security_capable line 41security/safesetid/lsm.c: function safesetid_security_capable line 57security/safesetid/lsm.c: function safesetid_security_capable line 61arch/powerpc/net/bpf_jit_comp.c: function bpf_jit_build_body line 345arch/mips/rb532/setup.c: function get_system_type line 5arch/mips/rb532/setup.c: function get_system_type line 8sound/soc/intel/skylake/skl-pcm.c: function skl_pcm_trigger line 46drivers/scsi/pcmcia/nsp_cs.c: function nspintr line 151drivers/usb/storage/freecom.c: function freecom_transport line 220drivers/gpu/drm/radeon/radeon_i2c.c: function r100_hw_i2c_xfer line 133drivers/power/supply/wm831x_power.c: function wm831x_power_probe line 141drivers/platform/x86/acer-wmi.c: function AMW0_set_u32 line 34drivers/scsi/bnx2fc/bnx2fc_hwi.c: function bnx2fc_process_unsol_compl line 150 drivers/isdn/mISDN/dsp_dtmf.c: function dsp_dtmf_goertzel_decode line 57 drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c: function map_transmitter_id_to_phy_instance line 6 drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c: function map_transmitter_id_to_phy_instance line 9 drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c: function map_transmitter_id_to_phy_instance line 12 drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c: function map_transmitter_id_to_phy_instance line 15 drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c: function map_transmitter_id_to_phy_instance line 18 drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c: function map_transmitter_id_to_phy_instance line 21 drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c: function map_transmitter_id_to_phy_instance line 24 drivers/s390/scsi/zfcp_fc.c: function zfcp_fc_job_wka_port line 22drivers/s390/scsi/zfcp_fc.c: function zfcp_fc_job_wka_port line 25 drivers/media/dvb-frontends/stv0900_core.c: function stv0900_attach line 52 drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c: function ixgbe_calc_eeprom_checksum_X540 line 47 drivers/scsi/isci/phy.c: function sci_phy_event_handler line 72drivers/scsi/isci/phy.c: function sci_phy_event_handler line 277drivers/vme/vme.c: function find_bridge line 8drivers/vme/vme.c: function find_bridge line 13drivers/vme/vme.c: function find_bridge line 18drivers/vme/vme.c: function find_bridge line 23drivers/vme/vme.c: function find_bridge line 27drivers/vme/vme.c: function vme_get_size line 16drivers/vme/vme.c: function vme_get_size line 25drivers/vme/vme.c: function vme_get_size line 28drivers/vme/vme.c: function vme_get_size line 32drivers/scsi/lpfc/lpfc_debugfs.c: function lpfc_idiag_pcicfg_read line 59drivers/scsi/lpfc/lpfc_debugfs.c: function lpfc_idiag_queacc_write line 64drivers/scsi/lpfc/lpfc_debugfs.c: function lpfc_idiag_queacc_write line 120 drivers/scsi/lpfc/lpfc_debugfs.c: function lpfc_idiag_queacc_write line 135 drivers/scsi/lpfc/lpfc_debugfs.c: function lpfc_idiag_queacc_write line 180 drivers/scsi/lpfc/lpfc_debugfs.c: function lpfc_idiag_queacc_write line 207 drivers/scsi/lpfc/lpfc_debugfs.c: function lpfc_idiag_queacc_write line 210drivers/gpu/drm/qxl/qxl_ioctl.c: function qxl_process_single_command line 21 drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c: function map_transmitter_id_to_phy_instance line 6 drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c: function map_transmitter_id_to_phy_instance line 9 drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c: function map_transmitter_id_to_phy_instance line 12 drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c: function map_transmitter_id_to_phy_instance line 15 drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c: function map_transmitter_id_to_phy_instance line 18 drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c: function map_transmitter_id_to_phy_instance line 21 drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c: function map_transmitter_id_to_phy_instance line 24 drivers/net/wireless/ath/ath10k/htt_rx.c: function ath10k_htt_t2h_msg_handler line 119 drivers/gpu/drm/nouveau/nvkm/subdev/bios/pll.c: function pll_map line 11 drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramnv50.c: function nv50_ram_timing_read line 24 sound/pci/rme9652/rme9652.c: function rme9652_spdif_sample_rate line 34sound/pci/rme9652/rme9652.c: function rme9652_spdif_sample_rate line 38sound/pci/rme9652/rme9652.c: function rme9652_spdif_sample_rate line 42sound/pci/rme9652/rme9652.c: function rme9652_spdif_sample_rate line 46sound/pci/rme9652/rme9652.c: function rme9652_spdif_sample_rate line 50sound/pci/rme9652/rme9652.c: function rme9652_spdif_sample_rate line 54sound/pci/rme9652/rme9652.c: function rme9652_spdif_sample_rate line 61 drivers/gpu/drm/amd/amdgpu/dce_v11_0.c: function dce_v11_0_pick_dig_encoder line 32 drivers/media/usb/go7007/go7007-usb.c: function go7007_usb_probe line 58drivers/pnp/pnpbios/rsparser.c: function pnpbios_encode_allocated_resource_data line 95 drivers/pnp/pnpbios/rsparser.c: function pnpbios_parse_compatible_ids line 48 drivers/pnp/pnpbios/rsparser.c: function pnpbios_parse_allocated_resource_data line 120 drivers/net/wireless/ath/ath6kl/testmode.c: function ath6kl_tm_cmd line 31drivers/misc/mei/hbm.c: function mei_hbm_dispatch line 277drivers/scsi/hptiop.c: function hptiop_finish_scsi_req line 45drivers/pinctrl/samsung/pinctrl-s3c24xx.c: function s3c24xx_eint_get_trigger line 5 drivers/pinctrl/samsung/pinctrl-s3c24xx.c: function s3c24xx_eint_get_trigger line 8 drivers/pinctrl/samsung/pinctrl-s3c24xx.c: function s3c24xx_eint_get_trigger line 11 drivers/pinctrl/samsung/pinctrl-s3c24xx.c: function s3c24xx_eint_get_trigger line 14 drivers/pinctrl/samsung/pinctrl-s3c24xx.c: function s3c24xx_eint_get_trigger line 17 drivers/base/power/main.c: function pm_op line 18kernel/bpf/syscall.c: function attach_type_to_prog_type line 7drivers/pci/hotplug/ibmphp_pci.c: function ibmphp_configure_card line 234drivers/pci/hotplug/ibmphp_pci.c: function unconfigure_boot_card line 96drivers/scsi/fcoe/fcoe.c: function fcoe_device_notification line 54drivers/scsi/lpfc/lpfc_sli.c: function lpfc_mbox_api_table_setup line 26drivers/scsi/lpfc/lpfc_sli.c: function lpfc_sli_api_table_setup line 18drivers/scsi/lpfc/lpfc_sli.c: function lpfc_sli4_iocb2wqe line 567drivers/media/dvb-frontends/drxd_hard.c: function CorrectSysClockDeviation line 43 tools/perf/util/probe-event.c: function parse_perf_probe_point line 174drivers/scsi/bfa/bfa_ioc.h: function bfa_cb_image_get_chunk line 6drivers/scsi/bfa/bfa_ioc.h: function bfa_cb_image_get_chunk line 9drivers/scsi/bfa/bfa_ioc.h: function bfa_cb_image_get_chunk line 12drivers/scsi/bfa/bfa_ioc.h: function bfa_cb_image_get_size line 6drivers/scsi/bfa/bfa_ioc.h: function bfa_cb_image_get_size line 9drivers/scsi/bfa/bfa_ioc.h: function bfa_cb_image_get_size line 12 drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c: function map_transmitter_id_to_phy_instance line 6 drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c: function map_transmitter_id_to_phy_instance line 9 drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c: function map_transmitter_id_to_phy_instance line 12 drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c: function map_transmitter_id_to_phy_instance line 15 drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c: function map_transmitter_id_to_phy_instance line 18 drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c: function map_transmitter_id_to_phy_instance line 21 drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c: function map_transmitter_id_to_phy_instance line 24 drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c: function _rtl88ee_set_media_status line 35 sound/oss/dmasound/dmasound_core.c: function sq_ioctl line 12sound/oss/dmasound/dmasound_core.c: function sq_ioctl line 16sound/oss/dmasound/dmasound_core.c: function sq_ioctl line 33sound/oss/dmasound/dmasound_core.c: function sq_ioctl line 57sound/oss/dmasound/dmasound_core.c: function sq_ioctl line 143sound/oss/dmasound/dmasound_core.c: function get_afmt_string line 5sound/oss/dmasound/dmasound_core.c: function get_afmt_string line 8sound/oss/dmasound/dmasound_core.c: function get_afmt_string line 11sound/oss/dmasound/dmasound_core.c: function get_afmt_string line 14sound/oss/dmasound/dmasound_core.c: function get_afmt_string line 17sound/oss/dmasound/dmasound_core.c: function get_afmt_string line 20sound/oss/dmasound/dmasound_core.c: function get_afmt_string line 23sound/oss/dmasound/dmasound_core.c: function get_afmt_string line 26sound/oss/dmasound/dmasound_core.c: function get_afmt_string line 29drivers/s390/char/tape_3590.c: function tape_3590_erp_read_opposite line 15 drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c: function map_transmitter_id_to_phy_instance line 6 drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c: function map_transmitter_id_to_phy_instance line 9 drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c: function map_transmitter_id_to_phy_instance line 12 drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c: function map_transmitter_id_to_phy_instance line 15 drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c: function map_transmitter_id_to_phy_instance line 18 drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c: function map_transmitter_id_to_phy_instance line 21 drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c: function map_transmitter_id_to_phy_instance line 24 drivers/media/usb/ttusb-dec/ttusb_dec.c: function ttusb_dec_start_feed line 16 drivers/media/usb/ttusb-dec/ttusb_dec.c: function ttusb_dec_start_feed line 20 drivers/media/usb/ttusb-dec/ttusb_dec.c: function ttusb_dec_stop_feed line 7 drivers/media/usb/ttusb-dec/ttusb_dec.c: function ttusb_dec_stop_feed line 11 drivers/net/ethernet/cisco/enic/enic_ethtool.c: function enic_grxclsrule line 19 security/integrity/ima/ima_appraise.c: function ima_get_hash_algo line 18sound/pci/rme9652/hdspm.c: function hdspm_get_aes_sample_rate line 8sound/pci/rme9652/hdspm.c: function hdspm_wc_sync_check line 16sound/pci/rme9652/hdspm.c: function hdspm_wc_sync_check line 29sound/pci/rme9652/hdspm.c: function hdspm_wc_sync_check line 43sound/pci/rme9652/hdspm.c: function hdspm_get_tco_sample_rate line 10sound/pci/rme9652/hdspm.c: function hdspm_get_sync_in_sample_rate line 10sound/pci/rme9652/hdspm.c: function hdspm_get_wc_sample_rate line 9drivers/nfc/trf7970a.c: function trf7970a_is_iso15693_write_or_lock line 11 drivers/media/usb/gspca/pac_common.h: function pac_find_sof line 45 drivers/net/ethernet/aquantia/atlantic/aq_nic.c: function aq_nic_set_link_ksettings line 46 drivers/scsi/lpfc/lpfc_scsi.c: function lpfc_scsi_api_table_setup line 25 drivers/media/dvb-frontends/nxt200x.c: function nxt200x_readreg_multibyte line 18 drivers/media/dvb-frontends/nxt200x.c: function nxt200x_readreg_multibyte line 41 drivers/media/dvb-frontends/nxt200x.c: function nxt200x_readreg_multibyte line 44 drivers/media/dvb-frontends/nxt200x.c: function nxt200x_writereg_multibyte line 30 drivers/media/dvb-frontends/nxt200x.c: function nxt200x_writereg_multibyte line 54 drivers/media/dvb-frontends/nxt200x.c: function nxt200x_setup_frontend_parameters line 33 drivers/media/dvb-frontends/nxt200x.c: function nxt200x_setup_frontend_parameters line 58 drivers/media/dvb-frontends/nxt200x.c: function nxt200x_setup_frontend_parameters line 72 drivers/media/dvb-frontends/nxt200x.c: function nxt200x_setup_frontend_parameters line 88 drivers/media/dvb-frontends/nxt200x.c: function nxt200x_setup_frontend_parameters line 104 drivers/media/dvb-frontends/nxt200x.c: function nxt200x_setup_frontend_parameters line 116 drivers/media/dvb-frontends/nxt200x.c: function nxt200x_setup_frontend_parameters line 142 drivers/media/dvb-frontends/nxt200x.c: function nxt200x_setup_frontend_parameters line 198 drivers/media/dvb-frontends/nxt200x.c: function nxt200x_setup_frontend_parameters line 220 drivers/media/dvb-frontends/nxt200x.c: function nxt200x_init line 15drivers/media/dvb-frontends/nxt200x.c: function nxt200x_writetuner line 57drivers/tty/serial/imx.c: function imx_uart_readl line 5drivers/tty/serial/imx.c: function imx_uart_readl line 16drivers/tty/serial/imx.c: function imx_uart_readl line 19drivers/tty/serial/imx.c: function imx_uart_readl line 22drivers/tty/serial/imx.c: function imx_uart_readl line 25drivers/crypto/atmel-sha.c: function atmel_sha_init line 37drivers/edac/amd64_edac.c: function map_err_sym_to_channel line 7drivers/edac/amd64_edac.c: function map_err_sym_to_channel line 11drivers/edac/amd64_edac.c: function map_err_sym_to_channel line 14drivers/edac/amd64_edac.c: function map_err_sym_to_channel line 24drivers/edac/amd64_edac.c: function map_err_sym_to_channel line 28drivers/edac/amd64_edac.c: function map_err_sym_to_channel line 31drivers/edac/amd64_edac.c: function map_err_sym_to_channel line 34 drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c: function map_transmitter_id_to_phy_instance line 6 drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c: function map_transmitter_id_to_phy_instance line 9 drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c: function map_transmitter_id_to_phy_instance line 12 drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c: function map_transmitter_id_to_phy_instance line 15 drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c: function map_transmitter_id_to_phy_instance line 18 drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c: function map_transmitter_id_to_phy_instance line 21 drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c: function map_transmitter_id_to_phy_instance line 24 drivers/scsi/st.c: function st_int_ioctl line 155drivers/infiniband/hw/cxgb4/qp.c: function c4iw_modify_qp line 146drivers/infiniband/hw/cxgb4/qp.c: function c4iw_modify_qp line 195drivers/infiniband/hw/cxgb4/qp.c: function c4iw_modify_qp line 200 drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c: function mcp251xfd_get_mode_str line 4 drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c: function mcp251xfd_get_mode_str line 6 drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c: function mcp251xfd_get_mode_str line 8 drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c: function mcp251xfd_get_mode_str line 10 drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c: function mcp251xfd_get_mode_str line 12 drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c: function mcp251xfd_get_mode_str line 14 drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c: function mcp251xfd_get_mode_str line 16 drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c: function mcp251xfd_get_mode_str line 18 drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c: function __mcp251xfd_get_model_str line 4 drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c: function __mcp251xfd_get_model_str line 6 drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c: function __mcp251xfd_get_model_str line 8 drivers/ata/libata-scsi.c: function ata_get_xlat_func line 35drivers/char/ipmi/ipmi_devintf.c: function ipmi_ioctl line 201arch/arm/nwfpe/fpa11_cprt.c: function EmulateCPRT line 15arch/arm/nwfpe/fpa11_cprt.c: function EmulateCPRT line 18drivers/vme/bridges/vme_ca91cx42.c: function ca91cx42_dma_list_add line 108 drivers/vme/bridges/vme_ca91cx42.c: function ca91cx42_master_set line 92drivers/vme/bridges/vme_ca91cx42.c: function ca91cx42_master_set line 124 drivers/vme/bridges/vme_ca91cx42.c: function ca91cx42_slave_set line 39drivers/vme/bridges/vme_ca91cx42.c: function ca91cx42_lm_set line 45drivers/scsi/sym53c8xx_2/sym_hipd.c: function sym_int_sir line 230drivers/gpu/drm/radeon/r300.c: function r300_packet0_check line 534 drivers/gpu/drm/amd/amdgpu/atombios_encoders.c: function amdgpu_atombios_encoder_get_encoder_mode line 70 drivers/gpu/drm/amd/amdgpu/atombios_encoders.c: function amdgpu_atombios_encoder_get_encoder_mode line 96 drivers/gpu/drm/amd/amdgpu/atombios_encoders.c: function amdgpu_atombios_encoder_get_encoder_mode line 103 drivers/media/dvb-frontends/si21xx.c: function si21xx_set_voltage line 15 drivers/media/dvb-frontends/si21xx.c: function si21xx_set_voltage line 18 drivers/staging/vme/devices/vme_user.c: function vme_user_ioctl line 75 drivers/staging/vme/devices/vme_user.c: function vme_user_ioctl line 119drivers/mmc/host/atmel-mci.c: function atmci_tasklet_func line 197drivers/irqchip/irq-mips-gic.c: function gic_ipi_domain_match line 9 drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: function input_buffer_configuration line 47 drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: function input_buffer_configuration line 84 drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: function input_system_configure_channel line 14 drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: function input_system_configure_channel line 17 drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: function input_system_configure_channel line 20 drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: function input_system_configure_channel line 23 drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: function configuration_to_registers line 83 drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: function input_system_configure_channel_sensor line 82 drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: function input_system_configure_channel_sensor line 85 drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: function input_system_configure_channel_sensor line 88 drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: function input_system_configure_channel_sensor line 91 drivers/net/ethernet/8390/mac8390.c: function mac8390_ident line 27drivers/net/ethernet/8390/mac8390.c: function mac8390_ident line 42drivers/irqchip/irq-crossbar.c: function crossbar_of_init line 100drivers/mtd/devices/ms02-nv.c: function ms02nv_init line 21arch/powerpc/platforms/cell/spufs/switch.c: function __do_spu_restore line 21 arch/powerpc/platforms/cell/spufs/switch.c: function __do_spu_save line 23 arch/powerpc/include/asm/kvm_book3s_64.h: function kvmppc_hpte_page_shifts line 11 arch/powerpc/include/asm/kvm_book3s_64.h: function kvmppc_hpte_page_shifts line 14 arch/powerpc/include/asm/kvm_book3s_64.h: function kvmppc_hpte_page_shifts line 17 arch/powerpc/include/asm/kvm_book3s_64.h: function kvmppc_hpte_page_shifts line 20 arch/x86/kernel/cpu/mce/core.c: function __mcheck_cpu_ancient_init line 10arch/x86/kernel/cpu/mce/core.c: function __mcheck_cpu_ancient_init line 14sound/pci/echoaudio/midi.c: function mtc_process_data line 10sound/pci/echoaudio/midi.c: function mtc_process_data line 14sound/pci/rme32.c: function snd_rme32_capture_getrate line 36tools/power/acpi/tools/acpidbg/acpidbg.c: function main line 33tools/power/acpi/tools/acpidbg/acpidbg.c: function main line 39drivers/scsi/lpfc/lpfc_init.c: function lpfc_init_api_table_setup line 22 drivers/gpu/drm/amd/amdgpu/dce_v10_0.c: function dce_v10_0_pick_dig_encoder line 32drivers/acpi/utils.c: function acpi_extract_package line 66drivers/acpi/utils.c: function acpi_extract_package line 91drivers/acpi/utils.c: function acpi_extract_package line 106drivers/acpi/utils.c: function acpi_extract_package line 117drivers/char/lp.c: function lp_do_ioctl line 48drivers/mtd/mtdchar.c: function mtdchar_ioctl line 265drivers/mtd/mtdchar.c: function mtdchar_ioctl line 276arch/x86/kvm/emulate.c: function writeback line 26drivers/usb/host/xhci-mem.c: function xhci_setup_addressable_virt_dev line 46 drivers/media/usb/tm6000/tm6000-core.c: function tm6000_set_audio_rinput line 26 drivers/media/usb/tm6000/tm6000-core.c: function tm6000_set_audio_rinput line 48 drivers/media/usb/tm6000/tm6000-core.c: function tm6000_tvaudio_set_mute line 26 drivers/media/dvb-frontends/dib0090.c: function dib0090_fw_identify line 79 drivers/media/dvb-frontends/dib0090.c: function dib0090_identify line 81drivers/net/dsa/b53/b53_common.c: function b53_switch_init line 46 drivers/net/wireless/intel/iwlwifi/mvm/mac-ctxt.c: function iwl_mvm_mac_ctx_send line 9 drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c: function map_transmitter_id_to_phy_instance line 6 drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c: function map_transmitter_id_to_phy_instance line 9 drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c: function map_transmitter_id_to_phy_instance line 12 drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c: function map_transmitter_id_to_phy_instance line 15 drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c: function map_transmitter_id_to_phy_instance line 18 sound/soc/sh/hac.c: function hac_hw_params line 19drivers/gpu/drm/radeon/atombios_encoders.c: function atombios_get_encoder_mode line 83 drivers/gpu/drm/radeon/atombios_encoders.c: function atombios_get_encoder_mode line 119 drivers/gpu/drm/radeon/atombios_encoders.c: function atombios_get_encoder_mode line 126 drivers/pci/controller/pci-v3-semi.c: function v3_get_dma_range_config line 64drivers/video/fbdev/amifb.c: function amifb_probe line 90drivers/video/fbdev/amifb.c: function ami_decode_var line 84fs/efs/inode.c: function efs_iget line 120drivers/vme/bridges/vme_tsi148.c: function tsi148_dma_list_add line 81drivers/vme/bridges/vme_tsi148.c: function tsi148_dma_list_add line 119drivers/vme/bridges/vme_tsi148.c: function tsi148_master_set line 191drivers/vme/bridges/vme_tsi148.c: function tsi148_slave_set line 38drivers/vme/bridges/vme_tsi148.c: function tsi148_dma_set_vme_dest_attributes line 87 drivers/vme/bridges/vme_tsi148.c: function tsi148_dma_set_vme_src_attributes line 87 drivers/vme/bridges/vme_tsi148.c: function tsi148_lm_set line 41net/ipv4/fib_frontend.c: function fib_gw_from_via line 35arch/arm/mach-s3c/mach-rx1950.c: function rx1950_led_blink_set line 17tools/perf/ui/stdio/hist.c: function hist_entry_callchain__fprintf line 15tools/perf/ui/stdio/hist.c: function hist_entry_callchain__fprintf line 21tools/perf/ui/stdio/hist.c: function hist_entry_callchain__fprintf line 24tools/perf/ui/stdio/hist.c: function hist_entry_callchain__fprintf line 27drivers/usb/serial/iuu_phoenix.c: function iuu_uart_baud line 74drivers/usb/serial/iuu_phoenix.c: function iuu_uart_baud line 88drivers/gpu/drm/amd/amdgpu/dce_v8_0.c: function dce_v8_0_pick_dig_encoder line 32 drivers/net/hyperv/netvsc.c: function netvsc_process_raw_pkt line 19 drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c: function map_transmitter_id_to_phy_instance line 6 drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c: function map_transmitter_id_to_phy_instance line 9 drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c: function map_transmitter_id_to_phy_instance line 12 drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c: function map_transmitter_id_to_phy_instance line 15 drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c: function map_transmitter_id_to_phy_instance line 18 drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c: function map_transmitter_id_to_phy_instance line 21 drivers/cpufreq/e_powersaver.c: function eps_cpu_init line 55
_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
Joe Perches
maintainerQuoted 27 lines · Julia Lawall
Quoted 11 lines · Joe Perches
Quoted 10 lines · On Sat, 2020-10-17 at 09:09 -0700, [email protected] wrote:
From: Tom Rix <[email protected]>
This is a upcoming change to clean up a new warning treewide.
I am wondering if the change could be one mega patch (see below) or normal patch per file about 100 patches or somewhere half way by collecting early acks.clang has a number of useful, new warnings see
https://clang.llvm.org/docs/DiagnosticsReference.htmlQuoted 6 lines
Quoted 3 lines
This change cleans up -Wunreachable-code-break
https://clang.llvm.org/docs/DiagnosticsReference.html#wunreachable-code-break
for 266 of 485 warnings in this week's linux-next, allyesconfig onx86_64.Early acks/individual patches by subsystem would be good. Better still would be an automated cocci script.
Coccinelle is not especially good at this, because it is based on control flow, and a return or goto diverts the control flow away from the break. A hack to solve the problem is to put an if around the return or goto, but that gives the break a meaningless file name and line number. I collected the following list, but it only has 439 results, so fewer than clang. But maybe there are some files that are not considered by clang in the x86 allyesconfig configuration.
Quoted 2 lines
Probably checkpatch is the best solution here, since it is not configuration sensitive and doesn't care about control flow.
Likely the clang compiler is the best option here.
It might be useful to add -Wunreachable-code-break to W=1 or just always enable it if it isn't already enabled.
scripts/Makefile.extrawarn +1 -0
@@ -32,6 +32,7 @@ KBUILD_CFLAGS += $(call cc-option, -Wunused-but-set-variable) KBUILD_CFLAGS += $(call cc-option, -Wunused-const-variable) KBUILD_CFLAGS += $(call cc-option, -Wpacked-not-aligned) KBUILD_CFLAGS += $(call cc-option, -Wstringop-truncation) +KBUILD_CFLAGS += $(call cc-option, -Wunreachable-code-break) # The following turn off the warnings enabled by -Wextra KBUILD_CFLAGS += -Wno-missing-field-initializers KBUILD_CFLAGS += -Wno-sign-compare
(and thank you Tom for pushing this forward)
checkpatch can't find instances like:
case FOO: if (foo) return 1; else return 2; break;
As it doesn't track flow and relies on the number of tabs to be the same for any goto/return and break;
checkpatch will warn on:
case FOO: ... goto bar; break;
_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
Joe Perches
maintainerPATCH 1/1 checkpatch: Allow --fix removal of unnecessary break statements
In reply to Julia Lawallswitch/case use of break after a return or goto is unnecessary.
There is an existing warning for these uses, so add a --fix option too.
---
For today's next, this would remove ~300 instances like:
case FOO: return bar; break; or case FOO: goto bar; break;
scripts/checkpatch.pl | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
scripts/checkpatch.pl +5 -2
@@ -3678,8 +3678,11 @@ sub process { if ($sline =~ /^\+([\t]+)break\s*;\s*$/) { my $tabs = $1; if ($prevline =~ /^\+$tabs(?:goto|return)\b/) { - WARN("UNNECESSARY_BREAK", - "break is not useful after a goto or return\n" . $hereprev); + if (WARN("UNNECESSARY_BREAK", + "break is not useful after a goto or return\n" . $hereprev) && + $fix) { + fix_delete_line($fixlinenr, $rawline); + } } }
Re: [PATCH] checkpatch: Allow --fix removal of unnecessary break statements
I like!
Quoted 25 lines · Joe Perches
switch/case use of break after a return or goto is unnecessary.
There is an existing warning for these uses, so add a --fix option too.
Signed-off-by Joe Perches <[email protected]>---
For today's next, this would remove ~300 instances like:
case FOO: return bar; break; or case FOO: goto bar; break;scripts/checkpatch.pl | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)scripts/checkpatch.pl +0
-0
scripts/checkpatch.pl sub process { · line 3680
Quoted 3 lines
scripts/checkpatch.pl +0
-0@@ -3678,8 +3678,11 @@ sub process { if ($sline =~ /^\+([\t]+)break\s*;\s*$/) { my $tabs = $1; if ($prevline =~ /^\+$tabs(?:goto|return)\b/) {
could add a '|break' here to catch the couple
break;
break;
Quoted 12 lines
scripts/checkpatch.pl +5
-2- WARN("UNNECESSARY_BREAK", - "break is not useful after a goto or return\n" . $hereprev); + if (WARN("UNNECESSARY_BREAK", + "break is not useful after a goto or return\n" . $hereprev) && + $fix) { + fix_delete_line($fixlinenr, $rawline); + } } }
Joe Perches
maintainerRe: [PATCH] checkpatch: Allow --fix removal of unnecessary break statements
Quoted 1 line · Tom Rix
I like!
[]
Quoted 1 line
could add a '|break' here to catch the couple
[]
Quoted 3 lines
break;
break;
Unfortunately, checkpatch is really stupid and it
wouldn't catch those
cases as there are blank lines
between the existing consecutive break
statements.
It would catch
break; break;
but there aren't any of those so it seems unlikely to be a very useful addition.
Re: [PATCH] checkpatch: Allow --fix removal of unnecessary break statements
Quoted 14 lines · Joe Perches
Quoted 1 line · Tom Rix
I like!
[]
Quoted 1 line
could add a '|break' here to catch the couple
[]
Quoted 3 lines
break;
break;
Unfortunately, checkpatch is really stupid and it
wouldn't catch those
cases as there are blank lines
between the existing consecutive break
statements.
Quoted 7 lines
It would catch
break; break;but there aren't any of those so it seems unlikely to be a very useful addition.
Unusual, but there are a couple of these.
Here's one from my rfc diff
sound/soc/codecs/wcd-clsh-v2.c +0 -0
@@ -478,11 +478,10 @@ static int _wcd_clsh_ctrl_set_state(struct wcd_clsh_ctrl *ctrl, int req_state,
wcd_clsh_state_hph_l(ctrl, req_state, is_enable, mode); break;
case WCD_CLSH_STATE_HPHR:
wcd_clsh_state_hph_r(ctrl, req_state, is_enable, mode); break;
- break;
case WCD_CLSH_STATE_LO:
wcd_clsh_state_lo(ctrl, req_state, is_enable, mode); break;
default:
break;
Tom
Quoted 1 line
Joe Perches
maintainerRe: [PATCH] checkpatch: Allow --fix removal of unnecessary break statements
Quoted 33 lines · Tom Rix
Quoted 14 lines · Joe Perches
Quoted 1 line · Tom Rix
I like!
[]
Quoted 1 line
could add a '|break' here to catch the couple
[]
Quoted 3 lines
break;
break;
Unfortunately, checkpatch is really stupid and it
wouldn't catch those
cases as there are blank lines
between the existing consecutive break
statements.Quoted 7 lines
It would catch
break; break;but there aren't any of those so it seems unlikely to be a very useful addition.
Unusual, but there are a couple of these.
Here's one from my rfc diff
sound/soc/codecs/wcd-clsh-v2.c +0
-0@@ -478,11 +478,10 @@ static int _wcd_clsh_ctrl_set_state(struct wcd_clsh_ctrl *ctrl, int req_state,wcd_clsh_state_hph_l (ctrl, req_state, is_enable, mode);
sound/soc/codecs/wcd-clsh-v2.c static int _wcd_clsh_ctrl_set_state(struct wcd_clsh_ctrl *ctrl, int req_state, · line 487
Quoted 10 lines
sound/soc/codecs/wcd-clsh-v2.c +0
-1break ;case WCD_CLSH_STATE_HPHR :wcd_clsh_state_hph_r (ctrl, req_state, is_enable, mode);break ; -break ;case WCD_CLSH_STATE_LO :wcd_clsh_state_lo (ctrl, req_state, is_enable, mode);break ;default :break ;
Thanks, I guess my grep skilz ain't good enough.
I used:
.
$ git grep -A1 -n "break;" | grep -B1 -P '\-\d+\-.*break;'
but that doesn't work because the line after the first break is also break then that line also matches break; too so the second grep expecting to match the '-<line#>- break;' doesn't work. That line also matches the first pattern so it's ':<line#>:'
Duh...
This seems to work though:
$ git grep -n -P '^\s*break;\s*$' | \
awk -F: '{if ($1==o1 && $2==o2+1) {print $0;} o1=$1; o2=$2;}'
drivers/gpu/drm/amd/display/dc/dce/dce_transform.c:1333: break;
drivers/media/usb/gspca/sn9c20x.c:1864: break;
drivers/video/fbdev/pm2fb.c:479: break;
drivers/video/fbdev/pm2fb.c:501: break;
sound/soc/codecs/wcd-clsh-v2.c:483: break;Anyway it doesn't hurt to add it.
cheers, Joe
Joe Perches
maintainerPATCH v2 1/1 checkpatch: Allow --fix removal of unnecessary break statements
In reply to Julia Lawallswitch/case use of break after a return, goto or break is unnecessary.
There is an existing warning for the return and goto uses, so add break and a --fix option too.
---
v2: Add break to matched keyword
and change the message to show the matched keyword
For today's next, this would remove ~300 instances like:
case FOO: return bar; break; or case FOO: goto bar; break;
scripts/checkpatch.pl | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)
scripts/checkpatch.pl +8 -4
@@ -3674,12 +3674,16 @@ sub process { } # check indentation of a line with a break; -# if the previous line is a goto or return and is indented the same # of tabs +# if the previous line is a goto, return or break +# and is indented the same # of tabs if ($sline =~ /^\+([\t]+)break\s*;\s*$/) { my $tabs = $1; - if ($prevline =~ /^\+$tabs(?:goto|return)\b/) { - WARN("UNNECESSARY_BREAK", - "break is not useful after a goto or return\n" . $hereprev); + if ($prevline =~ /^\+$tabs(goto|return|break)\b/) { + if (WARN("UNNECESSARY_BREAK", + "break is not useful after a $1\n" . $hereprev) && + $fix) { + fix_delete_line($fixlinenr, $rawline); + } } }
Quoted 58 lines · On Sat, Oct 17, 2020 at 9:10 AM <[email protected]> wrote:
From: Tom Rix <[email protected]>
This is a upcoming change to clean up a new warning treewide.
I am wondering if the change could be one mega patch (see below) or normal patch per file about 100 patches or somewhere half way by collecting early acks.clang has a number of useful, new warnings see
https://clang.llvm.org/docs/DiagnosticsReference.htmlThis change cleans up -Wunreachable-code-break
https://clang.llvm.org/docs/DiagnosticsReference.html#wunreachable-code-break
for 266 of 485 warnings in this week's linux-next, allyesconfig onx86_64.The method of fixing was to look for warnings where the preceding statement was a simple statement and by inspection made the subsequent break unneeded. In order of frequency these look like
return and break
switch (c->x86_vendor) { case X86_VENDOR_INTEL: intel_p5_mcheck_init(c); return 1;- break;
goto and break
default:
operation = 0; /* make gcc happy */ gotofail_response;
- break;break and break
case COLOR_SPACE_SRGB: /* by pass */ REG_SET(OUTPUT_CSC_CONTROL, 0, OUTPUT_CSC_GRPH_MODE, 0); break;- break;
The exception to the simple statement, is a switch case with a block and the end of block is a return
struct obj_buffer *buff = r->ptr; return scnprintf(str, PRIV_STR_SIZE, "size=%u\naddr=0x%X\n", buff->size, buff->addr); }- break;
Not considered obvious and excluded, breaks after
multi level switches
complicated if-else if-else blockspanic()or similar callsAnd there is an odd addition of a 'fallthrough' in
drivers/tty/nozomi.c
[..]
drivers/nvdimm/claim.c ssize_t nd_namespace_store(struct device *dev, · line 205
Quoted 12 lines
drivers/nvdimm/claim.c +0
-1@@ -200,11 +200,10 @@ ssize_t nd_namespace_store(struct device *dev, }break ;default : len = -EBUSY ; goto out_attach; -break ; }
Greg KH
maintainerQuoted 6 lines · On Sat, Oct 17, 2020 at 09:09:28AM -0700, [email protected] wrote:
From: Tom Rix <[email protected]>
This is a upcoming change to clean up a new warning treewide.
I am wondering if the change could be one mega patch (see below) or normal patch per file about 100 patches or somewhere half way by collecting early acks.
Please break it up into one-patch-per-subsystem, like normal, and get it merged that way.
Sending us a patch, without even a diffstat to review, isn't going to get you very far...
thanks,
greg k-h
_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 9 lines · Greg KH
Quoted 6 lines · trix at redhat.com
From: Tom Rix <[email protected]>
This is a upcoming change to clean up a new warning treewide.
I am wondering if the change could be one mega patch (see below) or normal patch per file about 100 patches or somewhere half way by collecting early acks.Please break it up into one-patch-per-subsystem, like normal, and get it merged that way.
OK.
Thanks,
Tom
Quoted 8 lines
Sending us a patch, without even a diffstat to review, isn't going to get you very far...
thanks,
greg k-h
Quoted 9 lines · Greg KH
Quoted 6 lines · trix at redhat.com
From: Tom Rix <[email protected]>
This is a upcoming change to clean up a new warning treewide.
I am wondering if the change could be one mega patch (see below) or normal patch per file about 100 patches or somewhere half way by collecting early acks.
Quoted 5 lines
Please break it up into one-patch-per-subsystem, like normal, and get it merged that way.
Sending us a patch, without even a diffstat to review, isn't going to get you very far...
Tom,
If you're able to automate this cleanup, I suggest checking in a script that can be run on a directory. Then for each subsystem you can say in your commit "I ran scripts/fix_whatever.py on this subdir."
Then others can help you drive the tree wide cleanup. Then we can
enable -Wunreachable-code-break either by default, or W=2 right now might be a good idea.
Ah, George (gbiv@, cc'ed), did an analysis recently of -Wunreachable-code-loop-increment, -Wunreachable-code-break, and -Wunreachable-code-return for Android userspace. From the review:
``` Spoilers: of these, it seems useful to turn on -Wunreachable-code-loop-increment and -Wunreachable-code-return by default for Android ... While these conventions about always having break arguably became obsolete when we enabled -Wfallthrough, my sample turned up zero potential bugs caught by this warning, and we'd need to put a lot of effort into getting a clean tree. So this warning doesn't seem to be worth it. ```
Looks like there's an order of magnitude of -Wunreachable-code-break than the other two.
We probably should add all 3 to W=2 builds (wrapped in cc-option). I've filed https://github.com/ClangBuiltLinux/linux/issues/1180 to follow up on.
Signature · 2 lines
Thanks, ~Nick Desaulniers
Quoted 16 lines · Nick Desaulniers
Quoted 9 lines · Greg KH
Quoted 6 lines · trix at redhat.com
From: Tom Rix <[email protected]>
This is a upcoming change to clean up a new warning treewide.
I am wondering if the change could be one mega patch (see below) or normal patch per file about 100 patches or somewhere half way by collecting early acks.Quoted 5 lines
Please break it up into one-patch-per-subsystem, like normal, and get it merged that way.
Sending us a patch, without even a diffstat to review, isn't going to get you very far...
Quoted 7 lines
Tom,
If you're able to automate this cleanup, I suggest checking in a script that can be run on a directory. Then for each subsystem you can say in your commit "I ranscripts/fix_whatever.pyon this subdir."
Then others can help you drive the tree wide cleanup. Then we can
enable -Wunreachable-code-break either by default, or W=2 right now might be a good idea.
I remember using clang-modernize in the past to fix issues very similar to this, if clang machinery can generate the warning, can't something like clang-tidy directly generate the patch?
You can send me a patch for drivers/infiniband/* as well
Thanks,
Jason
Quoted 21 lines · Jason Gunthorpe
Quoted 13 lines · Nick Desaulniers
Quoted 7 lines · Greg KH
Quoted 6 lines · trix at redhat.com
From: Tom Rix <[email protected]>
This is a upcoming change to clean up a new warning treewide.
I am wondering if the change could be one mega patch (see below) or normal patch per file about 100 patches or somewhere half way by collecting early acks.Quoted 5 lines
Please break it up into one-patch-per-subsystem, like normal, and get it merged that way.
Sending us a patch, without even a diffstat to review, isn't going to get you very far...
Quoted 7 lines
Tom,
If you're able to automate this cleanup, I suggest checking in a script that can be run on a directory. Then for each subsystem you can say in your commit "I ranscripts/fix_whatever.pyon this subdir."
Then others can help you drive the tree wide cleanup. Then we can
enable -Wunreachable-code-break either by default, or W=2 right now might be a good idea.
Quoted 3 lines
I remember using clang-modernize in the past to fix issues very similar to this, if clang machinery can generate the warning, can't something like clang-tidy directly generate the patch?
Yes clang-tidy and similar are good tools.
Sometimes they change too much and your time shifts
from editing to analyzing and dropping changes.
I am looking at them for auto changing api.
When i have something greater than half baked i will post.
Tom
Quoted 6 lines
You can send me a patch for
drivers/infiniband/*as wellThanks,
Jason
Quoted 7 lines · Nick Desaulniers
We probably should add all 3 to W=2 builds (wrapped in cc-option). I've filed https://github.com/ClangBuiltLinux/linux/issues/1180 to follow up on.
It looks as though the URL mangling has been fixed. If anyone sees that specific URL mangled, please let me know.
jch
_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 13 lines · Nick Desaulniers
Quoted 7 lines · Greg KH
Quoted 6 lines · trix at redhat.com
From: Tom Rix <[email protected]>
This is a upcoming change to clean up a new warning treewide.
I am wondering if the change could be one mega patch (see below) or normal patch per file about 100 patches or somewhere half way by collecting early acks.Quoted 5 lines
Please break it up into one-patch-per-subsystem, like normal, and get it merged that way.
Sending us a patch, without even a diffstat to review, isn't going to get you very far...
Quoted 7 lines
Tom,
If you're able to automate this cleanup, I suggest checking in a script that can be run on a directory. Then for each subsystem you can say in your commit "I ranscripts/fix_whatever.pyon this subdir."
Then others can help you drive the tree wide cleanup. Then we can
enable -Wunreachable-code-break either by default, or W=2 right now might be a good idea.
I should have waited for Joe Perches's fixer addition to checkpatch :)
The easy fixes I did only cover about 1/2 of the problems.
Remaining are mostly nested switches, which from a complexity standpoint is bad.
Quoted 8 lines
Ah, George (gbiv@, cc'ed), did an analysis recently of
-Wunreachable-code-loop-increment,-Wunreachable-code-break, and-Wunreachable-code-returnfor Android userspace. From the review:
```
Spoilers: of these, it seems useful to turn on -Wunreachable-code-loop-increment and -Wunreachable-code-return by default for Android
In my simple add-a-cflag bot, i see there are about 250
issues for -Wunreachable-code-return.
I'll see about doing this one next.
Quoted 10 lines
...
While these conventions about always having break arguably became obsolete when we enabled -Wfallthrough, my sample turned up zero potential bugs caught by this warning, and we'd need to put a lot of effort into getting a clean tree. So this warning doesn't seem to be worth it.
```
Looks like there's an order of magnitude of-Wunreachable-code-breakthan the other two.
Quoted 3 lines
We probably should add all 3 to W=2 builds (wrapped in cc-option). I've filed https://github.com/ClangBuiltLinux/linux/issues/1180 to follow up on.
Yes, i think think these should be added.
Tom
Joe Perches
maintainerQuoted 37 lines · Nick Desaulniers
Quoted 8 lines · Greg KH
Quoted 6 lines · On Sat, Oct 17, 2020 at 09:09:28AM -0700, [email protected] wrote:
From: Tom Rix <[email protected]>
This is a upcoming change to clean up a new warning treewide.
I am wondering if the change could be one mega patch (see below) or normal patch per file about 100 patches or somewhere half way by collecting early acks.Quoted 5 lines
Please break it up into one-patch-per-subsystem, like normal, and get it merged that way.
Sending us a patch, without even a diffstat to review, isn't going to get you very far...
Tom,
If you're able to automate this cleanup, I suggest checking in a script that can be run on a directory. Then for each subsystem you can say in your commit "I ranscripts/fix_whatever.pyon this subdir."
Then others can help you drive the tree wide cleanup. Then we can
enable -Wunreachable-code-break either by default, or W=2 right now might be a good idea.Ah, George (gbiv@, cc'ed), did an analysis recently of
-Wunreachable-code-loop-increment,-Wunreachable-code-break, and-Wunreachable-code-returnfor Android userspace. From the review:``` Spoilers: of these, it seems useful to turn on -Wunreachable-code-loop-increment and -Wunreachable-code-return by default for Android ... While these conventions about always having break arguably became obsolete when we enabled -Wfallthrough, my sample turned up zero potential bugs caught by this warning, and we'd need to put a lot of effort into getting a clean tree. So this warning doesn't seem to be worth it. ```
Quoted 6 lines
Looks like there's an order of magnitude of
-Wunreachable-code-breakthan the other two.We probably should add all 3 to W=2 builds (wrapped in cc-option). I've filed https://github.com/ClangBuiltLinux/linux/issues/1180 to follow up on.
I suggest using W=1 as people that are doing cleanups generally use that and not W=123 or any other style.
Every other use of W= is still quite noisy and these code warnings are relatively trivially to fix up.
_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 11 lines · Joe Perches
Quoted 3 lines · Nick Desaulniers
We probably should add all 3 to W=2 builds (wrapped in cc-option). I've filed https://github.com/ClangBuiltLinux/linux/issues/1180 to follow up on.
I suggest using W=1 as people that are doing cleanups generally use that and not W=123 or any other style.
Every other use of W= is still quite noisy and these code warnings are relatively trivially to fix up.
The 0day bot folks have enabled W=1 recently; hence the uptick in reports of -Wimplicit-function-declaration.
If it gets added to W=1, it's effectively "on by default" for new code tested by 0day bot.
--
Thanks,
~Nick Desaulniers
Joe Perches
maintainerQuoted 9 lines · Nick Desaulniers
Quoted 8 lines · Joe Perches
Quoted 3 lines · Nick Desaulniers
We probably should add all 3 to W=2 builds (wrapped in cc-option). I've filed https://github.com/ClangBuiltLinux/linux/issues/1180 to follow up on.
I suggest using W=1 as people that are doing cleanups generally use that and not W=123 or any other style.
Quoted 8 lines
Quoted 2 lines
Every other use of W= is still quite noisy and these code warnings are relatively trivially to fix up.
The 0day bot folks have enabled W=1 recently; hence the uptick in reports of -Wimplicit-function-declaration.
If it gets added to W=1, it's effectively "on by default" for new code tested by 0day bot.
And that would mean these get fixed faster no?
Isn't that a good thing?
Hi Tom,
Quick self intro: I have take over drivers/platform/x86 maintainership from Andy.
Quoted 51 lines · trix at redhat.com
From: Tom Rix <[email protected]>
This is a upcoming change to clean up a new warning treewide.
I am wondering if the change could be one mega patch (see below) or normal patch per file about 100 patches or somewhere half way by collecting early acks.clang has a number of useful, new warnings see
https://clang.llvm.org/docs/DiagnosticsReference.htmlThis change cleans up -Wunreachable-code-break
https://clang.llvm.org/docs/DiagnosticsReference.html#wunreachable-code-break
for 266 of 485 warnings in this week's linux-next, allyesconfig onx86_64.The method of fixing was to look for warnings where the preceding statement was a simple statement and by inspection made the subsequent break unneeded. In order of frequency these look like
return and break
arch/x86/kernel/cpu/mce/core.c +0
-1switch (c->x86_vendor) {case X86_VENDOR_INTEL :intel_p5_mcheck_init (c);return 1 ; -break ;goto and break
drivers/block/xen-blkback/blkback.c +0
-1default : operation =0 ;/* make gcc happy */ goto fail_response; -break ;break and break
drivers/gpu/drm/amd/display/dc/dce/dce_transform.c +0
-1case COLOR_SPACE_SRGB :/* by pass */ REG_SET (OUTPUT_CSC_CONTROL ,0 ,OUTPUT_CSC_GRPH_MODE ,0 );break ; -break ;The exception to the simple statement, is a switch case with a block and the end of block is a return
drivers/net/wireless/intersil/prism54/oid_mgt.c +0
-1struct obj_buffer *buff = r->ptr;return scnprintf (str,PRIV_STR_SIZE ,"size=%u\naddr=0x%X\n" , buff->size, buff->addr); } -break ;
Quoted 6 lines
Not considered obvious and excluded, breaks after
multi level switches
complicated if-else if-else blockspanic()or similar callsAnd there is an odd addition of a 'fallthrough' in
drivers/tty/nozomi.c
As Greg already mentioned please split this out into per subsystem patches.
I would be happy to take all the changes to drivers/platform/x86 code upstream as a single patch for all the files there.
Regards,
Hans
Quoted 2,785 lines
---
arch/x86/kernel/cpu/mce/core.c +0
-2@@ -1809,15 +1809,13 @@ static int __mcheck_cpu_ancient_init(struct cpuinfo_x86 *c)switch (c->x86_vendor) {case X86_VENDOR_INTEL :intel_p5_mcheck_init (c);return 1 ; -break ;case X86_VENDOR_CENTAUR :winchip_mcheck_init (c);return 1 ; -break ;default :return 0 ; }return 0 ;arch/x86/kernel/cpu/microcode/amd.c +0
-1@@ -213,11 +213,10 @@ static unsigned int __verify_patch_size(u8 family, u32 sh_psize, size_t buf_size max_size =F14H_MPB_MAX_SIZE ;break ;default :WARN (1 ,"%s: WTF family: 0x%x\n" , __func__, family);return 0 ; -break ; }if (sh_psize >min_t (u32, buf_size, max_size))return 0 ;drivers/acpi/utils.c +0
-4@@ -102,11 +102,10 @@ acpi_extract_package(union acpi_object *package, printk(KERN_WARNING PREFIX "Invalid package element"" [%d]: got number, expecting" " [%c]\n" , i, format_string[i]);return AE_BAD_DATA ; -break ; }break ;case ACPI_TYPE_STRING :case ACPI_TYPE_BUFFER :@@ -127,11 +126,10 @@ acpi_extract_package(union acpi_object *package, printk(KERN_WARNING PREFIX "Invalid package element"" [%d] got string/buffer," " expecting [%c]\n" , i, format_string[i]);return AE_BAD_DATA ; -break ; }break ;case ACPI_TYPE_LOCAL_REFERENCE :switch (format_string[i]) {case 'R' :@@ -142,22 +140,20 @@ acpi_extract_package(union acpi_object *package, printk(KERN_WARNING PREFIX "Invalid package element"" [%d] got reference," " expecting [%c]\n" , i, format_string[i]);return AE_BAD_DATA ; -break ; }break ;case ACPI_TYPE_PACKAGE :default :ACPI_DEBUG_PRINT ((ACPI_DB_INFO ,"Found unsupported element at index=%d\n" , i));/* TBD: handle nested packages... */ return AE_SUPPORT ; -break ; } }/* * Validate output buffer. drivers/base/power/main.c +0
-1@@ -361,11 +361,10 @@ static pm_callback_t pm_op(const struct dev_pm_ops *ops, pm_message_t state)case PM_EVENT_HIBERNATE :return ops->poweroff;case PM_EVENT_THAW :case PM_EVENT_RECOVER :return ops->thaw; -break ;case PM_EVENT_RESTORE :return ops->restore;#endif /* CONFIG_HIBERNATE_CALLBACKS */ }drivers/block/xen-blkback/blkback.c +0
-1@@ -1267,11 +1267,10 @@ static int dispatch_rw_block_io(struct xen_blkif_ring *ring, operation_flags =REQ_PREFLUSH ;break ;default : operation =0 ;/* make gcc happy */ goto fail_response; -break ; }/* Check that the number of segments is sane. */ nseg = req->operation ==BLKIF_OP_INDIRECT ? req->u.indirect.nr_segments : req->u.rw.nr_segments;drivers/char/ipmi/ipmi_devintf.c +0
-1@@ -488,11 +488,10 @@ static long ipmi_ioctl(struct file *file, rv = -EFAULT ;break ; }return ipmi_set_my_address (priv->user, val.channel, val.value); -break ; }case IPMICTL_GET_MY_CHANNEL_ADDRESS_CMD : {struct ipmi_channel_lun_address_set val;drivers/char/lp.c +0
-1@@ -620,11 +620,10 @@ static int lp_do_ioctl(unsigned int minor, unsigned int cmd,case LPWAIT :LP_WAIT (minor) = arg;break ;case LPSETIRQ :return -EINVAL ; -break ;case LPGETIRQ :if (copy_to_user (argp, &LP_IRQ (minor),sizeof (int )))return -EFAULT ;break ;drivers/char/mwave/mwavedd.c +0
-1@@ -401,11 +401,10 @@ static long mwave_ioctl(struct file *file, unsigned int iocmd, }break ;default :return -ENOTTY ; -break ; }/* switch */ PRINTK_2 (TRACE_MWAVE ,"mwavedd::mwave_ioctl, exit retval %x\n" , retval);return retval;drivers/crypto/atmel-sha.c +0
-1@@ -457,11 +457,10 @@ static int atmel_sha_init(struct ahash_request *req) ctx->flags |=SHA_FLAGS_SHA512 ; ctx->block_size =SHA512_BLOCK_SIZE ;break ;default :return -EINVAL ; -break ; } ctx->bufcnt =0 ; ctx->digcnt[0 ] =0 ; ctx->digcnt[1 ] =0 ;drivers/edac/amd64_edac.c +0
-8@@ -2459,38 +2459,30 @@ static int map_err_sym_to_channel(int err_sym, int sym_size)if (sym_size ==4 )switch (err_sym) {case 0x20 :case 0x21 :return 0 ; -break ;case 0x22 :case 0x23 :return 1 ; -break ;default :return err_sym >>4 ; -break ; }/* x8 symbols */ else switch (err_sym) {/* imaginary bits not in a DIMM */ case 0x10 :WARN (1 ,KERN_ERR "Invalid error symbol: 0x%x\n" , err_sym);return -1 ; -break ; -case 0x11 :return 0 ; -break ;case 0x12 :return 1 ; -break ;default :return err_sym >>3 ; -break ; }return -1 ; }static int get_channel_from_ecc_syndrome (struct mem_ctl_info *mci,u16 syndrome)drivers/gpio/gpio-bd70528.c +0
-3@@ -69,21 +69,18 @@ static int bd70528_gpio_set_config(struct gpio_chip *chip, unsigned int offset,case PIN_CONFIG_DRIVE_OPEN_DRAIN :return regmap_update_bits (bdgpio->chip.regmap,GPIO_OUT_REG (offset),BD70528_GPIO_DRIVE_MASK ,BD70528_GPIO_OPEN_DRAIN ); -break ;case PIN_CONFIG_DRIVE_PUSH_PULL :return regmap_update_bits (bdgpio->chip.regmap,GPIO_OUT_REG (offset),BD70528_GPIO_DRIVE_MASK ,BD70528_GPIO_PUSH_PULL ); -break ;case PIN_CONFIG_INPUT_DEBOUNCE :return bd70528_set_debounce (bdgpio, offset,pinconf_to_config_argument (config)); -break ;default :break ; }return -ENOTSUPP ; }drivers/gpu/drm/amd/display/dc/dce/dce_transform.c +0
-1@@ -1328,11 +1328,10 @@ static bool configure_graphics_mode(case COLOR_SPACE_SRGB :/* by pass */ REG_SET (OUTPUT_CSC_CONTROL ,0 ,OUTPUT_CSC_GRPH_MODE ,0 );break ; -break ;case COLOR_SPACE_SRGB_LIMITED :/* TV RGB */ REG_SET (OUTPUT_CSC_CONTROL ,0 ,OUTPUT_CSC_GRPH_MODE ,1 );break ;drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c +0
-7@@ -416,29 +416,22 @@ static int map_transmitter_id_to_phy_instance( enum transmitter transmitter) {switch (transmitter) {case TRANSMITTER_UNIPHY_A :return 0 ; -break ;case TRANSMITTER_UNIPHY_B :return 1 ; -break ;case TRANSMITTER_UNIPHY_C :return 2 ; -break ;case TRANSMITTER_UNIPHY_D :return 3 ; -break ;case TRANSMITTER_UNIPHY_E :return 4 ; -break ;case TRANSMITTER_UNIPHY_F :return 5 ; -break ;case TRANSMITTER_UNIPHY_G :return 6 ; -break ;default :ASSERT (0 );return 0 ; } }drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c +0
-7@@ -469,29 +469,22 @@ static int map_transmitter_id_to_phy_instance( enum transmitter transmitter) {switch (transmitter) {case TRANSMITTER_UNIPHY_A :return 0 ; -break ;case TRANSMITTER_UNIPHY_B :return 1 ; -break ;case TRANSMITTER_UNIPHY_C :return 2 ; -break ;case TRANSMITTER_UNIPHY_D :return 3 ; -break ;case TRANSMITTER_UNIPHY_E :return 4 ; -break ;case TRANSMITTER_UNIPHY_F :return 5 ; -break ;case TRANSMITTER_UNIPHY_G :return 6 ; -break ;default :ASSERT (0 );return 0 ; } }drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c +0
-7@@ -444,29 +444,22 @@ static int map_transmitter_id_to_phy_instance( enum transmitter transmitter) {switch (transmitter) {case TRANSMITTER_UNIPHY_A :return 0 ; -break ;case TRANSMITTER_UNIPHY_B :return 1 ; -break ;case TRANSMITTER_UNIPHY_C :return 2 ; -break ;case TRANSMITTER_UNIPHY_D :return 3 ; -break ;case TRANSMITTER_UNIPHY_E :return 4 ; -break ;case TRANSMITTER_UNIPHY_F :return 5 ; -break ;case TRANSMITTER_UNIPHY_G :return 6 ; -break ;default :ASSERT (0 );return 0 ; } }drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +0
-7@@ -381,29 +381,22 @@ static int map_transmitter_id_to_phy_instance( enum transmitter transmitter) {switch (transmitter) {case TRANSMITTER_UNIPHY_A :return 0 ; -break ;case TRANSMITTER_UNIPHY_B :return 1 ; -break ;case TRANSMITTER_UNIPHY_C :return 2 ; -break ;case TRANSMITTER_UNIPHY_D :return 3 ; -break ;case TRANSMITTER_UNIPHY_E :return 4 ; -break ;case TRANSMITTER_UNIPHY_F :return 5 ; -break ;case TRANSMITTER_UNIPHY_G :return 6 ; -break ;default :ASSERT (0 );return 0 ; } }drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c +0
-7@@ -451,29 +451,22 @@ static int map_transmitter_id_to_phy_instance( enum transmitter transmitter) {switch (transmitter) {case TRANSMITTER_UNIPHY_A :return 0 ; -break ;case TRANSMITTER_UNIPHY_B :return 1 ; -break ;case TRANSMITTER_UNIPHY_C :return 2 ; -break ;case TRANSMITTER_UNIPHY_D :return 3 ; -break ;case TRANSMITTER_UNIPHY_E :return 4 ; -break ;case TRANSMITTER_UNIPHY_F :return 5 ; -break ;case TRANSMITTER_UNIPHY_G :return 6 ; -break ;default :ASSERT (0 );return 0 ; } }drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c +0
-7@@ -456,29 +456,22 @@ static int map_transmitter_id_to_phy_instance( enum transmitter transmitter) {switch (transmitter) {case TRANSMITTER_UNIPHY_A :return 0 ; -break ;case TRANSMITTER_UNIPHY_B :return 1 ; -break ;case TRANSMITTER_UNIPHY_C :return 2 ; -break ;case TRANSMITTER_UNIPHY_D :return 3 ; -break ;case TRANSMITTER_UNIPHY_E :return 4 ; -break ;case TRANSMITTER_UNIPHY_F :return 5 ; -break ;case TRANSMITTER_UNIPHY_G :return 6 ; -break ;default :ASSERT (0 );return 0 ; } }drivers/gpu/drm/mgag200/mgag200_mode.c +0
-5@@ -792,25 +792,20 @@ static int mgag200_crtc_set_plls(struct mga_device *mdev, long clock)case G200_AGP :return mgag200_g200_set_plls (mdev, clock);case G200_SE_A :case G200_SE_B :return mga_g200se_set_plls (mdev, clock); -break ;case G200_WB :case G200_EW3 :return mga_g200wb_set_plls (mdev, clock); -break ;case G200_EV :return mga_g200ev_set_plls (mdev, clock); -break ;case G200_EH :case G200_EH3 :return mga_g200eh_set_plls (mdev, clock); -break ;case G200_ER :return mga_g200er_set_plls (mdev, clock); -break ; } misc =RREG8 (MGA_MISC_IN ); misc &= ~MGAREG_MISC_CLK_SEL_MASK ; misc |=MGAREG_MISC_CLK_SEL_MGA_MSK ;drivers/gpu/drm/nouveau/nvkm/subdev/bios/pll.c +0
-1@@ -121,11 +121,10 @@ pll_map(struct nvkm_bios *bios)case NV_10 :case NV_11 :case NV_20 :case NV_30 :return nv04_pll_mapping; -break ;case NV_40 :return nv40_pll_mapping;case NV_50 :if (device->chipset ==0x50 )return nv50_pll_mapping;drivers/gpu/drm/nouveau/nvkm/subdev/clk/mcp77.c +0
-3@@ -138,21 +138,18 @@ mcp77_clk_read(struct nvkm_clk *base, enum nv_clk_src src)case 0x00000030 :return read_pll (clk,0x004020 ) >>P ; }break ;case nv_clk_src_mem:return 0 ; -break ;case nv_clk_src_vdec:P = (read_div (clk) &0x00000700 ) >>8 ;switch (mast &0x00400000 ) {case 0x00400000 :return nvkm_clk_read (&clk->base, nv_clk_src_core) >>P ; -break ;default :return 500000 >>P ; -break ; }break ;default :break ; }drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramnv50.c +0
-1@@ -169,11 +169,10 @@ nv50_ram_timing_read(struct nv50_ram *ram, u32 *timing)case NVKM_RAM_TYPE_GDDR3 :T (CWL ) = ((timing[2 ] &0xff000000 ) >>24 ) +1 ;break ;default :return -ENOSYS ; -break ; }T (WR ) = ((timing[1 ] >>24 ) &0xff ) -1 -T (CWL );return 0 ;drivers/gpu/drm/nouveau/nvkm/subdev/top/gk104.c +0
-1@@ -88,11 +88,10 @@ gk104_top_oneinit(struct nvkm_top *top)case 0x0000000e :B_ (NVENC );break ;case 0x0000000f :A_ (NVENC1 );break ;case 0x00000010 :B_ (NVDEC );break ;case 0x00000013 :B_ (CE );break ;case 0x00000014 :C_ (GSP );break ; -break ;default :break ; } nvkm_debug(subdev, "%02x.%d (%8s): addr %06x fault %2d "drivers/gpu/drm/qxl/qxl_ioctl.c +0
-1@@ -158,11 +158,10 @@ static int qxl_process_single_command(struct qxl_device *qdev,case QXL_CMD_SURFACE :case QXL_CMD_CURSOR :default :DRM_DEBUG ("Only draw commands in execbuffers\n" );return -EINVAL ; -break ; }if (cmd->command_size >PAGE_SIZE -sizeof (union qxl_release_info ))return -EINVAL ;drivers/iio/adc/meson_saradc.c +0
-2@@ -591,17 +591,15 @@ static int meson_sar_adc_iio_info_read_raw(struct iio_dev *indio_dev,switch (mask) {case IIO_CHAN_INFO_RAW :return meson_sar_adc_get_sample (indio_dev, chan,NO_AVERAGING ,ONE_SAMPLE , val); -break ;case IIO_CHAN_INFO_AVERAGE_RAW :return meson_sar_adc_get_sample (indio_dev, chan,MEAN_AVERAGING ,EIGHT_SAMPLES , val); -break ;case IIO_CHAN_INFO_SCALE :if (chan->type ==IIO_VOLTAGE ) { ret =regulator_get_voltage (priv->vref);if (ret <0 ) {drivers/iio/imu/bmi160/bmi160_core.c +0
-1@@ -484,11 +484,10 @@ static int bmi160_write_raw(struct iio_dev *indio_dev,switch (mask) {case IIO_CHAN_INFO_SCALE :return bmi160_set_scale (data,bmi160_to_sensor (chan->type), val2); -break ;case IIO_CHAN_INFO_SAMP_FREQ :return bmi160_set_odr (data,bmi160_to_sensor (chan->type), val, val2);default :return -EINVAL ;drivers/ipack/devices/ipoctal.c +0
-1@@ -542,11 +542,10 @@ static void ipoctal_set_termios(struct tty_struct *tty, mr1 |= MR1_RxRTS_CONTROL_OFF; mr2 |= MR2_TxRTS_CONTROL_ON |MR2_CTS_ENABLE_TX_OFF ;break ;default :return ; -break ; } baud =tty_get_baud_rate (tty);tty_termios_encode_baud_rate (&tty->termios, baud, baud);drivers/media/dvb-frontends/drx39xyj/drxj.c +0
-7@@ -2323,11 +2323,10 @@ hi_command(struct i2c_device_addr *dev_addr, const struct drxj_hi_cmd *cmd, u16/* No parameters */ break ;default :return -EINVAL ; -break ; }/* Write command */ rc =drxj_dap_write_reg16 (dev_addr,SIO_HI_RA_RAM_CMD__A , cmd->cmd,0 );if (rc !=0 ) {@@ -3592,11 +3591,10 @@ static int ctrl_set_uio_cfg(struct drx_demod_instance *demod, struct drxuio_cfg goto rw_error; }break ;default :return -EINVAL ; -break ; }/* switch ( uio_cfg->mode ) */ break ;/*====================================================================*/ case DRX_UIO3 :/* DRX_UIO3: GPIO UIO-3 */ @@ -3616,11 +3614,10 @@ static int ctrl_set_uio_cfg(struct drx_demod_instance *demod, struct drxuio_cfg goto rw_error; }break ;default :return -EINVAL ; -break ; }/* switch ( uio_cfg->mode ) */ break ;/*====================================================================*/ case DRX_UIO4 :/* DRX_UIO4: IRQN UIO-4 */ @@ -3640,11 +3637,10 @@ static int ctrl_set_uio_cfg(struct drx_demod_instance *demod, struct drxuio_cfg ext_attr->uio_irqn_mode = uio_cfg->mode;break ;case DRX_UIO_MODE_FIRMWARE0 :default :return -EINVAL ; -break ; }/* switch ( uio_cfg->mode ) */ break ;/*====================================================================*/ default :return -EINVAL ;@@ -10951,11 +10947,10 @@ ctrl_set_standard(struct drx_demod_instance *demod, enum drx_standard *standard) }break ;default : ext_attr->standard =DRX_STANDARD_UNKNOWN ;return -EINVAL ; -break ; }return 0 ; rw_error:/* Don't know what the standard is now ... try again */ @@ -11072,11 +11067,10 @@ ctrl_power_mode(struct drx_demod_instance *demod, enum drx_power_mode *mode) sio_cc_pwd_mode =SIO_CC_PWD_MODE_LEVEL_OSC ;break ;default :/* Unknow sleep mode */ return -EINVAL ; -break ; }/* Check if device needs to be powered up */ if ((common_attr->current_power_mode !=DRX_POWER_UP )) { rc =power_up_device (demod);@@ -11894,11 +11888,10 @@ static int drx_ctrl_u_code(struct drx_demod_instance *demod, }break ; }default :return -EINVAL ; -break ; } mc_data += mc_block_nr_bytes; }drivers/media/dvb-frontends/drxd_hard.c +0
-1@@ -1620,11 +1620,10 @@ static int CorrectSysClockDeviation(struct drxd_state *state)case 6000000 : bandwidth =DRXD_BANDWIDTH_6MHZ_IN_HZ ;break ;default :return -1 ; -break ; }/* Compute new sysclock value sysClockFreq = (((incr + 2^23)*bandwidth)/2^21)/1000 */ incr += (1 <<23 );drivers/media/dvb-frontends/nxt200x.c +0
-16@@ -166,11 +166,10 @@ static int nxt200x_writereg_multibyte (struct nxt200x_state* state, u8 reg, u8* len2 = ((attr <<4 ) |0x10 ) | len; buf =0x80 ;break ;default :return -EINVAL ; -break ; }/* set multi register length */ nxt200x_writebytes (state,0x34 , &len2,1 );@@ -188,11 +187,10 @@ static int nxt200x_writereg_multibyte (struct nxt200x_state* state, u8 reg, u8*if (buf ==0 )return 0 ;break ;default :return -EINVAL ; -break ; }pr_warn ("Error writing multireg register 0x%02X\n" , reg);return 0 ;@@ -214,11 +212,10 @@ static int nxt200x_readreg_multibyte (struct nxt200x_state* state, u8 reg, u8* dnxt200x_writebytes (state,0x34 , &len2,1 );/* read the actual data */ nxt200x_readbytes (state, reg, data, len);return 0 ; -break ;case NXT2004 :/* probably not right, but gives correct values */ attr =0x02 ;if (reg &0x80 ) { attr = attr <<1 ;@@ -237,14 +234,12 @@ static int nxt200x_readreg_multibyte (struct nxt200x_state* state, u8 reg, u8* d/* read the actual data */ for (i =0 ; i < len; i++) {nxt200x_readbytes (state,0x36 + i, &data[i],1 ); }return 0 ; -break ;default :return -EINVAL ; -break ; } }static void nxt200x_microcontroller_stop (struct nxt200x_state * state) {@@ -372,11 +367,10 @@ static int nxt200x_writetuner (struct nxt200x_state* state, u8* data) }pr_warn ("timeout error writing to tuner\n" );break ;default :return -EINVAL ; -break ; }return 0 ; }static void nxt200x_agc_reset (struct nxt200x_state * state)@@ -553,11 +547,10 @@ static int nxt200x_setup_frontend_parameters(struct dvb_frontend *fe)if (state->config->set_ts_params) state->config->set_ts_params (fe,0 );break ;default :return -EINVAL ; -break ; }if (fe->ops.tuner_ops.calc_regs) {/* get tuning information */ fe->ops.tuner_ops.calc_regs (fe, buf,5 );@@ -578,11 +571,10 @@ static int nxt200x_setup_frontend_parameters(struct dvb_frontend *fe)case VSB_8 : buf[0 ] =0x70 ;break ;default :return -EINVAL ; -break ; }nxt200x_writebytes (state,0x42 , buf,1 );/* configure sdm */ switch (state->demod_chip) {@@ -592,11 +584,10 @@ static int nxt200x_setup_frontend_parameters(struct dvb_frontend *fe)case NXT2004 : buf[0 ] =0x07 ;break ;default :return -EINVAL ; -break ; }nxt200x_writebytes (state,0x57 , buf,1 );/* write sdm1 input */ buf[0 ] =0x10 ;@@ -608,11 +599,10 @@ static int nxt200x_setup_frontend_parameters(struct dvb_frontend *fe)case NXT2004 :nxt200x_writebytes (state,0x58 , buf,2 );break ;default :return -EINVAL ; -break ; }/* write sdmx input */ switch (p->modulation) {case QAM_64 :@@ -624,11 +614,10 @@ static int nxt200x_setup_frontend_parameters(struct dvb_frontend *fe)case VSB_8 : buf[0 ] =0x60 ;break ;default :return -EINVAL ; -break ; } buf[1 ] =0x00 ;switch (state->demod_chip) {case NXT2002 :nxt200x_writereg_multibyte (state,0x5C , buf,2 );@@ -636,11 +625,10 @@ static int nxt200x_setup_frontend_parameters(struct dvb_frontend *fe)case NXT2004 :nxt200x_writebytes (state,0x5C , buf,2 );break ;default :return -EINVAL ; -break ; }/* write adc power lpf fc */ buf[0 ] =0x05 ;nxt200x_writebytes (state,0x43 , buf,1 );@@ -662,11 +650,10 @@ static int nxt200x_setup_frontend_parameters(struct dvb_frontend *fe)case NXT2004 :nxt200x_writebytes (state,0x4B , buf,2 );break ;default :return -EINVAL ; -break ; }/* write kg1 */ buf[0 ] =0x00 ;nxt200x_writebytes (state,0x4D , buf,1 );@@ -718,11 +705,10 @@ static int nxt200x_setup_frontend_parameters(struct dvb_frontend *fe)case VSB_8 : buf[0 ] =0x00 ;break ;default :return -EINVAL ; -break ; }nxt200x_writebytes (state,0x30 , buf,1 );/* write agc control reg */ buf[0 ] =0x00 ;@@ -740,11 +726,10 @@ static int nxt200x_setup_frontend_parameters(struct dvb_frontend *fe)nxt200x_writebytes (state,0x49 , buf,2 );nxt200x_writebytes (state,0x4B , buf,2 );break ;default :return -EINVAL ; -break ; }/* write agc control reg */ buf[0 ] =0x04 ;nxt200x_writebytes (state,0x41 , buf,1 );@@ -1112,11 +1097,10 @@ static int nxt200x_init(struct dvb_frontend* fe)case NXT2004 : ret =nxt2004_init (fe);break ;default :return -EINVAL ; -break ; } state->initialised =1 ; }return ret; }drivers/media/dvb-frontends/si21xx.c +0
-2@@ -462,14 +462,12 @@ static int si21xx_set_voltage(struct dvb_frontend *fe, enum fe_sec_voltage volt) val = (0x80 |si21_readreg (state,LNB_CTRL_REG_1 ));switch (volt) {case SEC_VOLTAGE_18 :return si21_writereg (state,LNB_CTRL_REG_1 , val |0x40 ); -break ;case SEC_VOLTAGE_13 :return si21_writereg (state,LNB_CTRL_REG_1 , (val & ~0x40 )); -break ;default :return -EINVAL ; } }drivers/media/tuners/mt2063.c +0
-1@@ -1847,11 +1847,10 @@ static int mt2063_init(struct dvb_frontend *fe) def = MT2063B0_defaults;break ;default :return -ENODEV ; -break ; }while (status >=0 && *def) {u8 reg = *def++;u8 val = *def++;drivers/message/fusion/mptbase.c +0
-1@@ -471,11 +471,10 @@ mpt_turbo_reply(MPT_ADAPTER *ioc, u32 pa) req_idx = pa &0x0000FFFF ; mf =MPT_INDEX_2_MFPTR (ioc, req_idx);mpt_free_msg_frame (ioc, mf);mb ();return ; -break ; } mr = (MPT_FRAME_HDR *)CAST_U32_TO_PTR (pa);break ;case MPI_CONTEXT_REPLY_TYPE_SCSI_TARGET : cb_idx =mpt_get_cb_idx (MPTSTM_DRIVER );drivers/misc/mei/hbm.c +0
-1@@ -1375,11 +1375,10 @@ int mei_hbm_dispatch(struct mei_device *dev, struct mei_msg_hdr *hdr) dev->dev_state =MEI_DEV_POWER_DOWN ;dev_info (dev->dev,"hbm: stop response: resetting.\n" );/* force the reset */ return -EPROTO ; -break ;case CLIENT_DISCONNECT_REQ_CMD :dev_dbg (dev->dev,"hbm: disconnect request: message received\n" ); disconnect_req = (struct hbm_client_connect_request *)mei_msg;drivers/mtd/mtdchar.c +0
-2@@ -879,21 +879,19 @@ static int mtdchar_ioctl(struct file *file, u_int cmd, u_long arg)loff_t offs;if (copy_from_user (&offs, argp,sizeof (loff_t)))return -EFAULT ;return mtd_block_isbad (mtd, offs); -break ; }case MEMSETBADBLOCK : {loff_t offs;if (copy_from_user (&offs, argp,sizeof (loff_t)))return -EFAULT ;return mtd_block_markbad (mtd, offs); -break ; }case OTPSELECT : {int mode;drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c +11
-11@@ -73,15 +73,15 @@ static const struct can_bittiming_const mcp251xfd_data_bittiming_const = {static const char *__mcp251xfd_get_model_str (enum mcp251xfd_model model) {switch (model) {case MCP251XFD_MODEL_MCP2517FD : -return "MCP2517FD" ;break ; +return "MCP2517FD" ;case MCP251XFD_MODEL_MCP2518FD : -return "MCP2518FD" ;break ; +return "MCP2518FD" ;case MCP251XFD_MODEL_MCP251XFD : -return "MCP251xFD" ;break ; +return "MCP251xFD" ; }return "<unknown>" ; }@@ -93,25 +93,25 @@ mcp251xfd_get_model_str(const struct mcp251xfd_priv *priv)static const char *mcp251xfd_get_mode_str (const u8 mode) {switch (mode) {case MCP251XFD_REG_CON_MODE_MIXED : -return "Mixed (CAN FD/CAN 2.0)" ;break ; +return "Mixed (CAN FD/CAN 2.0)" ;case MCP251XFD_REG_CON_MODE_SLEEP : -return "Sleep" ;break ; +return "Sleep" ;case MCP251XFD_REG_CON_MODE_INT_LOOPBACK : -return "Internal Loopback" ;break ; +return "Internal Loopback" ;case MCP251XFD_REG_CON_MODE_LISTENONLY : -return "Listen Only" ;break ; +return "Listen Only" ;case MCP251XFD_REG_CON_MODE_CONFIG : -return "Configuration" ;break ; +return "Configuration" ;case MCP251XFD_REG_CON_MODE_EXT_LOOPBACK : -return "External Loopback" ;break ; +return "External Loopback" ;case MCP251XFD_REG_CON_MODE_CAN2_0 : -return "CAN 2.0" ;break ; +return "CAN 2.0" ;case MCP251XFD_REG_CON_MODE_RESTRICTED : -return "Restricted Operation" ;break ; +return "Restricted Operation" ; }return "<unknown>" ; }drivers/net/ethernet/aquantia/atlantic/aq_nic.c +0
-1@@ -1161,11 +1161,10 @@ int aq_nic_set_link_ksettings(struct aq_nic_s *self,break ;default : err =-1 ; goto err_exit; -break ; }if (!(self->aq_nic_cfg.aq_hw_caps->link_speed_msk & rate)) { err =-1 ; goto err_exit; }drivers/net/ethernet/cisco/enic/enic_ethtool.c +0
-1@@ -432,11 +432,10 @@ static int enic_grxclsrule(struct enic *enic, struct ethtool_rxnfc *cmd)case IPPROTO_UDP : fsp->flow_type =UDP_V4_FLOW ;break ;default :return -EINVAL ; -break ; } fsp->h_u.tcp_ip4_spec.ip4src =flow_get_u32_src (&n->keys); fsp->m_u.tcp_ip4_spec.ip4src = (__u32 )~0 ;drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c +0
-1@@ -348,11 +348,10 @@ static s32 ixgbe_calc_eeprom_checksum_X540(struct ixgbe_hw *hw)continue ;if (ixgbe_read_eerd_generic (hw, pointer, &length)) {hw_dbg (hw,"EEPROM read failed\n" );return IXGBE_ERR_EEPROM ; -break ; }/* Skip pointer section if length is invalid. */ if (length ==0xFFFF || length ==0 || (pointer + length) >= hw->eeprom.word_size)drivers/net/wan/lmc/lmc_proto.c +0
-4@@ -87,21 +87,17 @@ void lmc_proto_close(lmc_softc_t *sc)__be16 lmc_proto_type (lmc_softc_t *sc,struct sk_buff *skb)/*FOLD00*/ {switch (sc->if_type){case LMC_PPP :return hdlc_type_trans (skb, sc->lmc_device); -break ;case LMC_NET :return htons (ETH_P_802_2 ); -break ;case LMC_RAW :/* Packet type for skbuff kind of useless */ return htons (ETH_P_802_2 ); -break ;default :printk (KERN_WARNING "%s: No protocol set for this interface, assuming 802.2 (which is wrong!!)\n" , sc->name);return htons (ETH_P_802_2 ); -break ; } }void lmc_proto_netif (lmc_softc_t *sc,struct sk_buff *skb)/*FOLD00*/ {drivers/net/wireless/ath/ath10k/htt_rx.c +0
-1@@ -3876,11 +3876,10 @@ bool ath10k_htt_t2h_msg_handler(struct ath10k *ar, struct sk_buff *skb)atomic_inc (&htt->num_mpdus_ready);return ath10k_htt_rx_proc_rx_frag_ind (htt, &resp->rx_frag_ind, skb); -break ; }case HTT_T2H_MSG_TYPE_TEST :break ;case HTT_T2H_MSG_TYPE_STATS_CONF :trace_ath10k_htt_stats (ar, skb->data, skb->len);drivers/net/wireless/ath/ath6kl/testmode.c +0
-1@@ -92,11 +92,10 @@ int ath6kl_tm_cmd(struct wiphy *wiphy, struct wireless_dev *wdev,ath6kl_wmi_test_cmd (ar->wmi, buf, buf_len);return 0 ; -break ;case ATH6KL_TM_CMD_RX_REPORT :default :return -EOPNOTSUPP ; } }drivers/net/wireless/ath/ath9k/hw.c +0
-1@@ -2306,11 +2306,10 @@ void ath9k_hw_beaconinit(struct ath_hw *ah, u32 next_beacon, u32 beacon_period)break ;default :ath_dbg (ath9k_hw_common (ah),BEACON ,"%s: unsupported opmode: %d\n" , __func__, ah->opmode);return ; -break ; }REG_WRITE (ah,AR_BEACON_PERIOD , beacon_period);REG_WRITE (ah,AR_DMA_BEACON_PERIOD , beacon_period);REG_WRITE (ah,AR_SWBA_PERIOD , beacon_period);drivers/net/wireless/intel/iwlwifi/mvm/mac-ctxt.c +0
-2@@ -1200,17 +1200,15 @@ static int iwl_mvm_mac_ctx_send(struct iwl_mvm *mvm, struct ieee80211_vif *vif,switch (vif->type) {case NL80211_IFTYPE_STATION :return iwl_mvm_mac_ctxt_cmd_sta (mvm, vif, action, force_assoc_off, bssid_override); -break ;case NL80211_IFTYPE_AP :if (!vif->p2p)return iwl_mvm_mac_ctxt_cmd_ap (mvm, vif, action);else return iwl_mvm_mac_ctxt_cmd_go (mvm, vif, action); -break ;case NL80211_IFTYPE_MONITOR :return iwl_mvm_mac_ctxt_cmd_listener (mvm, vif, action);case NL80211_IFTYPE_P2P_DEVICE :return iwl_mvm_mac_ctxt_cmd_p2p_device (mvm, vif, action);case NL80211_IFTYPE_ADHOC :drivers/net/wireless/intersil/p54/eeprom.c +0
-1@@ -868,11 +868,10 @@ int p54_parse_eeprom(struct ieee80211_hw *dev, void *eeprom, int len) err = -ENOMSG ; goto err; }else { goto good_eeprom; } -break ;default :break ; } crc16 =crc_ccitt (crc16, (u8 *)entry, (entry_len +1 ) *2 );drivers/net/wireless/intersil/prism54/oid_mgt.c +0
-10@@ -785,21 +785,19 @@ mgt_response_to_str(enum oid_num_t n, union oid_res_t *r, char *str)struct obj_buffer *buff = r->ptr;return scnprintf (str,PRIV_STR_SIZE ,"size=%u\naddr=0x%X\n" , buff->size, buff->addr); } -break ;case OID_TYPE_BSS :{struct obj_bss *bss = r->ptr;return scnprintf (str,PRIV_STR_SIZE ,"age=%u\nchannel=%u\n" "capinfo=0x%X\nrates=0x%X\n" "basic_rates=0x%X\n" , bss->age, bss->channel, bss->capinfo, bss->rates, bss->basic_rates); } -break ;case OID_TYPE_BSSLIST :{struct obj_bsslist *list = r->ptr;int i, k; k =scnprintf (str,PRIV_STR_SIZE ,"nr=%u\n" , list->nr);for (i =0 ; i < list->nr; i++)@@ -812,53 +810,47 @@ mgt_response_to_str(enum oid_num_t n, union oid_res_t *r, char *str) list->bsslist[i].capinfo, list->bsslist[i].rates, list->bsslist[i].basic_rates);return k; } -break ;case OID_TYPE_FREQUENCIES :{struct obj_frequencies *freq = r->ptr;int i, t;printk ("nr : %u\n" , freq->nr); t =scnprintf (str,PRIV_STR_SIZE ,"nr=%u\n" , freq->nr);for (i =0 ; i < freq->nr; i++) t +=scnprintf (str + t,PRIV_STR_SIZE - t,"mhz[%u]=%u\n" , i, freq->mhz[i]);return t; } -break ;case OID_TYPE_MLME :{struct obj_mlme *mlme = r->ptr;return scnprintf (str,PRIV_STR_SIZE ,"id=0x%X\nstate=0x%X\ncode=0x%X\n" , mlme->id, mlme->state, mlme->code); } -break ;case OID_TYPE_MLMEEX :{struct obj_mlmeex *mlme = r->ptr;return scnprintf (str,PRIV_STR_SIZE ,"id=0x%X\nstate=0x%X\n" "code=0x%X\nsize=0x%X\n" , mlme->id, mlme->state, mlme->code, mlme->size); } -break ;case OID_TYPE_ATTACH :{struct obj_attachment *attach = r->ptr;return scnprintf (str,PRIV_STR_SIZE ,"id=%d\nsize=%d\n" , attach->id, attach->size); } -break ;case OID_TYPE_SSID :{struct obj_ssid *ssid = r->ptr;return scnprintf (str,PRIV_STR_SIZE ,"length=%u\noctets=%.*s\n" , ssid->length, ssid->length, ssid->octets); } -break ;case OID_TYPE_KEY :{struct obj_key *key = r->ptr;int t, i; t = scnprintf(str, PRIV_STR_SIZE, "type=0x%X\nlength=0x%X\nkey=0x",@@ -867,11 +859,10 @@ mgt_response_to_str(enum oid_num_t n, union oid_res_t *r, char *str) t +=scnprintf (str + t,PRIV_STR_SIZE - t,"%02X:" , key->key[i]); t +=scnprintf (str + t,PRIV_STR_SIZE - t,"\n" );return t; } -break ;case OID_TYPE_RAW :case OID_TYPE_ADDR :{unsigned char *buff = r->ptr;int t, i; t =scnprintf (str,PRIV_STR_SIZE ,"hex data=" );@@ -879,11 +870,10 @@ mgt_response_to_str(enum oid_num_t n, union oid_res_t *r, char *str) t +=scnprintf (str + t,PRIV_STR_SIZE - t,"%02X:" , buff[i]); t +=scnprintf (str + t,PRIV_STR_SIZE - t,"\n" );return t; } -break ;default :BUG (); }return 0 ; }drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c +0
-1@@ -1224,11 +1224,10 @@ static int _rtl88ee_set_media_status(struct ieee80211_hw *hw, "Set Network type to AP!\n");break ;default :pr_err ("Network type %d not support!\n" , type);return 1 ; -break ; }/* MSR_INFRA == Link in infrastructure network; * MSR_ADHOC == Link in ad hoc network; * Therefore, check link state is necessary. drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c +0
-1@@ -1130,11 +1130,10 @@ static int _rtl8723e_set_media_status(struct ieee80211_hw *hw, "Set Network type to AP!\n");break ;default :pr_err ("Network type %d not support!\n" , type);return 1 ; -break ; }/* MSR_INFRA == Link in infrastructure network; * MSR_ADHOC == Link in ad hoc network; * Therefore, check link state is necessary. drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c +0
-3@@ -2083,16 +2083,14 @@ bool rtl8812ae_phy_config_rf_with_headerfile(struct ieee80211_hw *hw,switch (rfpath) {case RF90_PATH_A :return __rtl8821ae_phy_config_with_headerfile (hw, radioa_array_table_a, radioa_arraylen_a, _rtl8821ae_config_rf_radio_a); -break ;case RF90_PATH_B :return __rtl8821ae_phy_config_with_headerfile (hw, radioa_array_table_b, radioa_arraylen_b, _rtl8821ae_config_rf_radio_b); -break ;case RF90_PATH_C :case RF90_PATH_D :pr_err ("switch case %#x not processed\n" , rfpath);break ; }@@ -2114,11 +2112,10 @@ bool rtl8821ae_phy_config_rf_with_headerfile(struct ieee80211_hw *hw,switch (rfpath) {case RF90_PATH_A :return __rtl8821ae_phy_config_with_headerfile (hw, radioa_array_table, radioa_arraylen, _rtl8821ae_config_rf_radio_a); -break ;case RF90_PATH_B :case RF90_PATH_C :case RF90_PATH_D :pr_err ("switch case %#x not processed\n" , rfpath);drivers/nfc/st21nfca/core.c +0
-1@@ -792,11 +792,10 @@ static int st21nfca_hci_im_transceive(struct nfc_hci_dev *hdev,return nfc_hci_send_cmd_async (hdev, target->hci_reader_gate,ST21NFCA_WR_XCHG_DATA , skb->data, skb->len, st21nfca_hci_data_exchange_cb, info); -break ;default :return 1 ; } }drivers/nfc/trf7970a.c +0
-1@@ -1380,11 +1380,10 @@ static int trf7970a_is_iso15693_write_or_lock(u8 cmd)case ISO15693_CMD_WRITE_AFI :case ISO15693_CMD_LOCK_AFI :case ISO15693_CMD_WRITE_DSFID :case ISO15693_CMD_LOCK_DSFID :return 1 ; -break ;default :return 0 ; } }drivers/nvdimm/claim.c +0
-1@@ -200,11 +200,10 @@ ssize_t nd_namespace_store(struct device *dev, }break ;default : len = -EBUSY ; goto out_attach; -break ; }if (__nvdimm_namespace_capacity (ndns) <SZ_16M ) {dev_dbg (dev,"%s too small to host\n" , name); len = -ENXIO ;drivers/pci/controller/pci-v3-semi.c +0
-1@@ -656,11 +656,10 @@ static int v3_get_dma_range_config(struct v3_pci *v3, val |=V3_LB_BASE_ADR_SIZE_2GB ;break ;default :dev_err (v3->dev,"illegal dma memory chunk size\n" );return -EINVAL ; -break ; } val |=V3_PCI_MAP_M_REG_EN |V3_PCI_MAP_M_ENABLE ; *pci_map = val; dev_dbg(dev,drivers/pinctrl/samsung/pinctrl-s3c24xx.c +0
-5@@ -106,23 +106,18 @@ struct s3c24xx_eint_domain_data {static int s3c24xx_eint_get_trigger (unsigned int type) {switch (type) {case IRQ_TYPE_EDGE_RISING :return EINT_EDGE_RISING ; -break ;case IRQ_TYPE_EDGE_FALLING :return EINT_EDGE_FALLING ; -break ;case IRQ_TYPE_EDGE_BOTH :return EINT_EDGE_BOTH ; -break ;case IRQ_TYPE_LEVEL_HIGH :return EINT_LEVEL_HIGH ; -break ;case IRQ_TYPE_LEVEL_LOW :return EINT_LEVEL_LOW ; -break ;default :return -EINVAL ; } }drivers/platform/x86/acer-wmi.c +0
-1@@ -790,11 +790,10 @@ static acpi_status AMW0_set_u32(u32 value, u32 cap)if (value > max_brightness)return AE_BAD_PARAMETER ;switch (quirks->brightness) {default :return ec_write (0x83 , value); -break ; }default :return AE_ERROR ; }drivers/platform/x86/sony-laptop.c +0
-3@@ -2465,26 +2465,23 @@ static int __sony_nc_gfx_switch_status_get(void)case 0x0146 :/* 1: discrete GFX (speed) * 0: integrated GFX (stamina) */ return result &0x1 ?SPEED :STAMINA ; -break ;case 0x015B :/* 0: discrete GFX (speed) * 1: integrated GFX (stamina) */ return result &0x1 ?STAMINA :SPEED ; -break ;case 0x0128 :/* it's a more elaborated bitmask, for now: * 2: integrated GFX (stamina) * 0: discrete GFX (speed) */ dprintk ("GFX Status: 0x%x\n" , result);return result &0x80 ?AUTO : result &0x02 ?STAMINA :SPEED ; -break ; }return -EINVAL ; } static ssize_t sony_nc_gfx_switch_status_show(struct device *dev,drivers/platform/x86/wmi.c +0
-3@@ -1258,17 +1258,14 @@ acpi_wmi_ec_space_handler(u32 function, acpi_physical_address address, }switch (result) {case -EINVAL :return AE_BAD_PARAMETER ; -break ;case -ENODEV :return AE_NOT_FOUND ; -break ;case -ETIME :return AE_TIME ; -break ;default :return AE_OK ; } }drivers/power/supply/wm831x_power.c +0
-1@@ -666,11 +666,10 @@ static int wm831x_power_probe(struct platform_device *pdev)default :dev_err (&pdev->dev,"Failed to find USB phy: %d\n" , ret); fallthrough;case -EPROBE_DEFER : goto err_bat_irq; -break ; }return ret; err_bat_irq:drivers/scsi/aic94xx/aic94xx_task.c +0
-1@@ -267,11 +267,10 @@ static void asd_task_tasklet_complete(struct asd_ascb *ascb, ts->stat =SAS_NAK_R_ERR ;break ;case TA_I_T_NEXUS_LOSS : opcode = dl->status_block[0 ]; goto Again; -break ;case TF_INV_CONN_HANDLE : ts->resp =SAS_TASK_UNDELIVERED ; ts->stat =SAS_DEVICE_UNKNOWN ;break ;case TF_REQUESTED_N_PENDING :drivers/scsi/be2iscsi/be_mgmt.c +0
-4@@ -1242,22 +1242,18 @@ beiscsi_adap_family_disp(struct device *dev, struct device_attribute *attr,case BE_DEVICE_ID1 :case OC_DEVICE_ID1 :case OC_DEVICE_ID2 :return snprintf (buf,PAGE_SIZE ,"Obsolete/Unsupported BE2 Adapter Family\n" ); -break ;case BE_DEVICE_ID2 :case OC_DEVICE_ID3 :return snprintf (buf,PAGE_SIZE ,"BE3-R Adapter Family\n" ); -break ;case OC_SKH_ID1 :return snprintf (buf,PAGE_SIZE ,"Skyhawk-R Adapter Family\n" ); -break ;default :return snprintf (buf,PAGE_SIZE ,"Unknown Adapter Family: 0x%x\n" , dev_id); -break ; } }/** * beiscsi_phys_port()- Display Physical Port Identifier drivers/scsi/bnx2fc/bnx2fc_hwi.c +0
-1@@ -768,11 +768,10 @@ static void bnx2fc_process_unsol_compl(struct bnx2fc_rport *tgt, u16 wqe)if (rc) goto skip_rec; }else printk(KERN_ERR PFX "SRR in progress\n"); goto ret_err_rqe; -break ;default :break ; } skip_rec:drivers/scsi/fcoe/fcoe.c +0
-1@@ -1892,11 +1892,10 @@ static int fcoe_device_notification(struct notifier_block *notifier,fcoe_interface_remove (fcoe);fcoe_interface_cleanup (fcoe);mutex_unlock (&fcoe_config_mutex);fcoe_ctlr_device_delete (fcoe_ctlr_to_ctlr_dev (ctlr)); goto out; -break ;case NETDEV_FEAT_CHANGE :fcoe_netdev_features_change (lport, netdev);break ;default : FCOE_NETDEV_DBG(netdev, "Unknown event %ld "drivers/scsi/hpsa.c +0
-1@@ -7440,11 +7440,10 @@ static int find_PCI_BAR_index(struct pci_dev *pdev, unsigned long pci_bar_addr)break ;default :/* reserved in PCI 2.2 */ dev_warn (&pdev->dev,"base address is invalid\n" );return -1 ; -break ; } }if (offset == pci_bar_addr -PCI_BASE_ADDRESS_0 )return i +1 ; }drivers/scsi/hptiop.c +0
-1@@ -756,11 +756,10 @@ static void hptiop_finish_scsi_req(struct hptiop_hba *hba, u32 tag,scsi_set_resid (scp,scsi_bufflen (scp) -le32_to_cpu (req->dataxfer_length)); scp->result =SAM_STAT_CHECK_CONDITION ;memcpy (scp->sense_buffer, &req->sg_list,SCSI_SENSE_BUFFERSIZE ); goto skip_resid; -break ;default : scp->result =DRIVER_INVALID <<24 |DID_ABORT <<16 ;break ; }drivers/scsi/ipr.c +0
-1@@ -9485,11 +9485,10 @@ static pci_ers_result_t ipr_pci_error_detected(struct pci_dev *pdev,ipr_pci_frozen (pdev);return PCI_ERS_RESULT_CAN_RECOVER ;case pci_channel_io_perm_failure:ipr_pci_perm_failure (pdev);return PCI_ERS_RESULT_DISCONNECT ; -break ;default :break ; }return PCI_ERS_RESULT_NEED_RESET ; }drivers/scsi/isci/phy.c +0
-2@@ -751,11 +751,10 @@ enum sci_status sci_phy_event_handler(struct isci_phy *iphy, u32 event_code)sci_change_state (&iphy->sm,SCI_PHY_STARTING );break ;default :phy_event_warn (iphy, state, event_code);return SCI_FAILURE ; -break ; }return SCI_SUCCESS ;case SCI_PHY_SUB_AWAIT_IAF_UF :switch (scu_get_event_code (event_code)) {case SCU_EVENT_SAS_PHY_DETECTED :@@ -956,11 +955,10 @@ enum sci_status sci_phy_event_handler(struct isci_phy *iphy, u32 event_code)sci_change_state (&iphy->sm,SCI_PHY_STARTING );break ;default :phy_event_warn (iphy, state, event_code);return SCI_FAILURE_INVALID_STATE ; -break ; }return SCI_SUCCESS ;default :dev_dbg (sciphy_to_dev (iphy),"%s: in wrong state: %s\n" , __func__,phy_state_name (state));drivers/scsi/lpfc/lpfc_debugfs.c +4
-8@@ -3339,11 +3339,10 @@ lpfc_idiag_pcicfg_read(struct file *file, char __user *buf, size_t nbytes, len +=scnprintf (pbuffer+len,LPFC_PCI_CFG_SIZE -len,"%03x: %08x\n" , where, u32val);break ;case LPFC_PCI_CFG_BROWSE :/* browse all */ goto pcicfg_browse; -break ;default :/* illegal count */ len =0 ;break ; }@@ -4379,11 +4378,11 @@ lpfc_idiag_queacc_write(struct file *file, const char __user *buf, goto pass_check; } } } goto error_out; -break ; +case LPFC_IDIAG_CQ :/* MBX complete queue */ if (phba->sli4_hba.mbx_cq && phba->sli4_hba.mbx_cq->queue_id == queid) {/* Sanity check */ @@ -4431,11 +4430,11 @@ lpfc_idiag_queacc_write(struct file *file, const char __user *buf, goto pass_check; } } } goto error_out; -break ; +case LPFC_IDIAG_MQ :/* MBX work queue */ if (phba->sli4_hba.mbx_wq && phba->sli4_hba.mbx_wq->queue_id == queid) {/* Sanity check */ @@ -4445,11 +4444,11 @@ lpfc_idiag_queacc_write(struct file *file, const char __user *buf, goto error_out; idiag.ptr_private = phba->sli4_hba.mbx_wq; goto pass_check; } goto error_out; -break ; +case LPFC_IDIAG_WQ :/* ELS work queue */ if (phba->sli4_hba.els_wq && phba->sli4_hba.els_wq->queue_id == queid) {/* Sanity check */ @@ -4485,13 +4484,12 @@ lpfc_idiag_queacc_write(struct file *file, const char __user *buf, idiag.ptr_private = qp; goto pass_check; } } } - goto error_out; -break ; +case LPFC_IDIAG_RQ :/* HDR queue */ if (phba->sli4_hba.hdr_rq && phba->sli4_hba.hdr_rq->queue_id == queid) {/* Sanity check */ @@ -4512,14 +4510,12 @@ lpfc_idiag_queacc_write(struct file *file, const char __user *buf, goto error_out; idiag.ptr_private = phba->sli4_hba.dat_rq; goto pass_check; } goto error_out; -break ;default : goto error_out; -break ; } pass_check:if (idiag.cmd.opcode ==LPFC_IDIAG_CMD_QUEACC_RD ) {drivers/scsi/lpfc/lpfc_init.c +0
-1@@ -7194,11 +7194,10 @@ lpfc_init_api_table_setup(struct lpfc_hba *phba, uint8_t dev_grp)default :lpfc_printf_log (phba,KERN_ERR ,LOG_TRACE_EVENT ,"1431 Invalid HBA PCI-device group: 0x%x\n" , dev_grp);return -ENODEV ; -break ; }return 0 ; }/** drivers/scsi/lpfc/lpfc_scsi.c +0
-1@@ -4282,11 +4282,10 @@ lpfc_scsi_api_table_setup(struct lpfc_hba *phba, uint8_t dev_grp)default :lpfc_printf_log (phba,KERN_ERR ,LOG_TRACE_EVENT ,"1418 Invalid HBA PCI-device group: 0x%x\n" , dev_grp);return -ENODEV ; -break ; } phba->lpfc_rampdown_queue_depth = lpfc_rampdown_queue_depth; phba->lpfc_scsi_cmd_iocb_cmpl = lpfc_scsi_cmd_iocb_cmpl;return 0 ; }drivers/scsi/lpfc/lpfc_sli.c +0
-3@@ -9187,11 +9187,10 @@ lpfc_mbox_api_table_setup(struct lpfc_hba *phba, uint8_t dev_grp)default :lpfc_printf_log (phba,KERN_ERR ,LOG_TRACE_EVENT ,"1420 Invalid HBA PCI-device group: 0x%x\n" , dev_grp);return -ENODEV ; -break ; }return 0 ; }/** @@ -10070,11 +10069,10 @@ lpfc_sli4_iocb2wqe(struct lpfc_hba *phba, struct lpfc_iocbq *iocbq,default :lpfc_printf_log (phba,KERN_ERR ,LOG_TRACE_EVENT ,"2014 Invalid command 0x%x\n" , iocbq->iocb.ulpCommand);return IOCB_ERROR ; -break ; }if (iocbq->iocb_flag &LPFC_IO_DIF_PASS )bf_set (wqe_dif, &wqe->generic.wqe_com,LPFC_WQE_DIF_PASSTHRU );else if (iocbq->iocb_flag &LPFC_IO_DIF_STRIP )@@ -10232,11 +10230,10 @@ lpfc_sli_api_table_setup(struct lpfc_hba *phba, uint8_t dev_grp)default :lpfc_printf_log (phba,KERN_ERR ,LOG_TRACE_EVENT ,"1419 Invalid HBA PCI-device group: 0x%x\n" , dev_grp);return -ENODEV ; -break ; } phba->lpfc_get_iocb_from_iocbq = lpfc_get_iocb_from_iocbq;return 0 ; }drivers/scsi/mvumi.c +0
-1@@ -2294,11 +2294,10 @@ static int mvumi_cfg_hw_reg(struct mvumi_hba *mhba) regs->int_drbl_int_mask =0x3FFFFFFF ; regs->int_mu = regs->int_dl_cpu2pciea | regs->int_comaout;break ;default :return -1 ; -break ; }return 0 ; }drivers/scsi/pcmcia/nsp_cs.c +0
-2@@ -1100,12 +1100,10 @@ static irqreturn_t nspintr(int irq, void *dev_id)nsp_index_write (base,SCSIBUSCTRL ,SCSI_ATN );udelay (1 );nsp_index_write (base,SCSIBUSCTRL ,SCSI_ATN |AUTODIRECTION |ACKENB );return IRQ_HANDLED ; -break ; -case PH_RESELECT ://nsp_dbg(NSP_DEBUG_INTR, "phase reselect"); // *sync_neg = SYNC_NOT_YET; if ((phase &BUSMON_PHASE_MASK ) !=BUSPHASE_MESSAGE_IN ) {drivers/scsi/qla2xxx/qla_mbx.c +0
-1@@ -4028,11 +4028,10 @@ qla24xx_report_id_acquisition(scsi_qla_host_t *vha,/* if our portname is higher then initiate N2N login */ set_bit (N2N_LOGIN_NEEDED , &vha->dpc_flags);return ; -break ;case TOPO_FL : ha->current_topology =ISP_CFG_FL ;break ;case TOPO_F : ha->current_topology =ISP_CFG_F ;drivers/scsi/st.c +0
-1@@ -2844,11 +2844,10 @@ static int st_int_ioctl(struct scsi_tape *STp, unsigned int cmd_in, unsigned lon fileno = blkno = at_sm =0 ;break ;case MTNOP :DEBC_printk (STp,"No op on tape.\n" );return 0 ;/* Should do something ? */ -break ;case MTRETEN : cmd[0 ] =START_STOP ;if (STp->immediate) { cmd[1 ] =1 ;/* Don't wait for completion */ timeout = STp->device->request_queue->rq_timeout;drivers/scsi/sym53c8xx_2/sym_hipd.c +0
-1@@ -4594,11 +4594,10 @@ static void sym_int_sir(struct sym_hcb *np)sym_print_addr (cp->cmd,"M_REJECT received (%x:%x).\n" ,scr_to_cpu (np->lastmsg), np->msgout[0 ]); } goto out_clrack; -break ;default : goto out_reject; }break ;/* drivers/staging/media/atomisp/pci/sh_css.c +0
-1@@ -6284,11 +6284,10 @@ allocate_delay_frames(struct ia_css_pipe *pipe) {case IA_CSS_PIPE_ID_CAPTURE : {struct ia_css_capture_settings *mycs_capture = &pipe->pipe_settings.capture; (void )mycs_capture;return err; } -break ;case IA_CSS_PIPE_ID_VIDEO : {struct ia_css_video_settings *mycs_video = &pipe->pipe_settings.video; ref_info = mycs_video->video_binary.internal_frame_info;/*The ref frame expects drivers/staging/rts5208/rtsx_scsi.c +0
-2@@ -569,12 +569,10 @@ static int start_stop_unit(struct scsi_cmnd *srb, struct rtsx_chip *chip)case LOAD_MEDIUM :if (check_card_ready (chip, lun))return TRANSPORT_GOOD ;set_sense_type (chip, lun,SENSE_TYPE_MEDIA_NOT_PRESENT );return TRANSPORT_FAILED ; - -break ; }return TRANSPORT_ERROR ; }drivers/staging/vme/devices/vme_user.c +0
-4@@ -355,12 +355,10 @@ static int vme_user_ioctl(struct inode *inode, struct file *file,* to userspace as they are */ return vme_master_set (image[minor].resource, master.enable, master.vme_addr, master.size, master.aspace, master.cycle, master.dwidth); - -break ; }break ;case SLAVE_MINOR :switch (cmd) {case VME_GET_SLAVE :@@ -396,12 +394,10 @@ static int vme_user_ioctl(struct inode *inode, struct file *file,*/ return vme_slave_set (image[minor].resource, slave.enable, slave.vme_addr, slave.size, image[minor].pci_buf, slave.aspace, slave.cycle); - -break ; }break ; }return -EINVAL ;drivers/tty/nozomi.c +1
-4@@ -412,15 +412,13 @@ static void read_mem32(u32 *buf, const void __iomem *mem_addr_start,switch (size_bytes) {case 2 :/* 2 bytes */ buf16 = (u16 *) buf; *buf16 =__le16_to_cpu (readw (ptr)); goto out; -break ;case 4 :/* 4 bytes */ *(buf) =__le32_to_cpu (readl (ptr)); goto out; -break ; }while (i < size_bytes) {if (size_bytes - i ==2 ) {/* Handle 2 bytes in the end */ @@ -458,19 +456,18 @@ static u32 write_mem32(void __iomem *mem_addr_start, const u32 *buf,switch (size_bytes) {case 2 :/* 2 bytes */ buf16 = (const u16 *)buf;writew (__cpu_to_le16 (*buf16), ptr);return 2 ; -break ;case 1 :/* * also needs to write 4 bytes in this case * so falling through.. */ + fallthrough;case 4 :/* 4 bytes */ writel (__cpu_to_le32 (*buf), ptr);return 4 ; -break ; }while (i < size_bytes) {if (size_bytes - i ==2 ) {/* 2 bytes */ drivers/tty/serial/imx.c +0
-5@@ -318,31 +318,26 @@ static void imx_uart_writel(struct imx_port *sport, u32 val, u32 offset)static u32 imx_uart_readl (struct imx_port *sport,u32 offset) {switch (offset) {case UCR1 :return sport->ucr1; -break ;case UCR2 :/* * UCR2_SRST is the only bit in the cached registers that might * differ from the value that was last written. As it only * automatically becomes one after being cleared, reread * conditionally. */ if (!(sport->ucr2 &UCR2_SRST )) sport->ucr2 =readl (sport->port.membase + offset);return sport->ucr2; -break ;case UCR3 :return sport->ucr3; -break ;case UCR4 :return sport->ucr4; -break ;case UFCR :return sport->ufcr; -break ;default :return readl (sport->port.membase + offset); } }drivers/usb/gadget/function/f_hid.c +0
-9@@ -509,27 +509,23 @@ static int hidg_setup(struct usb_function *f,VDBG (cdev,"get_report\n" );/* send an empty report */ length =min_t (unsigned, length, hidg->report_length);memset (req->buf,0x0 , length); - goto respond; -break ;case ((USB_DIR_IN |USB_TYPE_CLASS |USB_RECIP_INTERFACE ) <<8 |HID_REQ_GET_PROTOCOL ):VDBG (cdev,"get_protocol\n" ); length = min_t(unsigned int, length, 1); ((u8 *) req->buf)[0 ] = hidg->protocol; goto respond; -break ;case ((USB_DIR_OUT |USB_TYPE_CLASS |USB_RECIP_INTERFACE ) <<8 |HID_REQ_SET_REPORT ):VDBG (cdev,"set_report | wLength=%d\n" , ctrl->wLength); goto stall; -break ;case ((USB_DIR_OUT |USB_TYPE_CLASS |USB_RECIP_INTERFACE ) <<8 |HID_REQ_SET_PROTOCOL ):VDBG (cdev,"set_protocol\n" );if (value >HID_REPORT_PROTOCOL )@@ -542,11 +538,10 @@ static int hidg_setup(struct usb_function *f,if (hidg->bInterfaceSubClass ==USB_INTERFACE_SUBCLASS_BOOT ) { hidg->protocol = value; goto respond; } goto stall; -break ;case ((USB_DIR_IN |USB_TYPE_STANDARD |USB_RECIP_INTERFACE ) <<8 |USB_REQ_GET_DESCRIPTOR ):switch (value >>8 ) {case HID_DT_HID :@@ -560,33 +555,29 @@ static int hidg_setup(struct usb_function *f, length = min_t(unsigned short, length, hidg_desc_copy.bLength);memcpy (req->buf, &hidg_desc_copy, length); goto respond; -break ; }case HID_DT_REPORT :VDBG (cdev,"USB_REQ_GET_DESCRIPTOR: REPORT\n" ); length = min_t(unsigned short, length, hidg->report_desc_length);memcpy (req->buf, hidg->report_desc, length); goto respond; -break ;default :VDBG (cdev,"Unknown descriptor request 0x%x\n" , value >>8 ); goto stall; -break ; }break ;default :VDBG (cdev,"Unknown request 0x%x\n" , ctrl->bRequest); goto stall; -break ; } stall:return -EOPNOTSUPP ;drivers/usb/host/xhci-mem.c +0
-1@@ -1142,11 +1142,10 @@ int xhci_setup_addressable_virt_dev(struct xhci_hcd *xhci, struct usb_device *ud max_packets =MAX_PACKET (8 );break ;case USB_SPEED_WIRELESS :xhci_dbg (xhci,"FIXME xHCI doesn't support wireless speeds\n" );return -EINVAL ; -break ;default :/* Speed was set earlier, this shouldn't happen. */ return -EINVAL ; }/* Find the root hub port this device is under */ drivers/usb/misc/iowarrior.c +0
-3@@ -382,11 +382,10 @@ static ssize_t iowarrior_write(struct file *file, goto exit; } retval =usb_set_report (dev->interface,2 ,0 , buf, count);kfree (buf); goto exit; -break ;case USB_DEVICE_ID_CODEMERCS_IOW56 :case USB_DEVICE_ID_CODEMERCS_IOW56AM :case USB_DEVICE_ID_CODEMERCS_IOW28 :case USB_DEVICE_ID_CODEMERCS_IOW28L :case USB_DEVICE_ID_CODEMERCS_IOW100 :@@ -452,18 +451,16 @@ static ssize_t iowarrior_write(struct file *file, }/* submit was ok */ retval = count;usb_free_urb (int_out_urb); goto exit; -break ;default :/* what do we have here ? An unsupported Product-ID ? */ dev_err (&dev->interface->dev,"%s - not supported for product=0x%x\n" , __func__, dev->product_id); retval = -EFAULT ; goto exit; -break ; } error:usb_free_coherent (dev->udev, dev->report_size, buf, int_out_urb->transfer_dma); error_no_buffer:drivers/usb/serial/iuu_phoenix.c +0
-2@@ -848,11 +848,10 @@ static int iuu_uart_baud(struct usb_serial_port *port, u32 baud_base, dataout[DataCount++] =0x04 ;break ;default :kfree (dataout);return IUU_INVALID_PARAMETER ; -break ; }switch (parity &0xF0 ) {case IUU_ONE_STOP_BIT : dataout[DataCount -1 ] |=IUU_ONE_STOP_BIT ;@@ -862,11 +861,10 @@ static int iuu_uart_baud(struct usb_serial_port *port, u32 baud_base, dataout[DataCount -1 ] |=IUU_TWO_STOP_BITS ;break ;default :kfree (dataout);return IUU_INVALID_PARAMETER ; -break ; } status =bulk_immediate (port, dataout, DataCount);if (status !=IUU_OPERATION_OK )dev_dbg (&port->dev,"%s - uart_off error\n" , __func__);drivers/usb/storage/freecom.c +0
-1@@ -429,11 +429,10 @@ static int freecom_transport(struct scsi_cmnd *srb, struct us_data *us)/* should never hit here -- filtered in usb.c */ usb_stor_dbg (us,"freecom unimplemented direction: %d\n" , us->srb->sc_data_direction);/* Return fail, SCSI seems to handle this better. */ return USB_STOR_TRANSPORT_FAILED ; -break ; }return USB_STOR_TRANSPORT_GOOD ; }drivers/vme/bridges/vme_tsi148.c +0
-7@@ -504,11 +504,10 @@ static int tsi148_slave_set(struct vme_slave_resource *image, int enabled, addr |=TSI148_LCSR_ITAT_AS_A64 ;break ;default :dev_err (tsi148_bridge->parent,"Invalid address space\n" );return -EINVAL ; -break ; }/* Convert 64-bit variables to 2x 32-bit variables */ reg_split (vme_base, &vme_base_high, &vme_base_low);@@ -993,11 +992,10 @@ static int tsi148_master_set(struct vme_master_resource *image, int enabled,default :spin_unlock (&image->lock);dev_err (tsi148_bridge->parent,"Invalid address space\n" ); retval = -EINVAL ; goto err_aspace; -break ; } temp_ctl &= ~(3 <<4 );if (cycle &VME_SUPER ) temp_ctl |=TSI148_LCSR_OTAT_SUP ;@@ -1501,11 +1499,10 @@ static int tsi148_dma_set_vme_src_attributes(struct device *dev, __be32 *attr, val |=TSI148_LCSR_DSAT_AMODE_USER4 ;break ;default :dev_err (dev,"Invalid address space\n" );return -EINVAL ; -break ; }if (cycle &VME_SUPER ) val |=TSI148_LCSR_DSAT_SUP ;if (cycle &VME_PROG )@@ -1601,11 +1598,10 @@ static int tsi148_dma_set_vme_dest_attributes(struct device *dev, __be32 *attr, val |=TSI148_LCSR_DDAT_AMODE_USER4 ;break ;default :dev_err (dev,"Invalid address space\n" );return -EINVAL ; -break ; }if (cycle &VME_SUPER ) val |=TSI148_LCSR_DDAT_SUP ;if (cycle &VME_PROG )@@ -1699,11 +1695,10 @@ static int tsi148_dma_list_add(struct vme_dma_list *list,break ;default :dev_err (tsi148_bridge->parent,"Invalid source type\n" ); retval = -EINVAL ; goto err_source; -break ; }/* Assume last link - this will be over-written by adding another */ entry->descriptor.dnlau =cpu_to_be32 (0 ); entry->descriptor.dnlal =cpu_to_be32 (TSI148_LCSR_DNLAL_LLA );@@ -1736,11 +1731,10 @@ static int tsi148_dma_list_add(struct vme_dma_list *list,break ;default :dev_err (tsi148_bridge->parent,"Invalid destination type\n" ); retval = -EINVAL ; goto err_dest; -break ; }/* Fill out count */ entry->descriptor.dcnt =cpu_to_be32 ((u32 )count);@@ -1962,11 +1956,10 @@ static int tsi148_lm_set(struct vme_lm_resource *lm, unsigned long long lm_base,break ;default :mutex_unlock (&lm->mtx);dev_err (tsi148_bridge->parent,"Invalid address space\n" );return -EINVAL ; -break ; }if (cycle &VME_SUPER ) lm_ctl |=TSI148_LCSR_LMAT_SUPR ;if (cycle &VME_USER )drivers/vme/vme.c +0
-9@@ -50,27 +50,22 @@ static struct vme_bridge *find_bridge(struct vme_resource *resource)/* Get list to search */ switch (resource->type) {case VME_MASTER : return list_entry(resource->entry, struct vme_master_resource, list)->parent; -break ;case VME_SLAVE : return list_entry(resource->entry, struct vme_slave_resource, list)->parent; -break ;case VME_DMA : return list_entry(resource->entry, struct vme_dma_resource, list)->parent; -break ;case VME_LM : return list_entry(resource->entry, struct vme_lm_resource, list)->parent; -break ;default :printk (KERN_ERR "Unknown resource type\n" );return NULL ; -break ; } }/** * vme_free_consistent - Allocate contiguous memory. @@ -177,26 +172,22 @@ size_t vme_get_size(struct vme_resource *resource) &aspace, &cycle, &dwidth);if (retval)return 0 ;return size; -break ;case VME_SLAVE : retval =vme_slave_get (resource, &enabled, &base, &size, &buf_base, &aspace, &cycle);if (retval)return 0 ;return size; -break ;case VME_DMA :return 0 ; -break ;default :printk (KERN_ERR "Unknown resource type\n" );return 0 ; -break ; } }EXPORT_SYMBOL (vme_get_size); int vme_check_window(u32 aspace, unsigned long long vme_base,drivers/watchdog/geodewdt.c +0
-2@@ -148,12 +148,10 @@ static long geodewdt_ioctl(struct file *file, unsigned int cmd,switch (cmd) {case WDIOC_GETSUPPORT :return copy_to_user (argp, &ident,sizeof (ident)) ? -EFAULT :0 ; -break ; -case WDIOC_GETSTATUS :case WDIOC_GETBOOTSTATUS :return put_user (0 , p);case WDIOC_SETOPTIONS :fs/efs/inode.c +0
-1@@ -161,11 +161,10 @@ struct inode *efs_iget(struct super_block *super, unsigned long ino)init_special_inode (inode, inode->i_mode, device);break ;default :pr_warn ("unsupported inode mode %o\n" , inode->i_mode); goto read_inode_error; -break ; }unlock_new_inode (inode);return inode;fs/ocfs2/cluster/tcp.c +0
-1@@ -1196,11 +1196,10 @@ static int o2net_process_message(struct o2net_sock_container *sc,break ;default :msglog (hdr,"bad magic\n" ); ret = -EINVAL ; goto out; -break ; }/* find a handler for it */ handler_status =0 ; nmh = o2net_handler_get(be16_to_cpu(hdr->msg_type),kernel/bpf/syscall.c +0
-1@@ -2911,11 +2911,10 @@ attach_type_to_prog_type(enum bpf_attach_type attach_type) {switch (attach_type) {case BPF_CGROUP_INET_INGRESS :case BPF_CGROUP_INET_EGRESS :return BPF_PROG_TYPE_CGROUP_SKB ; -break ;case BPF_CGROUP_INET_SOCK_CREATE :case BPF_CGROUP_INET_SOCK_RELEASE :case BPF_CGROUP_INET4_POST_BIND :case BPF_CGROUP_INET6_POST_BIND :return BPF_PROG_TYPE_CGROUP_SOCK ;security/integrity/ima/ima_appraise.c +0
-1@@ -179,11 +179,10 @@ enum hash_algo ima_get_hash_algo(struct evm_ima_xattr_data *xattr_value,case EVM_IMA_XATTR_DIGSIG : sig = (typeof (sig ))xattr_value;if (sig->version !=2 || xattr_len <=sizeof (*sig))return ima_hash_algo;return sig->hash_algo; -break ;case IMA_XATTR_DIGEST_NG :/* first byte contains algorithm id */ ret = xattr_value->data[0 ];if (ret <HASH_ALGO__LAST )return ret;security/keys/trusted-keys/trusted_tpm1.c +0
-1@@ -899,11 +899,10 @@ static int datablob_parse(char *datablob, struct trusted_key_payload *p,return ret; ret = Opt_update;break ;case Opt_err:return -EINVAL ; -break ; }return ret; }static struct trusted_key_options *trusted_options_alloc (void )security/safesetid/lsm.c +0
-3@@ -123,11 +123,10 @@ static int safesetid_security_capable(const struct cred *cred,* set*uid() (e.g. setting up userns uid mappings). */ pr_warn ("Operation requires CAP_SETUID, which is not available to UID %u for operations besides approved set*uid transitions\n" ,__kuid_val (cred->uid));return -EPERM ; -break ;case CAP_SETGID :/* * If no policy applies to this task, allow the use of CAP_SETGID for * other purposes. */ @@ -138,15 +137,13 @@ static int safesetid_security_capable(const struct cred *cred,* set*gid() (e.g. setting up userns gid mappings). */ pr_warn ("Operation requires CAP_SETGID, which is not available to GID %u for operations besides approved set*gid transitions\n" ,__kuid_val (cred->uid));return -EPERM ; -break ;default :/* Error, the only capabilities were checking for is CAP_SETUID/GID */ return 0 ; -break ; }return 0 ; }/* sound/pci/rme32.c +0
-1@@ -466,11 +466,10 @@ static int snd_rme32_capture_getrate(struct rme32 * rme32, int *is_adat)return 44100 ;case 7 :return 32000 ;default :return -1 ; -break ; }else switch (n) {/* supporting the CS8412 */ case 0 :return -1 ;sound/pci/rme9652/hdspm.c +0
-8@@ -2284,11 +2284,10 @@ static int hdspm_get_wc_sample_rate(struct hdspm *hdspm)switch (hdspm->io_type) {case RayDAT:case AIO : status =hdspm_read (hdspm,HDSPM_RD_STATUS_1 );return (status >>16 ) &0xF ; -break ;case AES32 : status =hdspm_read (hdspm, HDSPM_statusRegister);return (status >> HDSPM_AES32_wcFreq_bit) &0xF ;default :break ;@@ -2310,11 +2309,10 @@ static int hdspm_get_tco_sample_rate(struct hdspm *hdspm)switch (hdspm->io_type) {case RayDAT:case AIO : status =hdspm_read (hdspm,HDSPM_RD_STATUS_1 );return (status >>20 ) &0xF ; -break ;case AES32 : status =hdspm_read (hdspm, HDSPM_statusRegister);return (status >>1 ) &0xF ;default :break ;@@ -2336,11 +2334,10 @@ static int hdspm_get_sync_in_sample_rate(struct hdspm *hdspm)switch (hdspm->io_type) {case RayDAT:case AIO : status =hdspm_read (hdspm,HDSPM_RD_STATUS_2 );return (status >>12 ) &0xF ; -break ;default :break ; } }@@ -2356,11 +2353,10 @@ static int hdspm_get_aes_sample_rate(struct hdspm *hdspm, int index)switch (hdspm->io_type) {case AES32 : timecode =hdspm_read (hdspm, HDSPM_timecodeRegister);return (timecode >> (4 *index)) &0xF ; -break ;default :break ; }return 0 ; }@@ -3843,22 +3839,20 @@ static int hdspm_wc_sync_check(struct hdspm *hdspm)return 2 ; else return 1; }return 0 ; -break ;case MADI : status2 =hdspm_read (hdspm, HDSPM_statusRegister2);if (status2 & HDSPM_wcLock) {if (status2 & HDSPM_wcSync)return 2 ;else return 1 ; }return 0 ; -break ;case RayDAT:case AIO : status =hdspm_read (hdspm, HDSPM_statusRegister);@@ -3866,12 +3860,10 @@ static int hdspm_wc_sync_check(struct hdspm *hdspm)return 2 ; else if (status & 0x1000000) return 1;return 0 ; -break ; -case MADIface:break ; }sound/pci/rme9652/rme9652.c +0
-7@@ -730,38 +730,31 @@ static inline int rme9652_spdif_sample_rate(struct snd_rme9652 *s) rate_bits =rme9652_read (s, RME9652_status_register) &RME9652_F ;switch (rme9652_decode_spdif_rate (rate_bits)) {case 0x7 :return 32000 ; -break ;case 0x6 :return 44100 ; -break ;case 0x5 :return 48000 ; -break ;case 0x4 :return 88200 ; -break ;case 0x3 :return 96000 ; -break ;case 0x0 :return 64000 ; -break ;default :dev_err (s->card->dev,"%s: unknown S/PDIF input rate (bits = 0x%x)\n" , s->card_name, rate_bits);return 0 ; -break ; } }/*----------------------------------------------------------------------------- Control Interface sound/soc/codecs/wcd-clsh-v2.c +0
-1@@ -478,11 +478,10 @@ static int _wcd_clsh_ctrl_set_state(struct wcd_clsh_ctrl *ctrl, int req_state,wcd_clsh_state_hph_l (ctrl, req_state, is_enable, mode);break ;case WCD_CLSH_STATE_HPHR :wcd_clsh_state_hph_r (ctrl, req_state, is_enable, mode);break ; -break ;case WCD_CLSH_STATE_LO :wcd_clsh_state_lo (ctrl, req_state, is_enable, mode);break ;default :break ;sound/soc/codecs/wl1273.c +0
-1@@ -309,11 +309,10 @@ static int wl1273_startup(struct snd_pcm_substream *substream,return -EINVAL ; }break ;default :return -EINVAL ; -break ; }return 0 ; }sound/soc/intel/skylake/skl-pcm.c +0
-1@@ -500,11 +500,10 @@ static int skl_pcm_trigger(struct snd_pcm_substream *substream, int cmd,*/ ret =skl_decoupled_trigger (substream, cmd);if (ret <0 )return ret;return skl_run_pipe (skl, mconfig->pipe); -break ;case SNDRV_PCM_TRIGGER_PAUSE_PUSH :case SNDRV_PCM_TRIGGER_SUSPEND :case SNDRV_PCM_TRIGGER_STOP :/* sound/soc/ti/davinci-mcasp.c +0
-1@@ -2383,11 +2383,10 @@ static int davinci_mcasp_probe(struct platform_device *pdev)break ;default :dev_err (&pdev->dev,"No DMA controller found (%d)\n" , ret);case -EPROBE_DEFER : goto err; -break ; }if (ret) {dev_err (&pdev->dev,"register PCM failed: %d\n" , ret); goto err;
Matthew Wilcox
maintainerQuoted 2 lines · On Sat, Oct 17, 2020 at 09:09:28AM -0700, [email protected] wrote:
clang has a number of useful, new warnings see
https://urldefense.com/v3/__https://clang.llvm.org/docs/DiagnosticsReference.html__;!!GqivPVa7Brio!Krxz78O3RKcB9JBMVo_F98FupVhj_jxX60ddN6tKGEbv_cnooXc1nnBmchm-e_O9ieGnyQ$
Please get your IT department to remove that stupidity. If you can't, please send email from a non-Red Hat email address.
I don't understand why this is a useful warning to fix. What actual problem is caused by the code below?
arch/x86/kernel/cpu/mce/core.c static int __mcheck_cpu_ancient_init(struct cpuinfo_x86 *c) · line 1814
Quoted 7 lines
return and break
arch/x86/kernel/cpu/mce/core.c +0
-1switch (c->x86_vendor) {case X86_VENDOR_INTEL :intel_p5_mcheck_init (c);return 1 ; -break ;
Sure, it's unnecessary, but it's not masking a bug. It's not unclear. Why do we want to enable this warning?
_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
Joe Perches
maintainerQuoted 6 lines · Matthew Wilcox
Quoted 2 lines · On Sat, Oct 17, 2020 at 09:09:28AM -0700, [email protected] wrote:
clang has a number of useful, new warnings see
https://urldefense.com/v3/__https://clang.llvm.org/docs/DiagnosticsReference.html__;!!GqivPVa7Brio!Krxz78O3RKcB9JBMVo_F98FupVhj_jxX60ddN6tKGEbv_cnooXc1nnBmchm-e_O9ieGnyQ$Please get your IT department to remove that stupidity. If you can't, please send email from a non-Red Hat email address.
I didn't get it this way, neither did lore.
It's on your end.
https://lore.kernel.org/lkml/[email protected]/
Quoted 1 line
I don't understand why this is a useful warning to fix.
Precision in coding style intent and code minimization would be the biggest factors IMO.
Quoted 1 line
What actual problem is caused by the code below?
Obviously none.
_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
James Bottomley
maintainerQuoted 6 lines · Matthew Wilcox
Quoted 2 lines · On Sat, Oct 17, 2020 at 09:09:28AM -0700, [email protected] wrote:
clang has a number of useful, new warnings see
https://urldefense.com/v3/__https://clang.llvm.org/docs/DiagnosticsReference.html__;!!GqivPVa7Brio!Krxz78O3RKcB9JBMVo_F98FupVhj_jxX60ddN6tKGEbv_cnooXc1nnBmchm-e_O9ieGnyQ$Please get your IT department to remove that stupidity. If you can't, please send email from a non-Red Hat email address.
Actually, the problem is at Oracle's end somewhere in the ocfs2 list ... if you could fix it, that would be great. The usual real mailing lists didn't get this transformation
https://lore.kernel.org/bpf/[email protected]/
but the ocfs2 list archive did:
https://oss.oracle.com/pipermail/ocfs2-devel/2020-October/015330.html
I bet Oracle IT has put some spam filter on the list that mangles URLs this way.
James
_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
Matthew Wilcox
maintainerQuoted 12 lines · James Bottomley
Quoted 6 lines · Matthew Wilcox
Quoted 2 lines · On Sat, Oct 17, 2020 at 09:09:28AM -0700, [email protected] wrote:
clang has a number of useful, new warnings see
https://urldefense.com/v3/__https://clang.llvm.org/docs/DiagnosticsReference.html__;!!GqivPVa7Brio!Krxz78O3RKcB9JBMVo_F98FupVhj_jxX60ddN6tKGEbv_cnooXc1nnBmchm-e_O9ieGnyQ$Please get your IT department to remove that stupidity. If you can't, please send email from a non-Red Hat email address.
Actually, the problem is at Oracle's end somewhere in the ocfs2 list ... if you could fix it, that would be great. The usual real mailing lists didn't get this transformation
Quoted 8 lines
https://lore.kernel.org/bpf/[email protected]/
but the ocfs2 list archive did:
https://oss.oracle.com/pipermail/ocfs2-devel/2020-October/015330.html
I bet Oracle IT has put some spam filter on the list that mangles URLs this way.
*sigh*. I'm sure there's a way. I've raised it with someone who should be able to fix it.
_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
James Bottomley
maintainerQuoted 17 lines · Matthew Wilcox
Quoted 16 lines · James Bottomley
Quoted 6 lines · Matthew Wilcox
Quoted 2 lines · On Sat, Oct 17, 2020 at 09:09:28AM -0700, [email protected] wrote:
clang has a number of useful, new warnings see
https://urldefense.com/v3/__https://clang.llvm.org/docs/DiagnosticsReference.html__;!!GqivPVa7Brio!Krxz78O3RKcB9JBMVo_F98FupVhj_jxX60ddN6tKGEbv_cnooXc1nnBmchm-e_O9ieGnyQ$Please get your IT department to remove that stupidity. If you can't, please send email from a non-Red Hat email address.
Actually, the problem is at Oracle's end somewhere in the ocfs2 list ... if you could fix it, that would be great. The usual real mailing lists didn't get this transformation
https://lore.kernel.org/bpf/[email protected]/
but the ocfs2 list archive did:
Quoted 7 lines
Quoted 4 lines
https://oss.oracle.com/pipermail/ocfs2-devel/2020-October/015330.html
I bet Oracle IT has put some spam filter on the list that mangles URLs this way.
*sigh*. I'm sure there's a way. I've raised it with someone who should be able to fix it.
As someone who works for IBM I can only say I feel your pain ...
James
_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k