gpio: aspeed: fix ast2600 bank properties
Subsystems (2)
Billy Tsai
reviewerPATCH 1/1 gpio: aspeed: fix ast2600 bank properties
GPIO_T is mapped to the most significant byte of input/output mask, and the byte in "output" mask should be 0 because GPIO_T is input only. All the other bits need to be 1 because GPIO_Q/R/S support both input and output modes.
--- drivers/gpio/gpio-aspeed.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpio/gpio-aspeed.c +1 -0
@@ -1114,6 +1114,7 @@ static const struct aspeed_gpio_config ast2500_config =static const struct aspeed_bank_props ast2600_bank_props[] = {/* input output */ + {4 ,0xffffffff ,0x00ffffff },/* Q/R/S/T */ {5 ,0xffffffff ,0xffffff00 },/* U/V/W/X */ {6 ,0x0000ffff ,0x0000ffff },/* Y/Z */ { },
Signature · 1 line
2.17.1
Hi Billy,
Quoted 6 lines · Billy Tsai
GPIO_Tis mapped to the most significant byte of input/output mask, and the byte in "output" mask should be 0 becauseGPIO_Tis input only. All the other bits need to be 1 because GPIO_Q/R/S support both input and output modes.Signed-off-by Billy Tsai <[email protected]>
You may want to add "Fixes" tag if you take it as a bug fix? For example:
drivers/gpio/gpio-aspeed.c static const struct aspeed_gpio_config ast2500_config = · line 1117
Quoted 13 lines
--- drivers/gpio/gpio-aspeed.c | 1 + 1 file changed, 1 insertion(+)drivers/gpio/gpio-aspeed.c +1
-0@@ -1114,6 +1114,7 @@ static const struct aspeed_gpio_config ast2500_config =static const struct aspeed_bank_props ast2600_bank_props[] = {/* input output */ + {4 ,0xffffffff ,0x00ffffff },/* Q/R/S/T */
Quoted 6 lines
drivers/gpio/gpio-aspeed.c +0
-0{5, 0xffffffff, 0xffffff00}, /* U/V/W/X */ {6, 0x0000ffff, 0x0000ffff}, /* Y/Z */ { },Signature · 1 line
2.17.1
Cheers,
Tao
Hi Billy,
Quoted 7 lines · Billy Tsai
GPIO_Tis mapped to the most significant byte of input/output mask, and the byte in "output" mask should be 0 becauseGPIO_Tis input only. All the other bits need to be 1 because GPIO_Q/R/S support both input and output modes.Signed-off-by Billy Tsai <[email protected]>
This is a very similar commit message to the one that Tao sent out, so I thought for a moment that it was a duplicate patch. I can see now that it's a different change.
Cheers,
Joel
Quoted 19 lines
--- drivers/gpio/gpio-aspeed.c | 1 + 1 file changed, 1 insertion(+)drivers/gpio/gpio-aspeed.c +1
-1@@ -1114,6 +1114,7 @@ static const struct aspeed_gpio_config ast2500_config =static const struct aspeed_bank_props ast2600_bank_props[] = {/* input output */ + {4 ,0xffffffff ,0x00ffffff },/* Q/R/S/T */ {5 ,0xffffffff ,0xffffff00 },/* U/V/W/X */ {6 ,0x0000ffff ,0x0000ffff },/* Y/Z */ { }, --2.17.1
Quoted 6 lines · Billy Tsai
GPIO_Tis mapped to the most significant byte of input/output mask, and the byte in "output" mask should be 0 becauseGPIO_Tis input only. All the other bits need to be 1 because GPIO_Q/R/S support both input and output modes.Signed-off-by Billy Tsai <[email protected]>
Good catch, thanks Billy.
Bartosz Golaszewski
AppliedQuoted 24 lines · Billy Tsai
GPIO_Tis mapped to the most significant byte of input/output mask, and the byte in "output" mask should be 0 becauseGPIO_Tis input only. All the other bits need to be 1 because GPIO_Q/R/S support both input and output modes.Signed-off-by Billy Tsai <[email protected]>--- drivers/gpio/gpio-aspeed.c | 1 + 1 file changed, 1 insertion(+)drivers/gpio/gpio-aspeed.c +1
-1@@ -1114,6 +1114,7 @@ static const struct aspeed_gpio_config ast2500_config =static const struct aspeed_bank_props ast2600_bank_props[] = {/* input output */ + {4 ,0xffffffff ,0x00ffffff },/* Q/R/S/T */ {5 ,0xffffffff ,0xffffff00 },/* U/V/W/X */ {6 ,0x0000ffff ,0x0000ffff },/* Y/Z */ { }, --
Quoted 2 lines
2.17.1
Applied to fixes with reviews collected and added the Fixes: tag.
Bartosz