Skip to contentSkip to conversation

app/regex: change default qp configuration flags

PATCH In review [email protected] 2 participants 6 messages Oct 19, 2020 – Oct 20, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 app/regex: change default qp configuration flags

From: Guy Kaneti <[email protected]>

added --cfg_oos argument to config queue
pair out of order scan

---
 app/test-regex/main.c | 24 +++++++++++++++++-------
 1 file changed, 17 insertions(+), 7 deletions(-)
app/test-regex/main.c +17 -7
index 0d35f4583..9b19031ea 100644
@@ -33,6 +33,7 @@ enum app_args {
 	ARG_NUM_OF_JOBS,
 	ARG_PERF_MODE,
 	ARG_NUM_OF_ITERATIONS,
+	ARG_CFG_OOS,
 };
 
 static void
@@ -43,13 +44,15 @@ usage(const char *prog_name)
 		" --data NAME: data file to use\n"
 		" --nb_jobs: number of jobs to use\n"
 		" --perf N: only outputs the performance data\n"
-		" --nb_iter N: number of iteration to run\n",
+		" --nb_iter N: number of iteration to run\n"
+		" --cfg_oos: configure regexdev queue flag out of order scan\n",
 		prog_name);
 }
 
 static void
 args_parse(int argc, char **argv, char *rules_file, char *data_file,
-	   uint32_t *nb_jobs, bool *perf_mode, uint32_t *nb_iterations)
+	   uint32_t *nb_jobs, bool *perf_mode, uint32_t *nb_iterations,
+	   uint32_t *qp_conf_flags)
 {
 	char **argvopt;
 	int opt;
@@ -66,7 +69,9 @@ args_parse(int argc, char **argv, char *rules_file, char *data_file,
 		/* Perf test only */
 		{ "perf", 0, 0, ARG_PERF_MODE},
 		/* Number of iterations to run with perf test */
-		{ "nb_iter", 1, 0, ARG_NUM_OF_ITERATIONS}
+		{ "nb_iter", 1, 0, ARG_NUM_OF_ITERATIONS},
+		/* configure out of order scan */
+		{ "cfg_oos", 0, 0, ARG_CFG_OOS}
 	};
 
 	argvopt = argv;
@@ -98,6 +103,9 @@ args_parse(int argc, char **argv, char *rules_file, char *data_file,
 		case ARG_NUM_OF_ITERATIONS:
 			*nb_iterations = atoi(optarg);
 			break;
+		case ARG_CFG_OOS:
+			*qp_conf_flags = RTE_REGEX_QUEUE_PAIR_CFG_OOS_F;
+			break;
 		case ARG_HELP:
 			usage("RegEx test app");
 			break;
@@ -158,7 +166,8 @@ read_file(char *file, char **buf)
 
 static int
 init_port(struct rte_mempool **mbuf_mp, uint32_t nb_jobs,
-	  uint16_t *nb_max_payload, char *rules_file, uint8_t *nb_max_matches)
+	  uint16_t *nb_max_payload, char *rules_file, uint8_t *nb_max_matches,
+	  uint32_t qp_conf_flags)
 {
 	uint16_t id;
 	uint16_t num_devs;
@@ -171,7 +180,7 @@ init_port(struct rte_mempool **mbuf_mp, uint32_t nb_jobs,
 	};
 	struct rte_regexdev_qp_conf qp_conf = {
 		.nb_desc = 1024,
-		.qp_conf_flags = RTE_REGEX_QUEUE_PAIR_CFG_OOS_F,
+		.qp_conf_flags = qp_conf_flags,
 	};
 	int res = 0;
 
@@ -407,6 +416,7 @@ main(int argc, char **argv)
 	bool perf_mode = 0;
 	uint32_t nb_iterations = 0;
 	uint8_t nb_max_matches = 0;
+	uint32_t qp_conf_flags = 0;
 	int ret;
 
 	ret = rte_eal_init(argc, argv);
@@ -416,10 +426,10 @@ main(int argc, char **argv)
 	argv += ret;
 	if (argc > 1)
 		args_parse(argc, argv, rules_file, data_file, &nb_jobs,
-			   &perf_mode, &nb_iterations);
+			   &perf_mode, &nb_iterations, &qp_conf_flags);
 
 	ret = init_port(&mbuf_mp, nb_jobs, &nb_max_payload, rules_file,
-			&nb_max_matches);
+			&nb_max_matches, qp_conf_flags);
 	if (ret < 0)
 		rte_exit(EXIT_FAILURE, "init port failed\n");
 	ret = run_regex(mbuf_mp, nb_jobs, nb_max_payload, perf_mode,
Signature · 1 line
2.28.0
#1 lore raw

PATCH 1/1 app/regex: change default qp configuration flags

From: Guy Kaneti <[email protected]>

By default qp configuration flags was set with RTE_REGEX_QUEUE_PAIR_CFG_OOS_F.
Changed flags default to 0. In order to set OOS flag use new argument --cfg_oos to config queue pair out of order scan.

---
 app/test-regex/main.c | 24 +++++++++++++++++-------
 1 file changed, 17 insertions(+), 7 deletions(-)
app/test-regex/main.c +17 -7
index 0d35f4583..9b19031ea 100644
@@ -33,6 +33,7 @@ enum app_args {
 	ARG_NUM_OF_JOBS,
 	ARG_PERF_MODE,
 	ARG_NUM_OF_ITERATIONS,
+	ARG_CFG_OOS,
 };
 
 static void
@@ -43,13 +44,15 @@ usage(const char *prog_name)
 		" --data NAME: data file to use\n"
 		" --nb_jobs: number of jobs to use\n"
 		" --perf N: only outputs the performance data\n"
-		" --nb_iter N: number of iteration to run\n",
+		" --nb_iter N: number of iteration to run\n"
+		" --cfg_oos: configure regexdev queue flag out of order scan\n",
 		prog_name);
 }
 
 static void
 args_parse(int argc, char **argv, char *rules_file, char *data_file,
-	   uint32_t *nb_jobs, bool *perf_mode, uint32_t *nb_iterations)
+	   uint32_t *nb_jobs, bool *perf_mode, uint32_t *nb_iterations,
+	   uint32_t *qp_conf_flags)
 {
 	char **argvopt;
 	int opt;
@@ -66,7 +69,9 @@ args_parse(int argc, char **argv, char *rules_file, char *data_file,
 		/* Perf test only */
 		{ "perf", 0, 0, ARG_PERF_MODE},
 		/* Number of iterations to run with perf test */
-		{ "nb_iter", 1, 0, ARG_NUM_OF_ITERATIONS}
+		{ "nb_iter", 1, 0, ARG_NUM_OF_ITERATIONS},
+		/* configure out of order scan */
+		{ "cfg_oos", 0, 0, ARG_CFG_OOS}
 	};
 
 	argvopt = argv;
@@ -98,6 +103,9 @@ args_parse(int argc, char **argv, char *rules_file, char *data_file,
 		case ARG_NUM_OF_ITERATIONS:
 			*nb_iterations = atoi(optarg);
 			break;
+		case ARG_CFG_OOS:
+			*qp_conf_flags = RTE_REGEX_QUEUE_PAIR_CFG_OOS_F;
+			break;
 		case ARG_HELP:
 			usage("RegEx test app");
 			break;
@@ -158,7 +166,8 @@ read_file(char *file, char **buf)
 
 static int
 init_port(struct rte_mempool **mbuf_mp, uint32_t nb_jobs,
-	  uint16_t *nb_max_payload, char *rules_file, uint8_t *nb_max_matches)
+	  uint16_t *nb_max_payload, char *rules_file, uint8_t *nb_max_matches,
+	  uint32_t qp_conf_flags)
 {
 	uint16_t id;
 	uint16_t num_devs;
@@ -171,7 +180,7 @@ init_port(struct rte_mempool **mbuf_mp, uint32_t nb_jobs,
 	};
 	struct rte_regexdev_qp_conf qp_conf = {
 		.nb_desc = 1024,
-		.qp_conf_flags = RTE_REGEX_QUEUE_PAIR_CFG_OOS_F,
+		.qp_conf_flags = qp_conf_flags,
 	};
 	int res = 0;
 
@@ -407,6 +416,7 @@ main(int argc, char **argv)
 	bool perf_mode = 0;
 	uint32_t nb_iterations = 0;
 	uint8_t nb_max_matches = 0;
+	uint32_t qp_conf_flags = 0;
 	int ret;
 
 	ret = rte_eal_init(argc, argv);
@@ -416,10 +426,10 @@ main(int argc, char **argv)
 	argv += ret;
 	if (argc > 1)
 		args_parse(argc, argv, rules_file, data_file, &nb_jobs,
-			   &perf_mode, &nb_iterations);
+			   &perf_mode, &nb_iterations, &qp_conf_flags);
 
 	ret = init_port(&mbuf_mp, nb_jobs, &nb_max_payload, rules_file,
-			&nb_max_matches);
+			&nb_max_matches, qp_conf_flags);
 	if (ret < 0)
 		rte_exit(EXIT_FAILURE, "init port failed\n");
 	ret = run_regex(mbuf_mp, nb_jobs, nb_max_payload, perf_mode,
Signature · 1 line
2.28.0
#2 lore raw

Hi Guy,

Quoted 116 lines

-----Original Message-----
From: [email protected] <[email protected]>
Sent: Monday, October 19, 2020 12:27 PM
Subject: [PATCH v1] app/regex: change default qp configuration flags

From: Guy Kaneti <[email protected]>

By default qp configuration flags was set with RTE_REGEX_QUEUE_PAIR_CFG_OOS_F.
Changed flags default to 0. In order to set OOS flag use new argument --cfg_oos to config queue pair out of order scan.

---
 app/test-regex/main.c | 24 +++++++++++++++++-------
 1 file changed, 17 insertions(+), 7 deletions(-)
app/test-regex/main.c +5 -2
index 0d35f4583..9b19031ea 100644
@@ -33,6 +33,7 @@ enum app_args {
 	ARG_NUM_OF_JOBS,
 	ARG_PERF_MODE,
 	ARG_NUM_OF_ITERATIONS,
+	ARG_CFG_OOS,
 };
 
 static void
@@ -43,13 +44,15 @@ usage(const char *prog_name)
 		" --data NAME: data file to use\n"
 		" --nb_jobs: number of jobs to use\n"
 		" --perf N: only outputs the performance data\n"
-		" --nb_iter N: number of iteration to run\n",
+		" --nb_iter N: number of iteration to run\n"
+		" --cfg_oos: configure regexdev queue flag out of order
 scan\n",
 		prog_name);
 }
 
 static void
 args_parse(int argc, char **argv, char *rules_file, char *data_file,
-	   uint32_t *nb_jobs, bool *perf_mode, uint32_t *nb_iterations)
+	   uint32_t *nb_jobs, bool *perf_mode, uint32_t *nb_iterations,
+	   uint32_t *qp_conf_flags)
 {
 	char **argvopt;
app/test-regex/main.c +3 -1
 	int opt;
@@ -66,7 +69,9 @@ args_parse(int argc, char **argv, char *rules_file, char
 *data_file,
 		/* Perf test only */
 		{ "perf", 0, 0, ARG_PERF_MODE},
 		/* Number of iterations to run with perf test */
-		{ "nb_iter", 1, 0, ARG_NUM_OF_ITERATIONS}
+		{ "nb_iter", 1, 0, ARG_NUM_OF_ITERATIONS},
+		/* configure out of order scan */
+		{ "cfg_oos", 0, 0, ARG_CFG_OOS}
 	};
 
app/test-regex/main.c +3 -0
 	argvopt = argv;
@@ -98,6 +103,9 @@ args_parse(int argc, char **argv, char *rules_file, char
 *data_file,
 		case ARG_NUM_OF_ITERATIONS:
 			*nb_iterations = atoi(optarg);
 			break;
+		case ARG_CFG_OOS:
+			*qp_conf_flags =
 RTE_REGEX_QUEUE_PAIR_CFG_OOS_F;
+			break;
 		case ARG_HELP:
app/test-regex/main.c +2 -1
 			usage("RegEx test app");
 			break;
@@ -158,7 +166,8 @@ read_file(char *file, char **buf)
 
 static int
 init_port(struct rte_mempool **mbuf_mp, uint32_t nb_jobs,
-	  uint16_t *nb_max_payload, char *rules_file, uint8_t
 *nb_max_matches)
+	  uint16_t *nb_max_payload, char *rules_file, uint8_t
 *nb_max_matches,
+	  uint32_t qp_conf_flags)
 {
app/test-regex/main.c +4 -4
 	uint16_t id;
 	uint16_t num_devs;
@@ -171,7 +180,7 @@ init_port(struct rte_mempool **mbuf_mp, uint32_t
 nb_jobs,
 	};
 	struct rte_regexdev_qp_conf qp_conf = {
 		.nb_desc = 1024,
-		.qp_conf_flags = RTE_REGEX_QUEUE_PAIR_CFG_OOS_F,
+		.qp_conf_flags = qp_conf_flags,
 	};
 	int res = 0;
@@ -407,6 +416,7 @@ main(int argc, char **argv)
 	bool perf_mode = 0;
 	uint32_t nb_iterations = 0;
 	uint8_t nb_max_matches = 0;
+	uint32_t qp_conf_flags = 0;
 	int ret;
 
 	ret = rte_eal_init(argc, argv);
@@ -416,10 +426,10 @@ main(int argc, char **argv)
 	argv += ret;
 	if (argc > 1)
 		args_parse(argc, argv, rules_file, data_file, &nb_jobs,
-			   &perf_mode, &nb_iterations);
+			   &perf_mode, &nb_iterations, &qp_conf_flags);
 
 	ret = init_port(&mbuf_mp, nb_jobs, &nb_max_payload, rules_file,
-			&nb_max_matches);
+			&nb_max_matches, qp_conf_flags);
 	if (ret < 0)
 		rte_exit(EXIT_FAILURE, "init port failed\n");
 	ret = run_regex(mbuf_mp, nb_jobs, nb_max_payload, perf_mode,
--
Quoted 1 line

2.28.0

General comment I think we should add
capability to the rte_regexdev to check if the PMD support OOF. and have the default based on this capability.

Best,
Ori

author
#3 lore raw

Hi Ori,

Quoted 124 lines

-----Original Message-----
From: Ori Kam <[email protected]>
Sent: Monday, October 19, 2020 6:03 PM
To: Guy Kaneti <[email protected]>; [email protected]
Cc: NBU-Contact-Thomas Monjalon <[email protected]>; Smadar Fuks <[email protected]>; [email protected]
Subject: [EXT] RE: [PATCH v1] app/regex: change default qp configuration flags

External Email

----------------------------------------------------------------------
Hi Guy,

app/test-regex/main.c init_port(struct rte_mempool **mbuf_mp,

Quoted 85 lines

-----Original Message-----
From: [email protected] <[email protected]>
Sent: Monday, October 19, 2020 12:27 PM
Subject: [PATCH v1] app/regex: change default qp configuration flags

From: Guy Kaneti <[email protected]>

By default qp configuration flags was set with RTE_REGEX_QUEUE_PAIR_CFG_OOS_F.
Changed flags default to 0. In order to set OOS flag use new argument --cfg_oos to config queue pair out of order scan.

---
 app/test-regex/main.c | 24 +++++++++++++++++-------
 1 file changed, 17 insertions(+), 7 deletions(-)
app/test-regex/main.c index renamed from app/test-regex/main.c +0 -0

0d35f4583..9b19031ea 100644

app/test-regex/main.c +5 -2
@@ -33,6 +33,7 @@ enum app_args {
 	ARG_NUM_OF_JOBS,
 	ARG_PERF_MODE,
 	ARG_NUM_OF_ITERATIONS,
+	ARG_CFG_OOS,
 };
 
 static void
@@ -43,13 +44,15 @@ usage(const char *prog_name)
 		" --data NAME: data file to use\n"
 		" --nb_jobs: number of jobs to use\n"
 		" --perf N: only outputs the performance data\n"
-		" --nb_iter N: number of iteration to run\n",
+		" --nb_iter N: number of iteration to run\n"
+		" --cfg_oos: configure regexdev queue flag out of order
 scan\n",
 		prog_name);
 }
 
 static void
 args_parse(int argc, char **argv, char *rules_file, char *data_file,
-	   uint32_t *nb_jobs, bool *perf_mode, uint32_t *nb_iterations)
+	   uint32_t *nb_jobs, bool *perf_mode, uint32_t *nb_iterations,
+	   uint32_t *qp_conf_flags)
 {
 	char **argvopt;
app/test-regex/main.c +3 -1
 	int opt;
@@ -66,7 +69,9 @@ args_parse(int argc, char **argv, char *rules_file,
 char *data_file,
 		/* Perf test only */
 		{ "perf", 0, 0, ARG_PERF_MODE},
 		/* Number of iterations to run with perf test */
-		{ "nb_iter", 1, 0, ARG_NUM_OF_ITERATIONS}
+		{ "nb_iter", 1, 0, ARG_NUM_OF_ITERATIONS},
+		/* configure out of order scan */
+		{ "cfg_oos", 0, 0, ARG_CFG_OOS}
 	};
 
app/test-regex/main.c +3 -0
 	argvopt = argv;
@@ -98,6 +103,9 @@ args_parse(int argc, char **argv, char *rules_file,
 char *data_file,
 		case ARG_NUM_OF_ITERATIONS:
 			*nb_iterations = atoi(optarg);
 			break;
+		case ARG_CFG_OOS:
+			*qp_conf_flags =
 RTE_REGEX_QUEUE_PAIR_CFG_OOS_F;
+			break;
 		case ARG_HELP:
app/test-regex/main.c +2 -1
 			usage("RegEx test app");
 			break;
@@ -158,7 +166,8 @@ read_file(char *file, char **buf)
 
 static int
 init_port(struct rte_mempool **mbuf_mp, uint32_t nb_jobs,
-	  uint16_t *nb_max_payload, char *rules_file, uint8_t
 *nb_max_matches)
+	  uint16_t *nb_max_payload, char *rules_file, uint8_t
 *nb_max_matches,
+	  uint32_t qp_conf_flags)
 {
app/test-regex/main.c +0 -0
 	uint16_t id;
 	uint16_t num_devs;
@@ -171,7 +180,7 @@ init_port(struct rte_mempool **mbuf_mp,

uint32_t

Quoted 24 lines
app/test-regex/main.c +3 -2
 nb_jobs,
 	};
 	struct rte_regexdev_qp_conf qp_conf = {
 		.nb_desc = 1024,
-		.qp_conf_flags = RTE_REGEX_QUEUE_PAIR_CFG_OOS_F,
+		.qp_conf_flags = qp_conf_flags,
 	};
 	int res = 0;
@@ -407,6 +416,7 @@ main(int argc, char **argv)
 	bool perf_mode = 0;
 	uint32_t nb_iterations = 0;
 	uint8_t nb_max_matches = 0;
+	uint32_t qp_conf_flags = 0;
 	int ret;
 
 	ret = rte_eal_init(argc, argv);
@@ -416,10 +426,10 @@ main(int argc, char **argv)
 	argv += ret;
 	if (argc > 1)
 		args_parse(argc, argv, rules_file, data_file, &nb_jobs,
-			   &perf_mode, &nb_iterations);
+			   &perf_mode, &nb_iterations, &qp_conf_flags);
 
Quoted 12 lines
Quoted 8 lines
app/test-regex/main.c +1 -2
 	ret = init_port(&mbuf_mp, nb_jobs, &nb_max_payload, rules_file,
-			&nb_max_matches);
+			&nb_max_matches, qp_conf_flags);
 	if (ret < 0)
 		rte_exit(EXIT_FAILURE, "init port failed\n");
 	ret = run_regex(mbuf_mp, nb_jobs, nb_max_payload, perf_mode,
--

2.28.0

General comment I think we should add
capability to the rte_regexdev to check if the PMD support OOF. and have the default based on this capability.

I agree.
Should it be returned by rte_regexdev_info_get()
And be defined as RTE_REGEXDEV_CAPA_ ?

Quoted 3 lines

Best,
Ori

#4 lore raw
Quoted 144 lines

-----Original Message-----
From: Guy Kaneti <[email protected]>
Sent: Monday, October 19, 2020 8:12 PM
Subject: RE: [PATCH v1] app/regex: change default qp configuration flags

Hi Ori,

Quoted 121 lines

-----Original Message-----
From: Ori Kam <[email protected]>
Sent: Monday, October 19, 2020 6:03 PM
Subject: [EXT] RE: [PATCH v1] app/regex: change default qp configuration flags

External Email

----------------------------------------------------------------------
Hi Guy,

app/test-regex/main.c init_port(struct rte_mempool **mbuf_mp,

Quoted 85 lines

-----Original Message-----
From: [email protected] <[email protected]>
Sent: Monday, October 19, 2020 12:27 PM
Subject: [PATCH v1] app/regex: change default qp configuration flags

From: Guy Kaneti <[email protected]>

By default qp configuration flags was set with RTE_REGEX_QUEUE_PAIR_CFG_OOS_F.
Changed flags default to 0. In order to set OOS flag use new argument --cfg_oos to config queue pair out of order scan.

---
 app/test-regex/main.c | 24 +++++++++++++++++-------
 1 file changed, 17 insertions(+), 7 deletions(-)
app/test-regex/main.c index renamed from app/test-regex/main.c +0 -0

0d35f4583..9b19031ea 100644

app/test-regex/main.c +5 -2
@@ -33,6 +33,7 @@ enum app_args {
 	ARG_NUM_OF_JOBS,
 	ARG_PERF_MODE,
 	ARG_NUM_OF_ITERATIONS,
+	ARG_CFG_OOS,
 };
 
 static void
@@ -43,13 +44,15 @@ usage(const char *prog_name)
 		" --data NAME: data file to use\n"
 		" --nb_jobs: number of jobs to use\n"
 		" --perf N: only outputs the performance data\n"
-		" --nb_iter N: number of iteration to run\n",
+		" --nb_iter N: number of iteration to run\n"
+		" --cfg_oos: configure regexdev queue flag out of order
 scan\n",
 		prog_name);
 }
 
 static void
 args_parse(int argc, char **argv, char *rules_file, char *data_file,
-	   uint32_t *nb_jobs, bool *perf_mode, uint32_t *nb_iterations)
+	   uint32_t *nb_jobs, bool *perf_mode, uint32_t *nb_iterations,
+	   uint32_t *qp_conf_flags)
 {
 	char **argvopt;
app/test-regex/main.c +3 -1
 	int opt;
@@ -66,7 +69,9 @@ args_parse(int argc, char **argv, char *rules_file,
 char *data_file,
 		/* Perf test only */
 		{ "perf", 0, 0, ARG_PERF_MODE},
 		/* Number of iterations to run with perf test */
-		{ "nb_iter", 1, 0, ARG_NUM_OF_ITERATIONS}
+		{ "nb_iter", 1, 0, ARG_NUM_OF_ITERATIONS},
+		/* configure out of order scan */
+		{ "cfg_oos", 0, 0, ARG_CFG_OOS}
 	};
 
app/test-regex/main.c +3 -0
 	argvopt = argv;
@@ -98,6 +103,9 @@ args_parse(int argc, char **argv, char *rules_file,
 char *data_file,
 		case ARG_NUM_OF_ITERATIONS:
 			*nb_iterations = atoi(optarg);
 			break;
+		case ARG_CFG_OOS:
+			*qp_conf_flags =
 RTE_REGEX_QUEUE_PAIR_CFG_OOS_F;
+			break;
 		case ARG_HELP:
app/test-regex/main.c +2 -1
 			usage("RegEx test app");
 			break;
@@ -158,7 +166,8 @@ read_file(char *file, char **buf)
 
 static int
 init_port(struct rte_mempool **mbuf_mp, uint32_t nb_jobs,
-	  uint16_t *nb_max_payload, char *rules_file, uint8_t
 *nb_max_matches)
+	  uint16_t *nb_max_payload, char *rules_file, uint8_t
 *nb_max_matches,
+	  uint32_t qp_conf_flags)
 {
app/test-regex/main.c +0 -0
 	uint16_t id;
 	uint16_t num_devs;
@@ -171,7 +180,7 @@ init_port(struct rte_mempool **mbuf_mp,

uint32_t

Quoted 24 lines
app/test-regex/main.c +3 -2
 nb_jobs,
 	};
 	struct rte_regexdev_qp_conf qp_conf = {
 		.nb_desc = 1024,
-		.qp_conf_flags = RTE_REGEX_QUEUE_PAIR_CFG_OOS_F,
+		.qp_conf_flags = qp_conf_flags,
 	};
 	int res = 0;
@@ -407,6 +416,7 @@ main(int argc, char **argv)
 	bool perf_mode = 0;
 	uint32_t nb_iterations = 0;
 	uint8_t nb_max_matches = 0;
+	uint32_t qp_conf_flags = 0;
 	int ret;
 
 	ret = rte_eal_init(argc, argv);
@@ -416,10 +426,10 @@ main(int argc, char **argv)
 	argv += ret;
 	if (argc > 1)
 		args_parse(argc, argv, rules_file, data_file, &nb_jobs,
-			   &perf_mode, &nb_iterations);
+			   &perf_mode, &nb_iterations, &qp_conf_flags);
 
Quoted 12 lines
Quoted 8 lines
app/test-regex/main.c +1 -2
 	ret = init_port(&mbuf_mp, nb_jobs, &nb_max_payload, rules_file,
-			&nb_max_matches);
+			&nb_max_matches, qp_conf_flags);
 	if (ret < 0)
 		rte_exit(EXIT_FAILURE, "init port failed\n");
 	ret = run_regex(mbuf_mp, nb_jobs, nb_max_payload, perf_mode,
--

2.28.0

General comment I think we should add
capability to the rte_regexdev to check if the PMD support OOF. and have the default based on this capability.

Quoted 4 lines

I agree.
Should it be returned by rte_regexdev_info_get() And be defined as RTE_REGEXDEV_CAPA_ ?

Yes this is my thinking.

Quoted 3 lines
Quoted 3 lines

Best,
Ori

author
#5 lore raw
In reply to [email protected]

Please Ignore this patch, it was sent by mistake
v1 is the correct one

Quoted 117 lines

-----Original Message-----
From: [email protected] <[email protected]>
Sent: Monday, October 19, 2020 12:26 PM
To: [email protected]
Cc: [email protected]; Guy Kaneti <[email protected]>; Smadar Fuks <[email protected]>; [email protected]
Subject: [PATCH] app/regex: change default qp configuration flags

From: Guy Kaneti <[email protected]>

added --cfg_oos argument to config queue pair out of order scan

---
 app/test-regex/main.c | 24 +++++++++++++++++-------
 1 file changed, 17 insertions(+), 7 deletions(-)
app/test-regex/main.c index renamed from app/test-regex/main.c +0 -0

0d35f4583..9b19031ea 100644

app/test-regex/main.c +5 -2
@@ -33,6 +33,7 @@ enum app_args {
 	ARG_NUM_OF_JOBS,
 	ARG_PERF_MODE,
 	ARG_NUM_OF_ITERATIONS,
+	ARG_CFG_OOS,
 };
 
 static void
@@ -43,13 +44,15 @@ usage(const char *prog_name)
 		" --data NAME: data file to use\n"
 		" --nb_jobs: number of jobs to use\n"
 		" --perf N: only outputs the performance data\n"
-		" --nb_iter N: number of iteration to run\n",
+		" --nb_iter N: number of iteration to run\n"
+		" --cfg_oos: configure regexdev queue flag out of order
 scan\n",
 		prog_name);
 }
 
 static void
 args_parse(int argc, char **argv, char *rules_file, char *data_file,
-	   uint32_t *nb_jobs, bool *perf_mode, uint32_t *nb_iterations)
+	   uint32_t *nb_jobs, bool *perf_mode, uint32_t *nb_iterations,
+	   uint32_t *qp_conf_flags)
 {
 	char **argvopt;
app/test-regex/main.c +3 -1
 	int opt;
@@ -66,7 +69,9 @@ args_parse(int argc, char **argv, char *rules_file, char
 *data_file,
 		/* Perf test only */
 		{ "perf", 0, 0, ARG_PERF_MODE},
 		/* Number of iterations to run with perf test */
-		{ "nb_iter", 1, 0, ARG_NUM_OF_ITERATIONS}
+		{ "nb_iter", 1, 0, ARG_NUM_OF_ITERATIONS},
+		/* configure out of order scan */
+		{ "cfg_oos", 0, 0, ARG_CFG_OOS}
 	};
 
app/test-regex/main.c +3 -0
 	argvopt = argv;
@@ -98,6 +103,9 @@ args_parse(int argc, char **argv, char *rules_file, char
 *data_file,
 		case ARG_NUM_OF_ITERATIONS:
 			*nb_iterations = atoi(optarg);
 			break;
+		case ARG_CFG_OOS:
+			*qp_conf_flags =
 RTE_REGEX_QUEUE_PAIR_CFG_OOS_F;
+			break;
 		case ARG_HELP:
app/test-regex/main.c +2 -1
 			usage("RegEx test app");
 			break;
@@ -158,7 +166,8 @@ read_file(char *file, char **buf)
 
 static int
 init_port(struct rte_mempool **mbuf_mp, uint32_t nb_jobs,
-	  uint16_t *nb_max_payload, char *rules_file, uint8_t
 *nb_max_matches)
+	  uint16_t *nb_max_payload, char *rules_file, uint8_t
 *nb_max_matches,
+	  uint32_t qp_conf_flags)
 {
app/test-regex/main.c +4 -4
 	uint16_t id;
 	uint16_t num_devs;
@@ -171,7 +180,7 @@ init_port(struct rte_mempool **mbuf_mp, uint32_t
 nb_jobs,
 	};
 	struct rte_regexdev_qp_conf qp_conf = {
 		.nb_desc = 1024,
-		.qp_conf_flags = RTE_REGEX_QUEUE_PAIR_CFG_OOS_F,
+		.qp_conf_flags = qp_conf_flags,
 	};
 	int res = 0;
@@ -407,6 +416,7 @@ main(int argc, char **argv)
 	bool perf_mode = 0;
 	uint32_t nb_iterations = 0;
 	uint8_t nb_max_matches = 0;
+	uint32_t qp_conf_flags = 0;
 	int ret;
 
 	ret = rte_eal_init(argc, argv);
@@ -416,10 +426,10 @@ main(int argc, char **argv)
 	argv += ret;
 	if (argc > 1)
 		args_parse(argc, argv, rules_file, data_file, &nb_jobs,
-			   &perf_mode, &nb_iterations);
+			   &perf_mode, &nb_iterations, &qp_conf_flags);
 
 	ret = init_port(&mbuf_mp, nb_jobs, &nb_max_payload, rules_file,
-			&nb_max_matches);
+			&nb_max_matches, qp_conf_flags);
 	if (ret < 0)
 		rte_exit(EXIT_FAILURE, "init port failed\n");
 	ret = run_regex(mbuf_mp, nb_jobs, nb_max_payload, perf_mode,
--

2.28.0