mptcp: MPTCP_KUNIT_TESTS should depend on MPTCP instead of selecting it
Subsystems (3)
PATCH 1/1 mptcp: MPTCP_KUNIT_TESTS should depend on MPTCP instead of selecting it
MPTCP_KUNIT_TESTS selects MPTCP, thus enabling an optional feature the user may not want to enable. Fix this by making the test depend on MPTCP instead.
--- net/mptcp/Kconfig | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
net/mptcp/Kconfig +1 -3
@@ -22,11 +22,8 @@ config MPTCP_IPV6 select IPV6 default y -endif - config MPTCP_KUNIT_TESTS tristate "This builds the MPTCP KUnit tests" if !KUNIT_ALL_TESTS - select MPTCP depends on KUNIT default KUNIT_ALL_TESTS help
@@ -39,3 +36,4 @@ config MPTCP_KUNIT_TESTS If unsure, say N. +endif
Signature · 1 line
2.17.1
Hi Geert,
Thank you for the patch!
Quoted 3 lines · Geert Uytterhoeven
MPTCP_KUNIT_TESTSselects MPTCP, thus enabling an optional feature the user may not want to enable. Fix this by making the test depend on MPTCP instead.
I think the initial intension was to select MPTCP to have an easy way to enable all KUnit tests. We imitated what was and is still done in fs/ext4/Kconfig.
But it probably makes sense to depend on MPTCP instead of selecting it. So that's fine for me. But then please also send a patch to ext4 maintainer to do the same there.
Cheers,
Matt
Signature · 2 lines
Tessares | Belgium | Hybrid Access Solutions www.tessares.net
Hi Matthieu,
Quoted 5 lines · Matthieu Baerts
Quoted 3 lines · Geert Uytterhoeven
MPTCP_KUNIT_TESTSselects MPTCP, thus enabling an optional feature the user may not want to enable. Fix this by making the test depend on MPTCP instead.
Quoted 7 lines
I think the initial intension was to select MPTCP to have an easy way to enable all KUnit tests. We imitated what was and is still done in
fs/ext4/Kconfig.But it probably makes sense to depend on MPTCP instead of selecting it. So that's fine for me. But then please also send a patch to ext4 maintainer to do the same there.
Thanks, good point. I didn't notice, as I did have ext4 enabled anyway. Will send a patch for ext4. Looks like ext4 and MPTCP where the only test modules selecting their dependencies.
Quoted 1 line
Reviewed-by Matthieu Baerts <matthieu.baerts(a)tessares.net>
Thanks!
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert(a)linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus TorvaldsQuoted 11 lines · Geert Uytterhoeven
Quoted 9 lines · Matthieu Baerts
Quoted 3 lines · Geert Uytterhoeven
MPTCP_KUNIT_TESTSselects MPTCP, thus enabling an optional feature the user may not want to enable. Fix this by making the test depend on MPTCP instead.I think the initial intension was to select MPTCP to have an easy way to enable all KUnit tests. We imitated what was and is still done in
fs/ext4/Kconfig.
Quoted 7 lines
Quoted 3 lines
But it probably makes sense to depend on MPTCP instead of selecting it. So that's fine for me. But then please also send a patch to ext4 maintainer to do the same there.
Thanks, good point. I didn't notice, as I did have ext4 enabled anyway. Will send a patch for ext4. Looks like ext4 and MPTCP where the only test modules selecting their dependencies.
FTR, "[PATCH] ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it"
https://lore.kernel.org/lkml/20201020073740.29081-1-geert(a)linux-m68k.org/
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert(a)linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus TorvaldsHi Geert,
Quoted 17 lines · Geert Uytterhoeven
Quoted 15 lines · Geert Uytterhoeven
Quoted 12 lines · Matthieu Baerts
Quoted 3 lines · Geert Uytterhoeven
MPTCP_KUNIT_TESTSselects MPTCP, thus enabling an optional feature the user may not want to enable. Fix this by making the test depend on MPTCP instead.I think the initial intension was to select MPTCP to have an easy way to enable all KUnit tests. We imitated what was and is still done in
fs/ext4/Kconfig.But it probably makes sense to depend on MPTCP instead of selecting it. So that's fine for me. But then please also send a patch to ext4 maintainer to do the same there.
Quoted 7 lines
Quoted 3 lines
Thanks, good point. I didn't notice, as I did have ext4 enabled anyway. Will send a patch for ext4. Looks like ext4 and MPTCP where the only test modules selecting their dependencies.
FTR, "[PATCH] ext:
EXT4_KUNIT_TESTSshould depend onEXT4_FSinstead of selecting it"
https://lore.kernel.org/lkml/20201020073740.29081-1-geert(a)linux-m68k.org/
Thank you for having sent this other patch and shared the link here!
Groetjes,
Matt
Signature · 2 lines
Tessares | Belgium | Hybrid Access Solutions www.tessares.net
Quoted 6 lines · On Mon, 19 Oct 2020 17:47:20 +0200 Matthieu Baerts wrote:
Quoted 3 lines · Geert Uytterhoeven
MPTCP_KUNIT_TESTSselects MPTCP, thus enabling an optional feature the user may not want to enable. Fix this by making the test depend on MPTCP instead.Reviewed-by Matthieu Baerts <matthieu.baerts(a)tessares.net>
Applied, thanks!