platform/x86: remove unneeded break
PATCH 1/1 platform/x86: remove unneeded break
From: Tom Rix <[email protected]>
A break is not needed if it is preceded by a return
Signed-off-by Tom Rix <[email protected]>
--- drivers/platform/x86/acer-wmi.c | 1 - drivers/platform/x86/sony-laptop.c | 3 --- drivers/platform/x86/wmi.c | 3 --- 3 files changed, 7 deletions(-)
drivers/platform/x86/acer-wmi.c +0 -1
@@ -792,7 +792,6 @@ static acpi_status AMW0_set_u32(u32 value, u32 cap)switch (quirks->brightness) {default :return ec_write (0x83 , value); -break ; }default :return AE_ERROR ;
drivers/platform/x86/sony-laptop.c +0 -3
@@ -2467,13 +2467,11 @@ static int __sony_nc_gfx_switch_status_get(void)* 0: integrated GFX (stamina) */ return result &0x1 ?SPEED :STAMINA ; -break ;case 0x015B :/* 0: discrete GFX (speed) * 1: integrated GFX (stamina) */ return result &0x1 ?STAMINA :SPEED ; -break ;case 0x0128 :/* it's a more elaborated bitmask, for now: * 2: integrated GFX (stamina)
@@ -2482,7 +2480,6 @@ static int __sony_nc_gfx_switch_status_get(void)dprintk ("GFX Status: 0x%x\n" , result);return result &0x80 ?AUTO : result &0x02 ?STAMINA :SPEED ; -break ; }return -EINVAL ; }
drivers/platform/x86/wmi.c +0 -3
@@ -1260,13 +1260,10 @@ acpi_wmi_ec_space_handler(u32 function, acpi_physical_address address,switch (result) {case -EINVAL :return AE_BAD_PARAMETER ; -break ;case -ENODEV :return AE_NOT_FOUND ; -break ;case -ETIME :return AE_TIME ; -break ;default :return AE_OK ; }
Signature · 1 line
2.18.1
Hi,
Quoted 5 lines · On 10/19/20 3:32 PM, [email protected] wrote:
From: Tom Rix <[email protected]>
A break is not needed if it is preceded by a return
Signed-off-by Tom Rix <[email protected]>
Thank you for your patch, I've applied this patch to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up there once I've pushed my local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window.
Regards,
Hans
Quoted 63 lines
--- drivers/platform/x86/acer-wmi.c | 1 - drivers/platform/x86/sony-laptop.c | 3 --- drivers/platform/x86/wmi.c | 3 --- 3 files changed, 7 deletions(-)drivers/platform/x86/acer-wmi.c +0
-1@@ -792,7 +792,6 @@ static acpi_status AMW0_set_u32(u32 value, u32 cap)switch (quirks->brightness) {default :return ec_write (0x83 , value); -break ; }default :return AE_ERROR ;drivers/platform/x86/sony-laptop.c +0
-3@@ -2467,13 +2467,11 @@ static int __sony_nc_gfx_switch_status_get(void)* 0: integrated GFX (stamina) */ return result &0x1 ?SPEED :STAMINA ; -break ;case 0x015B :/* 0: discrete GFX (speed) * 1: integrated GFX (stamina) */ return result &0x1 ?STAMINA :SPEED ; -break ;case 0x0128 :/* it's a more elaborated bitmask, for now: * 2: integrated GFX (stamina) @@ -2482,7 +2480,6 @@ static int __sony_nc_gfx_switch_status_get(void)dprintk ("GFX Status: 0x%x\n" , result);return result &0x80 ?AUTO : result &0x02 ?STAMINA :SPEED ; -break ; }return -EINVAL ; }drivers/platform/x86/wmi.c +0
-3@@ -1260,13 +1260,10 @@ acpi_wmi_ec_space_handler(u32 function, acpi_physical_address address,switch (result) {case -EINVAL :return AE_BAD_PARAMETER ; -break ;case -ENODEV :return AE_NOT_FOUND ; -break ;case -ETIME :return AE_TIME ; -break ;default :return AE_OK ; }