drm/amdkfd: Use same SQ prefetch setting as amdgpu
Subsystems (3)
PATCH 1/1 drm/amdkfd: Use same SQ prefetch setting as amdgpu
0 causes instruction fetch stall at cache line boundary under some conditions on Navi10. A non-zero prefetch is the preferred default in any case.
Fixes soft hang in Luxmark.
Signed-off-by Jay Cornwall <[email protected]>
--- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_v10.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_v10.c +3 -2
@@ -58,8 +58,9 @@ static int update_qpd_v10(struct device_queue_manager *dqm,/* check if sh_mem_config register already configured */ if (qpd->sh_mem_config ==0 ) { qpd->sh_mem_config = -SH_MEM_ALIGNMENT_MODE_UNALIGNED << -SH_MEM_CONFIG__ALIGNMENT_MODE__SHIFT ; + (SH_MEM_ALIGNMENT_MODE_UNALIGNED << +SH_MEM_CONFIG__ALIGNMENT_MODE__SHIFT ) | + (3 <<SH_MEM_CONFIG__INITIAL_INST_PREFETCH__SHIFT );#if 0 /* TODO: * This shouldn't be an issue with Navi10. Verify.
Signature · 6 lines
2.17.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Am 2020-10-19 um 10:02 a.m. schrieb Jay Cornwall:
Quoted 7 lines
0 causes instruction fetch stall at cache line boundary under some conditions on Navi10. A non-zero prefetch is the preferred default in any case.
Fixes soft hang in Luxmark.
Signed-off-by Jay Cornwall <[email protected]>
Reviewed-by Felix Kuehling <[email protected]>
Quoted 10 lines
--- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_v10.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_v10.c +0
-0@@ -58,8 +58,9 @@ static int update_qpd_v10(struct device_queue_manager *dqm,/* check if sh_mem_config register already configured */
drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_v10.c static int update_qpd_v10(struct device_queue_manager *dqm, · line 66
Quoted 10 lines
drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_v10.c +3
-2if (qpd->sh_mem_config ==0 ) { qpd->sh_mem_config = -SH_MEM_ALIGNMENT_MODE_UNALIGNED << -SH_MEM_CONFIG__ALIGNMENT_MODE__SHIFT ; + (SH_MEM_ALIGNMENT_MODE_UNALIGNED << +SH_MEM_CONFIG__ALIGNMENT_MODE__SHIFT ) | + (3 <<SH_MEM_CONFIG__INITIAL_INST_PREFETCH__SHIFT );#if 0 /* TODO: * This shouldn't be an issue with Navi10. Verify.
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx