dt-bindings: media: imx258: add bindings for IMX258 sensor

The IMX258 sensor driver checked in device properties for a clock-frequency property which actually does not mean that the clock is really running such frequency or is it even enabled.

Get the provided clock and check it frequency. If none is provided, fall back to old property.

Enable the clock when accessing the IMX258 registers and when streaming starts with runtime PM.

Signed-off-by Krzysztof Kozlowski <[email protected]>

---

Changes since v4:
1. Add missing imx258_power_off.

Changes since v3:
1. None

Changes since v2:
1. Do not try to set drvdata, wrap lines.
2. Use dev_dbg.

Changes since v1:
1. Use runtime PM for clock toggling

---
 drivers/media/i2c/imx258.c | 73 +++++++++++++++++++++++++++++++++-----
 1 file changed, 64 insertions(+), 9 deletions(-)

drivers/media/i2c/imx258.c +36 -3

index ae183b0dbba9..038115471f17 100644
@@ -2,6 +2,7 @@
 // Copyright (C) 2018 Intel Corporation
 
 #include <linux/acpi.h>
+#include <linux/clk.h>
 #include <linux/delay.h>
 #include <linux/i2c.h>
 #include <linux/module.h>

@@ -68,6 +69,9 @@
 #define REG_CONFIG_MIRROR_FLIP		0x03
 #define REG_CONFIG_FLIP_TEST_PATTERN	0x02
 
+/* Input clock frequency in Hz */
+#define IMX258_INPUT_CLOCK_FREQ		19200000
+
 struct imx258_reg {
 	u16 address;
 	u8 val;

@@ -610,6 +614,8 @@ struct imx258 {
 
 	/* Streaming on/off */
 	bool streaming;
+
+	struct clk *clk;
 };
 
 static inline struct imx258 *to_imx258(struct v4l2_subdev *_sd)

@@ -972,6 +978,29 @@ static int imx258_stop_streaming(struct imx258 *imx258)
 	return 0;
 }
 
+static int imx258_power_on(struct device *dev)
+{
+	struct v4l2_subdev *sd = dev_get_drvdata(dev);
+	struct imx258 *imx258 = to_imx258(sd);
+	int ret;
+
+	ret = clk_prepare_enable(imx258->clk);
+	if (ret)
+		dev_err(dev, "failed to enable clock\n");
+
+	return ret;
+}
+
+static int imx258_power_off(struct device *dev)
+{
+	struct v4l2_subdev *sd = dev_get_drvdata(dev);
+	struct imx258 *imx258 = to_imx258(sd);
+
+	clk_disable_unprepare(imx258->clk);
+
+	return 0;
+}
+
 static int imx258_set_stream(struct v4l2_subdev *sd, int enable)
 {
 	struct imx258 *imx258 = to_imx258(sd);

@@ -1199,9 +1228,28 @@ static int imx258_probe(struct i2c_client *client)
 	int ret;
 	u32 val = 0;
 
-	device_property_read_u32(&client->dev, "clock-frequency", &val);
-	if (val != 19200000)
-		return -EINVAL;
+	imx258 = devm_kzalloc(&client->dev, sizeof(*imx258), GFP_KERNEL);
+	if (!imx258)
+		return -ENOMEM;
+
+	imx258->clk = devm_clk_get_optional(&client->dev, NULL);
+	if (!imx258->clk) {
+		dev_dbg(&client->dev,

drivers/media/i2c/imx258.c +18 -6

+			dev_err(&client->dev,
+				"input clock frequency not supported\n");
+			return -EINVAL;
+		}
+	}
 
 	/*
 	 * Check that the device is mounted upside down. The driver only

@@ -1211,24 +1259,25 @@ static int imx258_probe(struct i2c_client *client)
 	if (ret || val != 180)
 		return -EINVAL;
 
-	imx258 = devm_kzalloc(&client->dev, sizeof(*imx258), GFP_KERNEL);
-	if (!imx258)
-		return -ENOMEM;
-
 	/* Initialize subdev */
 	v4l2_i2c_subdev_init(&imx258->sd, client, &imx258_subdev_ops);
 
+	/* Will be powered off via pm_runtime_idle */
+	ret = imx258_power_on(&client->dev);
+	if (ret)
+		return ret;
+
 	/* Check module identity */
 	ret = imx258_identify_module(imx258);
 	if (ret)
-		return ret;
+		goto error_identify;
 
 	/* Set default mode to max resolution */
 	imx258->cur_mode = &supported_modes[0];
 
 	ret = imx258_init_controls(imx258);
 	if (ret)
-		return ret;
+		goto error_identify;
 
 	/* Initialize subdev */
 	imx258->sd.internal_ops = &imx258_internal_ops;

@@ -1258,6 +1307,9 @@ static int imx258_probe(struct i2c_client *client)
 error_handler_free:
 	imx258_free_controls(imx258);
 
+error_identify:
+	imx258_power_off(&client->dev);
+
 	return ret;
 }
 

@@ -1271,6 +1323,8 @@ static int imx258_remove(struct i2c_client *client)
 	imx258_free_controls(imx258);
 
 	pm_runtime_disable(&client->dev);
+	if (!pm_runtime_status_suspended(&client->dev))
+		imx258_power_off(&client->dev);
 	pm_runtime_set_suspended(&client->dev);
 
 	return 0;

@@ -1278,6 +1332,7 @@ static int imx258_remove(struct i2c_client *client)
 
 static const struct dev_pm_ops imx258_pm_ops = {
 	SET_SYSTEM_SLEEP_PM_OPS(imx258_suspend, imx258_resume)
+	SET_RUNTIME_PM_OPS(imx258_power_off, imx258_power_on, NULL)
 };
 
 #ifdef CONFIG_ACPI

Hi Krysztof,

Quoted 110 lines · Krzysztof Kozlowski

The IMX258 sensor driver checked in device properties for a clock-frequency property which actually does not mean that the clock is really running such frequency or is it even enabled.

Get the provided clock and check it frequency. If none is provided, fall back to old property.

Enable the clock when accessing the IMX258 registers and when streaming starts with runtime PM.

Signed-off-by Krzysztof Kozlowski <[email protected]>

---

Changes since v4:
1. Add missing imx258_power_off.

Changes since v3:
1. None

Changes since v2:
1. Do not try to set drvdata, wrap lines.
2. Use dev_dbg.

Changes since v1:
1. Use runtime PM for clock toggling

---
 drivers/media/i2c/imx258.c | 73 +++++++++++++++++++++++++++++++++-----
 1 file changed, 64 insertions(+), 9 deletions(-)

drivers/media/i2c/imx258.c +41 -3

index ae183b0dbba9..038115471f17 100644
@@ -2,6 +2,7 @@
 // Copyright (C) 2018 Intel Corporation
 
 #include <linux/acpi.h>
+#include <linux/clk.h>
 #include <linux/delay.h>
 #include <linux/i2c.h>
 #include <linux/module.h>

@@ -68,6 +69,9 @@
 #define REG_CONFIG_MIRROR_FLIP		0x03
 #define REG_CONFIG_FLIP_TEST_PATTERN	0x02
 
+/* Input clock frequency in Hz */
+#define IMX258_INPUT_CLOCK_FREQ		19200000
+
 struct imx258_reg {
 	u16 address;
 	u8 val;

@@ -610,6 +614,8 @@ struct imx258 {
 
 	/* Streaming on/off */
 	bool streaming;
+
+	struct clk *clk;
 };
 
 static inline struct imx258 *to_imx258(struct v4l2_subdev *_sd)

@@ -972,6 +978,29 @@ static int imx258_stop_streaming(struct imx258 *imx258)
 	return 0;
 }
 
+static int imx258_power_on(struct device *dev)
+{
+	struct v4l2_subdev *sd = dev_get_drvdata(dev);
+	struct imx258 *imx258 = to_imx258(sd);
+	int ret;
+
+	ret = clk_prepare_enable(imx258->clk);
+	if (ret)
+		dev_err(dev, "failed to enable clock\n");
+
+	return ret;
+}
+
+static int imx258_power_off(struct device *dev)
+{
+	struct v4l2_subdev *sd = dev_get_drvdata(dev);
+	struct imx258 *imx258 = to_imx258(sd);
+
+	clk_disable_unprepare(imx258->clk);
+
+	return 0;
+}
+
 static int imx258_set_stream(struct v4l2_subdev *sd, int enable)
 {
 	struct imx258 *imx258 = to_imx258(sd);

@@ -1199,9 +1228,28 @@ static int imx258_probe(struct i2c_client *client)
 	int ret;
 	u32 val = 0;
 
-	device_property_read_u32(&client->dev, "clock-frequency", &val);
-	if (val != 19200000)
-		return -EINVAL;
+	imx258 = devm_kzalloc(&client->dev, sizeof(*imx258), GFP_KERNEL);
+	if (!imx258)
+		return -ENOMEM;
+
+	imx258->clk = devm_clk_get_optional(&client->dev, NULL);
+	if (!imx258->clk) {
+		dev_dbg(&client->dev,
+			"no clock provided, using clock-frequency property\n");
+
+		device_property_read_u32(&client->dev, "clock-frequency", &val);
+		if (val != IMX258_INPUT_CLOCK_FREQ)
+			return -EINVAL;

drivers/media/i2c/imx258.c static int imx258_probe(struct i2c_client *client) · line 1247

Quoted 5 lines

drivers/media/i2c/imx258.c +5 -0

+	} else if (IS_ERR(imx258->clk)) {
+		return dev_err_probe(&client->dev, PTR_ERR(imx258->clk),
+				     "error getting clock\n");
+	} else {
+		if (clk_get_rate(imx258->clk) != IMX258_INPUT_CLOCK_FREQ) {

Please move the check outside the conditional block. May be a separate patch if you like.

Add bindings for the IMX258 camera sensor. The bindings, just like the driver, are quite limited, e.g. do not support regulator supplies.

Signed-off-by Krzysztof Kozlowski <[email protected]>

Reviewed-by Rob Herring <[email protected]>

---

Changes since v4:
1. Add clock-lanes,
2. Add Rob's review,
3. Add one more example and extend existing one,
4. Add common clock properties (assigned-*).

Hi Krzysztof,

Quoted 6 lines · Krzysztof Kozlowski

Add bindings for the IMX258 camera sensor. The bindings, just like the driver, are quite limited, e.g. do not support regulator supplies.

Signed-off-by Krzysztof Kozlowski <[email protected]>

Reviewed-by Rob Herring <[email protected]>

Quoted 7 lines

---

Changes since v4:
1. Add clock-lanes,
2. Add Rob's review,
3. Add one more example and extend existing one,
4. Add common clock properties (assigned-*).

Using the assigned-* clock properties may be workable for this driver at the moment. But using these properties does not guarantee the external clock frequency intended to be used on the hardware.

Using other
frequencies *is not* expected to work. That applies to this driver as well.

This, instead of the clock-frequency property, effectively removes the ability to set the correct frequency from the driver, at least with current set of the used APIs.

I suppose you could add a function to set the assigned clock frequency and keep it, just as clk_set_rate_exclusive does?

Cc the common clock framework list + maintainers.

Quoted 18 lines · Sakari Ailus

Hi Krzysztof,

Quoted 13 lines · Krzysztof Kozlowski

Add bindings for the IMX258 camera sensor. The bindings, just like the driver, are quite limited, e.g. do not support regulator supplies.

Signed-off-by Krzysztof Kozlowski <[email protected]>

Reviewed-by Rob Herring <[email protected]>

---

Changes since v4:
1. Add clock-lanes,
2. Add Rob's review,
3. Add one more example and extend existing one,
4. Add common clock properties (assigned-*).

Quoted 3 lines

Using the assigned-* clock properties may be workable for this driver at the moment. But using these properties does not guarantee the external clock frequency intended to be used on the hardware.

It guarantees it. The clock frequency will be as expected (except if someone misconfigures the DTS).

Quoted 3 lines

Using other
frequencies *is not* expected to work. That applies to this driver as well.

This is the binding which is HW description. According to HW datasheet other frequencies from described range are accepted and expected to work.

Quoted 4 lines

This, instead of the clock-frequency property, effectively removes the ability to set the correct frequency from the driver, at least with current set of the used APIs.

It seems you confuse DT bindings with some specific driver implementation. Bindings do not describe the driver behavior but the HW. The ability to set the correct frequency from the driver is not removed. It was never part of the bindings and never should. It is part of the driver.

Quoted 5 lines

I suppose you could add a function to set the assigned clock frequency and keep it, just as clk_set_rate_exclusive does?

Cc the common clock framework list + maintainers.

The bindings have Rob review which is the DT maintainer. His ack/review is needed for the bindings to be accepted. What more do you need? Shall I point to submitting-bindings document?

I am really tired of discussing this. You raise some concerns about driver behavior in the wrong context - in the patch for device tree bindings. You use the arguments about the driver while we talk about bindings. This is clearly not correct. I am all the time repeating myself - the bindings describe the hardware, not the driver.

Hi Krzysztof,

Quoted 19 lines · Krzysztof Kozlowski

Quoted 18 lines · Sakari Ailus

Hi Krzysztof,

Quoted 13 lines · Krzysztof Kozlowski

Add bindings for the IMX258 camera sensor. The bindings, just like the driver, are quite limited, e.g. do not support regulator supplies.

Signed-off-by Krzysztof Kozlowski <[email protected]>

Reviewed-by Rob Herring <[email protected]>

---

Changes since v4:
1. Add clock-lanes,
2. Add Rob's review,
3. Add one more example and extend existing one,
4. Add common clock properties (assigned-*).

Quoted 6 lines

Quoted 3 lines

Using the assigned-* clock properties may be workable for this driver at the moment. But using these properties does not guarantee the external clock frequency intended to be used on the hardware.

It guarantees it. The clock frequency will be as expected (except if someone misconfigures the DTS).

Is that guaranteed?

I'm not saying no to the approach, but if we change how camera sensor DT bindings are defined, I'd prefer an informed decision is made on the matter.

Quoted 7 lines

Quoted 3 lines

Using other
frequencies *is not* expected to work. That applies to this driver as well.

This is the binding which is HW description. According to HW datasheet other frequencies from described range are accepted and expected to work.

As per datasheet, yes, different external clock frequencies can be used. But the link frequency is still not independent of the external clock frequency.

The properties of the sensor's PLL tree determines what can be achieved given a certain external clock frequency. So picking a wrong external clock frequency quite possibly means that none of the designated link frequencies are available, rendering the sensor inoperable.

Quoted 13 lines

Quoted 5 lines

This, instead of the clock-frequency property, effectively removes the ability to set the correct frequency from the driver, at least with current set of the used APIs.

It seems you confuse DT bindings with some specific driver implementation. Bindings do not describe the driver behavior but the HW. The ability to set the correct frequency from the driver is not removed. It was never part of the bindings and never should. It is part of the driver.

Quoted 1 line

Quoted 2 lines

Quoted 2 lines

I suppose you could add a function to set the assigned clock frequency and keep it, just as clk_set_rate_exclusive does?

Quoted 7 lines

Quoted 2 lines

Cc the common clock framework list + maintainers.

The bindings have Rob review which is the DT maintainer. His ack/review is needed for the bindings to be accepted. What more do you need? Shall I point to submitting-bindings document?

Quoted 5 lines

I am really tired of discussing this. You raise some concerns about driver behavior in the wrong context - in the patch for device tree bindings. You use the arguments about the driver while we talk about bindings. This is clearly not correct. I am all the time repeating myself - the bindings describe the hardware, not the driver.

My concerns are not related to the current driver implementation nor the driver patches in this set.

Quoted 47 lines · Sakari Ailus

Hi Krzysztof,

Quoted 19 lines · Krzysztof Kozlowski

Quoted 18 lines · Sakari Ailus

Hi Krzysztof,

Quoted 13 lines · Krzysztof Kozlowski

Add bindings for the IMX258 camera sensor. The bindings, just like the driver, are quite limited, e.g. do not support regulator supplies.

Signed-off-by Krzysztof Kozlowski <[email protected]>

Reviewed-by Rob Herring <[email protected]>

---

Changes since v4:
1. Add clock-lanes,
2. Add Rob's review,
3. Add one more example and extend existing one,
4. Add common clock properties (assigned-*).

Quoted 6 lines

Quoted 3 lines

Using the assigned-* clock properties may be workable for this driver at the moment. But using these properties does not guarantee the external clock frequency intended to be used on the hardware.

It guarantees it. The clock frequency will be as expected (except if someone misconfigures the DTS).

Is that guaranteed?

I'm not saying no to the approach, but if we change how camera sensor DT bindings are defined, I'd prefer an informed decision is made on the matter.

Quoted 7 lines

Quoted 3 lines

Using other
frequencies *is not* expected to work. That applies to this driver as well.

This is the binding which is HW description. According to HW datasheet other frequencies from described range are accepted and expected to work.

As per datasheet, yes, different external clock frequencies can be used. But the link frequency is still not independent of the external clock frequency.

Quoted 4 lines

The properties of the sensor's PLL tree determines what can be achieved given a certain external clock frequency. So picking a wrong external clock frequency quite possibly means that none of the designated link frequencies are available, rendering the sensor inoperable.

The driver then controls the HW and knows exactly what is needed. If link frequency (which has its own DT property) requires some clock frequency, the driver will configure the clock to that value. The same

going other direction. Driver has the knowledge about both its input clock and link frequency, therefore it can make the best decision.

Quoted 11 lines

Quoted 11 lines

Quoted 3 lines

This, instead of the clock-frequency property, effectively removes the ability to set the correct frequency from the driver, at least with current set of the used APIs.

It seems you confuse DT bindings with some specific driver implementation. Bindings do not describe the driver behavior but the HW. The ability to set the correct frequency from the driver is not removed. It was never part of the bindings and never should. It is part of the driver.

Quoted 1 line

Quoted 2 lines

Quoted 2 lines

Quoted 2 lines

I suppose you could add a function to set the assigned clock frequency and keep it, just as clk_set_rate_exclusive does?

I did not reply to this comment, so let me know. Of course, one could add such functions. It's not a job for DT bindings, though.

Quoted 53 lines · Krzysztof Kozlowski

Quoted 51 lines · Sakari Ailus

Hi Krzysztof,

Quoted 19 lines · Krzysztof Kozlowski

Quoted 18 lines · Sakari Ailus

Hi Krzysztof,

Quoted 13 lines · Krzysztof Kozlowski

Add bindings for the IMX258 camera sensor. The bindings, just like the driver, are quite limited, e.g. do not support regulator supplies.

Signed-off-by Krzysztof Kozlowski <[email protected]>

Reviewed-by Rob Herring <[email protected]>

---

Changes since v4:
1. Add clock-lanes,
2. Add Rob's review,
3. Add one more example and extend existing one,
4. Add common clock properties (assigned-*).

Quoted 6 lines

Quoted 3 lines

Using the assigned-* clock properties may be workable for this driver at the moment. But using these properties does not guarantee the external clock frequency intended to be used on the hardware.

It guarantees it. The clock frequency will be as expected (except if someone misconfigures the DTS).

Is that guaranteed?

I'm not saying no to the approach, but if we change how camera sensor DT bindings are defined, I'd prefer an informed decision is made on the matter.

Quoted 7 lines

Quoted 3 lines

Using other
frequencies *is not* expected to work. That applies to this driver as well.

This is the binding which is HW description. According to HW datasheet other frequencies from described range are accepted and expected to work.

As per datasheet, yes, different external clock frequencies can be used. But the link frequency is still not independent of the external clock frequency.

The properties of the sensor's PLL tree determines what can be achieved given a certain external clock frequency. So picking a wrong external clock frequency quite possibly means that none of the designated link frequencies are available, rendering the sensor inoperable.

Quoted 3 lines

The driver then controls the HW and knows exactly what is needed. If link frequency (which has its own DT property) requires some clock frequency, the driver will configure the clock to that value. The same

Well it doesn't if it doesn't get that information from DT.

The frequency is usually a range, and looking at these bindings, it's from 6 MHz to 27 MHz. That'd be a lot of frequencies for a driver to try.

Quoted 3 lines

going other direction. Driver has the knowledge about both its input clock and link frequency, therefore it can make the best decision.

Again you're assuming a particular driver implementation.

Typically only a few frequencies are really available on platforms, so a in practice a driver would not be able to get any requested frequency. I wouldn't start hard-coding every possible frequency to camera sensor drivers

Quoted 12 lines

Quoted 12 lines

Quoted 12 lines

Quoted 4 lines

This, instead of the clock-frequency property, effectively removes the ability to set the correct frequency from the driver, at least with current set of the used APIs.

It seems you confuse DT bindings with some specific driver implementation. Bindings do not describe the driver behavior but the HW. The ability to set the correct frequency from the driver is not removed. It was never part of the bindings and never should. It is part of the driver.

Quoted 1 line

Quoted 5 lines

Quoted 2 lines

Quoted 2 lines

Quoted 2 lines

I suppose you could add a function to set the assigned clock frequency and keep it, just as clk_set_rate_exclusive does?

I did not reply to this comment, so let me know. Of course, one could add such functions. It's not a job for DT bindings, though.

I'm not suggesting to add it to DT binding patch. What I'm saying that with this approach is looks like it may well be needed.

Quoted 54 lines · Sakari Ailus

Quoted 53 lines · Krzysztof Kozlowski

Quoted 51 lines · Sakari Ailus

Hi Krzysztof,

Quoted 19 lines · Krzysztof Kozlowski

Quoted 18 lines · Sakari Ailus

Hi Krzysztof,

Quoted 13 lines · Krzysztof Kozlowski

Add bindings for the IMX258 camera sensor. The bindings, just like the driver, are quite limited, e.g. do not support regulator supplies.

Signed-off-by Krzysztof Kozlowski <[email protected]>

Reviewed-by Rob Herring <[email protected]>

---

Changes since v4:
1. Add clock-lanes,
2. Add Rob's review,
3. Add one more example and extend existing one,
4. Add common clock properties (assigned-*).

Quoted 6 lines

Quoted 3 lines

Using the assigned-* clock properties may be workable for this driver at the moment. But using these properties does not guarantee the external clock frequency intended to be used on the hardware.

It guarantees it. The clock frequency will be as expected (except if someone misconfigures the DTS).

Is that guaranteed?

I'm not saying no to the approach, but if we change how camera sensor DT bindings are defined, I'd prefer an informed decision is made on the matter.

Quoted 7 lines

Quoted 3 lines

Using other
frequencies *is not* expected to work. That applies to this driver as well.

This is the binding which is HW description. According to HW datasheet other frequencies from described range are accepted and expected to work.

As per datasheet, yes, different external clock frequencies can be used. But the link frequency is still not independent of the external clock frequency.

The properties of the sensor's PLL tree determines what can be achieved given a certain external clock frequency. So picking a wrong external clock frequency quite possibly means that none of the designated link frequencies are available, rendering the sensor inoperable.

Quoted 5 lines

Quoted 3 lines

The driver then controls the HW and knows exactly what is needed. If link frequency (which has its own DT property) requires some clock frequency, the driver will configure the clock to that value. The same

Well it doesn't if it doesn't get that information from DT.

It will get it - via clk_get_rate(). You do not need DT for this.

Quoted 2 lines

The frequency is usually a range, and looking at these bindings, it's from 6 MHz to 27 MHz. That'd be a lot of frequencies for a driver to try.

It does not have to try all of them. Assuming link frequency is fixed, just use any matching (or hard-coded) input clock frequency. Since the input clock frequency most likely will be set with assigned-clock-rates, there will be no job to do for the driver at all. Unless the driver wants to do something more, of course.

Quoted 5 lines

Quoted 3 lines

going other direction. Driver has the knowledge about both its input clock and link frequency, therefore it can make the best decision.

Again you're assuming a particular driver implementation.

Actually not, I am talking about bindings as far away from the driver implementation as possible. This is why some specific frequency *is not* part of the bindings.

Quoted 5 lines

Typically only a few frequencies are really available on platforms, so a in practice a driver would not be able to get any requested frequency. I wouldn't start hard-coding every possible frequency to camera sensor drivers

If the driver cannot get requested frequency which it apparently requires, there is nothing more to do. It's broken HW implementation. The input clock must be matching requirements, regardless of what property you put in DT. You can add "clock-frequency" property, you can even add "really-i-require-clock-frequency" but if the real HW input clock does not have, it won't work.

IOW, adding "clock-frequency" property does not change the reality - the board (HW) must provide given frequency so the entire system works.

Quoted 15 lines

Quoted 15 lines

Quoted 14 lines

Quoted 14 lines

Quoted 4 lines

This, instead of the clock-frequency property, effectively removes the ability to set the correct frequency from the driver, at least with current set of the used APIs.

It seems you confuse DT bindings with some specific driver implementation. Bindings do not describe the driver behavior but the HW. The ability to set the correct frequency from the driver is not removed. It was never part of the bindings and never should. It is part of the driver.

Quoted 3 lines

I suppose you could add a function to set the assigned clock frequency and keep it, just as clk_set_rate_exclusive does?

Quoted 5 lines

Quoted 2 lines

I did not reply to this comment, so let me know. Of course, one could add such functions. It's not a job for DT bindings, though.

I'm not suggesting to add it to DT binding patch. What I'm saying that with this approach is looks like it may well be needed.

New properties can always be added to DT. However existing properties cannot be removed. Their meaning or values cannot be changed.

Add bindings for the IMX258 camera sensor. The bindings, just like the driver, are quite limited, e.g. do not support regulator supplies.

Signed-off-by Krzysztof Kozlowski <[email protected]>

Reviewed-by Rob Herring <[email protected]>

---

Changes since v4:
1. Add clock-lanes,
2. Add Rob's review,
3. Add one more example and extend existing one,
4. Add common clock properties (assigned-*).

Changes since v3:
1. Document also two lane setup.

Changes since v2:
1. Remove clock-frequency, add reset GPIOs, add supplies.
2. Use additionalProperties.

Changes since v1:
1. None

---
 .../devicetree/bindings/media/i2c/imx258.yaml | 140 ++++++++++++++++++
 MAINTAINERS                                   |   1 +
 2 files changed, 141 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/imx258.yaml

Documentation/devicetree/bindings/media/i2c/imx258.yaml new file +14 -0

new file mode 100644
index 000000000000..4a3471fb88a1
@@ -0,0 +1,140 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/imx258.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sony IMX258 13 Mpixel CMOS Digital Image Sensor
+
+maintainers:
+  - Krzysztof Kozlowski <[email protected]>
+
+description: |-
+  IMX258 is a diagonal 5.867mm (Type 1/3.06) 13 Mega-pixel CMOS active pixel
+  type stacked image sensor with a square pixel array of size 4208 x 3120. It