Skip to contentSkip to conversation

arm: socfpga: fix Gen5 enable of EMAC via FPGA

PATCH New Ralph Siemsen 2 participants 3 messages Sep 29, 2020 – Oct 20, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: socfpga: fix Gen5 enable of EMAC via FPGA

An earlier conversion from struct to defines introduced two errors, both related to setup of EMAC routed via the FPGA. One of the offsets was incorrect, and the EMAC0/EMAC1 were swapped.

The effect of this was rather odd: both ports could operate at gigabit, but one of them would fail to transmit when operating at 100Mbit.

Fixes db5741f7a85ec3ee79b64496172afaa7dc2cb225 ("arm: socfpga: Convert system manager from struct to defines")

---
I reviewed the other #defines for gen5 and they seem correct. I have NOT checked the defines for Arria 10 or Stratix 10!

 arch/arm/mach-socfpga/include/mach/system_manager_gen5.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-socfpga/include/mach/system_manager_gen5.h +2 -2
index 90cb465d13..a63a4ee27d 100644
@@ -26,9 +26,9 @@ void sysmgr_get_pinmux_table(const u8 **table, unsigned int *table_len);
 #define SYSMGR_GEN5_ECCGRP_OCRAM		0x144
 #define SYSMGR_GEN5_EMACIO			0x400
 #define SYSMGR_GEN5_NAND_USEFPGA		0x6f0
-#define SYSMGR_GEN5_RGMII0_USEFPGA		0x6f8
+#define SYSMGR_GEN5_RGMII1_USEFPGA		0x6f8
 #define SYSMGR_GEN5_SDMMC_USEFPGA		0x708
-#define SYSMGR_GEN5_RGMII1_USEFPGA		0x704
+#define SYSMGR_GEN5_RGMII0_USEFPGA		0x714
 #define SYSMGR_GEN5_SPIM1_USEFPGA		0x730
 #define SYSMGR_GEN5_SPIM0_USEFPGA		0x738
 
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 arm: socfpga: fix Gen5 enable of EMAC via FPGA

Quoted 2 lines · Ralph Siemsen
Fixes db5741f7a85ec3ee79b64496172afaa7dc2cb225 ("arm: socfpga: Convert

system manager from struct to defines")

Just curious if you have had a chance to look over this patch?
http://patchwork.ozlabs.org/project/uboot/patch/20200929145152.v1.1.I7900a579743ce0fc5fe382213612b5af29e3706f at changeid/

It fixes a problem introduced here:
https://gitlab.denx.de/u-boot/u-boot/-/commit/db5741f7a85ec3ee79b64496172afaa7dc2cb225?view=parallel#fd949530559c32d01169ed7f0667e63ab210fe14_16_16
after which one of the GMAC on Gen 5 devices no longer operates at 100mbit.

Thanks,
Ralph

#2 lore raw

PATCH 1/1 arm: socfpga: fix Gen5 enable of EMAC via FPGA

Quoted 26 lines

-----Original Message-----
From: Ralph Siemsen <[email protected]>
Sent: Tuesday, October 20, 2020 1:43 AM
To: Tan, Ley Foon <[email protected]>
Cc: Dinh Nguyen <[email protected]>; Marek Vasut <[email protected]>; Simon Goldschmidt <[email protected]>; u- boot at lists.denx.de; Tom Rini <[email protected]>
Subject: Re: [PATCH v1] arm: socfpga: fix Gen5 enable of EMAC via FPGA

Quoted 1 line · Ralph Siemsen
Fixes db5741f7a85ec3ee79b64496172afaa7dc2cb225 ("arm: socfpga:

Convert

Quoted 1 line

system manager from struct to defines")

Just curious if you have had a chance to look over this patch?
http://patchwork.ozlabs.org/project/uboot/patch/20200929145152.v1.1.I79
00a579743ce0fc5fe382213612b5af29e3706f at changeid/

It fixes a problem introduced here:
https://gitlab.denx.de/u-boot/u-boot/-
/commit/db5741f7a85ec3ee79b64496172afaa7dc2cb225?view=parallel#fd9 49530559c32d01169ed7f0667e63ab210fe14_16_16
after which one of the GMAC on Gen 5 devices no longer operates at 100mbit.

Quoted 2 lines

Thanks,
Ralph

Thanks for the patch, will merge this to next -rc.

Regards
Ley Foon