Skip to contentSkip to conversation

pci: remove unneeded break

PATCH In review [email protected] 3 participants 3 messages Oct 19, 2020 – Oct 20, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pci: remove unneeded break

From: Tom Rix <[email protected]>

A break is not needed if it is preceded by a return

---
 drivers/pci/controller/pci-v3-semi.c | 1 -
 1 file changed, 1 deletion(-)
drivers/pci/controller/pci-v3-semi.c +0 -1
index 1f54334f09f7..154a5398633c 100644
@@ -658,7 +658,6 @@ static int v3_get_dma_range_config(struct v3_pci *v3,
 	default:
 		dev_err(v3->dev, "illegal dma memory chunk size\n");
 		return -EINVAL;
-		break;
 	}
 	val |= V3_PCI_MAP_M_REG_EN | V3_PCI_MAP_M_ENABLE;
 	*pci_map = val;
Signature · 1 line
2.18.1
#2 lore raw
In reply to [email protected]
Quoted 5 lines · On Mon, Oct 19, 2020 at 12:02:49PM -0700, [email protected] wrote:

From: Tom Rix <[email protected]>

A break is not needed if it is preceded by a return

Applied with Linus' reviewed-by to pci/misc for v5.10, thanks!

Quoted 19 lines
---
 drivers/pci/controller/pci-v3-semi.c | 1 -
 1 file changed, 1 deletion(-)
drivers/pci/controller/pci-v3-semi.c +0 -1
index 1f54334f09f7..154a5398633c 100644
@@ -658,7 +658,6 @@ static int v3_get_dma_range_config(struct v3_pci *v3,
 	default:
 		dev_err(v3->dev, "illegal dma memory chunk size\n");
 		return -EINVAL;
-		break;
 	}
 	val |= V3_PCI_MAP_M_REG_EN | V3_PCI_MAP_M_ENABLE;
 	*pci_map = val;
Signature · 1 line
2.18.1