Skip to contentSkip to conversation

hw/arm/trace-events: Fix misuse of '0x' prefix with '%d' format

PATCH In review Peter Maydell 2 participants 2 messages Oct 19, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw/arm/trace-events: Fix misuse of '0x' prefix with '%d' format

The smmuv3_cmdq_cfgi_ste_range trace event prints decimal values with an 0x prefix, which is confusing. We're printing a range of stream IDs here, which elsewhere we do in decimal, so use decimal here too and just drop the '0x' prefix.

---
 hw/arm/trace-events | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/arm/trace-events +1 -1
index c8a4d80f6bd..806e1d89d2b 100644
@@ -41,7 +41,7 @@ smmuv3_get_cd(uint64_t addr) "CD addr: 0x%"PRIx64
 smmuv3_decode_cd(uint32_t oas) "oas=%d"
 smmuv3_decode_cd_tt(int i, uint32_t tsz, uint64_t ttb, uint32_t granule_sz, bool had) "TT[%d]:tsz:%d ttb:0x%"PRIx64" granule_sz:%d had:%d"
 smmuv3_cmdq_cfgi_ste(int streamid) "streamid =%d"
-smmuv3_cmdq_cfgi_ste_range(int start, int end) "start=0x%d - end=0x%d"
+smmuv3_cmdq_cfgi_ste_range(int start, int end) "start=%d - end=%d"
 smmuv3_cmdq_cfgi_cd(uint32_t sid) "streamid = %d"
 smmuv3_config_cache_hit(uint32_t sid, uint32_t hits, uint32_t misses, uint32_t perc) "Config cache HIT for sid %d (hits=%d, misses=%d, hit rate=%d)"
 smmuv3_config_cache_miss(uint32_t sid, uint32_t hits, uint32_t misses, uint32_t perc) "Config cache MISS for sid %d (hits=%d, misses=%d, hit rate=%d)"
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Peter Maydell

The smmuv3_cmdq_cfgi_ste_range trace event prints decimal values with an 0x prefix, which is confusing. We're printing a range of stream IDs here, which elsewhere we do in decimal, so use decimal here too and just drop the '0x' prefix.

---
  hw/arm/trace-events | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)