Skip to contentSkip to conversation

crypto: atmel-sha: remove unneeded break

PATCH In review [email protected] 3 participants 3 messages Oct 19, 2020 – Nov 6, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto: atmel-sha: remove unneeded break

From: Tom Rix <[email protected]>

A break is not needed if it is preceded by a return

---
 drivers/crypto/atmel-sha.c | 1 -
 1 file changed, 1 deletion(-)
drivers/crypto/atmel-sha.c +0 -1
index 75ccf41a7cb9..0eb6f54e3b66 100644
@@ -459,7 +459,6 @@ static int atmel_sha_init(struct ahash_request *req)
 		break;
 	default:
 		return -EINVAL;
-		break;
 	}
 
 	ctx->bufcnt = 0;
Signature · 1 line
2.18.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · On 19/10/2020 12:36:53-0700, [email protected] wrote:

From: Tom Rix <[email protected]>

A break is not needed if it is preceded by a return

Quoted 19 lines
---
 drivers/crypto/atmel-sha.c | 1 -
 1 file changed, 1 deletion(-)
drivers/crypto/atmel-sha.c +0 -1
index 75ccf41a7cb9..0eb6f54e3b66 100644
@@ -459,7 +459,6 @@ static int atmel_sha_init(struct ahash_request *req)
 		break;
 	default:
 		return -EINVAL;
-		break;
 	}
 
 	ctx->bufcnt = 0;
Signature · 1 line
2.18.1
Signature · 3 lines
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
maintainer
#2 lore raw
In reply to [email protected]
Quoted 8 lines · On Mon, Oct 19, 2020 at 12:36:53PM -0700, [email protected] wrote:

From: Tom Rix <[email protected]>

A break is not needed if it is preceded by a return

---
 drivers/crypto/atmel-sha.c | 1 -
 1 file changed, 1 deletion(-)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt