Skip to contentSkip to conversation

ipack: iopctal: remove unneeded break

PATCH In review [email protected] 3 participants 3 messages Oct 19, 2020 – Oct 20, 2020 Industry pack subsystem (ipack)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ipack: iopctal: remove unneeded break

From: Tom Rix <[email protected]>

A break is not needed if it is preceded by a return

---
 drivers/ipack/devices/ipoctal.c | 1 -
 1 file changed, 1 deletion(-)
drivers/ipack/devices/ipoctal.c +0 -1
index d480a514c983..3940714e4397 100644
@@ -544,7 +544,6 @@ static void ipoctal_set_termios(struct tty_struct *tty,
 		break;
 	default:
 		return;
-		break;
 	}
 
 	baud = tty_get_baud_rate(tty);
Signature · 1 line
2.18.1
Acked-by on v1 1/1
#1 lore raw

Hi Tom,

Thanks for the patch!

Patch is,

Greg, Would you mind picking this patch through your char-misc tree?

Thanks!

Sam

Quoted 23 lines · On Mon, 2020-10-19 at 12:32 -0700, [email protected] wrote:

From: Tom Rix <[email protected]>

A break is not needed if it is preceded by a return

---
 drivers/ipack/devices/ipoctal.c | 1 -
 1 file changed, 1 deletion(-)
drivers/ipack/devices/ipoctal.c +0 -1
index d480a514c983..3940714e4397 100644
@@ -544,7 +544,6 @@ static void ipoctal_set_termios(struct tty_struct
 *tty,
 		break;
 	default:
 		return;
-		break;
 	}
 

baud = tty_get_baud_rate(tty);