examples/tep_term: deprecate this example
PATCH 1/1 examples/tep_term: deprecate this example
The tunnel cases this example wants to test can be covered by testpmd with rte_flow_create. And this example hasn't been used for a long time. So deprecate this example.
--- MAINTAINERS | 4 - .../img/tep_termination_arch.svg | 1400 ----------------- doc/guides/sample_app_ug/index.rst | 1 - doc/guides/sample_app_ug/tep_termination.rst | 233 --- examples/meson.build | 2 +- examples/tep_termination/Makefile | 45 - examples/tep_termination/main.c | 1235 --------------- examples/tep_termination/main.h | 93 -- examples/tep_termination/meson.build | 16 - examples/tep_termination/vxlan.c | 243 --- examples/tep_termination/vxlan.h | 57 - examples/tep_termination/vxlan_setup.c | 443 ------ examples/tep_termination/vxlan_setup.h | 58 - 13 files changed, 1 insertion(+), 3829 deletions(-) delete mode 100644 doc/guides/sample_app_ug/img/tep_termination_arch.svg delete mode 100644 doc/guides/sample_app_ug/tep_termination.rst delete mode 100644 examples/tep_termination/Makefile delete mode 100644 examples/tep_termination/main.c delete mode 100644 examples/tep_termination/main.h delete mode 100644 examples/tep_termination/meson.build delete mode 100644 examples/tep_termination/vxlan.c delete mode 100644 examples/tep_termination/vxlan.h delete mode 100644 examples/tep_termination/vxlan_setup.c delete mode 100644 examples/tep_termination/vxlan_setup.h
MAINTAINERS +0 -4
@@ -1659,10 +1659,6 @@ M: John McNamara <[email protected]> F: examples/skeleton/ F: doc/guides/sample_app_ug/skeleton.rst -TEP termination example -M: Xiaoyun Li <[email protected]> -F: examples/tep_termination/ - VMDq examples F: examples/vmdq/ F: doc/guides/sample_app_ug/vmdq_forwarding.rst
doc/guides/sample_app_ug/img/tep_termination_arch.svg deleted +0 -1400
1,401 lines not on this page · raw message
doc/guides/sample_app_ug/index.rst +0 -1
@@ -51,7 +51,6 @@ Sample Applications User Guides eventdev_pipeline dist_app vm_power_management - tep_termination ptpclient performance_thread fips_validation
doc/guides/sample_app_ug/tep_termination.rst deleted +0 -233
233 lines not on this page · raw message
examples/meson.build +1 -1
@@ -40,7 +40,7 @@ all_examples = [ 'server_node_efd/node', 'server_node_efd/server', 'service_cores', - 'skeleton', 'tep_termination', + 'skeleton', 'timer', 'vdpa', 'vhost', 'vhost_crypto', 'vhost_blk', 'vm_power_manager',
examples/tep_termination/Makefile deleted +0 -45
45 lines not on this page · raw message
examples/tep_termination/main.c deleted +0 -1235
1,235 lines not on this page · raw message
examples/tep_termination/main.h deleted +0 -93
61 lines not on this page · raw message
examples/tep_termination/meson.build deleted +0 -16
Lines of this file are not shown. View the raw message.
examples/tep_termination/vxlan.c deleted +0 -243
243 lines not on this page · raw message
examples/tep_termination/vxlan.h deleted +0 -57
57 lines not on this page · raw message
examples/tep_termination/vxlan_setup.c deleted +0 -443
443 lines not on this page · raw message
examples/tep_termination/vxlan_setup.h deleted +0 -58
58 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.17.1
Part of the diff is not shown here. View the raw message.
19/10/2020 10:27, Xiaoyun Li:
Quoted 5 lines
The tunnel cases this example wants to test can be covered by testpmd with
rte_flow_create. And this example hasn't been used for a long time. So deprecate this example.Signed-off-by Xiaoyun Li <[email protected]>
Thanks for the cleanup.
Andrew Rybchenko
Acked-byQuoted 8 lines · Thomas Monjalon
19/10/2020 10:27, Xiaoyun Li:
Quoted 5 lines
The tunnel cases this example wants to test can be covered by testpmd with
rte_flow_create. And this example hasn't been used for a long time. So deprecate this example.Signed-off-by Xiaoyun Li <[email protected]>Acked-by Thomas Monjalon <[email protected]>
Quoted 1 line
Thanks for the cleanup.
+1
Quoted 5 lines · Xiaoyun Li
The tunnel cases this example wants to test can be covered by testpmd with
rte_flow_create. And this example hasn't been used for a long time. So deprecate this example.Signed-off-by Xiaoyun Li <[email protected]>
cc'ed techboard since it has a recurring task to remove unused examples, this seems suit well.
@Xiaoyun, only do you think does it help to put some documentation to show how testpmd can be used for same functionality?
Hi
Quoted 12 lines
-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Monday, October 19, 2020 17:14
To: Li, Xiaoyun <[email protected]>; [email protected]
Cc: [email protected]; [email protected]
Subject: Re: [PATCH] examples/tep_term: deprecate this exampleQuoted 4 lines · Xiaoyun Li
The tunnel cases this example wants to test can be covered by testpmd with
rte_flow_create. And this example hasn't been used for a long time. So deprecate this example.
Quoted 7 lines
Quoted 1 line
Signed-off-by Xiaoyun Li <[email protected]>cc'ed techboard since it has a recurring task to remove unused examples, this seems suit well.
@Xiaoyun, only do you think does it help to put some documentation to show how testpmd can be used for same functionality?
Yes. Make sense. This example wants to prove the vxlan packet to queue offloading. This can be covered by rte_flow_create. I will add an sample usage of this in testpmd doc. And this example builds a scenario for that and does software encap/decap for vxlan packet. OVS is commonly used to do this. I'll mention this in commit log in next version. Thanks.
BRs
Xiaoyun
PATCH v2 1/1 examples/tep_term: deprecate this example
In reply to Xiaoyun LiThis example sets up a scenario that VXLAN packets can be received by different PF queues based on VNID and each queue is bound to a VM with a VNID so that the VM can receive its inner packets.
Usually, OVS is used to do the software encap/decap for VXLAN packets.
And the VXLAN packets offloading can be replaced with flow rules in testpmd like Chapter "Sample VXLAN flow rules" in Testpmd Application User Guide.
And this example hasn't been used for a long time.
So deprecate this example.
---
v2:
* Polished the commit log.
* Added the doc for testpmd VXLAN flow rules which can replace the
* offload that this example wanted.
--- MAINTAINERS | 4 - .../img/tep_termination_arch.svg | 1400 ----------------- doc/guides/sample_app_ug/index.rst | 1 - doc/guides/sample_app_ug/tep_termination.rst | 233 --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 43 + examples/meson.build | 2 +- examples/tep_termination/Makefile | 45 - examples/tep_termination/main.c | 1235 --------------- examples/tep_termination/main.h | 93 -- examples/tep_termination/meson.build | 16 - examples/tep_termination/vxlan.c | 243 --- examples/tep_termination/vxlan.h | 57 - examples/tep_termination/vxlan_setup.c | 443 ------ examples/tep_termination/vxlan_setup.h | 58 - 14 files changed, 44 insertions(+), 3829 deletions(-) delete mode 100644 doc/guides/sample_app_ug/img/tep_termination_arch.svg delete mode 100644 doc/guides/sample_app_ug/tep_termination.rst delete mode 100644 examples/tep_termination/Makefile delete mode 100644 examples/tep_termination/main.c delete mode 100644 examples/tep_termination/main.h delete mode 100644 examples/tep_termination/meson.build delete mode 100644 examples/tep_termination/vxlan.c delete mode 100644 examples/tep_termination/vxlan.h delete mode 100644 examples/tep_termination/vxlan_setup.c delete mode 100644 examples/tep_termination/vxlan_setup.h
MAINTAINERS +0 -4
@@ -1659,10 +1659,6 @@ M: John McNamara <[email protected]> F: examples/skeleton/ F: doc/guides/sample_app_ug/skeleton.rst -TEP termination example -M: Xiaoyun Li <[email protected]> -F: examples/tep_termination/ - VMDq examples F: examples/vmdq/ F: doc/guides/sample_app_ug/vmdq_forwarding.rst
doc/guides/sample_app_ug/img/tep_termination_arch.svg deleted +0 -1400
1,401 lines not on this page · raw message
doc/guides/sample_app_ug/index.rst +0 -1
@@ -51,7 +51,6 @@ Sample Applications User Guides eventdev_pipeline dist_app vm_power_management - tep_termination ptpclient performance_thread fips_validation
doc/guides/sample_app_ug/tep_termination.rst deleted +0 -233
233 lines not on this page · raw message
doc/guides/testpmd_app_ug/testpmd_funcs.rst +43 -0
49 lines not on this page · raw message
examples/meson.build +1 -1
@@ -40,7 +40,7 @@ all_examples = [ 'server_node_efd/node', 'server_node_efd/server', 'service_cores', - 'skeleton', 'tep_termination', + 'skeleton', 'timer', 'vdpa', 'vhost', 'vhost_crypto', 'vhost_blk', 'vm_power_manager',
examples/tep_termination/Makefile deleted +0 -45
45 lines not on this page · raw message
examples/tep_termination/main.c deleted +0 -1235
1,235 lines not on this page · raw message
examples/tep_termination/main.h deleted +0 -93
12 lines not on this page · raw message
examples/tep_termination/meson.build deleted +0 -16
Lines of this file are not shown. View the raw message.
examples/tep_termination/vxlan.c deleted +0 -243
243 lines not on this page · raw message
examples/tep_termination/vxlan.h deleted +0 -57
57 lines not on this page · raw message
examples/tep_termination/vxlan_setup.c deleted +0 -443
443 lines not on this page · raw message
examples/tep_termination/vxlan_setup.h deleted +0 -58
58 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.17.1
Part of the diff is not shown here. View the raw message.
Quoted 14 lines · Xiaoyun Li
This example sets up a scenario that VXLAN packets can be received by different PF queues based on VNID and each queue is bound to a VM with a VNID so that the VM can receive its inner packets.
Usually, OVS is used to do the software encap/decap for VXLAN packets.
And the VXLAN packets offloading can be replaced with flow rules in testpmd like Chapter "Sample VXLAN flow rules" in Testpmd Application User Guide.
And this example hasn't been used for a long time.
So deprecate this example.
Quoted 8 lines
Signed-off-by Xiaoyun Li <[email protected]>Acked-by Thomas Monjalon <[email protected]>Acked-by Andrew Rybchenko <[email protected]>---
v2:
* Polished the commit log.
* Added the doc for testpmd VXLAN flow rules which can replace the
* offload that this example wanted.
lgtm, thanks for the update
20/10/2020 08:11, Xiaoyun Li:
Quoted 13 lines
This example sets up a scenario that VXLAN packets can be received by different PF queues based on VNID and each queue is bound to a VM with a VNID so that the VM can receive its inner packets.
Usually, OVS is used to do the software encap/decap for VXLAN packets.
And the VXLAN packets offloading can be replaced with flow rules in testpmd like Chapter "Sample VXLAN flow rules" in Testpmd Application User Guide.
And this example hasn't been used for a long time.
So deprecate this example.
Quoted 16 lines
--- MAINTAINERS | 4 - .../img/tep_termination_arch.svg | 1400 ----------------- doc/guides/sample_app_ug/index.rst | 1 - doc/guides/sample_app_ug/tep_termination.rst | 233 --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 43 + examples/meson.build | 2 +- examples/tep_termination/Makefile | 45 - examples/tep_termination/main.c | 1235 --------------- examples/tep_termination/main.h | 93 -- examples/tep_termination/meson.build | 16 - examples/tep_termination/vxlan.c | 243 --- examples/tep_termination/vxlan.h | 57 - examples/tep_termination/vxlan_setup.c | 443 ------ examples/tep_termination/vxlan_setup.h | 58 - 14 files changed, 44 insertions(+), 3829 deletions(-)
Please list this example as a removed item in the release notes. Thanks
OK.
Quoted 43 lines
-----Original Message-----
From: Thomas Monjalon <[email protected]>
Sent: Tuesday, October 20, 2020 19:43
To: Li, Xiaoyun <[email protected]>
Cc: Yigit, Ferruh <[email protected]>; [email protected]; [email protected]; [email protected]
Subject: Re: [dpdk-dev] [PATCH v2] examples/tep_term: deprecate this example20/10/2020 08:11, Xiaoyun Li:
Quoted 13 lines
This example sets up a scenario that VXLAN packets can be received by different PF queues based on VNID and each queue is bound to a VM with a VNID so that the VM can receive its inner packets.
Usually, OVS is used to do the software encap/decap for VXLAN packets.
And the VXLAN packets offloading can be replaced with flow rules in testpmd like Chapter "Sample VXLAN flow rules" in Testpmd Application User Guide.
And this example hasn't been used for a long time.
So deprecate this example.
Quoted 16 lines
--- MAINTAINERS | 4 - .../img/tep_termination_arch.svg | 1400 ----------------- doc/guides/sample_app_ug/index.rst | 1 - doc/guides/sample_app_ug/tep_termination.rst | 233 --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 43 + examples/meson.build | 2 +- examples/tep_termination/Makefile | 45 - examples/tep_termination/main.c | 1235 --------------- examples/tep_termination/main.h | 93 -- examples/tep_termination/meson.build | 16 - examples/tep_termination/vxlan.c | 243 --- examples/tep_termination/vxlan.h | 57 - examples/tep_termination/vxlan_setup.c | 443 ------ examples/tep_termination/vxlan_setup.h | 58 - 14 files changed, 44 insertions(+), 3829 deletions(-)Please list this example as a removed item in the release notes. Thanks
PATCH v3 1/1 examples/tep_term: deprecate this example
In reply to Xiaoyun LiThis example sets up a scenario that VXLAN packets can be received by different PF queues based on VNID and each queue is bound to a VM with a VNID so that the VM can receive its inner packets.
Usually, OVS is used to do the software encap/decap for VXLAN packets.
And the VXLAN packets offloading can be replaced with flow rules in testpmd like Chapter "Sample VXLAN flow rules" in Testpmd Application User Guide.
And this example hasn't been used for a long time.
So deprecate this example.
---
v3:
* Added release note in removed items.
v2:
* Polished the commit log.
* Added the doc for testpmd VXLAN flow rules which can replace the
* offload that this example wanted.
--- MAINTAINERS | 4 - doc/guides/rel_notes/release_20_11.rst | 2 + .../img/tep_termination_arch.svg | 1400 ----------------- doc/guides/sample_app_ug/index.rst | 1 - doc/guides/sample_app_ug/tep_termination.rst | 233 --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 43 + examples/meson.build | 2 +- examples/tep_termination/Makefile | 45 - examples/tep_termination/main.c | 1235 --------------- examples/tep_termination/main.h | 93 -- examples/tep_termination/meson.build | 16 - examples/tep_termination/vxlan.c | 243 --- examples/tep_termination/vxlan.h | 57 - examples/tep_termination/vxlan_setup.c | 443 ------ examples/tep_termination/vxlan_setup.h | 58 - 15 files changed, 46 insertions(+), 3829 deletions(-) delete mode 100644 doc/guides/sample_app_ug/img/tep_termination_arch.svg delete mode 100644 doc/guides/sample_app_ug/tep_termination.rst delete mode 100644 examples/tep_termination/Makefile delete mode 100644 examples/tep_termination/main.c delete mode 100644 examples/tep_termination/main.h delete mode 100644 examples/tep_termination/meson.build delete mode 100644 examples/tep_termination/vxlan.c delete mode 100644 examples/tep_termination/vxlan.h delete mode 100644 examples/tep_termination/vxlan_setup.c delete mode 100644 examples/tep_termination/vxlan_setup.h
MAINTAINERS +0 -4
@@ -1659,10 +1659,6 @@ M: John McNamara <[email protected]> F: examples/skeleton/ F: doc/guides/sample_app_ug/skeleton.rst -TEP termination example -M: Xiaoyun Li <[email protected]> -F: examples/tep_termination/ - VMDq examples F: examples/vmdq/ F: doc/guides/sample_app_ug/vmdq_forwarding.rst
doc/guides/rel_notes/release_20_11.rst +2 -0
@@ -358,6 +358,8 @@ Removed Items * Removed Python 2 support since it was EOL'd in January 2020. +* Removed TEP termination sample application. + API Changes -----------
doc/guides/sample_app_ug/img/tep_termination_arch.svg deleted +0 -1400
1,401 lines not on this page · raw message
doc/guides/sample_app_ug/index.rst +0 -1
@@ -51,7 +51,6 @@ Sample Applications User Guides eventdev_pipeline dist_app vm_power_management - tep_termination ptpclient performance_thread fips_validation
doc/guides/sample_app_ug/tep_termination.rst deleted +0 -233
233 lines not on this page · raw message
doc/guides/testpmd_app_ug/testpmd_funcs.rst +43 -0
49 lines not on this page · raw message
examples/meson.build +1 -1
@@ -40,7 +40,7 @@ all_examples = [ 'server_node_efd/node', 'server_node_efd/server', 'service_cores', - 'skeleton', 'tep_termination', + 'skeleton', 'timer', 'vdpa', 'vhost', 'vhost_crypto', 'vhost_blk', 'vm_power_manager',
examples/tep_termination/Makefile deleted +0 -45
45 lines not on this page · raw message
examples/tep_termination/main.c deleted +0 -1235
1,235 lines not on this page · raw message
examples/tep_termination/main.h deleted +0 -93
4 lines not on this page · raw message
examples/tep_termination/meson.build deleted +0 -16
Lines of this file are not shown. View the raw message.
examples/tep_termination/vxlan.c deleted +0 -243
243 lines not on this page · raw message
examples/tep_termination/vxlan.h deleted +0 -57
57 lines not on this page · raw message
examples/tep_termination/vxlan_setup.c deleted +0 -443
443 lines not on this page · raw message
examples/tep_termination/vxlan_setup.h deleted +0 -58
58 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.17.1
Part of the diff is not shown here. View the raw message.
PATCH v4 1/1 examples/tep_term: deprecate this example
In reply to Xiaoyun LiThis example sets up a scenario that VXLAN packets can be received by different PF queues based on VNID and each queue is bound to a VM with a VNID so that the VM can receive its inner packets.
Usually, OVS is used to do the software encap/decap for VXLAN packets.
And the VXLAN packets offloading can be replaced with flow rules in testpmd like Chapter "Sample VXLAN flow rules" in Testpmd Application User Guide.
And this example hasn't been used for a long time.
So deprecate this example.
---
v4:
* Rebased to the newest dpdk branch.
v3:
* Added release note in removed items.
v2:
* Polished the commit log.
* Added the doc for testpmd VXLAN flow rules which can replace the
* offload that this example wanted.
--- MAINTAINERS | 4 - doc/guides/rel_notes/release_20_11.rst | 2 + .../img/tep_termination_arch.svg | 1400 ----------------- doc/guides/sample_app_ug/index.rst | 1 - doc/guides/sample_app_ug/tep_termination.rst | 214 --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 43 + examples/meson.build | 2 +- examples/tep_termination/Makefile | 45 - examples/tep_termination/main.c | 1235 --------------- examples/tep_termination/main.h | 93 -- examples/tep_termination/meson.build | 16 - examples/tep_termination/vxlan.c | 243 --- examples/tep_termination/vxlan.h | 57 - examples/tep_termination/vxlan_setup.c | 443 ------ examples/tep_termination/vxlan_setup.h | 58 - 15 files changed, 46 insertions(+), 3810 deletions(-) delete mode 100644 doc/guides/sample_app_ug/img/tep_termination_arch.svg delete mode 100644 doc/guides/sample_app_ug/tep_termination.rst delete mode 100644 examples/tep_termination/Makefile delete mode 100644 examples/tep_termination/main.c delete mode 100644 examples/tep_termination/main.h delete mode 100644 examples/tep_termination/meson.build delete mode 100644 examples/tep_termination/vxlan.c delete mode 100644 examples/tep_termination/vxlan.h delete mode 100644 examples/tep_termination/vxlan_setup.c delete mode 100644 examples/tep_termination/vxlan_setup.h
MAINTAINERS +0 -4
@@ -1670,10 +1670,6 @@ M: John McNamara <[email protected]> F: examples/skeleton/ F: doc/guides/sample_app_ug/skeleton.rst -TEP termination example -M: Xiaoyun Li <[email protected]> -F: examples/tep_termination/ - VMDq examples F: examples/vmdq/ F: doc/guides/sample_app_ug/vmdq_forwarding.rst
doc/guides/rel_notes/release_20_11.rst +2 -0
@@ -369,6 +369,8 @@ Removed Items * Removed Python 2 support since it was EOL'd in January 2020. +* Removed TEP termination sample application. + API Changes -----------
doc/guides/sample_app_ug/img/tep_termination_arch.svg deleted +0 -1400
1,401 lines not on this page · raw message
doc/guides/sample_app_ug/index.rst +0 -1
@@ -51,7 +51,6 @@ Sample Applications User Guides eventdev_pipeline dist_app vm_power_management - tep_termination ptpclient performance_thread fips_validation
doc/guides/sample_app_ug/tep_termination.rst deleted +0 -214
214 lines not on this page · raw message
doc/guides/testpmd_app_ug/testpmd_funcs.rst +43 -0
49 lines not on this page · raw message
examples/meson.build +1 -1
@@ -40,7 +40,7 @@ all_examples = [ 'server_node_efd/node', 'server_node_efd/server', 'service_cores', - 'skeleton', 'tep_termination', + 'skeleton', 'timer', 'vdpa', 'vhost', 'vhost_crypto', 'vhost_blk', 'vm_power_manager',
examples/tep_termination/Makefile deleted +0 -45
45 lines not on this page · raw message
examples/tep_termination/main.c deleted +0 -1235
1,235 lines not on this page · raw message
examples/tep_termination/main.h deleted +0 -93
23 lines not on this page · raw message
examples/tep_termination/meson.build deleted +0 -16
Lines of this file are not shown. View the raw message.
examples/tep_termination/vxlan.c deleted +0 -243
243 lines not on this page · raw message
examples/tep_termination/vxlan.h deleted +0 -57
57 lines not on this page · raw message
examples/tep_termination/vxlan_setup.c deleted +0 -443
443 lines not on this page · raw message
examples/tep_termination/vxlan_setup.h deleted +0 -58
58 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.17.1
Part of the diff is not shown here. View the raw message.
Thomas Monjalon
Applied26/10/2020 09:11, Xiaoyun Li:
Quoted 10 lines
This example sets up a scenario that VXLAN packets can be received by different PF queues based on VNID and each queue is bound to a VM with a VNID so that the VM can receive its inner packets.
Usually, OVS is used to do the software encap/decap for VXLAN packets.
And the VXLAN packets offloading can be replaced with flow rules in testpmd like Chapter "Sample VXLAN flow rules" in Testpmd Application User Guide.
Quoted 8 lines
And this example hasn't been used for a long time.
So deprecate this example.
Signed-off-by Xiaoyun Li <[email protected]>Acked-by Thomas Monjalon <[email protected]>Acked-by Andrew Rybchenko <[email protected]>Acked-by Ferruh Yigit <[email protected]>
Applied, thanks