Skip to contentSkip to conversation

arm64: meson: ship only the necessary clock controllers

PATCH Applied Jerome Brunet 3 participants 6 messages Oct 20, 2020 – Nov 20, 2020

Subsystems (2)
lore
Share & tools
lore

Jerome Brunet

author reviewer
#0 lore raw

PATCH 1/1 arm64: meson: ship only the necessary clock controllers

There now the menu entries for the amlogic clock controllers. Do not select these when ARM64 is enabled so it possible to ship only the required.

---
 arch/arm64/Kconfig.platforms | 3 ---
 1 file changed, 3 deletions(-)
arch/arm64/Kconfig.platforms +0 -3
index cd58f8495c45..b22d1bdd6eb6 100644
@@ -154,9 +154,6 @@ config ARCH_MESON
 	bool "Amlogic Platforms"
 	select PINCTRL
 	select PINCTRL_MESON
-	select COMMON_CLK_GXBB
-	select COMMON_CLK_AXG
-	select COMMON_CLK_G12A
 	select MESON_IRQ_GPIO
 	help
 	  This enables support for the arm64 based Amlogic SoCs
Signature · 1 line
2.25.4
Reviewed-by on v1 1/1
#1 lore raw
Quoted 15 lines · Jerome Brunet

There now the menu entries for the amlogic clock controllers. Do not select these when ARM64 is enabled so it possible to ship only the required.

---
 arch/arm64/Kconfig.platforms | 3 ---
 1 file changed, 3 deletions(-)
arch/arm64/Kconfig.platforms +0 -0
index cd58f8495c45..b22d1bdd6eb6 100644

arch/arm64/Kconfig.platforms config ARCH_MESON · line 159

Quoted 9 lines
arch/arm64/Kconfig.platforms +0 -3
@@ -154,9 +154,6 @@ config ARCH_MESON
 	bool "Amlogic Platforms"
 	select PINCTRL
 	select PINCTRL_MESON
-	select COMMON_CLK_GXBB
-	select COMMON_CLK_AXG
-	select COMMON_CLK_G12A
 	select MESON_IRQ_GPIO
 	help
 	  This enables support for the arm64 based Amlogic SoCs
maintainer Acked-by on v1 1/1
#2 lore raw
In reply to Jerome Brunet
Quoted 14 lines · Jerome Brunet

There now the menu entries for the amlogic clock controllers. Do not select these when ARM64 is enabled so it possible to ship only the required.

---
 arch/arm64/Kconfig.platforms | 3 ---
 1 file changed, 3 deletions(-)
arch/arm64/Kconfig.platforms +0 -0
index cd58f8495c45..b22d1bdd6eb6 100644

arch/arm64/Kconfig.platforms config ARCH_MESON · line 159

Quoted 6 lines
arch/arm64/Kconfig.platforms +0 -3
@@ -154,9 +154,6 @@ config ARCH_MESON
 	bool "Amlogic Platforms"
 	select PINCTRL
 	select PINCTRL_MESON
-	select COMMON_CLK_GXBB
-	select COMMON_CLK_AXG
-	select COMMON_CLK_G12A

This patch alone will break boot when using the default, upstream defconfig because these options will all now be disabled and we'll have no clock providers.

I think you also need a default value (e.g. default y) in drivers/clk/meson/Kconfig for each of these entries to keep the same
defaults. But these defaults could be overridden by SoC-specific
defconfigs leading to more flexibilty.

So, assuming you queue up a drivers/clk patch to go in when this lands...

author reviewer
#3 lore raw
Quoted 27 lines · Kevin Hilman
Quoted 14 lines · Jerome Brunet

There now the menu entries for the amlogic clock controllers. Do not select these when ARM64 is enabled so it possible to ship only the required.

---
 arch/arm64/Kconfig.platforms | 3 ---
 1 file changed, 3 deletions(-)
arch/arm64/Kconfig.platforms +0 -0
index cd58f8495c45..b22d1bdd6eb6 100644

arch/arm64/Kconfig.platforms config ARCH_MESON · line 159

Quoted 6 lines
arch/arm64/Kconfig.platforms +0 -3
@@ -154,9 +154,6 @@ config ARCH_MESON
 	bool "Amlogic Platforms"
 	select PINCTRL
 	select PINCTRL_MESON
-	select COMMON_CLK_GXBB
-	select COMMON_CLK_AXG
-	select COMMON_CLK_G12A

This patch alone will break boot when using the default, upstream defconfig because these options will all now be disabled and we'll have no clock providers.

Quoted 7 lines

I think you also need a default value (e.g. default y) in drivers/clk/meson/Kconfig for each of these entries to keep the same
defaults. But these defaults could be overridden by SoC-specific
defconfigs leading to more flexibilty.

So, assuming you queue up a drivers/clk patch to go in when this lands...

Indeed.
Please wait till the clock PR lands during the merge window, you'll see that it is already taken care of.

I was not expecting you to look at it so soon ;)

Quoted 2 lines
maintainer Applied
#4 lore raw
In reply to Jerome Brunet
Quoted 3 lines · Jerome Brunet

There now the menu entries for the amlogic clock controllers. Do not select these when ARM64 is enabled so it possible to ship only the required.

Applied, thanks!

[1/1] arm64: meson: ship only the necessary clock controllers
(no commit info)

Best regards,

Signature · 1 line
Kevin Hilman <[email protected]>
maintainer Applied
#5 lore raw
In reply to Jerome Brunet
Quoted 3 lines · Jerome Brunet

There now the menu entries for the amlogic clock controllers. Do not select these when ARM64 is enabled so it possible to ship only the required.

Applied, thanks!

[1/1] arm64: meson: ship only the necessary clock controllers
(no commit info)

Best regards,

Signature · 6 lines
Kevin Hilman <[email protected]>

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic