net: remove an assert call in eth_get_gso_type
PATCH 1/1 net: remove an assert call in eth_get_gso_type
From: Prasad J Pandit <[email protected]>
eth_get_gso_type() routine returns segmentation offload type to use based on L3 protocol type. It calls g_assert_not_reached if L3 protocol is unknown, making the following return statement unreachable. Remove the g_assert call, as it maybe triggered by a guest user.
--- net/eth.c | 3 --- 1 file changed, 3 deletions(-)
net/eth.c +0 -3
@@ -72,9 +72,6 @@ eth_get_gso_type(uint16_t l3_proto, uint8_t *l3_hdr, uint8_t l4proto) } } -/* Unsupported offload */ -g_assert_not_reached (); -return VIRTIO_NET_HDR_GSO_NONE | ecn_state; }
Signature · 1 line
2.26.2
Quoted 18 lines · P J P
From: Prasad J Pandit <[email protected]>
eth_get_gso_type()routine returns segmentation offload type to use based on L3 protocol type. It callsg_assert_not_reachedif L3 protocol is unknown, making the following return statement unreachable. Remove theg_assertcall, as it maybe triggered by a guest user.Reported-by Gaoning Pan <[email protected]>Signed-off-by Prasad J Pandit <[email protected]>--- net/eth.c | 3 --- 1 file changed, 3 deletions(-)net/eth.c +0
-0
net/eth.c eth_get_gso_type(uint16_t l3_proto, uint8_t *l3_hdr, uint8_t l4proto) · line 76
Quoted 5 lines
net/eth.c +0
-2@@ -72,9 +72,6 @@ eth_get_gso_type(uint16_t l3_proto, uint8_t *l3_hdr, uint8_t l4proto) } } -/* Unsupported offload */ -g_assert_not_reached ();
Maybe LOG_UNIMP with useful fields, so when user send bug report we directly know what has to be implemented.
Quoted 5 lines
net/eth.c +0
-1-return VIRTIO_NET_HDR_GSO_NONE | ecn_state; }
+-- On Tue, 20 Oct 2020, Philippe Mathieu-Daudé wrote --+ | Maybe LOG_UNIMP with useful fields, so when user send bug report we directly | know what has to be implemented.
qemu_log("Probably not GSO frame, unknown L3 protocol: %hd\n", l3_proto);Maybe just qemu_log()? LOG_UNIMP seems mismatching.
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
8685 545E B54C 486B C6EB 271E E285 8B5A F050 DE8D