Skip to contentSkip to conversation

eal/windows: fix missing header inclusion

PATCH Applied Tal Shnaiderman 3 participants 3 messages Oct 20, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 eal/windows: fix missing header inclusion

Following the addition of the in_addr/in6_addr structs to in.h the header file must have stdint.h included for the definitions of the uint8_t/uint32_t types used within the new structs.

Not having it could results in the following errors in places where in.h is included:

in.h:30:2: error: unknown type name 'uint32_t'

        uint32_t s_addr;

in.h:34:2: error: unknown type name 'uint8_t'

        uint8_t s6_addr[16];
Fixes f40a74cfcf0 ("eal/windows: improve compatibility networking headers")
---
 lib/librte_eal/windows/include/netinet/in.h | 1 +
 1 file changed, 1 insertion(+)
lib/librte_eal/windows/include/netinet/in.h +1 -0
index be1469ec11..6455b9ba51 100644
@@ -5,6 +5,7 @@
 #ifndef _IN_H_
 #define _IN_H_
 
+#include <stdint.h>
 #include <sys/socket.h>
 
 #define IPPROTO_IP         0
Signature · 1 line
2.16.1.windows.4
Acked-by on v1 1/1
#1 lore raw
Quoted 27 lines · Tal Shnaiderman

Following the addition of the in_addr/in6_addr structs to in.h the header file must have stdint.h included for the definitions of the uint8_t/uint32_t types used within the new structs.

Not having it could results in the following errors in places where in.h is included:

in.h:30:2: error: unknown type name 'uint32_t'

        uint32_t s_addr;

in.h:34:2: error: unknown type name 'uint8_t'

        uint8_t s6_addr[16];
Fixes f40a74cfcf0 ("eal/windows: improve compatibility networking headers")
---
 lib/librte_eal/windows/include/netinet/in.h | 1 +
 1 file changed, 1 insertion(+)
lib/librte_eal/windows/include/netinet/in.h +0 -0
index be1469ec11..6455b9ba51 100644

lib/librte_eal/windows/include/netinet/in.h line 11

Quoted 7 lines
lib/librte_eal/windows/include/netinet/in.h +1 -0
@@ -5,6 +5,7 @@
 #ifndef _IN_H_
 #define _IN_H_
 
+#include <stdint.h>
 #include <sys/socket.h>
 
 #define IPPROTO_IP         0
#2 lore raw

20/10/2020 11:37, Dmitry Kozlyuk:

Quoted 9 lines · Tal Shnaiderman
Quoted 8 lines

Following the addition of the in_addr/in6_addr structs to in.h the header file must have stdint.h included for the definitions of the uint8_t/uint32_t types used within the new structs.

Not having it could results in the following errors in places where in.h is included:

Quoted 8 lines
Quoted 8 lines

in.h:30:2: error: unknown type name 'uint32_t'

        uint32_t s_addr;

in.h:34:2: error: unknown type name 'uint8_t'

        uint8_t s6_addr[16];
Fixes f40a74cfcf0 ("eal/windows: improve compatibility networking headers")

Removing [email protected] as the bug is only in current release.

Quoted 4 lines
Quoted 2 lines

Applied, thanks