Skip to contentSkip to conversation

config: fix kni build

PATCH Applied Bruce Richardson 2 participants 3 messages Oct 20, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 config: fix kni build

When building kernel modules such as kni, the "config" directory is not passed as a standard path in the EXTRA_CFLAGS value, meaning that the rte_compatibility_defines.h is not found from rte_config.h. However, since both headers are in the same directory, we can just use quotes rather than angle-brackets to ensure the second header is always found if the first is.

Fixes b0b672aeadaa ("build: add defines for compatibility with make build")
---
 config/rte_config.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
config/rte_config.h +1 -1
index f64b4d634..8aa46a1aa 100644
@@ -13,7 +13,7 @@
 #define _RTE_CONFIG_H_
 
 #include <rte_build_config.h>
-#include <rte_compatibility_defines.h>
+#include "rte_compatibility_defines.h"
 
 /* legacy defines */
 #ifdef RTE_EXEC_ENV_LINUX
Signature · 1 line
2.25.1
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Bruce Richardson

When building kernel modules such as kni, the "config" directory is not passed as a standard path in the EXTRA_CFLAGS value, meaning that the rte_compatibility_defines.h is not found from rte_config.h. However, since both headers are in the same directory, we can just use quotes rather than angle-brackets to ensure the second header is always found if the first is.

Fixes b0b672aeadaa ("build: add defines for compatibility with make build")
Signature · 1 line
David Marchand
#2 lore raw
Quoted 10 lines · David Marchand
Quoted 7 lines · Bruce Richardson

When building kernel modules such as kni, the "config" directory is not passed as a standard path in the EXTRA_CFLAGS value, meaning that the rte_compatibility_defines.h is not found from rte_config.h. However, since both headers are in the same directory, we can just use quotes rather than angle-brackets to ensure the second header is always found if the first is.

Quoted 4 lines
Quoted 3 lines
Fixes b0b672aeadaa ("build: add defines for compatibility with make build")

Applied, thanks.

Signature · 1 line
David Marchand