net/ixgbe fix unchecked return value and rte_panic
cover net/ixgbe fix unchecked return value and rte_panic
This patchset resolves a coverity issue where the return value of rte_eth_switch_domain_alloc() was not being checked and also removes a use of rte_panic within ixgbe_pf_host_init().
Conor Walsh (2):
net/ixgbe: fix unchecked return value
net/ixgbe: remove rte_panic
drivers/net/ixgbe/ixgbe_ethdev.c | 6 ++++-- drivers/net/ixgbe/ixgbe_ethdev.h | 2 +- drivers/net/ixgbe/ixgbe_pf.c | 23 ++++++++++++++++++----- 3 files changed, 23 insertions(+), 8 deletions(-)
Signature · 1 line
2.25.1
PATCH 1/2 net/ixgbe: fix unchecked return value
The return value of rte_eth_switch_domain_alloc() was not being checked within ixgbe_pf_host_init() which caused a coverity issue. If the call fails a warning is logged using PMD_INIT_LOG() and *vfinfo is free'd. ixgbe_pf_host_init() now has a return value which is checked in eth_ixgbe_dev_init()
Coverity issue: 362795
--- drivers/net/ixgbe/ixgbe_ethdev.c | 6 ++++-- drivers/net/ixgbe/ixgbe_ethdev.h | 2 +- drivers/net/ixgbe/ixgbe_pf.c | 16 +++++++++++++--- 3 files changed, 18 insertions(+), 6 deletions(-)
drivers/net/ixgbe/ixgbe_ethdev.c +4 -2
@@ -1077,7 +1077,7 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)IXGBE_DEV_PRIVATE_TO_BW_CONF (eth_dev->data->dev_private);uint32_t ctrl_ext;uint16_t csum; -int diag, i; +int diag, i, ret;PMD_INIT_FUNC_TRACE ();
@@ -1256,7 +1256,9 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)memset (hwstrip,0 ,sizeof (*hwstrip));/* initialize PF if max_vfs not zero */ -ixgbe_pf_host_init (eth_dev); + ret =ixgbe_pf_host_init (eth_dev); +if (ret) +return ret; ctrl_ext =IXGBE_READ_REG (hw,IXGBE_CTRL_EXT );/* let hardware know driver is loaded */
drivers/net/ixgbe/ixgbe_ethdev.h +1 -1
@@ -717,7 +717,7 @@ void ixgbe_vlan_hw_filter_disable(struct rte_eth_dev *dev);void ixgbe_vlan_hw_strip_config (struct rte_eth_dev *dev); -void ixgbe_pf_host_init (struct rte_eth_dev *eth_dev); +int ixgbe_pf_host_init (struct rte_eth_dev *eth_dev);void ixgbe_pf_host_uninit (struct rte_eth_dev *eth_dev);
drivers/net/ixgbe/ixgbe_pf.c +13 -3
@@ -66,7 +66,7 @@ ixgbe_mb_intr_setup(struct rte_eth_dev *dev)return 0 ; } -void ixgbe_pf_host_init (struct rte_eth_dev *eth_dev) +int ixgbe_pf_host_init (struct rte_eth_dev *eth_dev) {struct ixgbe_vf_info **vfinfo =IXGBE_DEV_PRIVATE_TO_P_VFDATA (eth_dev->data->dev_private);
@@ -78,19 +78,27 @@ void ixgbe_pf_host_init(struct rte_eth_dev *eth_dev)IXGBE_DEV_PRIVATE_TO_HW (eth_dev->data->dev_private);uint16_t vf_num;uint8_t nb_queue; +int ret =0 ;PMD_INIT_FUNC_TRACE ();RTE_ETH_DEV_SRIOV (eth_dev).active =0 ; vf_num =dev_num_vf (eth_dev);if (vf_num ==0 ) -return ; +return ret; *vfinfo =rte_zmalloc ("vf_info" ,sizeof (struct ixgbe_vf_info ) * vf_num,0 );if (*vfinfo ==NULL )rte_panic ("Cannot allocate memory for private VF data\n" ); -rte_eth_switch_domain_alloc (&(*vfinfo)->switch_domain_id); + ret =rte_eth_switch_domain_alloc (&(*vfinfo)->switch_domain_id); +if (ret) { +PMD_INIT_LOG (ERR , +"failed to allocate switch domain for device %d" , ret); +rte_free (*vfinfo); + *vfinfo =NULL ; +return ret; + }memset (mirror_info,0 ,sizeof (struct ixgbe_mirror_info ));memset (uta_info,0 ,sizeof (struct ixgbe_uta_info ));
@@ -118,6 +126,8 @@ void ixgbe_pf_host_init(struct rte_eth_dev *eth_dev)/* set mb interrupt mask */ ixgbe_mb_intr_setup (eth_dev); + +return ret; }void ixgbe_pf_host_uninit (struct rte_eth_dev *eth_dev)
Signature · 1 line
2.25.1
Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix unchecked return value
Quoted 39 lines
-----Original Message-----
From: Walsh, Conor <[email protected]>
Sent: Monday, October 19, 2020 20:26
To: Guo, Jia <[email protected]>; Wang, Haiyue <[email protected]>; Yigit, Ferruh <[email protected]>; Awal, Mohammad Abdul <[email protected]>; Doherty, Declan <[email protected]>
Cc: [email protected]; Walsh, Conor <[email protected]>
Subject: [PATCH 1/2] net/ixgbe: fix unchecked return valueThe return value of
rte_eth_switch_domain_alloc()was not being checked withinixgbe_pf_host_init()which caused a coverity issue. If the call fails a warning is logged usingPMD_INIT_LOG()and *vfinfo is free'd.ixgbe_pf_host_init()now has a return value which is checked ineth_ixgbe_dev_init()Coverity issue: 362795
Fixes cf80ba6e2038 ("net/ixgbe: add support for representor ports")Signed-off-by Conor Walsh <[email protected]>--- drivers/net/ixgbe/ixgbe_ethdev.c | 6 ++++-- drivers/net/ixgbe/ixgbe_ethdev.h | 2 +- drivers/net/ixgbe/ixgbe_pf.c | 16 +++++++++++++--- 3 files changed, 18 insertions(+), 6 deletions(-)drivers/net/ixgbe/ixgbe_ethdev.c +1
-1@@ -1077,7 +1077,7 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)IXGBE_DEV_PRIVATE_TO_BW_CONF (eth_dev->data->dev_private);uint32_t ctrl_ext;uint16_t csum; -int diag, i; +int diag, i, ret;PMD_INIT_FUNC_TRACE ();
drivers/net/ixgbe/ixgbe_ethdev.c eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused) · line 1262
Quoted 8 lines
drivers/net/ixgbe/ixgbe_ethdev.c +3
-1@@ -1256,7 +1256,9 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)memset (hwstrip,0 ,sizeof (*hwstrip));/* initialize PF if max_vfs not zero */ -ixgbe_pf_host_init (eth_dev); + ret =ixgbe_pf_host_init (eth_dev); +if (ret) +return ret;
Seems that just return is not enough, the eth_dev->data->mac_addrs and eth_dev->data->hash_mac_addrs also needs to be freed, please refer to ' ice_dev_init':
static intice_dev_init(struct rte_eth_dev *dev)
rte_free(dev->data->mac_addrs); dev->data->mac_addrs = NULL;
Quoted 2 lines
drivers/net/ixgbe/ixgbe_ethdev.c +0
-1--2.25.1
Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix unchecked return value
Thanks Haiyue,
I will implement a v2, following your suggestions.
/Conor.
Quoted 77 lines
-----Original Message-----
From: Wang, Haiyue <[email protected]>
Sent: Tuesday 20 October 2020 09:34
To: Walsh, Conor <[email protected]>; Guo, Jia <[email protected]>; Yigit, Ferruh <[email protected]>; Awal, Mohammad Abdul <[email protected]>; Doherty, Declan <[email protected]>
Cc: [email protected]
Subject: RE: [PATCH 1/2] net/ixgbe: fix unchecked return valueQuoted 4 lines
-----Original Message-----
From: Walsh, Conor <[email protected]>
Sent: Monday, October 19, 2020 20:26
To: Guo, Jia <[email protected]>; Wang, Haiyue<[email protected]>; Yigit, Ferruh
Quoted 1 line
<[email protected]>; Awal, Mohammad Abdul
<[email protected]>; Doherty, Declan
Quoted 13 lines
<[email protected]>
Cc: [email protected]; Walsh, Conor <[email protected]>
Subject: [PATCH 1/2] net/ixgbe: fix unchecked return valueThe return value of
rte_eth_switch_domain_alloc()was not being checked withinixgbe_pf_host_init()which caused a coverity issue. If the call fails a warning is logged usingPMD_INIT_LOG()and *vfinfo is free'd.ixgbe_pf_host_init()now has a return value which is checked ineth_ixgbe_dev_init()Coverity issue: 362795
Fixes cf80ba6e2038 ("net/ixgbe: add support for representor ports")Review
Quoted 8 lines
Signed-off-by Conor Walsh <[email protected]>--- drivers/net/ixgbe/ixgbe_ethdev.c | 6 ++++-- drivers/net/ixgbe/ixgbe_ethdev.h | 2 +- drivers/net/ixgbe/ixgbe_pf.c | 16 +++++++++++++--- 3 files changed, 18 insertions(+), 6 deletions(-)(quoted diff) +0
-0
b/drivers/net/ixgbe/ixgbe_ethdev.cdrivers/net/ixgbe/ixgbe_ethdev.c eth_ixgbe_dev_init(struct rte_eth_dev
Quoted 4 lines
index
14a254ab74..49ff523ea8100644drivers/net/ixgbe/ixgbe_ethdev.c +0
-0@@ -1077,7 +1077,7 @@ eth_ixgbe_dev_init(struct rte_eth_dev
*eth_dev, void*init_params__rte_unused)drivers/net/ixgbe/ixgbe_ethdev.c eth_ixgbe_dev_init(struct rte_eth_dev
Quoted 10 lines
drivers/net/ixgbe/ixgbe_ethdev.c +1
-1IXGBE_DEV_PRIVATE_TO_BW_CONF (eth_dev->data- dev_private);uint32_t ctrl_ext;uint16_t csum; -int diag, i; +int diag, i, ret;PMD_INIT_FUNC_TRACE ();@@ -1256,7 +1256,9 @@ eth_ixgbe_dev_init(struct rte_eth_dev
*eth_dev, void*init_params__rte_unused)drivers/net/ixgbe/ixgbe_ethdev.c eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused) · line 1262
Quoted 8 lines
drivers/net/ixgbe/ixgbe_ethdev.c +3
-1memset (hwstrip,0 ,sizeof (*hwstrip));/* initialize PF if max_vfs not zero */ -ixgbe_pf_host_init (eth_dev); + ret =ixgbe_pf_host_init (eth_dev); +if (ret) +return ret;Seems that just return is not enough, the
eth_dev->data->mac_addrsandeth_dev->data->hash_mac_addrs
also needs to be freed, please refer to 'ice_dev_init':static int
ice_dev_init(struct rte_eth_dev *dev)rte_free(dev->data->mac_addrs); dev->data->mac_addrs = NULL;Quoted 2 lines
drivers/net/ixgbe/ixgbe_ethdev.c +0
-1--2.25.1
PATCH 2/2 net/ixgbe: remove rte_panic
In reply to Conor WalshRemove the usage of rte_panic() within ixgbe_pf_host_init()
--- drivers/net/ixgbe/ixgbe_pf.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/net/ixgbe/ixgbe_pf.c +5 -2
@@ -88,8 +88,11 @@ int ixgbe_pf_host_init(struct rte_eth_dev *eth_dev)return ret; *vfinfo =rte_zmalloc ("vf_info" ,sizeof (struct ixgbe_vf_info ) * vf_num,0 ); -if (*vfinfo ==NULL ) -rte_panic ("Cannot allocate memory for private VF data\n" ); +if (*vfinfo ==NULL ) { +PMD_INIT_LOG (ERR , +"Cannot allocate memory for private VF data" ); +return -ENOMEM ; + } ret =rte_eth_switch_domain_alloc (&(*vfinfo)->switch_domain_id);if (ret) {
Signature · 1 line
2.25.1
v2 cover net/ixgbe fix unchecked return value and rte_panic
In reply to Conor WalshThis patchset resolves a coverity issue where the return value of rte_eth_switch_domain_alloc() was not being checked and also removes a use of rte_panic within ixgbe_pf_host_init().
---
v2: eth_dev->data->mac_addrs and eth_dev->data->hash_mac_addrs will now be free'd if ixgbe_pf_host_init() fails in eth_ixgbe_dev_init()
Conor Walsh (2):
net/ixgbe: fix unchecked return value
net/ixgbe: remove rte_panic
drivers/net/ixgbe/ixgbe_ethdev.c | 11 +++++++++-- drivers/net/ixgbe/ixgbe_ethdev.h | 2 +- drivers/net/ixgbe/ixgbe_pf.c | 23 ++++++++++++++++++----- 3 files changed, 28 insertions(+), 8 deletions(-)
Signature · 1 line
2.25.1
PATCH v2 1/2 net/ixgbe: fix unchecked return value
The return value of rte_eth_switch_domain_alloc() was not being checked within ixgbe_pf_host_init() which caused a coverity issue. If the call fails a warning is logged using PMD_INIT_LOG() and *vfinfo is free'd. ixgbe_pf_host_init() now has a return value which is checked in eth_ixgbe_dev_init()
Coverity issue: 362795
--- drivers/net/ixgbe/ixgbe_ethdev.c | 11 +++++++++-- drivers/net/ixgbe/ixgbe_ethdev.h | 2 +- drivers/net/ixgbe/ixgbe_pf.c | 16 +++++++++++++--- 3 files changed, 23 insertions(+), 6 deletions(-)
drivers/net/ixgbe/ixgbe_ethdev.c +9 -2
@@ -1077,7 +1077,7 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)IXGBE_DEV_PRIVATE_TO_BW_CONF (eth_dev->data->dev_private);uint32_t ctrl_ext;uint16_t csum; -int diag, i; +int diag, i, ret;PMD_INIT_FUNC_TRACE ();
@@ -1256,7 +1256,14 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)memset (hwstrip,0 ,sizeof (*hwstrip));/* initialize PF if max_vfs not zero */ -ixgbe_pf_host_init (eth_dev); + ret =ixgbe_pf_host_init (eth_dev); +if (ret) { +rte_free (eth_dev->data->mac_addrs); + eth_dev->data->mac_addrs =NULL ; +rte_free (eth_dev->data->hash_mac_addrs); + eth_dev->data->hash_mac_addrs =NULL ; +return ret; + } ctrl_ext =IXGBE_READ_REG (hw,IXGBE_CTRL_EXT );/* let hardware know driver is loaded */
drivers/net/ixgbe/ixgbe_ethdev.h +1 -1
@@ -717,7 +717,7 @@ void ixgbe_vlan_hw_filter_disable(struct rte_eth_dev *dev);void ixgbe_vlan_hw_strip_config (struct rte_eth_dev *dev); -void ixgbe_pf_host_init (struct rte_eth_dev *eth_dev); +int ixgbe_pf_host_init (struct rte_eth_dev *eth_dev);void ixgbe_pf_host_uninit (struct rte_eth_dev *eth_dev);
drivers/net/ixgbe/ixgbe_pf.c +13 -3
@@ -66,7 +66,7 @@ ixgbe_mb_intr_setup(struct rte_eth_dev *dev)return 0 ; } -void ixgbe_pf_host_init (struct rte_eth_dev *eth_dev) +int ixgbe_pf_host_init (struct rte_eth_dev *eth_dev) {struct ixgbe_vf_info **vfinfo =IXGBE_DEV_PRIVATE_TO_P_VFDATA (eth_dev->data->dev_private);
@@ -78,19 +78,27 @@ void ixgbe_pf_host_init(struct rte_eth_dev *eth_dev)IXGBE_DEV_PRIVATE_TO_HW (eth_dev->data->dev_private);uint16_t vf_num;uint8_t nb_queue; +int ret =0 ;PMD_INIT_FUNC_TRACE ();RTE_ETH_DEV_SRIOV (eth_dev).active =0 ; vf_num =dev_num_vf (eth_dev);if (vf_num ==0 ) -return ; +return ret; *vfinfo =rte_zmalloc ("vf_info" ,sizeof (struct ixgbe_vf_info ) * vf_num,0 );if (*vfinfo ==NULL )rte_panic ("Cannot allocate memory for private VF data\n" ); -rte_eth_switch_domain_alloc (&(*vfinfo)->switch_domain_id); + ret =rte_eth_switch_domain_alloc (&(*vfinfo)->switch_domain_id); +if (ret) { +PMD_INIT_LOG (ERR , +"failed to allocate switch domain for device %d" , ret); +rte_free (*vfinfo); + *vfinfo =NULL ; +return ret; + }memset (mirror_info,0 ,sizeof (struct ixgbe_mirror_info ));memset (uta_info,0 ,sizeof (struct ixgbe_uta_info ));
@@ -118,6 +126,8 @@ void ixgbe_pf_host_init(struct rte_eth_dev *eth_dev)/* set mb interrupt mask */ ixgbe_mb_intr_setup (eth_dev); + +return ret; }void ixgbe_pf_host_uninit (struct rte_eth_dev *eth_dev)
Signature · 1 line
2.25.1
Re: [dpdk-dev] [PATCH v2 1/2] net/ixgbe: fix unchecked return value
Quoted 16 lines
-----Original Message-----
From: Walsh, Conor <[email protected]>
Sent: Tuesday, October 20, 2020 18:03
To: Guo, Jia <[email protected]>; Wang, Haiyue <[email protected]>; Yigit, Ferruh <[email protected]>; Awal, Mohammad Abdul <[email protected]>; Doherty, Declan <[email protected]>; [email protected]
Cc: [email protected]; Walsh, Conor <[email protected]>
Subject: [PATCH v2 1/2] net/ixgbe: fix unchecked return valueThe return value of
rte_eth_switch_domain_alloc()was not being checked withinixgbe_pf_host_init()which caused a coverity issue. If the call fails a warning is logged usingPMD_INIT_LOG()and *vfinfo is free'd.ixgbe_pf_host_init()now has a return value which is checked ineth_ixgbe_dev_init()Coverity issue: 362795
Quoted 8 lines
Fixes cf80ba6e2038 ("net/ixgbe: add support for representor ports")Signed-off-by Conor Walsh <[email protected]>--- drivers/net/ixgbe/ixgbe_ethdev.c | 11 +++++++++-- drivers/net/ixgbe/ixgbe_ethdev.h | 2 +- drivers/net/ixgbe/ixgbe_pf.c | 16 +++++++++++++--- 3 files changed, 23 insertions(+), 6 deletions(-)
Quoted 2 lines
--
2.25.1
Zhang, Qi Z
AppliedRe: [dpdk-dev] [PATCH v2 1/2] net/ixgbe: fix unchecked return value
Quoted 31 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Wang, Haiyue
Sent: Wednesday, October 21, 2020 1:06 AM
To: Walsh, Conor <[email protected]>; Guo, Jia <[email protected]>; Yigit, Ferruh <[email protected]>; Awal, Mohammad Abdul <[email protected]>; Doherty, Declan <[email protected]>; [email protected]
Cc: [email protected]
Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/ixgbe: fix unchecked return valueQuoted 19 lines
-----Original Message-----
From: Walsh, Conor <[email protected]>
Sent: Tuesday, October 20, 2020 18:03
To: Guo, Jia <[email protected]>; Wang, Haiyue <[email protected]>; Yigit, Ferruh <[email protected]>; Awal, Mohammad Abdul <[email protected]>; Doherty, Declan <[email protected]>; [email protected]
Cc: [email protected]; Walsh, Conor <[email protected]>
Subject: [PATCH v2 1/2] net/ixgbe: fix unchecked return valueThe return value of
rte_eth_switch_domain_alloc()was not being checked withinixgbe_pf_host_init()which caused a coverity issue. If the call fails a warning is logged usingPMD_INIT_LOG()and *vfinfo is free'd.ixgbe_pf_host_init()now has a return value which is checked ineth_ixgbe_dev_init()Coverity issue: 362795
Fixes cf80ba6e2038 ("net/ixgbe: add support for representor ports")
Quoted 8 lines
Quoted 6 lines
Signed-off-by Conor Walsh <[email protected]>--- drivers/net/ixgbe/ixgbe_ethdev.c | 11 +++++++++-- drivers/net/ixgbe/ixgbe_ethdev.h | 2 +- drivers/net/ixgbe/ixgbe_pf.c | 16 +++++++++++++--- 3 files changed, 23 insertions(+), 6 deletions(-)Acked-by Haiyue Wang <[email protected]>
Applied to dpdk-next-net-intel.
Thanks
Qi
PATCH v2 2/2 net/ixgbe: remove rte_panic
In reply to Conor WalshRemove the usage of rte_panic() within ixgbe_pf_host_init()
--- drivers/net/ixgbe/ixgbe_pf.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/net/ixgbe/ixgbe_pf.c +5 -2
@@ -88,8 +88,11 @@ int ixgbe_pf_host_init(struct rte_eth_dev *eth_dev)return ret; *vfinfo =rte_zmalloc ("vf_info" ,sizeof (struct ixgbe_vf_info ) * vf_num,0 ); -if (*vfinfo ==NULL ) -rte_panic ("Cannot allocate memory for private VF data\n" ); +if (*vfinfo ==NULL ) { +PMD_INIT_LOG (ERR , +"Cannot allocate memory for private VF data" ); +return -ENOMEM ; + } ret =rte_eth_switch_domain_alloc (&(*vfinfo)->switch_domain_id);if (ret) {
Signature · 1 line
2.25.1
Re: [dpdk-dev] [PATCH v2 2/2] net/ixgbe: remove rte_panic
Quoted 9 lines
-----Original Message-----
From: Walsh, Conor <[email protected]>
Sent: Tuesday, October 20, 2020 18:03
To: Guo, Jia <[email protected]>; Wang, Haiyue <[email protected]>; Yigit, Ferruh <[email protected]>; Awal, Mohammad Abdul <[email protected]>; Doherty, Declan <[email protected]>; [email protected]
Cc: [email protected]; Walsh, Conor <[email protected]>
Subject: [PATCH v2 2/2] net/ixgbe: removerte_panic
Quoted 7 lines
Remove the usage of
rte_panic()withinixgbe_pf_host_init()Signed-off-by Conor Walsh <[email protected]>--- drivers/net/ixgbe/ixgbe_pf.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
Quoted 2 lines
--
2.25.1
Zhang, Qi Z
AppliedRe: [dpdk-dev] [PATCH v2 2/2] net/ixgbe: remove rte_panic
Quoted 24 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Wang, Haiyue
Sent: Wednesday, October 21, 2020 1:06 AM
To: Walsh, Conor <[email protected]>; Guo, Jia <[email protected]>; Yigit, Ferruh <[email protected]>; Awal, Mohammad Abdul <[email protected]>; Doherty, Declan <[email protected]>; [email protected]
Cc: [email protected]
Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/ixgbe: removerte_panicQuoted 12 lines
-----Original Message-----
From: Walsh, Conor <[email protected]>
Sent: Tuesday, October 20, 2020 18:03
To: Guo, Jia <[email protected]>; Wang, Haiyue <[email protected]>; Yigit, Ferruh <[email protected]>; Awal, Mohammad Abdul <[email protected]>; Doherty, Declan <[email protected]>; [email protected]
Cc: [email protected]; Walsh, Conor <[email protected]>
Subject: [PATCH v2 2/2] net/ixgbe: removerte_panicRemove the usage of
rte_panic()withinixgbe_pf_host_init()
Quoted 7 lines
Quoted 5 lines
Signed-off-by Conor Walsh <[email protected]>--- drivers/net/ixgbe/ixgbe_pf.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)Acked-by Haiyue Wang <[email protected]>
Applied to dpdk-next-net-intel.
Thanks
Qi
Quoted 3 lines
Quoted 3 lines
--
2.25.1