Skip to contentSkip to conversation

drm/i915/pmu: Handle PCI unbind

PATCH In review Tvrtko Ursulin 3 participants 14 messages Oct 20, 2020 – Oct 22, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 drm/i915/pmu: Handle PCI unbind

From: Tvrtko Ursulin <[email protected]>

Mark the device as closed and keep references to driver data alive to allow for safe driver unbind with active PMU clients. Perf core does not otherwise handle this case so we have to do it manually like this.

---
 drivers/gpu/drm/i915/i915_pmu.c | 39 +++++++++++++++++++++++++++++++--
 drivers/gpu/drm/i915/i915_pmu.h |  4 ++++
 2 files changed, 41 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_pmu.c +37 -2
index 69c0fa20eba1..51ed7d0efcdc 100644
@@ -445,6 +445,8 @@ static void i915_pmu_event_destroy(struct perf_event *event)
 		container_of(event->pmu, typeof(*i915), pmu.base);
 
 	drm_WARN_ON(&i915->drm, event->parent);
+
+	drm_dev_put(&i915->drm);
 }
 
 static int
@@ -510,8 +512,12 @@ static int i915_pmu_event_init(struct perf_event *event)
 {
 	struct drm_i915_private *i915 =
 		container_of(event->pmu, typeof(*i915), pmu.base);
+	struct i915_pmu *pmu = &i915->pmu;
 	int ret;
 
+	if (pmu->closed)
+		return -ENODEV;
+
 	if (event->attr.type != event->pmu->type)
 		return -ENOENT;
 
@@ -536,8 +542,10 @@ static int i915_pmu_event_init(struct perf_event *event)
 	if (ret)
 		return ret;
 
-	if (!event->parent)
+	if (!event->parent) {
+		drm_dev_get(&i915->drm);
 		event->destroy = i915_pmu_event_destroy;
+	}
 
 	return 0;
 }
@@ -594,9 +602,16 @@ static u64 __i915_pmu_event_read(struct perf_event *event)
 
 static void i915_pmu_event_read(struct perf_event *event)
 {
+	struct drm_i915_private *i915 =
+		container_of(event->pmu, typeof(*i915), pmu.base);
 	struct hw_perf_event *hwc = &event->hw;
+	struct i915_pmu *pmu = &i915->pmu;
 	u64 prev, new;
 
+	if (pmu->closed) {
+		event->hw.state = PERF_HES_STOPPED;
+		return;
+	}
 again:
 	prev = local64_read(&hwc->prev_count);
 	new = __i915_pmu_event_read(event);
@@ -724,6 +739,13 @@ static void i915_pmu_disable(struct perf_event *event)
 
 static void i915_pmu_event_start(struct perf_event *event, int flags)
 {
+	struct drm_i915_private *i915 =
+		container_of(event->pmu, typeof(*i915), pmu.base);
+	struct i915_pmu *pmu = &i915->pmu;
+
+	if (pmu->closed)
+		return;
+
 	i915_pmu_enable(event);
 	event->hw.state = 0;
 }
@@ -738,6 +760,13 @@ static void i915_pmu_event_stop(struct perf_event *event, int flags)
 
 static int i915_pmu_event_add(struct perf_event *event, int flags)
 {
+	struct drm_i915_private *i915 =
+		container_of(event->pmu, typeof(*i915), pmu.base);
+	struct i915_pmu *pmu = &i915->pmu;
+
+	if (pmu->closed)
+		return -ENODEV;
+
 	if (flags & PERF_EF_START)
 		i915_pmu_event_start(event, flags);
 
@@ -1167,7 +1196,13 @@ void i915_pmu_unregister(struct drm_i915_private *i915)
 	if (!pmu->base.event_init)
 		return;
 
-	drm_WARN_ON(&i915->drm, pmu->enable);
+	/*
+	 * "Disconnect" the PMU callbacks - since all are atomic synchronize_rcu
+	 * ensures all currently executing ones will have exited before we
+	 * proceed with unregistration.
+	 */
+	pmu->closed = true;
+	synchronize_rcu();
 
 	hrtimer_cancel(&pmu->timer);
 
drivers/gpu/drm/i915/i915_pmu.h +4 -0
index 941f0c14037c..59a0d19afb67 100644
@@ -49,6 +49,10 @@ struct i915_pmu {
 	 * @base: PMU base.
 	 */
 	struct pmu base;
+	/**
+	 * @closed: i915 is unregistering.
+	 */
+	bool closed;
 	/**
 	 * @name: Name as registered with perf core.
 	 */
Signature · 6 lines
2.25.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

PATCH 2/2 drm/i915/pmu: Fix CPU hotplug with multiple GPUs

From: Tvrtko Ursulin <[email protected]>

Since we keep a driver global mask of online CPUs and base the decision whether PMU needs to be migrated upon it, we need to make sure the migration is done for all registered PMUs (so GPUs).

To do this we need to track the current CPU for each PMU and base the decision on whether to migrate on a comparison between global and local state.

At the same time, since dynamic CPU hotplug notification slots are a scarce resource and given how we already register the multi instance type state, we can and should add multiple instance of the i915 PMU to this same state and not allocate a new one for every GPU.

v2:
* Use pr_notice. (Chris)

---
 drivers/gpu/drm/i915/i915_pci.c |  7 ++++-
 drivers/gpu/drm/i915/i915_pmu.c | 50 ++++++++++++++++++++-------------
 drivers/gpu/drm/i915/i915_pmu.h |  6 +++-
 3 files changed, 41 insertions(+), 22 deletions(-)
drivers/gpu/drm/i915/i915_pci.c +6 -1
index 27964ac0638a..a384f51c91c1 100644
@@ -1150,9 +1150,13 @@ static int __init i915_init(void)
 		return 0;
 	}
 
+	i915_pmu_init();
+
 	err = pci_register_driver(&i915_pci_driver);
-	if (err)
+	if (err) {
+		i915_pmu_exit();
 		return err;
+	}
 
 	i915_perf_sysctl_register();
 	return 0;
@@ -1166,6 +1170,7 @@ static void __exit i915_exit(void)
 	i915_perf_sysctl_unregister();
 	pci_unregister_driver(&i915_pci_driver);
 	i915_globals_exit();
+	i915_pmu_exit();
 }
 
 module_init(i915_init);
drivers/gpu/drm/i915/i915_pmu.c +30 -20

95 lines not on this page · raw message

drivers/gpu/drm/i915/i915_pmu.h +5 -1
index 59a0d19afb67..a24885ab415c 100644
@@ -43,7 +43,7 @@ struct i915_pmu {
 	 */
 	struct {
 		struct hlist_node node;
-		enum cpuhp_state slot;
+		unsigned int cpu;
 	} cpuhp;
 	/**
 	 * @base: PMU base.
@@ -126,11 +126,15 @@ struct i915_pmu {
 };
 
 #ifdef CONFIG_PERF_EVENTS
+void i915_pmu_init(void);
+void i915_pmu_exit(void);
 void i915_pmu_register(struct drm_i915_private *i915);
 void i915_pmu_unregister(struct drm_i915_private *i915);
 void i915_pmu_gt_parked(struct drm_i915_private *i915);
 void i915_pmu_gt_unparked(struct drm_i915_private *i915);
 #else
+static inline void i915_pmu_init(void) {}
+static inline void i915_pmu_exit(void) {}
 static inline void i915_pmu_register(struct drm_i915_private *i915) {}
 static inline void i915_pmu_unregister(struct drm_i915_private *i915) {}
 static inline void i915_pmu_gt_parked(struct drm_i915_private *i915) {}
Signature · 6 lines
2.25.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw

Re: [Intel-gfx] [PATCH 2/2] drm/i915/pmu: Fix CPU hotplug with multiple GPUs

Quoting Tvrtko Ursulin (2020-10-20 11:08:22)

Quoted 67 lines

From: Tvrtko Ursulin <[email protected]>

Since we keep a driver global mask of online CPUs and base the decision whether PMU needs to be migrated upon it, we need to make sure the migration is done for all registered PMUs (so GPUs).

To do this we need to track the current CPU for each PMU and base the decision on whether to migrate on a comparison between global and local state.

At the same time, since dynamic CPU hotplug notification slots are a scarce resource and given how we already register the multi instance type state, we can and should add multiple instance of the i915 PMU to this same state and not allocate a new one for every GPU.

v2:
* Use pr_notice. (Chris)

---
 drivers/gpu/drm/i915/i915_pci.c |  7 ++++-
 drivers/gpu/drm/i915/i915_pmu.c | 50 ++++++++++++++++++++-------------
 drivers/gpu/drm/i915/i915_pmu.h |  6 +++-
 3 files changed, 41 insertions(+), 22 deletions(-)
drivers/gpu/drm/i915/i915_pci.c +6 -1
index 27964ac0638a..a384f51c91c1 100644
@@ -1150,9 +1150,13 @@ static int __init i915_init(void)
                return 0;
        }
 
+       i915_pmu_init();
+
        err = pci_register_driver(&i915_pci_driver);
-       if (err)
+       if (err) {
+               i915_pmu_exit();
                return err;
+       }
 
        i915_perf_sysctl_register();
        return 0;
@@ -1166,6 +1170,7 @@ static void __exit i915_exit(void)
        i915_perf_sysctl_unregister();
        pci_unregister_driver(&i915_pci_driver);
        i915_globals_exit();
+       i915_pmu_exit();
 }
 
 module_init(i915_init);
drivers/gpu/drm/i915/i915_pmu.c +1 -0
index 51ed7d0efcdc..0d6c0945621e 100644
@@ -30,6 +30,7 @@
 #define ENGINE_SAMPLE_BITS (1 << I915_PMU_SAMPLE_BITS)
 
 static cpumask_t i915_pmu_cpumask;
+static unsigned int i915_pmu_target_cpu = -1;
 
 static u8 engine_config_sample(u64 config)
 {

drivers/gpu/drm/i915/i915_pmu.c static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node) · line 1053

Quoted 5 lines
drivers/gpu/drm/i915/i915_pmu.c +1 -1
@@ -1049,25 +1050,32 @@ static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node)
 static int i915_pmu_cpu_offline(unsigned int cpu, struct hlist_node *node)
 {
        struct i915_pmu *pmu = hlist_entry_safe(node, typeof(*pmu), cpuhp.node);
-       unsigned int target;
+       unsigned int target = i915_pmu_target_cpu;

So we still have multiple callbacks, one per pmu. But each callback is now stored in a list from the cpuhp_slot instead of each callback having its own slot.

drivers/gpu/drm/i915/i915_pmu.c static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node) · line 1057

Quoted 4 lines
drivers/gpu/drm/i915/i915_pmu.c +0 -0
        GEM_BUG_ON(!pmu->base.event_init);
 
        if (cpumask_test_and_clear_cpu(cpu, &i915_pmu_cpumask)) {

On first callback...

drivers/gpu/drm/i915/i915_pmu.c static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node) · line 1058

Quoted 1 line
drivers/gpu/drm/i915/i915_pmu.c +0 -0
                target = cpumask_any_but(topology_sibling_cpumask(cpu), cpu);

Pick any other cpu.

drivers/gpu/drm/i915/i915_pmu.c static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node) · line 1063

Quoted 6 lines
drivers/gpu/drm/i915/i915_pmu.c +2 -1
+
                /* Migrate events if there is a valid target */
                if (target < nr_cpu_ids) {
                        cpumask_set_cpu(target, &i915_pmu_cpumask);
-                       perf_pmu_migrate_context(&pmu->base, cpu, target);
+                       i915_pmu_target_cpu = target;

Store target for all callbacks.

drivers/gpu/drm/i915/i915_pmu.c static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node) · line 1067

Quoted 4 lines
drivers/gpu/drm/i915/i915_pmu.c +1 -0
                }
        }
 
+       if (target < nr_cpu_ids && target != pmu->cpuhp.cpu) {

If global [i915_pmu_target_cpu] target has changed, update perf.

drivers/gpu/drm/i915/i915_pmu.c static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node) · line 1069

Quoted 2 lines
drivers/gpu/drm/i915/i915_pmu.c +2 -0
+               perf_pmu_migrate_context(&pmu->base, cpu, target);
+               pmu->cpuhp.cpu = target;

It is claimed that cpuhp_state_remove_instance() will call the offline callback for all online cpus... Do we need a pmu->base.state != STOPPED guard?
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

Re: [Intel-gfx] [PATCH 2/2] drm/i915/pmu: Fix CPU hotplug with multiple GPUs

Quoting Chris Wilson (2020-10-20 12:59:57)

Quoted 103 lines

Quoting Tvrtko Ursulin (2020-10-20 11:08:22)

Quoted 67 lines

From: Tvrtko Ursulin <[email protected]>

Since we keep a driver global mask of online CPUs and base the decision whether PMU needs to be migrated upon it, we need to make sure the migration is done for all registered PMUs (so GPUs).

To do this we need to track the current CPU for each PMU and base the decision on whether to migrate on a comparison between global and local state.

At the same time, since dynamic CPU hotplug notification slots are a scarce resource and given how we already register the multi instance type state, we can and should add multiple instance of the i915 PMU to this same state and not allocate a new one for every GPU.

v2:
* Use pr_notice. (Chris)

---
 drivers/gpu/drm/i915/i915_pci.c |  7 ++++-
 drivers/gpu/drm/i915/i915_pmu.c | 50 ++++++++++++++++++++-------------
 drivers/gpu/drm/i915/i915_pmu.h |  6 +++-
 3 files changed, 41 insertions(+), 22 deletions(-)
drivers/gpu/drm/i915/i915_pci.c +6 -1
index 27964ac0638a..a384f51c91c1 100644
@@ -1150,9 +1150,13 @@ static int __init i915_init(void)
                return 0;
        }
 
+       i915_pmu_init();
+
        err = pci_register_driver(&i915_pci_driver);
-       if (err)
+       if (err) {
+               i915_pmu_exit();
                return err;
+       }
 
        i915_perf_sysctl_register();
        return 0;
@@ -1166,6 +1170,7 @@ static void __exit i915_exit(void)
        i915_perf_sysctl_unregister();
        pci_unregister_driver(&i915_pci_driver);
        i915_globals_exit();
+       i915_pmu_exit();
 }
 
 module_init(i915_init);
drivers/gpu/drm/i915/i915_pmu.c +1 -0
index 51ed7d0efcdc..0d6c0945621e 100644
@@ -30,6 +30,7 @@
 #define ENGINE_SAMPLE_BITS (1 << I915_PMU_SAMPLE_BITS)
 
 static cpumask_t i915_pmu_cpumask;
+static unsigned int i915_pmu_target_cpu = -1;
 
 static u8 engine_config_sample(u64 config)
 {

drivers/gpu/drm/i915/i915_pmu.c static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node) · line 1053

Quoted 5 lines
drivers/gpu/drm/i915/i915_pmu.c +1 -1
@@ -1049,25 +1050,32 @@ static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node)
 static int i915_pmu_cpu_offline(unsigned int cpu, struct hlist_node *node)
 {
        struct i915_pmu *pmu = hlist_entry_safe(node, typeof(*pmu), cpuhp.node);
-       unsigned int target;
+       unsigned int target = i915_pmu_target_cpu;

So we still have multiple callbacks, one per pmu. But each callback is now stored in a list from the cpuhp_slot instead of each callback having its own slot.

drivers/gpu/drm/i915/i915_pmu.c static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node) · line 1057

Quoted 4 lines
drivers/gpu/drm/i915/i915_pmu.c +0 -0
        GEM_BUG_ON(!pmu->base.event_init);
 
        if (cpumask_test_and_clear_cpu(cpu, &i915_pmu_cpumask)) {

On first callback...

drivers/gpu/drm/i915/i915_pmu.c static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node) · line 1058

Quoted 1 line
drivers/gpu/drm/i915/i915_pmu.c +0 -0
                target = cpumask_any_but(topology_sibling_cpumask(cpu), cpu);

Pick any other cpu.

drivers/gpu/drm/i915/i915_pmu.c static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node) · line 1063

Quoted 6 lines
drivers/gpu/drm/i915/i915_pmu.c +2 -1
+
                /* Migrate events if there is a valid target */
                if (target < nr_cpu_ids) {
                        cpumask_set_cpu(target, &i915_pmu_cpumask);
-                       perf_pmu_migrate_context(&pmu->base, cpu, target);
+                       i915_pmu_target_cpu = target;

Store target for all callbacks.

drivers/gpu/drm/i915/i915_pmu.c static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node) · line 1067

Quoted 4 lines
drivers/gpu/drm/i915/i915_pmu.c +1 -0
                }
        }
 
+       if (target < nr_cpu_ids && target != pmu->cpuhp.cpu) {
Quoted 8 lines

If global [i915_pmu_target_cpu] target has changed, update perf.

drivers/gpu/drm/i915/i915_pmu.c static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node) · line 1069

Quoted 2 lines
drivers/gpu/drm/i915/i915_pmu.c +2 -0
+               perf_pmu_migrate_context(&pmu->base, cpu, target);
+               pmu->cpuhp.cpu = target;

It is claimed that cpuhp_state_remove_instance() will call the offline callback for all online cpus... Do we need a pmu->base.state != STOPPED guard?

s/claimed/it definitely does :)/

Or rather pmu->closed.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

Re: [Intel-gfx] [PATCH 2/2] drm/i915/pmu: Fix CPU hotplug with multiple GPUs

Quoted 109 lines · Chris Wilson

Quoting Chris Wilson (2020-10-20 12:59:57)

Quoted 108 lines

Quoting Tvrtko Ursulin (2020-10-20 11:08:22)

Quoted 67 lines

From: Tvrtko Ursulin <[email protected]>

Since we keep a driver global mask of online CPUs and base the decision whether PMU needs to be migrated upon it, we need to make sure the migration is done for all registered PMUs (so GPUs).

To do this we need to track the current CPU for each PMU and base the decision on whether to migrate on a comparison between global and local state.

At the same time, since dynamic CPU hotplug notification slots are a scarce resource and given how we already register the multi instance type state, we can and should add multiple instance of the i915 PMU to this same state and not allocate a new one for every GPU.

v2:
* Use pr_notice. (Chris)

---
  drivers/gpu/drm/i915/i915_pci.c |  7 ++++-
  drivers/gpu/drm/i915/i915_pmu.c | 50 ++++++++++++++++++++-------------
  drivers/gpu/drm/i915/i915_pmu.h |  6 +++-
  3 files changed, 41 insertions(+), 22 deletions(-)
drivers/gpu/drm/i915/i915_pci.c +6 -1
index 27964ac0638a..a384f51c91c1 100644
@@ -1150,9 +1150,13 @@ static int __init i915_init(void)
                 return 0;
         }
 
+       i915_pmu_init();
+
         err = pci_register_driver(&i915_pci_driver);
-       if (err)
+       if (err) {
+               i915_pmu_exit();
                 return err;
+       }
 
         i915_perf_sysctl_register();
         return 0;
@@ -1166,6 +1170,7 @@ static void __exit i915_exit(void)
         i915_perf_sysctl_unregister();
         pci_unregister_driver(&i915_pci_driver);
         i915_globals_exit();
+       i915_pmu_exit();
  }
 
  module_init(i915_init);
drivers/gpu/drm/i915/i915_pmu.c +1 -0
index 51ed7d0efcdc..0d6c0945621e 100644
@@ -30,6 +30,7 @@
  #define ENGINE_SAMPLE_BITS (1 << I915_PMU_SAMPLE_BITS)
 
  static cpumask_t i915_pmu_cpumask;
+static unsigned int i915_pmu_target_cpu = -1;
 
  static u8 engine_config_sample(u64 config)
  {

drivers/gpu/drm/i915/i915_pmu.c static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node) · line 1053

Quoted 5 lines
drivers/gpu/drm/i915/i915_pmu.c +1 -1
@@ -1049,25 +1050,32 @@ static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node)
  static int i915_pmu_cpu_offline(unsigned int cpu, struct hlist_node *node)
  {
         struct i915_pmu *pmu = hlist_entry_safe(node, typeof(*pmu), cpuhp.node);
-       unsigned int target;
+       unsigned int target = i915_pmu_target_cpu;

So we still have multiple callbacks, one per pmu. But each callback is now stored in a list from the cpuhp_slot instead of each callback having its own slot.

drivers/gpu/drm/i915/i915_pmu.c static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node) · line 1057

Quoted 4 lines
drivers/gpu/drm/i915/i915_pmu.c +0 -0
         GEM_BUG_ON(!pmu->base.event_init);
 
         if (cpumask_test_and_clear_cpu(cpu, &i915_pmu_cpumask)) {

On first callback...

drivers/gpu/drm/i915/i915_pmu.c static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node) · line 1058

Quoted 1 line
drivers/gpu/drm/i915/i915_pmu.c +0 -0
                 target = cpumask_any_but(topology_sibling_cpumask(cpu), cpu);

Pick any other cpu.

drivers/gpu/drm/i915/i915_pmu.c static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node) · line 1063

Quoted 6 lines
drivers/gpu/drm/i915/i915_pmu.c +2 -1
+
                 /* Migrate events if there is a valid target */
                 if (target < nr_cpu_ids) {
                         cpumask_set_cpu(target, &i915_pmu_cpumask);
-                       perf_pmu_migrate_context(&pmu->base, cpu, target);
+                       i915_pmu_target_cpu = target;

Store target for all callbacks.

drivers/gpu/drm/i915/i915_pmu.c static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node) · line 1067

Quoted 4 lines
drivers/gpu/drm/i915/i915_pmu.c +1 -0
                 }
         }
 
+       if (target < nr_cpu_ids && target != pmu->cpuhp.cpu) {

If global [i915_pmu_target_cpu] target has changed, update perf.

Quoted 2 lines
drivers/gpu/drm/i915/i915_pmu.c +2 -0
+               perf_pmu_migrate_context(&pmu->base, cpu, target);
+               pmu->cpuhp.cpu = target;
Quoted 7 lines
Quoted 3 lines

It is claimed that cpuhp_state_remove_instance() will call the offline callback for all online cpus... Do we need a pmu->base.state != STOPPED guard?

s/claimed/it definitely does :)/

Or rather pmu->closed.

Hm why? You think perf_pmu_migrate_context accesses something in the PMU outside of the already protected entry points?

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

Re: [Intel-gfx] [PATCH 2/2] drm/i915/pmu: Fix CPU hotplug with multiple GPUs

Quoting Tvrtko Ursulin (2020-10-20 13:33:12)

Quoted 115 lines · Chris Wilson
Quoted 113 lines

Quoting Chris Wilson (2020-10-20 12:59:57)

Quoted 111 lines

Quoting Tvrtko Ursulin (2020-10-20 11:08:22)

Quoted 67 lines

From: Tvrtko Ursulin <[email protected]>

Since we keep a driver global mask of online CPUs and base the decision whether PMU needs to be migrated upon it, we need to make sure the migration is done for all registered PMUs (so GPUs).

To do this we need to track the current CPU for each PMU and base the decision on whether to migrate on a comparison between global and local state.

At the same time, since dynamic CPU hotplug notification slots are a scarce resource and given how we already register the multi instance type state, we can and should add multiple instance of the i915 PMU to this same state and not allocate a new one for every GPU.

v2:
* Use pr_notice. (Chris)

---
  drivers/gpu/drm/i915/i915_pci.c |  7 ++++-
  drivers/gpu/drm/i915/i915_pmu.c | 50 ++++++++++++++++++++-------------
  drivers/gpu/drm/i915/i915_pmu.h |  6 +++-
  3 files changed, 41 insertions(+), 22 deletions(-)
drivers/gpu/drm/i915/i915_pci.c +6 -1
index 27964ac0638a..a384f51c91c1 100644
@@ -1150,9 +1150,13 @@ static int __init i915_init(void)
                 return 0;
         }
 
+       i915_pmu_init();
+
         err = pci_register_driver(&i915_pci_driver);
-       if (err)
+       if (err) {
+               i915_pmu_exit();
                 return err;
+       }
 
         i915_perf_sysctl_register();
         return 0;
@@ -1166,6 +1170,7 @@ static void __exit i915_exit(void)
         i915_perf_sysctl_unregister();
         pci_unregister_driver(&i915_pci_driver);
         i915_globals_exit();
+       i915_pmu_exit();
  }
 
  module_init(i915_init);
drivers/gpu/drm/i915/i915_pmu.c +1 -0
index 51ed7d0efcdc..0d6c0945621e 100644
@@ -30,6 +30,7 @@
  #define ENGINE_SAMPLE_BITS (1 << I915_PMU_SAMPLE_BITS)
 
  static cpumask_t i915_pmu_cpumask;
+static unsigned int i915_pmu_target_cpu = -1;
 
  static u8 engine_config_sample(u64 config)
  {

drivers/gpu/drm/i915/i915_pmu.c static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node) · line 1053

Quoted 5 lines
drivers/gpu/drm/i915/i915_pmu.c +1 -1
@@ -1049,25 +1050,32 @@ static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node)
  static int i915_pmu_cpu_offline(unsigned int cpu, struct hlist_node *node)
  {
         struct i915_pmu *pmu = hlist_entry_safe(node, typeof(*pmu), cpuhp.node);
-       unsigned int target;
+       unsigned int target = i915_pmu_target_cpu;

So we still have multiple callbacks, one per pmu. But each callback is now stored in a list from the cpuhp_slot instead of each callback having its own slot.

drivers/gpu/drm/i915/i915_pmu.c static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node) · line 1057

Quoted 4 lines
drivers/gpu/drm/i915/i915_pmu.c +0 -0
         GEM_BUG_ON(!pmu->base.event_init);
 
         if (cpumask_test_and_clear_cpu(cpu, &i915_pmu_cpumask)) {

On first callback...

drivers/gpu/drm/i915/i915_pmu.c static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node) · line 1058

Quoted 1 line
drivers/gpu/drm/i915/i915_pmu.c +0 -0
                 target = cpumask_any_but(topology_sibling_cpumask(cpu), cpu);

Pick any other cpu.

drivers/gpu/drm/i915/i915_pmu.c static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node) · line 1063

Quoted 6 lines
drivers/gpu/drm/i915/i915_pmu.c +2 -1
+
                 /* Migrate events if there is a valid target */
                 if (target < nr_cpu_ids) {
                         cpumask_set_cpu(target, &i915_pmu_cpumask);
-                       perf_pmu_migrate_context(&pmu->base, cpu, target);
+                       i915_pmu_target_cpu = target;

Store target for all callbacks.

drivers/gpu/drm/i915/i915_pmu.c static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node) · line 1067

Quoted 4 lines
drivers/gpu/drm/i915/i915_pmu.c +1 -0
                 }
         }
 
+       if (target < nr_cpu_ids && target != pmu->cpuhp.cpu) {

If global [i915_pmu_target_cpu] target has changed, update perf.

drivers/gpu/drm/i915/i915_pmu.c static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node) · line 1069

Quoted 2 lines
drivers/gpu/drm/i915/i915_pmu.c +2 -0
+               perf_pmu_migrate_context(&pmu->base, cpu, target);
+               pmu->cpuhp.cpu = target;

It is claimed that cpuhp_state_remove_instance() will call the offline callback for all online cpus... Do we need a pmu->base.state != STOPPED guard?

Quoted 6 lines
Quoted 3 lines

s/claimed/it definitely does :)/

Or rather pmu->closed.

Hm why? You think perf_pmu_migrate_context accesses something in the PMU outside of the already protected entry points?

If this callback is being called for every online when we unplug one device, we then believe that no cpus remain online for all other devices. Should a cpu then be offlined, target is -1u so greater than nr_cpu_online and we move the perf context to the void, worst case, in the best case we fail to migrate the perf context off the dying cpu. -Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw

Re: [Intel-gfx] [PATCH 2/2] drm/i915/pmu: Fix CPU hotplug with multiple GPUs

Quoted 120 lines · Chris Wilson

Quoting Tvrtko Ursulin (2020-10-20 13:33:12)

Quoted 119 lines · Chris Wilson
Quoted 116 lines

Quoting Chris Wilson (2020-10-20 12:59:57)

Quoted 103 lines

Quoting Tvrtko Ursulin (2020-10-20 11:08:22)

Quoted 67 lines

From: Tvrtko Ursulin <[email protected]>

Since we keep a driver global mask of online CPUs and base the decision whether PMU needs to be migrated upon it, we need to make sure the migration is done for all registered PMUs (so GPUs).

To do this we need to track the current CPU for each PMU and base the decision on whether to migrate on a comparison between global and local state.

At the same time, since dynamic CPU hotplug notification slots are a scarce resource and given how we already register the multi instance type state, we can and should add multiple instance of the i915 PMU to this same state and not allocate a new one for every GPU.

v2:
* Use pr_notice. (Chris)

---
   drivers/gpu/drm/i915/i915_pci.c |  7 ++++-
   drivers/gpu/drm/i915/i915_pmu.c | 50 ++++++++++++++++++++-------------
   drivers/gpu/drm/i915/i915_pmu.h |  6 +++-
   3 files changed, 41 insertions(+), 22 deletions(-)
drivers/gpu/drm/i915/i915_pci.c +6 -1
index 27964ac0638a..a384f51c91c1 100644
@@ -1150,9 +1150,13 @@ static int __init i915_init(void)
                  return 0;
          }
 
+       i915_pmu_init();
+
          err = pci_register_driver(&i915_pci_driver);
-       if (err)
+       if (err) {
+               i915_pmu_exit();
                  return err;
+       }
 
          i915_perf_sysctl_register();
          return 0;
@@ -1166,6 +1170,7 @@ static void __exit i915_exit(void)
          i915_perf_sysctl_unregister();
          pci_unregister_driver(&i915_pci_driver);
          i915_globals_exit();
+       i915_pmu_exit();
   }
 
   module_init(i915_init);
drivers/gpu/drm/i915/i915_pmu.c +1 -0
index 51ed7d0efcdc..0d6c0945621e 100644
@@ -30,6 +30,7 @@
   #define ENGINE_SAMPLE_BITS (1 << I915_PMU_SAMPLE_BITS)
 
   static cpumask_t i915_pmu_cpumask;
+static unsigned int i915_pmu_target_cpu = -1;
 
   static u8 engine_config_sample(u64 config)
   {

drivers/gpu/drm/i915/i915_pmu.c static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node) · line 1053

Quoted 5 lines
drivers/gpu/drm/i915/i915_pmu.c +1 -1
@@ -1049,25 +1050,32 @@ static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node)
   static int i915_pmu_cpu_offline(unsigned int cpu, struct hlist_node *node)
   {
          struct i915_pmu *pmu = hlist_entry_safe(node, typeof(*pmu), cpuhp.node);
-       unsigned int target;
+       unsigned int target = i915_pmu_target_cpu;

So we still have multiple callbacks, one per pmu. But each callback is now stored in a list from the cpuhp_slot instead of each callback having its own slot.

drivers/gpu/drm/i915/i915_pmu.c static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node) · line 1057

Quoted 4 lines
drivers/gpu/drm/i915/i915_pmu.c +0 -0
          GEM_BUG_ON(!pmu->base.event_init);
 
          if (cpumask_test_and_clear_cpu(cpu, &i915_pmu_cpumask)) {

On first callback...

drivers/gpu/drm/i915/i915_pmu.c static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node) · line 1058

Quoted 1 line
drivers/gpu/drm/i915/i915_pmu.c +0 -0
                  target = cpumask_any_but(topology_sibling_cpumask(cpu), cpu);

Pick any other cpu.

drivers/gpu/drm/i915/i915_pmu.c static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node) · line 1063

Quoted 6 lines
drivers/gpu/drm/i915/i915_pmu.c +2 -1
+
                  /* Migrate events if there is a valid target */
                  if (target < nr_cpu_ids) {
                          cpumask_set_cpu(target, &i915_pmu_cpumask);
-                       perf_pmu_migrate_context(&pmu->base, cpu, target);
+                       i915_pmu_target_cpu = target;

Store target for all callbacks.

drivers/gpu/drm/i915/i915_pmu.c static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node) · line 1067

Quoted 4 lines
drivers/gpu/drm/i915/i915_pmu.c +1 -0
                  }
          }
 
+       if (target < nr_cpu_ids && target != pmu->cpuhp.cpu) {
Quoted 8 lines

If global [i915_pmu_target_cpu] target has changed, update perf.

drivers/gpu/drm/i915/i915_pmu.c static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node) · line 1069

Quoted 2 lines
drivers/gpu/drm/i915/i915_pmu.c +2 -0
+               perf_pmu_migrate_context(&pmu->base, cpu, target);
+               pmu->cpuhp.cpu = target;

It is claimed that cpuhp_state_remove_instance() will call the offline callback for all online cpus... Do we need a pmu->base.state != STOPPED guard?

s/claimed/it definitely does :)/

Or rather pmu->closed.

Quoted 8 lines
Quoted 2 lines

Hm why? You think perf_pmu_migrate_context accesses something in the PMU outside of the already protected entry points?

If this callback is being called for every online when we unplug one device, we then believe that no cpus remain online for all other devices. Should a cpu then be offlined, target is -1u so greater than nr_cpu_online and we move the perf context to the void, worst case, in the best case we fail to migrate the perf context off the dying cpu.

Well spotted nasty interaction, thanks.

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw

PATCH v2 2/2 drm/i915/pmu: Fix CPU hotplug with multiple GPUs

In reply to Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

Since we keep a driver global mask of online CPUs and base the decision whether PMU needs to be migrated upon it, we need to make sure the migration is done for all registered PMUs (so GPUs).

To do this we need to track the current CPU for each PMU and base the decision on whether to migrate on a comparison between global and local state.

At the same time, since dynamic CPU hotplug notification slots are a scarce resource and given how we already register the multi instance type state, we can and should add multiple instance of the i915 PMU to this same state and not allocate a new one for every GPU.

v2:
* Use pr_notice. (Chris)

v3:
* Handle a nasty interaction where unregistration which triggers a false CPU offline event. (Chris)

---
 drivers/gpu/drm/i915/i915_pci.c |  7 +++-
 drivers/gpu/drm/i915/i915_pmu.c | 57 +++++++++++++++++++++------------
 drivers/gpu/drm/i915/i915_pmu.h |  6 +++-
 3 files changed, 48 insertions(+), 22 deletions(-)
drivers/gpu/drm/i915/i915_pci.c +6 -1
index 27964ac0638a..a384f51c91c1 100644
@@ -1150,9 +1150,13 @@ static int __init i915_init(void)
 		return 0;
 	}
 
+	i915_pmu_init();
+
 	err = pci_register_driver(&i915_pci_driver);
-	if (err)
+	if (err) {
+		i915_pmu_exit();
 		return err;
+	}
 
 	i915_perf_sysctl_register();
 	return 0;
@@ -1166,6 +1170,7 @@ static void __exit i915_exit(void)
 	i915_perf_sysctl_unregister();
 	pci_unregister_driver(&i915_pci_driver);
 	i915_globals_exit();
+	i915_pmu_exit();
 }
 
 module_init(i915_init);
drivers/gpu/drm/i915/i915_pmu.c +37 -20

102 lines not on this page · raw message

drivers/gpu/drm/i915/i915_pmu.h +5 -1
index 59a0d19afb67..a24885ab415c 100644
@@ -43,7 +43,7 @@ struct i915_pmu {
 	 */
 	struct {
 		struct hlist_node node;
-		enum cpuhp_state slot;
+		unsigned int cpu;
 	} cpuhp;
 	/**
 	 * @base: PMU base.
@@ -126,11 +126,15 @@ struct i915_pmu {
 };
 
 #ifdef CONFIG_PERF_EVENTS
+void i915_pmu_init(void);
+void i915_pmu_exit(void);
 void i915_pmu_register(struct drm_i915_private *i915);
 void i915_pmu_unregister(struct drm_i915_private *i915);
 void i915_pmu_gt_parked(struct drm_i915_private *i915);
 void i915_pmu_gt_unparked(struct drm_i915_private *i915);
 #else
+static inline void i915_pmu_init(void) {}
+static inline void i915_pmu_exit(void) {}
 static inline void i915_pmu_register(struct drm_i915_private *i915) {}
 static inline void i915_pmu_unregister(struct drm_i915_private *i915) {}
 static inline void i915_pmu_gt_parked(struct drm_i915_private *i915) {}
Signature · 6 lines
2.25.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v2 2/2
#8 lore raw

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/pmu: Fix CPU hotplug with multiple GPUs

Quoting Tvrtko Ursulin (2020-10-20 17:11:44)

Quoted 36 lines

From: Tvrtko Ursulin <[email protected]>

Since we keep a driver global mask of online CPUs and base the decision whether PMU needs to be migrated upon it, we need to make sure the migration is done for all registered PMUs (so GPUs).

To do this we need to track the current CPU for each PMU and base the decision on whether to migrate on a comparison between global and local state.

At the same time, since dynamic CPU hotplug notification slots are a scarce resource and given how we already register the multi instance type state, we can and should add multiple instance of the i915 PMU to this same state and not allocate a new one for every GPU.

v2:
* Use pr_notice. (Chris)

v3:
* Handle a nasty interaction where unregistration which triggers a false CPU offline event. (Chris)

---
 drivers/gpu/drm/i915/i915_pci.c |  7 +++-
 drivers/gpu/drm/i915/i915_pmu.c | 57 +++++++++++++++++++++------------
 drivers/gpu/drm/i915/i915_pmu.h |  6 +++-
 3 files changed, 48 insertions(+), 22 deletions(-)
drivers/gpu/drm/i915/i915_pci.c +0 -0
index 27964ac0638a..a384f51c91c1 100644

drivers/gpu/drm/i915/i915_pci.c static int __init i915_init(void) · line 1158

Quoted 10 lines
drivers/gpu/drm/i915/i915_pci.c +4 -1
@@ -1150,9 +1150,13 @@ static int __init i915_init(void)
                return 0;
        }
 
+       i915_pmu_init();
+
        err = pci_register_driver(&i915_pci_driver);
-       if (err)
+       if (err) {
+               i915_pmu_exit();
                return err;

We could do an onion bhaji and call i915_globals_exit() as well.

drivers/gpu/drm/i915/i915_pci.c static void __exit i915_exit(void) · line 1173

Quoted 9 lines
drivers/gpu/drm/i915/i915_pci.c +2 -0
+       }
 
        i915_perf_sysctl_register();
        return 0;
@@ -1166,6 +1170,7 @@ static void __exit i915_exit(void)
        i915_perf_sysctl_unregister();
        pci_unregister_driver(&i915_pci_driver);
        i915_globals_exit();
+       i915_pmu_exit();

pmu_exit then globals_exit to pair with i915_init?

Quoted 105 lines
drivers/gpu/drm/i915/i915_pci.c +0 -0
 }
 
 module_init(i915_init);
drivers/gpu/drm/i915/i915_pmu.c +36 -19
index 51ed7d0efcdc..cd786ad12be7 100644
@@ -30,6 +30,7 @@
 #define ENGINE_SAMPLE_BITS (1 << I915_PMU_SAMPLE_BITS)
 
 static cpumask_t i915_pmu_cpumask;
+static unsigned int i915_pmu_target_cpu = -1;
 
 static u8 engine_config_sample(u64 config)
 {
@@ -1049,25 +1050,39 @@ static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node)
 static int i915_pmu_cpu_offline(unsigned int cpu, struct hlist_node *node)
 {
        struct i915_pmu *pmu = hlist_entry_safe(node, typeof(*pmu), cpuhp.node);
-       unsigned int target;
+       unsigned int target = i915_pmu_target_cpu;
 
        GEM_BUG_ON(!pmu->base.event_init);
 
+       /*
+        * Unregistering an instance generates a CPU offline event which we must
+        * ignore to avoid incorrectly modifying the shared i915_pmu_cpumask.
+        */
+       if (pmu->closed)
+               return 0;
+
        if (cpumask_test_and_clear_cpu(cpu, &i915_pmu_cpumask)) {
                target = cpumask_any_but(topology_sibling_cpumask(cpu), cpu);
+
                /* Migrate events if there is a valid target */
                if (target < nr_cpu_ids) {
                        cpumask_set_cpu(target, &i915_pmu_cpumask);
-                       perf_pmu_migrate_context(&pmu->base, cpu, target);
+                       i915_pmu_target_cpu = target;
                }
        }
 
+       if (target < nr_cpu_ids && target != pmu->cpuhp.cpu) {
+               perf_pmu_migrate_context(&pmu->base, cpu, target);
+               pmu->cpuhp.cpu = target;
+       }
+
        return 0;
 }
 
-static int i915_pmu_register_cpuhp_state(struct i915_pmu *pmu)
+static enum cpuhp_state cpuhp_slot = CPUHP_INVALID;
+
+void i915_pmu_init(void)
 {
-       enum cpuhp_state slot;
        int ret;
 
        ret = cpuhp_setup_state_multi(CPUHP_AP_ONLINE_DYN,
@@ -1075,27 +1090,29 @@ static int i915_pmu_register_cpuhp_state(struct i915_pmu *pmu)
                                      i915_pmu_cpu_online,
                                      i915_pmu_cpu_offline);
        if (ret < 0)
-               return ret;
+               pr_notice("Failed to setup cpuhp state for i915 PMU! (%d)\n",
+                         ret);
+       else
+               cpuhp_slot = ret;
+}
 
-       slot = ret;
-       ret = cpuhp_state_add_instance(slot, &pmu->cpuhp.node);
-       if (ret) {
-               cpuhp_remove_multi_state(slot);
-               return ret;
-       }
+void i915_pmu_exit(void)
+{
+       if (cpuhp_slot != CPUHP_INVALID)
+               cpuhp_remove_multi_state(cpuhp_slot);
+}
 
-       pmu->cpuhp.slot = slot;
-       return 0;
+static int i915_pmu_register_cpuhp_state(struct i915_pmu *pmu)
+{
+       if (cpuhp_slot == CPUHP_INVALID)
+               return -EINVAL;
+
+       return cpuhp_state_add_instance(cpuhp_slot, &pmu->cpuhp.node);
 }
 
 static void i915_pmu_unregister_cpuhp_state(struct i915_pmu *pmu)
 {
-       struct drm_i915_private *i915 = container_of(pmu, typeof(*i915), pmu);
-
-       drm_WARN_ON(&i915->drm, pmu->cpuhp.slot == CPUHP_INVALID);
-       drm_WARN_ON(&i915->drm, cpuhp_state_remove_instance(pmu->cpuhp.slot, &pmu->cpuhp.node));
-       cpuhp_remove_multi_state(pmu->cpuhp.slot);
-       pmu->cpuhp.slot = CPUHP_INVALID;
+       cpuhp_state_remove_instance(cpuhp_slot, &pmu->cpuhp.node);
 }
 
 static bool is_igp(struct drm_i915_private *i915)

drivers/gpu/drm/i915/i915_pmu.c void i915_pmu_register(struct drm_i915_private *i915) · line 1149

Quoted 5 lines
drivers/gpu/drm/i915/i915_pmu.c +1 -1
@@ -1129,7 +1146,7 @@ void i915_pmu_register(struct drm_i915_private *i915)
        spin_lock_init(&pmu->lock);
        hrtimer_init(&pmu->timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
        pmu->timer.function = i915_sample;
-       pmu->cpuhp.slot = CPUHP_INVALID;
+       pmu->cpuhp.cpu = -1;

To the best of my limited understanding of cpuhp,

-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#9 lore raw

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/pmu: Fix CPU hotplug with multiple GPUs

Quoted 52 lines · Chris Wilson

Quoting Tvrtko Ursulin (2020-10-20 17:11:44)

Quoted 36 lines

From: Tvrtko Ursulin <[email protected]>

Since we keep a driver global mask of online CPUs and base the decision whether PMU needs to be migrated upon it, we need to make sure the migration is done for all registered PMUs (so GPUs).

To do this we need to track the current CPU for each PMU and base the decision on whether to migrate on a comparison between global and local state.

At the same time, since dynamic CPU hotplug notification slots are a scarce resource and given how we already register the multi instance type state, we can and should add multiple instance of the i915 PMU to this same state and not allocate a new one for every GPU.

v2:
* Use pr_notice. (Chris)

v3:
* Handle a nasty interaction where unregistration which triggers a false CPU offline event. (Chris)

---
  drivers/gpu/drm/i915/i915_pci.c |  7 +++-
  drivers/gpu/drm/i915/i915_pmu.c | 57 +++++++++++++++++++++------------
  drivers/gpu/drm/i915/i915_pmu.h |  6 +++-
  3 files changed, 48 insertions(+), 22 deletions(-)
drivers/gpu/drm/i915/i915_pci.c +0 -0
index 27964ac0638a..a384f51c91c1 100644

drivers/gpu/drm/i915/i915_pci.c static int __init i915_init(void) · line 1158

Quoted 10 lines
drivers/gpu/drm/i915/i915_pci.c +4 -1
@@ -1150,9 +1150,13 @@ static int __init i915_init(void)
                 return 0;
         }
 
+       i915_pmu_init();
+
         err = pci_register_driver(&i915_pci_driver);
-       if (err)
+       if (err) {
+               i915_pmu_exit();
                 return err;

We could do an onion bhaji and call i915_globals_exit() as well.

Quoted 2 lines
drivers/gpu/drm/i915/i915_pci.c +1 -0
+       }
 
Quoted 9 lines

drivers/gpu/drm/i915/i915_pci.c static void __exit i915_exit(void) · line 1173

Quoted 7 lines
drivers/gpu/drm/i915/i915_pci.c +1 -0
         i915_perf_sysctl_register();
         return 0;
@@ -1166,6 +1170,7 @@ static void __exit i915_exit(void)
         i915_perf_sysctl_unregister();
         pci_unregister_driver(&i915_pci_driver);
         i915_globals_exit();
+       i915_pmu_exit();

pmu_exit then globals_exit to pair with i915_init?

Maybe later, sorry.

Quoted 112 lines
Quoted 105 lines
drivers/gpu/drm/i915/i915_pci.c +0 -0
  }
 
  module_init(i915_init);
drivers/gpu/drm/i915/i915_pmu.c +36 -19
index 51ed7d0efcdc..cd786ad12be7 100644
@@ -30,6 +30,7 @@
  #define ENGINE_SAMPLE_BITS (1 << I915_PMU_SAMPLE_BITS)
 
  static cpumask_t i915_pmu_cpumask;
+static unsigned int i915_pmu_target_cpu = -1;
 
  static u8 engine_config_sample(u64 config)
  {
@@ -1049,25 +1050,39 @@ static int i915_pmu_cpu_online(unsigned int cpu, struct hlist_node *node)
  static int i915_pmu_cpu_offline(unsigned int cpu, struct hlist_node *node)
  {
         struct i915_pmu *pmu = hlist_entry_safe(node, typeof(*pmu), cpuhp.node);
-       unsigned int target;
+       unsigned int target = i915_pmu_target_cpu;
 
         GEM_BUG_ON(!pmu->base.event_init);
 
+       /*
+        * Unregistering an instance generates a CPU offline event which we must
+        * ignore to avoid incorrectly modifying the shared i915_pmu_cpumask.
+        */
+       if (pmu->closed)
+               return 0;
+
         if (cpumask_test_and_clear_cpu(cpu, &i915_pmu_cpumask)) {
                 target = cpumask_any_but(topology_sibling_cpumask(cpu), cpu);
+
                 /* Migrate events if there is a valid target */
                 if (target < nr_cpu_ids) {
                         cpumask_set_cpu(target, &i915_pmu_cpumask);
-                       perf_pmu_migrate_context(&pmu->base, cpu, target);
+                       i915_pmu_target_cpu = target;
                 }
         }
 
+       if (target < nr_cpu_ids && target != pmu->cpuhp.cpu) {
+               perf_pmu_migrate_context(&pmu->base, cpu, target);
+               pmu->cpuhp.cpu = target;
+       }
+
         return 0;
  }
 
-static int i915_pmu_register_cpuhp_state(struct i915_pmu *pmu)
+static enum cpuhp_state cpuhp_slot = CPUHP_INVALID;
+
+void i915_pmu_init(void)
  {
-       enum cpuhp_state slot;
         int ret;
 
         ret = cpuhp_setup_state_multi(CPUHP_AP_ONLINE_DYN,
@@ -1075,27 +1090,29 @@ static int i915_pmu_register_cpuhp_state(struct i915_pmu *pmu)
                                       i915_pmu_cpu_online,
                                       i915_pmu_cpu_offline);
         if (ret < 0)
-               return ret;
+               pr_notice("Failed to setup cpuhp state for i915 PMU! (%d)\n",
+                         ret);
+       else
+               cpuhp_slot = ret;
+}
 
-       slot = ret;
-       ret = cpuhp_state_add_instance(slot, &pmu->cpuhp.node);
-       if (ret) {
-               cpuhp_remove_multi_state(slot);
-               return ret;
-       }
+void i915_pmu_exit(void)
+{
+       if (cpuhp_slot != CPUHP_INVALID)
+               cpuhp_remove_multi_state(cpuhp_slot);
+}
 
-       pmu->cpuhp.slot = slot;
-       return 0;
+static int i915_pmu_register_cpuhp_state(struct i915_pmu *pmu)
+{
+       if (cpuhp_slot == CPUHP_INVALID)
+               return -EINVAL;
+
+       return cpuhp_state_add_instance(cpuhp_slot, &pmu->cpuhp.node);
  }
 
  static void i915_pmu_unregister_cpuhp_state(struct i915_pmu *pmu)
  {
-       struct drm_i915_private *i915 = container_of(pmu, typeof(*i915), pmu);
-
-       drm_WARN_ON(&i915->drm, pmu->cpuhp.slot == CPUHP_INVALID);
-       drm_WARN_ON(&i915->drm, cpuhp_state_remove_instance(pmu->cpuhp.slot, &pmu->cpuhp.node));
-       cpuhp_remove_multi_state(pmu->cpuhp.slot);
-       pmu->cpuhp.slot = CPUHP_INVALID;
+       cpuhp_state_remove_instance(cpuhp_slot, &pmu->cpuhp.node);
  }
 
  static bool is_igp(struct drm_i915_private *i915)

drivers/gpu/drm/i915/i915_pmu.c void i915_pmu_register(struct drm_i915_private *i915) · line 1149

Quoted 5 lines
drivers/gpu/drm/i915/i915_pmu.c +1 -1
@@ -1129,7 +1146,7 @@ void i915_pmu_register(struct drm_i915_private *i915)
         spin_lock_init(&pmu->lock);
         hrtimer_init(&pmu->timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
         pmu->timer.function = i915_sample;
-       pmu->cpuhp.slot = CPUHP_INVALID;
+       pmu->cpuhp.cpu = -1;

To the best of my limited understanding of cpuhp,

Quoted 1 line

Pushed these two, having declared shard runs flip-flops are unrelated. Thanks!

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#10 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/pmu: Handle PCI unbind

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915/pmu: Handle PCI unbind
URL : https://patchwork.freedesktop.org/series/82864/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9169 -> Patchwork_18740
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/index.html

Known issues
------------

Here are the changes found in Patchwork_18740 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-byt-j1900: [PASS][1] -> [DMESG-WARN][2] ([i915#1982])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/fi-byt-j1900/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/fi-byt-j1900/igt@[email protected]

* igt@kms_chamelium@hdmi-crc-fast:
- fi-kbl-7500u: [PASS][3] -> [DMESG-WARN][4] ([i915#2203])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/fi-kbl-7500u/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/fi-kbl-7500u/igt@[email protected]

#### Possible fixes ####

* igt@i915_module_load@reload:
- fi-icl-y: [DMESG-WARN][5] ([i915#1982]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/fi-icl-y/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/fi-icl-y/igt@[email protected]

* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-n3050: [DMESG-WARN][7] ([i915#1982]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/fi-bsw-n3050/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/fi-bsw-n3050/igt@[email protected]

* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: [DMESG-FAIL][9] ([i915#541]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- {fi-kbl-7560u}: [DMESG-WARN][11] ([i915#1982]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/fi-kbl-7560u/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/fi-kbl-7560u/igt@[email protected]
- fi-bsw-kefka: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14] +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/fi-bsw-kefka/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/fi-bsw-kefka/igt@[email protected]

#### Warnings ####

* igt@i915_pm_rpm@basic-rte:
- fi-kbl-guc: [DMESG-FAIL][15] ([i915#2203]) -> [SKIP][16] ([fdo#109271])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/fi-kbl-guc/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/fi-kbl-guc/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541

Participating hosts (45 -> 39)
------------------------------

Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus

Build changes
-------------

* Linux: CI_DRM_9169 -> Patchwork_18740

CI-20190529: 20190529
CI_DRM_9169: 8a581847c1bea831f8edfbb813225df47fe28a3a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5822: b4bcf05cb9839037128905deda7146434155cc41 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18740: 4ff04849da48332f9715dcca1d196436b2320799 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

4ff04849da48 drm/i915/pmu: Fix CPU hotplug with multiple GPUs 7c0f98609c66 drm/i915/pmu: Handle PCI unbind

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#11 lore raw

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/pmu: Handle PCI unbind

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915/pmu: Handle PCI unbind
URL : https://patchwork.freedesktop.org/series/82864/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_9169_full -> Patchwork_18740_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_18740_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_18740_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_18740_full:

### IGT changes ###

#### Possible regressions ####

* igt@prime_vgem@coherency-blt:
- shard-hsw: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-hsw1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-hsw6/igt@[email protected]

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* {igt@core_hotunplug@hotrebind}:
- shard-hsw: NOTRUN -> [WARN][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-hsw6/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_18740_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_whisper@basic-forked-all:
- shard-glk: [PASS][4] -> [DMESG-WARN][5] ([i915#118] / [i915#95])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-glk3/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-glk8/igt@[email protected]

* igt@gem_userptr_blits@unsync-unmap-cycles:
- shard-skl: [PASS][6] -> [TIMEOUT][7] ([i915#2424])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl3/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-skl7/igt@[email protected]

* igt@i915_selftest@live@execlists:
- shard-skl: [PASS][8] -> [INCOMPLETE][9] ([CI#80])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl2/igt@i915_selftest@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-skl3/igt@i915_selftest@[email protected]

* igt@i915_suspend@debugfs-reader:
- shard-kbl: [PASS][10] -> [INCOMPLETE][11] ([i915#155])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-kbl7/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-kbl6/igt@[email protected]

* igt@kms_big_fb@y-tiled-8bpp-rotate-180:
- shard-apl: [PASS][12] -> [DMESG-WARN][13] ([i915#1635] / [i915#1982]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-apl2/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-apl2/igt@[email protected]

* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: [PASS][14] -> [FAIL][15] ([i915#96])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-hsw6/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-hsw1/igt@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-mmap-wc-xtiled:
- shard-skl: [PASS][16] -> [DMESG-WARN][17] ([i915#1982]) +8 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl1/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-skl1/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb2101010-blt-untiled:
- shard-snb: [PASS][18] -> [FAIL][19] ([i915#54])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-snb2/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-snb2/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-skl: [PASS][20] -> [FAIL][21] ([i915#79])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl7/igt@kms_flip@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-skl10/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1:
- shard-skl: [PASS][22] -> [FAIL][23] ([i915#2122])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl8/igt@kms_flip@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-skl2/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-render:
- shard-tglb: [PASS][24] -> [DMESG-WARN][25] ([i915#1982]) +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-tglb1/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-render.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-tglb8/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-render.html

* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][26] -> [FAIL][27] ([i915#1188])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl6/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-skl2/igt@[email protected]

* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][28] -> [SKIP][29] ([fdo#109441]) +2 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-iclb5/igt@kms_psr@psr2_cursor_render.html

* igt@kms_universal_plane@universal-plane-gen9-features-pipe-a:
- shard-kbl: [PASS][30] -> [DMESG-WARN][31] ([i915#1982])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-kbl4/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-kbl7/igt@[email protected]

* igt@kms_vblank@pipe-a-accuracy-idle:
- shard-glk: [PASS][32] -> [FAIL][33] ([i915#43])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-glk9/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-glk4/igt@[email protected]

#### Possible fixes ####

* {igt@core_hotunplug@hotrebind}:
- shard-iclb: [DMESG-WARN][34] ([i915#1982]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-iclb8/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-iclb5/igt@[email protected]

* igt@gem_exec_reloc@basic-many-active@vecs0:
- shard-glk: [FAIL][36] ([i915#2389]) -> [PASS][37] +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-glk1/igt@gem_exec_reloc@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-glk7/igt@gem_exec_reloc@[email protected]

* igt@gem_exec_whisper@basic-queues-priority-all:
- shard-glk: [FAIL][38] -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-glk8/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-glk6/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-128x128-onscreen:
- shard-skl: [FAIL][40] ([i915#54]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl8/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-skl8/igt@[email protected]

* igt@kms_cursor_edge_walk@pipe-b-128x128-top-edge:
- shard-glk: [DMESG-WARN][42] ([i915#1982]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-glk3/igt@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-glk8/igt@[email protected]

* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size:
- shard-skl: [DMESG-WARN][44] ([i915#1982]) -> [PASS][45] +3 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl3/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-skl6/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html

* igt@kms_cursor_legacy@cursor-vs-flip-varying-size:
- shard-hsw: [FAIL][46] ([i915#2370]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-hsw6/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-hsw2/igt@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-mmap-wc-xtiled:
- shard-apl: [DMESG-WARN][48] ([i915#1635] / [i915#1982]) -> [PASS][49] +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-apl3/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-apl8/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb2101010-blt-untiled:
- shard-skl: [TIMEOUT][50] -> [PASS][51] +3 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl10/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-skl5/igt@[email protected]

* igt@kms_flip@dpms-off-confusion-interruptible@a-dp1:
- shard-kbl: [DMESG-WARN][52] ([i915#1982]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-kbl2/igt@kms_flip@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-kbl7/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a2:
- shard-glk: [FAIL][54] ([i915#79]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-glk9/igt@kms_flip@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-glk2/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-expired-vblank@c-edp1:
- shard-skl: [FAIL][56] ([i915#79]) -> [PASS][57] +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl5/igt@kms_flip@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-skl5/igt@kms_flip@[email protected]

* igt@kms_hdr@bpc-switch:
- shard-skl: [FAIL][58] ([i915#1188]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl4/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-skl8/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][60] ([fdo#108145] / [i915#265]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl8/igt@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-skl8/igt@[email protected]

* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [SKIP][62] ([fdo#109441]) -> [PASS][63] +1 similar issue
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-iclb4/igt@kms_psr@psr2_sprite_plane_move.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html

* igt@kms_setmode@basic:
- shard-hsw: [FAIL][64] ([i915#31]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-hsw4/igt@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-hsw1/igt@[email protected]

* igt@perf@enable-disable:
- shard-skl: [FAIL][66] ([i915#1352]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl5/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-skl7/igt@[email protected]

* igt@perf_pmu@module-unload:
- shard-tglb: [DMESG-WARN][68] ([i915#1982]) -> [PASS][69] +2 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-tglb3/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-tglb7/igt@[email protected]

#### Warnings ####

* igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
- shard-skl: [TIMEOUT][70] -> [DMESG-WARN][71] ([i915#1982])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl10/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-skl5/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-suspend:
- shard-tglb: [DMESG-WARN][72] ([i915#1982] / [i915#2411]) -> [DMESG-WARN][73] ([i915#2411])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-tglb7/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-tglb6/igt@[email protected]

* igt@runner@aborted:
- shard-skl: [FAIL][74] ([i915#1814] / [i915#2029]) -> [FAIL][75] ([i915#1436] / [i915#2439])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl3/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/shard-skl3/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[CI#80]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/80
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1352]: https://gitlab.freedesktop.org/drm/intel/issues/1352
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2370]: https://gitlab.freedesktop.org/drm/intel/issues/2370
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2424]: https://gitlab.freedesktop.org/drm/intel/issues/2424
[i915#2439]: https://gitlab.freedesktop.org/drm/intel/issues/2439
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#43]: https://gitlab.freedesktop.org/drm/intel/issues/43
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[i915#96]: https://gitlab.freedesktop.org/drm/intel/issues/96

Participating hosts (11 -> 12)
------------------------------

Additional (1): pig-snb-2600

Build changes
-------------

* Linux: CI_DRM_9169 -> Patchwork_18740

CI-20190529: 20190529
CI_DRM_9169: 8a581847c1bea831f8edfbb813225df47fe28a3a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5822: b4bcf05cb9839037128905deda7146434155cc41 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18740: 4ff04849da48332f9715dcca1d196436b2320799 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18740/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#12 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/pmu: Handle PCI unbind (rev2)

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915/pmu: Handle PCI unbind (rev2)
URL : https://patchwork.freedesktop.org/series/82864/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9169 -> Patchwork_18744
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/index.html

Known issues
------------

Here are the changes found in Patchwork_18744 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live@gt_heartbeat:
- fi-tgl-u2: [PASS][1] -> [INCOMPLETE][2] ([i915#2557])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/fi-tgl-u2/igt@i915_selftest@live@gt_heartbeat.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/fi-tgl-u2/igt@i915_selftest@live@gt_heartbeat.html

#### Possible fixes ####

* igt@i915_module_load@reload:
- fi-icl-y: [DMESG-WARN][3] ([i915#1982]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/fi-icl-y/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/fi-icl-y/igt@[email protected]

* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-n3050: [DMESG-WARN][5] ([i915#1982]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/fi-bsw-n3050/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/fi-bsw-n3050/igt@[email protected]
- fi-bsw-kefka: [DMESG-WARN][7] ([i915#1982]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/fi-bsw-kefka/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/fi-bsw-kefka/igt@[email protected]

* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: [DMESG-FAIL][9] ([i915#541]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html

#### Warnings ####

* igt@i915_pm_rpm@basic-rte:
- fi-kbl-guc: [DMESG-FAIL][11] ([i915#2203]) -> [SKIP][12] ([fdo#109271])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/fi-kbl-guc/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/fi-kbl-guc/igt@[email protected]

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
[i915#2557]: https://gitlab.freedesktop.org/drm/intel/issues/2557
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541

Participating hosts (45 -> 38)
------------------------------

Missing (7): fi-ilk-m540 fi-hsw-4200u fi-skl-guc fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus

Build changes
-------------

* Linux: CI_DRM_9169 -> Patchwork_18744

CI-20190529: 20190529
CI_DRM_9169: 8a581847c1bea831f8edfbb813225df47fe28a3a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5822: b4bcf05cb9839037128905deda7146434155cc41 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18744: 982c1f290dce4481188b3d1673704195360813b6 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

982c1f290dce drm/i915/pmu: Fix CPU hotplug with multiple GPUs 716dbf8b3c33 drm/i915/pmu: Handle PCI unbind

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#13 lore raw

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/pmu: Handle PCI unbind (rev2)

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915/pmu: Handle PCI unbind (rev2)
URL : https://patchwork.freedesktop.org/series/82864/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_9169_full -> Patchwork_18744_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_18744_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_18744_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_18744_full:

### IGT changes ###

#### Possible regressions ####

* igt@kms_flip@2x-plain-flip-ts-check@bc-vga1-hdmi-a1:
- shard-hsw: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-hsw6/igt@kms_flip@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-hsw2/igt@kms_flip@[email protected]

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* {igt@core_hotunplug@hotrebind}:
- shard-hsw: NOTRUN -> [WARN][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-hsw6/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_18744_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_reloc@basic-many-active@vcs0:
- shard-glk: [PASS][4] -> [FAIL][5] ([i915#2389])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-glk1/igt@gem_exec_reloc@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-glk5/igt@gem_exec_reloc@[email protected]

* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-skl: [PASS][6] -> [TIMEOUT][7] ([i915#2424])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl2/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-skl1/igt@[email protected]

* igt@i915_pm_rc6_residency@rc6-fence:
- shard-hsw: [PASS][8] -> [WARN][9] ([i915#1519])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-hsw8/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-hsw8/igt@[email protected]

* igt@i915_suspend@debugfs-reader:
- shard-kbl: [PASS][10] -> [INCOMPLETE][11] ([i915#155])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-kbl7/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-kbl4/igt@[email protected]

* igt@kms_big_fb@linear-32bpp-rotate-180:
- shard-glk: [PASS][12] -> [DMESG-FAIL][13] ([i915#118] / [i915#95])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-glk9/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-glk8/igt@[email protected]

* igt@kms_big_fb@y-tiled-8bpp-rotate-180:
- shard-kbl: [PASS][14] -> [DMESG-WARN][15] ([i915#1982])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-kbl7/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-kbl4/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-skl: [PASS][16] -> [INCOMPLETE][17] ([i915#300])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl1/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-skl8/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
- shard-skl: [PASS][18] -> [FAIL][19] ([i915#2346])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl8/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-skl5/igt@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-mmap-wc-xtiled:
- shard-skl: [PASS][20] -> [DMESG-WARN][21] ([i915#1982]) +6 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl1/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-skl7/igt@[email protected]

* igt@kms_flip@plain-flip-ts-check-interruptible@a-edp1:
- shard-skl: [PASS][22] -> [FAIL][23] ([i915#2122])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl9/igt@kms_flip@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-skl3/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbc-modesetfrombusy:
- shard-snb: [PASS][24] -> [FAIL][25] ([i915#2546])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-snb7/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-snb2/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-rte:
- shard-tglb: [PASS][26] -> [DMESG-WARN][27] ([i915#1982]) +2 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-tglb2/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-tglb6/igt@[email protected]

* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][28] -> [FAIL][29] ([i915#1188])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl6/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-skl7/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [PASS][30] -> [FAIL][31] ([fdo#108145] / [i915#265])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl8/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-skl5/igt@[email protected]

* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][32] -> [SKIP][33] ([fdo#109441]) +2 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-iclb8/igt@kms_psr@psr2_cursor_render.html

* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-skl: [PASS][34] -> [INCOMPLETE][35] ([i915#198])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl9/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-skl2/igt@[email protected]

* igt@prime_vgem@coherency-blt:
- shard-snb: [PASS][36] -> [INCOMPLETE][37] ([i915#82])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-snb2/igt@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-snb2/igt@[email protected]

#### Possible fixes ####

* {igt@core_hotunplug@hotrebind}:
- shard-iclb: [DMESG-WARN][38] ([i915#1982]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-iclb8/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-iclb4/igt@[email protected]

* igt@gem_exec_reloc@basic-many-active@rcs0:
- shard-hsw: [FAIL][40] ([i915#2389]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-hsw2/igt@gem_exec_reloc@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-hsw8/igt@gem_exec_reloc@[email protected]

* igt@gem_exec_whisper@basic-queues-forked:
- shard-glk: [DMESG-WARN][42] ([i915#118] / [i915#95]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-glk7/igt@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-glk8/igt@[email protected]

* igt@gem_exec_whisper@basic-queues-priority-all:
- shard-glk: [FAIL][44] -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-glk8/igt@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-glk4/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-128x128-onscreen:
- shard-skl: [FAIL][46] ([i915#54]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl8/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-skl5/igt@[email protected]

* igt@kms_cursor_edge_walk@pipe-b-128x128-top-edge:
- shard-glk: [DMESG-WARN][48] ([i915#1982]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-glk3/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-glk2/igt@[email protected]

* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-skl: [DMESG-WARN][50] ([i915#1982]) -> [PASS][51] +4 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl7/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-skl6/igt@[email protected]

* igt@kms_cursor_legacy@cursor-vs-flip-varying-size:
- shard-hsw: [FAIL][52] ([i915#2370]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-hsw6/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-hsw2/igt@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-mmap-wc-xtiled:
- shard-apl: [DMESG-WARN][54] ([i915#1635] / [i915#1982]) -> [PASS][55] +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-apl3/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-apl1/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb2101010-blt-untiled:
- shard-skl: [TIMEOUT][56] -> [PASS][57] +3 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl10/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-skl10/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb8888-render-xtiled:
- shard-snb: [FAIL][58] ([i915#54]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-snb7/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-snb2/igt@[email protected]

* igt@kms_flip@dpms-off-confusion-interruptible@a-dp1:
- shard-kbl: [DMESG-WARN][60] ([i915#1982]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-kbl2/igt@kms_flip@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-kbl4/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a2:
- shard-glk: [FAIL][62] ([i915#79]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-glk9/igt@kms_flip@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-glk7/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-expired-vblank@c-edp1:
- shard-skl: [FAIL][64] ([i915#79]) -> [PASS][65] +1 similar issue
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl5/igt@kms_flip@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-skl10/igt@kms_flip@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][66] ([fdo#108145] / [i915#265]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl8/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-skl5/igt@[email protected]

* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][68] ([fdo#109441]) -> [PASS][69] +2 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-iclb5/igt@kms_psr@psr2_primary_mmap_cpu.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html

* igt@perf@enable-disable:
- shard-skl: [FAIL][70] ([i915#1352]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl5/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-skl5/igt@[email protected]

* igt@perf_pmu@module-unload:
- shard-tglb: [DMESG-WARN][72] ([i915#1982]) -> [PASS][73] +2 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-tglb3/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-tglb5/igt@[email protected]

#### Warnings ####

* igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
- shard-skl: [TIMEOUT][74] -> [DMESG-WARN][75] ([i915#1982])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl10/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-skl10/igt@[email protected]

* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [SKIP][76] ([fdo#109349]) -> [DMESG-WARN][77] ([i915#1226])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-iclb5/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-iclb2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][78] ([fdo#108145] / [i915#265]) -> [DMESG-WARN][79] ([i915#1982])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9169/shard-skl8/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/shard-skl9/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
[i915#1352]: https://gitlab.freedesktop.org/drm/intel/issues/1352
[i915#1519]: https://gitlab.freedesktop.org/drm/intel/issues/1519
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2370]: https://gitlab.freedesktop.org/drm/intel/issues/2370
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2424]: https://gitlab.freedesktop.org/drm/intel/issues/2424
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95

Participating hosts (11 -> 11)
------------------------------

No changes in participating hosts

Build changes
-------------

* Linux: CI_DRM_9169 -> Patchwork_18744

CI-20190529: 20190529
CI_DRM_9169: 8a581847c1bea831f8edfbb813225df47fe28a3a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5822: b4bcf05cb9839037128905deda7146434155cc41 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18744: 982c1f290dce4481188b3d1673704195360813b6 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18744/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx