igc: reinit_locked() should be called with rtnl_lock
Subsystems (2)
PATCH 1/1 igc: reinit_locked() should be called with rtnl_lock
This commit applies to the igc_reset_task the same changes that were applied to the igb driver in commit 024a8168b749 ("igb:reinit_locked() should be called with rtnl_lock")
and fix possible race in reset subtask.
Suggested-by Jakub Kicinski <[email protected]>
Signed-off-by Sasha Neftin <[email protected]>
--- drivers/net/ethernet/intel/igc/igc_main.c | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/net/ethernet/intel/igc/igc_main.c +9 -0
@@ -3849,10 +3849,19 @@ static void igc_reset_task(struct work_struct *work) adapter = container_of(work, struct igc_adapter, reset_task); +rtnl_lock (); +/* If we're already down or resetting, just bail */ +if (test_bit (__IGC_DOWN, &adapter->state) || +test_bit (__IGC_RESETTING, &adapter->state)) { +rtnl_unlock (); +return ; + } +igc_rings_dump (adapter);igc_regs_dump (adapter);netdev_err (adapter->netdev,"Reset adapter\n" );igc_reinit_locked (adapter); +rtnl_unlock (); }/**
Signature · 1 line
2.25.1