Skip to contentSkip to conversation

net: phylink: disable BMCR_ISOLATE in phylink_mii_c22_pcs_config

PATCH In review Robert Hancock 3 participants 3 messages Oct 20, 2020 – Oct 21, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: phylink: disable BMCR_ISOLATE in phylink_mii_c22_pcs_config

The Xilinx PCS/PMA PHY requires that BMCR_ISOLATE be disabled for proper operation in 1000BaseX mode. It should be safe to ensure this bit is disabled in phylink_mii_c22_pcs_config in all cases.

---
 drivers/net/phy/phylink.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/phy/phylink.c +2 -1
index fe2296fdda19..5d8c015bc9f2 100644
@@ -2515,9 +2515,10 @@ int phylink_mii_c22_pcs_config(struct mdio_device *pcs, unsigned int mode,
 
 	changed = ret > 0;
 
+	/* Ensure ISOLATE bit is disabled */
 	bmcr = mode == MLO_AN_INBAND ? BMCR_ANENABLE : 0;
 	ret = mdiobus_modify(pcs->bus, pcs->addr, MII_BMCR,
-			     BMCR_ANENABLE, bmcr);
+			     BMCR_ANENABLE | BMCR_ISOLATE, bmcr);
 	if (ret < 0)
 		return ret;
 
Signature · 1 line
2.18.4
maintainer Reviewed-by Russell King on v1 1/1
#1 lore raw
Quoted 5 lines · Robert Hancock

The Xilinx PCS/PMA PHY requires that BMCR_ISOLATE be disabled for proper operation in 1000BaseX mode. It should be safe to ensure this bit is disabled in phylink_mii_c22_pcs_config in all cases.

Please re-send when netdev is open, thanks.

Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
maintainer
#2 lore raw
Quoted 10 lines · On Wed, 21 Oct 2020 10:27:36 +0100 Russell King - ARM Linux admin wrote:
Quoted 5 lines · Robert Hancock

The Xilinx PCS/PMA PHY requires that BMCR_ISOLATE be disabled for proper operation in 1000BaseX mode. It should be safe to ensure this bit is disabled in phylink_mii_c22_pcs_config in all cases.

Please re-send when netdev is open, thanks.

And please mark it as [PATCH net-next] when you resend next week - just to be sure I don't get confused and apply this as a fix.