Skip to contentSkip to conversation

regexdev: add OOS capability definition

PATCH Superseded [email protected] 3 participants 11 messages Oct 20, 2020 – Nov 3, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 regexdev: add OOS capability definition

From: Guy Kaneti <[email protected]>

Add out of order scan capability to check PMD
support for OOS.

---
 lib/librte_regexdev/rte_regexdev.h | 8 ++++++++
 1 file changed, 8 insertions(+)
lib/librte_regexdev/rte_regexdev.h +8 -0
index 4077e62c9..60cccf816 100644
@@ -474,6 +474,14 @@ rte_regexdev_get_dev_id(const char *name);
  * @see RTE_REGEXDEV_CFG_MATCH_ALL_F
  */
 
+#define RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F (1ULL << 22)
+/**< RegEx device support out of order scan, this means the scan can be retired
+ * as soon as device returns completion.
+ *
+ * @see RTE_REGEX_QUEUE_PAIR_CFG_OOS_F
+ * @see struct rte_regexdev_info::regexdev_capa
+ */
+
 /* Enumerates PCRE rule flags */
 #define RTE_REGEX_PCRE_RULE_ALLOW_EMPTY_F (1ULL << 0)
 /**< When this flag is set, the pattern that can match against an empty string,
Signature · 1 line
2.28.0
Acked-by on v1 1/1
#1 lore raw

Hi Guy

Quoted 31 lines

-----Original Message-----
From: [email protected] <[email protected]>
Sent: Tuesday, October 20, 2020 11:16 AM [email protected]; [email protected]
Subject: [PATCH v1] regexdev: add OOS capability definition

From: Guy Kaneti <[email protected]>

Add out of order scan capability to check PMD
support for OOS.

---
 lib/librte_regexdev/rte_regexdev.h | 8 ++++++++
 1 file changed, 8 insertions(+)
lib/librte_regexdev/rte_regexdev.h +2 -0
index 4077e62c9..60cccf816 100644
@@ -474,6 +474,14 @@ rte_regexdev_get_dev_id(const char *name);
  * @see RTE_REGEXDEV_CFG_MATCH_ALL_F
  */
 
+#define RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F (1ULL << 22)
+/**< RegEx device support out of order scan, this means the scan can be

retired
+ * as soon as device returns completion.
+ *
+ * @see RTE_REGEX_QUEUE_PAIR_CFG_OOS_F

Quoted 8 lines

+ * @see struct rte_regexdev_info::regexdev_capa
+ */
+
/* Enumerates PCRE rule flags */
#define RTE_REGEX_PCRE_RULE_ALLOW_EMPTY_F (1ULL << 0)
/**< When this flag is set, the pattern that can match against an empty string,
--
2.28.0

Best,
Ori

#2 lore raw
In reply to [email protected]

20/10/2020 10:16, [email protected]:

lib/librte_regexdev/rte_regexdev.h rte_regexdev_get_dev_id(const char *name); · line 478

Quoted 11 lines

From: Guy Kaneti <[email protected]>

Add out of order scan capability to check PMD
support for OOS.

---

lib/librte_regexdev/rte_regexdev.h +2 -0
+#define RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F (1ULL << 22)
+/**< RegEx device support out of order scan, this means the scan can be retired

s/support/supports/

What means "retired"?

Quoted 5 lines

+ * as soon as device returns completion.
+ *
+ * @see RTE_REGEX_QUEUE_PAIR_CFG_OOS_F
+ * @see struct rte_regexdev_info::regexdev_capa
+ */

author
#3 lore raw
Quoted 26 lines

-----Original Message-----
From: Thomas Monjalon <[email protected]>
Sent: Tuesday, October 20, 2020 3:37 PM
To: Guy Kaneti <[email protected]>
Cc: [email protected]; [email protected]; Smadar Fuks <[email protected]>; Dovrat Zifroni <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>
Subject: [EXT] Re: [dpdk-dev] [PATCH v1] regexdev: add OOS capability definition

External Email

----------------------------------------------------------------------
20/10/2020 10:16, [email protected]:

lib/librte_regexdev/rte_regexdev.h

Quoted 9 lines

From: Guy Kaneti <[email protected]>

Add out of order scan capability to check PMD support for OOS.

---

lib/librte_regexdev/rte_regexdev.h +1 -0
+#define RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F (1ULL << 22) /**<

RegEx

Quoted 3 lines
Quoted 1 line

+device support out of order scan, this means the scan can be retired

s/support/supports/

I followed the other RTE_REGEXDEV_CAPA_ definitions I can fix it here

Quoted 2 lines

What means "retired"?

This was the original description in the rte_regexdev.h:

#define RTE_REGEX_QUEUE_PAIR_CFG_OOS_F (1ULL << 0)
/**< Out of order scan, If not set, a scan must retire after previously issued
* in-order scans to this queue pair. If set, this scan can be retired as soon
* as device returns completion. Application should not set out of order scan
* flag if it needs to maintain the ingress order of scan request.

Quoted 7 lines
Quoted 5 lines

+ * as soon as device returns completion.
+ *
+ * @see RTE_REGEX_QUEUE_PAIR_CFG_OOS_F
+ * @see struct rte_regexdev_info::regexdev_capa */

#4 lore raw

Hi

Quoted 42 lines

-----Original Message-----
From: Guy Kaneti <[email protected]>
Sent: Tuesday, October 20, 2020 5:24 PM
Subject: RE: [EXT] Re: [dpdk-dev] [PATCH v1] regexdev: add OOS capability definition

Quoted 24 lines

-----Original Message-----
From: Thomas Monjalon <[email protected]>
Sent: Tuesday, October 20, 2020 3:37 PM
To: Guy Kaneti <[email protected]>
Cc: [email protected]; [email protected]; Smadar Fuks <[email protected]>; Dovrat Zifroni <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>
Subject: [EXT] Re: [dpdk-dev] [PATCH v1] regexdev: add OOS capability definition

External Email

----------------------------------------------------------------------
20/10/2020 10:16, [email protected]:

lib/librte_regexdev/rte_regexdev.h

Quoted 9 lines

From: Guy Kaneti <[email protected]>

Add out of order scan capability to check PMD support for OOS.

---

lib/librte_regexdev/rte_regexdev.h +1 -0
+#define RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F (1ULL << 22) /**<

RegEx

Quoted 3 lines
Quoted 1 line

+device support out of order scan, this means the scan can be retired

s/support/supports/

I followed the other RTE_REGEXDEV_CAPA_ definitions I can fix it here

Quoted 2 lines

What means "retired"?

Quoted 8 lines

This was the original description in the rte_regexdev.h:

#define RTE_REGEX_QUEUE_PAIR_CFG_OOS_F (1ULL << 0)
/**< Out of order scan, If not set, a scan must retire after previously issued
* in-order scans to this queue pair. If set, this scan can be retired as soon
* as device returns completion. Application should not set out of order scan
* flag if it needs to maintain the ingress order of scan request.

I agree with Thomas, it is not very clear, The idea was to show that a scan can return a result From newer job/search on a specific queue before a previous job on the same queue is completed.

Best,
Ori

Quoted 7 lines
Quoted 7 lines
Quoted 5 lines

+ * as soon as device returns completion.
+ *
+ * @see RTE_REGEX_QUEUE_PAIR_CFG_OOS_F
+ * @see struct rte_regexdev_info::regexdev_capa */

author
#5 lore raw
Quoted 69 lines

-----Original Message-----
From: Ori Kam <[email protected]>
Sent: Wednesday, October 21, 2020 10:15 AM
To: Guy Kaneti <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>
Cc: [email protected]; Smadar Fuks <[email protected]>; Dovrat Zifroni <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>
Subject: RE: [EXT] Re: [dpdk-dev] [PATCH v1] regexdev: add OOS capability definition

Hi

Quoted 25 lines

-----Original Message-----
From: Guy Kaneti <[email protected]>
Sent: Tuesday, October 20, 2020 5:24 PM
Subject: RE: [EXT] Re: [dpdk-dev] [PATCH v1] regexdev: add OOS capability definition

Quoted 17 lines

-----Original Message-----
From: Thomas Monjalon <[email protected]>
Sent: Tuesday, October 20, 2020 3:37 PM
To: Guy Kaneti <[email protected]>
Cc: [email protected]; [email protected]; Smadar Fuks <[email protected]>; Dovrat Zifroni <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>
Subject: [EXT] Re: [dpdk-dev] [PATCH v1] regexdev: add OOS capability definition

External Email

--------------------------------------------------------------------
--
20/10/2020 10:16, [email protected]:

Quoted 2 lines

From: Guy Kaneti <[email protected]>

Quoted 7 lines
Quoted 7 lines

lib/librte_regexdev/rte_regexdev.h rte_regexdev_get_dev_id(const char *name); · line 477

Quoted 7 lines

Add out of order scan capability to check PMD support for OOS.

---

lib/librte_regexdev/rte_regexdev.h +1 -0
+#define RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F (1ULL << 22)

/**<

Quoted 6 lines
Quoted 5 lines

RegEx

lib/librte_regexdev/rte_regexdev.h

Quoted 2 lines
lib/librte_regexdev/rte_regexdev.h +2 -0
+device support out of order scan, this means the scan can be
+retired

s/support/supports/

Quoted 8 lines

I followed the other RTE_REGEXDEV_CAPA_ definitions I can fix it here

Quoted 2 lines

What means "retired"?

This was the original description in the rte_regexdev.h:

#define RTE_REGEX_QUEUE_PAIR_CFG_OOS_F (1ULL << 0) /**< Out of

order

Quoted 7 lines

scan, If not set, a scan must retire after previously issued
* in-order scans to this queue pair. If set, this scan can be retired
as soon
* as device returns completion. Application should not set out of
order scan
* flag if it needs to maintain the ingress order of scan request.

Quoted 3 lines

I agree with Thomas, it is not very clear, The idea was to show that a scan can return a result From newer job/search on a specific queue before a previous job on the same queue is completed.

How about this description:

/**< RegEx device supports out of order scan.
* Out of order scan means the response of a specific job can be returned as
* soon as it is ready even if previous jobs on the same queue didn't complete. *

Quoted 11 lines

Best,
Ori

Quoted 7 lines
Quoted 7 lines
Quoted 5 lines

+ * as soon as device returns completion.
+ *
+ * @see RTE_REGEX_QUEUE_PAIR_CFG_OOS_F
+ * @see struct rte_regexdev_info::regexdev_capa */

#6 lore raw

21/10/2020 09:39, Guy Kaneti:

Quoted 40 lines

From: Ori Kam <[email protected]>

Quoted 35 lines

From: Guy Kaneti <[email protected]>

Quoted 11 lines

From: Thomas Monjalon <[email protected]>

Quoted 10 lines

20/10/2020 10:16, [email protected]:

lib/librte_regexdev/rte_regexdev.h rte_regexdev_get_dev_id(const char *name); · line 477

Quoted 9 lines

From: Guy Kaneti <[email protected]>

Add out of order scan capability to check PMD support for OOS.

---

lib/librte_regexdev/rte_regexdev.h +1 -0
+#define RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F (1ULL << 22)

/**<

Quoted 6 lines
Quoted 5 lines

RegEx

lib/librte_regexdev/rte_regexdev.h

Quoted 2 lines
lib/librte_regexdev/rte_regexdev.h +2 -0
+device support out of order scan, this means the scan can be
+retired

s/support/supports/

Quoted 8 lines

I followed the other RTE_REGEXDEV_CAPA_ definitions I can fix it here

Quoted 2 lines

What means "retired"?

This was the original description in the rte_regexdev.h:

#define RTE_REGEX_QUEUE_PAIR_CFG_OOS_F (1ULL << 0) /**< Out of

order

Quoted 7 lines

scan, If not set, a scan must retire after previously issued
* in-order scans to this queue pair. If set, this scan can be retired
as soon
* as device returns completion. Application should not set out of
order scan
* flag if it needs to maintain the ingress order of scan request.

Quoted 3 lines

I agree with Thomas, it is not very clear, The idea was to show that a scan can return a result From newer job/search on a specific queue before a previous job on the same queue is completed.

Quoted 5 lines

How about this description:

/**< RegEx device supports out of order scan.
* Out of order scan means the response of a specific job can be returned as
* soon as it is ready even if previous jobs on the same queue didn't complete.

A lot better :)
Thanks

#7 lore raw

PATCH v2 1/1 regexdev: add OOS capability definition

In reply to [email protected]

From: Guy Kaneti <[email protected]>

Add out of order scan capability to check PMD
support for OOS.

---
v2 - fix definition comment

---
 lib/librte_regexdev/rte_regexdev.h | 9 +++++++++
 1 file changed, 9 insertions(+)
lib/librte_regexdev/rte_regexdev.h +9 -0
index 4077e62c9..000165892 100644
@@ -474,6 +474,15 @@ rte_regexdev_get_dev_id(const char *name);
  * @see RTE_REGEXDEV_CFG_MATCH_ALL_F
  */
 
+#define RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F (1ULL << 22)
+/**< RegEx device supports out of order scan.
+ * Out of order scan means the response of a specific job can be returned as
+ * soon as it is ready even if previous jobs on the same queue didn't complete.
+ *
+ * @see RTE_REGEX_QUEUE_PAIR_CFG_OOS_F
+ * @see struct rte_regexdev_info::regexdev_capa
+ */
+
 /* Enumerates PCRE rule flags */
 #define RTE_REGEX_PCRE_RULE_ALLOW_EMPTY_F (1ULL << 0)
 /**< When this flag is set, the pattern that can match against an empty string,
Signature · 1 line
2.28.0
Acked-by on v2 1/1
#8 lore raw
Quoted 41 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of [email protected]
Sent: Wednesday, October 21, 2020 11:04 AM
Subject: [dpdk-dev] [PATCH v2] regexdev: add OOS capability definition

From: Guy Kaneti <[email protected]>

Add out of order scan capability to check PMD
support for OOS.

---
v2 - fix definition comment

---
 lib/librte_regexdev/rte_regexdev.h | 9 +++++++++
 1 file changed, 9 insertions(+)
lib/librte_regexdev/rte_regexdev.h +9 -1
index 4077e62c9..000165892 100644
@@ -474,6 +474,15 @@ rte_regexdev_get_dev_id(const char *name);
  * @see RTE_REGEXDEV_CFG_MATCH_ALL_F
  */
 
+#define RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F (1ULL << 22)
+/**< RegEx device supports out of order scan.
+ * Out of order scan means the response of a specific job can be returned as
+ * soon as it is ready even if previous jobs on the same queue didn't complete.
+ *
+ * @see RTE_REGEX_QUEUE_PAIR_CFG_OOS_F
+ * @see struct rte_regexdev_info::regexdev_capa
+ */
+
 /* Enumerates PCRE rule flags */
 #define RTE_REGEX_PCRE_RULE_ALLOW_EMPTY_F (1ULL << 0)
 /**< When this flag is set, the pattern that can match against an empty string,
--
Quoted 1 line

2.28.0

Thanks,
Ori