Skip to contentSkip to conversation

media: ov2740: change the minimal exposure value to 4

PATCH In review Bingbu Cao 3 participants 4 messages Oct 21, 2020

Subsystems (3)
lore
Share & tools
lore

Bingbu Cao

author
#0 lore raw

PATCH 1/1 media: ov2740: change the minimal exposure value to 4

The minimal valid exposure value should be 4 lines instead of 8 for ov2740 mannual exposure control.

---
 drivers/media/i2c/ov2740.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/i2c/ov2740.c +1 -1
index bd0d45b0d43f..0dbae4949cb3 100644
@@ -37,7 +37,7 @@
 
 /* Exposure controls from sensor */
 #define OV2740_REG_EXPOSURE		0x3500
-#define OV2740_EXPOSURE_MIN		8
+#define OV2740_EXPOSURE_MIN		4
 #define OV2740_EXPOSURE_MAX_MARGIN	8
 #define OV2740_EXPOSURE_STEP		1
 
Signature · 1 line
2.7.4
maintainer
#1 lore raw

Hi Bingbu,

Quoted 13 lines · Bingbu Cao

The minimal valid exposure value should be 4 lines instead of 8 for ov2740 mannual exposure control.

---
 drivers/media/i2c/ov2740.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/i2c/ov2740.c +0 -0
index bd0d45b0d43f..0dbae4949cb3 100644

drivers/media/i2c/ov2740.c line 42

Quoted 7 lines
drivers/media/i2c/ov2740.c +1 -1
@@ -37,7 +37,7 @@
 
 /* Exposure controls from sensor */
 #define OV2740_REG_EXPOSURE		0x3500
-#define OV2740_EXPOSURE_MIN		8
+#define OV2740_EXPOSURE_MIN		4
 #define OV2740_EXPOSURE_MAX_MARGIN	8
 #define OV2740_EXPOSURE_STEP		1

This is already in my tree --- I may forgotten to push master after applying many patches, it is up-to-date now.

Signature · 3 lines
Regards,

Sakari Ailus
#2 lore raw

Sakari, thanks.
I did not find that on patchwork, so resend it again. :)

Quoted 27 lines · Sakari Ailus

Hi Bingbu,

Quoted 13 lines · Bingbu Cao

The minimal valid exposure value should be 4 lines instead of 8 for ov2740 mannual exposure control.

---
 drivers/media/i2c/ov2740.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/i2c/ov2740.c +0 -0
index bd0d45b0d43f..0dbae4949cb3 100644

drivers/media/i2c/ov2740.c line 42

Quoted 7 lines
drivers/media/i2c/ov2740.c +1 -1
@@ -37,7 +37,7 @@
 
 /* Exposure controls from sensor */
 #define OV2740_REG_EXPOSURE		0x3500
-#define OV2740_EXPOSURE_MIN		8
+#define OV2740_EXPOSURE_MIN		4
 #define OV2740_EXPOSURE_MAX_MARGIN	8
 #define OV2740_EXPOSURE_STEP		1

This is already in my tree --- I may forgotten to push master after applying many patches, it is up-to-date now.

Signature · 2 lines
Best regards,
Bingbu Cao
maintainer
#3 lore raw

Hi Bingbu,

Quoted 2 lines · Bingbu Cao

Sakari, thanks.
I did not find that on patchwork, so resend it again. :)

That patch simply seems to have been lost. It's also not on the list, only in my inbox.

We've had e-mail delivery problems recently both ways, I suppose this is attributable to those.

Thanks for resending so others could also see it.

Signature · 5 lines
Regards,

Sakari Ailus

P.S. Please avoid top posting.