Skip to contentSkip to conversation

dt-bindings: power/supply: Add ltc4162-l-charger

PATCH In review Mike Looijmans 2 participants 3 messages Oct 21, 2020 – Oct 26, 2020 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: power/supply: Add ltc4162-l-charger

Add support for the LTC4162-L Li-Ion battery charger. The driver allows reading back telemetry and to set some charging options like the input current limit.

This adds the devicetree bindings.

---
 .../bindings/power/supply/ltc4162-l.yaml      | 60 +++++++++++++++++++
 1 file changed, 60 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml
Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml new file +60 -0
new file mode 100644
index 000000000000..a23dd6f3fae0
@@ -0,0 +1,60 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+# Copyright (C) 2020 Topic Embedded Products
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/power/supply/ltc4162-l.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Linear Technology (Analog Devices) LTC4162-L Charger
+
+maintainers:
+  - Mike Looijmans <[email protected]>
+
+description: |
+  The LTC ® 4162-L is an advanced monolithic synchronous step-down switching
+  battery charger and PowerPath (TM) manager that seamlessly manages power
+  distribution between input sources such as wall adapters, backplanes, solar
+  panels, etc., and a rechargeable Lithium-Ion/Polymer battery.
+
+  Specifications about the charger can be found at:
+    https://www.analog.com/en/products/ltc4162-s.html
+
+properties:
+  compatible:
+    enum:
+      - lltc,ltc4162-l
+
+  reg:
+    maxItems: 1
+    description: I2C address of the charger.
+
+  lltc,rsnsb:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: Battery sense resistor in milli Ohm.
+    minimum: 1
+
+  lltc,rsnsi:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: Input current sense resistor in milli Ohm.
+    minimum: 1
+
+required:
+  - compatible
+  - reg
+  - lltc,rsnsb
+  - lltc,rsnsi
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c0 {
+      #address-cells = <1>;
+      #size-cells = <0>;
+      charger: battery-charger@68 {
+              compatible = "lltc,ltc4162-l";
+              reg =  <0x68>;
+              lltc,rsnsb = <10>;
+              lltc,rsnsi = <16>;
+      };
+    };
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 47 lines · Mike Looijmans

Add support for the LTC4162-L Li-Ion battery charger. The driver allows reading back telemetry and to set some charging options like the input current limit.

This adds the devicetree bindings.

---
 .../bindings/power/supply/ltc4162-l.yaml      | 60 +++++++++++++++++++
 1 file changed, 60 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml
Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml new file +29 -0
new file mode 100644
index 000000000000..a23dd6f3fae0
@@ -0,0 +1,60 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+# Copyright (C) 2020 Topic Embedded Products
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/power/supply/ltc4162-l.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Linear Technology (Analog Devices) LTC4162-L Charger
+
+maintainers:
+  - Mike Looijmans <[email protected]>
+
+description: |
+  The LTC ® 4162-L is an advanced monolithic synchronous step-down switching
+  battery charger and PowerPath (TM) manager that seamlessly manages power
+  distribution between input sources such as wall adapters, backplanes, solar
+  panels, etc., and a rechargeable Lithium-Ion/Polymer battery.
+
+  Specifications about the charger can be found at:
+    https://www.analog.com/en/products/ltc4162-s.html
+
+properties:
+  compatible:
+    enum:
+      - lltc,ltc4162-l
+
+  reg:
+    maxItems: 1
+    description: I2C address of the charger.

Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml line 39

Quoted 10 lines
Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml new file +10 -0
+
+  lltc,rsnsb:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: Battery sense resistor in milli Ohm.
+    minimum: 1
+
+  lltc,rsnsi:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: Input current sense resistor in milli Ohm.
+    minimum: 1

These should have a unit suffix as defined in property-units.txt. There's not one for milli Ohms, does micro Ohms give you enough range? If not, you can add it though that's discouraged simply so that we don't have differring units in each binding for the same thing.

Rob

#2 lore raw

Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert

TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: [email protected]
W: www.topicproducts.com

Please consider the environment before printing this e-mail

Quoted 54 lines · Rob Herring
Quoted 53 lines · Mike Looijmans

Add support for the LTC4162-L Li-Ion battery charger. The driver allows reading back telemetry and to set some charging options like the input current limit.

This adds the devicetree bindings.

---
  .../bindings/power/supply/ltc4162-l.yaml      | 60 +++++++++++++++++++
  1 file changed, 60 insertions(+)

create mode 100644 Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml

Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml new file +35 -0
new file mode 100644
index 000000000000..a23dd6f3fae0
@@ -0,0 +1,60 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+# Copyright (C) 2020 Topic Embedded Products
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/power/supply/ltc4162-l.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Linear Technology (Analog Devices) LTC4162-L Charger
+
+maintainers:
+  - Mike Looijmans <[email protected]>
+
+description: |
+  The LTC ® 4162-L is an advanced monolithic synchronous step-down switching
+  battery charger and PowerPath (TM) manager that seamlessly manages power
+  distribution between input sources such as wall adapters, backplanes, solar
+  panels, etc., and a rechargeable Lithium-Ion/Polymer battery.
+
+  Specifications about the charger can be found at:
+    https://www.analog.com/en/products/ltc4162-s.html
+
+properties:
+  compatible:
+    enum:
+      - lltc,ltc4162-l
+
+  reg:
+    maxItems: 1
+    description: I2C address of the charger.
+
+  lltc,rsnsb:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: Battery sense resistor in milli Ohm.
+    minimum: 1
+
Quoted 8 lines

Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml line 39

Quoted 4 lines
Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml new file +4 -0
+  lltc,rsnsi:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: Input current sense resistor in milli Ohm.
+    minimum: 1

These should have a unit suffix as defined in property-units.txt. There's not one for milli Ohms, does micro Ohms give you enough range? If not, you can add it though that's discouraged simply so that we don't have differring units in each binding for the same thing.

Micro Ohms is fine, might even be beneficial. Expected values are in the 10 milliohm range. Sorry to have missed that. I'll adapt the driver to use this value without overflowing.

Signature · 1 line
Mike Looijmans