drm/i915: wait PSR state back to idle when turn PSR off
Subsystems (3)
PATCH 1/1 drm/i915: wait PSR state back to idle when turn PSR off
Driver should refer to commit 'b2fc2252ce41 ("drm/i915/psr:
Always wait for idle state when disabling PSR")' to wait for idle state when turn PSR off. But it did not follow previous method. Driver just call intel_psr_exit() in intel_psr_invalidate() and psr_force_hw_tracking_exit(). Then leave the function right away.
After PSR disabled, we found some user space applications would enabled PSR again immediately. That caused particular TCON to get into incorrect state machine and can't recognize video data from source properly.
Add this change to wait PSR idle state in intel_psr_invalidate() and psr_force_hw_tracking_exit(). This symptom is not able to replicate anymore.
when disabling PSR).
--- drivers/gpu/drm/i915/display/intel_psr.c | 43 ++++++++++++++---------- 1 file changed, 26 insertions(+), 17 deletions(-)
drivers/gpu/drm/i915/display/intel_psr.c +26 -17
@@ -1036,6 +1036,25 @@ void intel_psr_enable(struct intel_dp *intel_dp,mutex_unlock (&dev_priv->psr.lock); } +static void intel_psr_wait_idle (struct drm_i915_private *dev_priv) +{ +i915_reg_t psr_status; +u32 psr_status_mask; + +if (dev_priv->psr.psr2_enabled) { + psr_status =EDP_PSR2_STATUS (dev_priv->psr.transcoder); + psr_status_mask =EDP_PSR2_STATUS_STATE_MASK ; + }else { + psr_status =EDP_PSR_STATUS (dev_priv->psr.transcoder); + psr_status_mask =EDP_PSR_STATUS_STATE_MASK ; + } + +/* Wait till PSR is idle */ +if (intel_de_wait_for_clear (dev_priv, psr_status, + psr_status_mask,2000 )) +drm_err (&dev_priv->drm,"Timed out waiting PSR idle state\n" ); +} +static void intel_psr_exit (struct drm_i915_private *dev_priv) {u32 val;
@@ -1076,8 +1095,6 @@ static void intel_psr_exit(struct drm_i915_private *dev_priv)static void intel_psr_disable_locked (struct intel_dp *intel_dp) {struct drm_i915_private *dev_priv =dp_to_i915 (intel_dp); -i915_reg_t psr_status; -u32 psr_status_mask;lockdep_assert_held (&dev_priv->psr.lock);
@@ -1088,19 +1105,7 @@ static void intel_psr_disable_locked(struct intel_dp *intel_dp) dev_priv->psr.psr2_enabled ? "2" : "1");intel_psr_exit (dev_priv); - -if (dev_priv->psr.psr2_enabled) { - psr_status =EDP_PSR2_STATUS (dev_priv->psr.transcoder); - psr_status_mask =EDP_PSR2_STATUS_STATE_MASK ; - }else { - psr_status =EDP_PSR_STATUS (dev_priv->psr.transcoder); - psr_status_mask =EDP_PSR_STATUS_STATE_MASK ; - } - -/* Wait till PSR is idle */ -if (intel_de_wait_for_clear (dev_priv, psr_status, - psr_status_mask,2000 )) -drm_err (&dev_priv->drm,"Timed out waiting PSR idle state\n" ); +intel_psr_wait_idle (dev_priv);/* WA 1408330847 */ if (dev_priv->psr.psr2_sel_fetch_enabled &&
@@ -1158,12 +1163,14 @@ static void psr_force_hw_tracking_exit(struct drm_i915_private *dev_priv)* pipe. */ intel_de_write (dev_priv,CURSURFLIVE (dev_priv->psr.pipe),0 ); - else + else {/* * A write to CURSURFLIVE do not cause HW tracking to exit PSR * on older gens so doing the manual exit instead. */ intel_psr_exit (dev_priv); +intel_psr_wait_idle (dev_priv); + } } void intel_psr2_program_plane_sel_fetch(struct intel_plane *plane,
@@ -1593,8 +1600,10 @@ void intel_psr_invalidate(struct drm_i915_private *dev_priv, frontbuffer_bits &=INTEL_FRONTBUFFER_ALL_MASK (dev_priv->psr.pipe); dev_priv->psr.busy_frontbuffer_bits |= frontbuffer_bits; -if (frontbuffer_bits) +if (frontbuffer_bits) {intel_psr_exit (dev_priv); +intel_psr_wait_idle (dev_priv); + }mutex_unlock (&dev_priv->psr.lock); }
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: wait PSR state back to idle when turn PSR off
== Series Details ==
== Series Details ==
Series: drm/i915: wait PSR state back to idle when turn PSR off
URL : https://patchwork.freedesktop.org/series/82920/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
57f806dd4a6e drm/i915: wait PSR state back to idle when turn PSR off
-:101: CHECK:BRACES: Unbalanced braces around else statement
#101: FILE: drivers/gpu/drm/i915/display/intel_psr.c:1166:
+ else {total: 0 errors, 0 warnings, 1 checks, 79 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: wait PSR state back to idle when turn PSR off
In reply to Lee Shawn C== Series Details ==
== Series Details ==
Series: drm/i915: wait PSR state back to idle when turn PSR off
URL : https://patchwork.freedesktop.org/series/82920/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9176 -> Patchwork_18754
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/index.html
Known issues
------------
Here are the changes found in Patchwork_18754 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@vgem_basic@unload:
- fi-skl-guc: [PASS][1] -> [DMESG-WARN][2] ([i915#2203])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/fi-skl-guc/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/fi-skl-guc/igt@[email protected]
#### Possible fixes ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-byt-j1900: [DMESG-WARN][3] ([i915#1982]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/fi-byt-j1900/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/fi-byt-j1900/igt@[email protected]
* igt@i915_selftest@live@gt_heartbeat:
- fi-tgl-u2: [INCOMPLETE][5] ([i915#2557]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/fi-tgl-u2/igt@i915_selftest@live@gt_heartbeat.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/fi-tgl-u2/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [DMESG-FAIL][7] ([i915#165] / [i915#262]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/fi-kbl-7500u/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/fi-kbl-7500u/igt@[email protected]
* igt@kms_chamelium@hdmi-crc-fast:
- fi-kbl-7500u: [DMESG-WARN][9] ([i915#1982] / [i915#2203]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/fi-kbl-7500u/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/fi-kbl-7500u/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- {fi-kbl-7560u}: [DMESG-WARN][11] ([i915#1982]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/fi-kbl-7560u/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/fi-kbl-7560u/igt@[email protected]
- fi-bsw-kefka: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14] +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/fi-bsw-kefka/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/fi-bsw-kefka/igt@[email protected]
* igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
- fi-icl-u2: [DMESG-WARN][15] ([i915#1982]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/fi-icl-u2/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/fi-icl-u2/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
[i915#2557]: https://gitlab.freedesktop.org/drm/intel/issues/2557
[i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
Participating hosts (45 -> 38)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9176 -> Patchwork_18754
CI-20190529: 20190529
CI_DRM_9176: e3d4f747f53899164788f2008a16c82d236b762a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5822: b4bcf05cb9839037128905deda7146434155cc41 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18754: 57f806dd4a6ee5165de688c2135fee878b3da06a @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
57f806dd4a6e drm/i915: wait PSR state back to idle when turn PSR off
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 11 lines · Lee Shawn C
Driver should refer to commit '
b2fc2252ce41("drm/i915/psr:
Always wait for idle state when disabling PSR")' to wait for idle state when turn PSR off. But it did not follow previous method. Driver just callintel_psr_exit()inintel_psr_invalidate()andpsr_force_hw_tracking_exit(). Then leave the function right away.After PSR disabled, we found some user space applications would enabled PSR again immediately. That caused particular TCON to get into incorrect state machine and can't recognize video data from source properly.
How? I don't see how this is possible this change is only adding delay between userspace calls.
Take a look at intel_psr_work(), PSR will only be enabled again when idle.
Quoted 129 lines
Add this change to wait PSR idle state in
intel_psr_invalidate()andpsr_force_hw_tracking_exit(). This symptom is not able to replicate anymore.Fixes b2fc2252ce41 (drm/i915/psr: Always wait for idle statewhen disabling PSR).
Cc Manasi Navare <[email protected]>Cc Jani Nikula <[email protected]>Cc Ville Syrjala <[email protected]>Cc José Roberto de Souza <[email protected]>Cc Cooper Chiou <[email protected]>Cc Khaled Almahallawy <[email protected]>Signed-off-by Lee Shawn C <[email protected]>---
drivers/gpu/drm/i915/display/intel_psr.c | 43 ++++++++++++++----------1 file changed, 26 insertions(+), 17 deletions(-)drivers/gpu/drm/i915/display/intel_psr.c +0
-0@@ -1036,6 +1036,25 @@ void intel_psr_enable(struct intel_dp *intel_dp, mutex_unlock(&dev_priv->psr.lock); }drivers/gpu/drm/i915/display/intel_psr.c +19
-0+static void intel_psr_wait_idle (struct drm_i915_private *dev_priv) +{ +i915_reg_t psr_status; +u32 psr_status_mask; + +if (dev_priv->psr.psr2_enabled) { + psr_status =EDP_PSR2_STATUS (dev_priv->psr.transcoder); + psr_status_mask =EDP_PSR2_STATUS_STATE_MASK ; + }else { + psr_status =EDP_PSR_STATUS (dev_priv->psr.transcoder); + psr_status_mask =EDP_PSR_STATUS_STATE_MASK ; + } + +/* Wait till PSR is idle */ +if (intel_de_wait_for_clear (dev_priv, psr_status, + psr_status_mask,2000 )) +drm_err (&dev_priv->drm,"Timed out waiting PSR idle state\n" ); +} +static void
intel_psr_exit(struct drm_i915_private *dev_priv){
u32 val;drivers/gpu/drm/i915/display/intel_psr.c +0
-2@@ -1076,8 +1095,6 @@ static void intel_psr_exit(struct drm_i915_private *dev_priv) static void intel_psr_disable_locked(struct intel_dp *intel_dp) { struct drm_i915_private *dev_priv = dp_to_i915(intel_dp); -i915_reg_t psr_status; -u32 psr_status_mask;
lockdep_assert_held(&dev_priv->psr.lock);drivers/gpu/drm/i915/display/intel_psr.c +0
-0@@ -1088,19 +1105,7 @@ static void intel_psr_disable_locked(struct intel_dp *intel_dp) dev_priv->psr.psr2_enabled ? "2" : "1");
intel_psr_exit(dev_priv);drivers/gpu/drm/i915/display/intel_psr.c +1
-13- -if (dev_priv->psr.psr2_enabled) { - psr_status =EDP_PSR2_STATUS (dev_priv->psr.transcoder); - psr_status_mask =EDP_PSR2_STATUS_STATE_MASK ; - }else { - psr_status =EDP_PSR_STATUS (dev_priv->psr.transcoder); - psr_status_mask =EDP_PSR_STATUS_STATE_MASK ; - } - -/* Wait till PSR is idle */ -if (intel_de_wait_for_clear (dev_priv, psr_status, - psr_status_mask,2000 )) -drm_err (&dev_priv->drm,"Timed out waiting PSR idle state\n" ); +intel_psr_wait_idle (dev_priv);/* WA 1408330847 */
if (dev_priv->psr.psr2_sel_fetch_enabled&&drivers/gpu/drm/i915/display/intel_psr.c +3
-1@@ -1158,12 +1163,14 @@ static void psr_force_hw_tracking_exit(struct drm_i915_private *dev_priv)* pipe. */ intel_de_write(dev_priv, CURSURFLIVE(dev_priv->psr.pipe), 0); - else + else { /* * A write to CURSURFLIVE do not cause HW tracking to exit PSR * on older gens so doing the manual exit instead. */ intel_psr_exit(dev_priv); +intel_psr_wait_idle (dev_priv); + } }void intel_psr2_program_plane_sel_fetch(struct
intel_plane*plane,drivers/gpu/drm/i915/display/intel_psr.c +0
-0@@ -1593,8 +1600,10 @@ void intel_psr_invalidate(struct drm_i915_private *dev_priv, frontbuffer_bits &= INTEL_FRONTBUFFER_ALL_MASK(dev_priv->psr.pipe); dev_priv->psr.busy_frontbuffer_bits |= frontbuffer_bits;drivers/gpu/drm/i915/display/intel_psr.c +1
-1-if (frontbuffer_bits) +if (frontbuffer_bits) {
intel_psr_exit(dev_priv);drivers/gpu/drm/i915/display/intel_psr.c +2
-0+intel_psr_wait_idle (dev_priv); + }
Quoted 2 lines
mutex_unlock(&dev_priv->psr.lock);
}
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 8 lines · Jose
Quoted 7 lines · Lee Shawn C
Driver should refer to commit '
b2fc2252ce41("drm/i915/psr:
Always wait for idle state when disabling PSR")' to wait for idle state when turn PSR off. But it did not follow previous method. Driver just callintel_psr_exit()inintel_psr_invalidate()andpsr_force_hw_tracking_exit(). Then leave the function right away.
Quoted 9 lines
Quoted 4 lines
After PSR disabled, we found some user space applications would enabled PSR again immediately. That caused particular TCON to get into incorrect state machine and can't recognize video data from source properly.
How? I don't see how this is possible this change is only adding delay between userspace calls.
Take a look at
intel_psr_work(), PSR will only be enabled again when idle.
Thanks for clarification! Per our finding, the problem was found on specific TCON support PSR2. Below is our observation on customer board.
After psr exit called at intel_psr_invalidate(), PSR2_STATUS (0x6f940, bit 31:28) report 0x3 sometimes. Which means source PSR state still active. Then we check sink's DPCD 2008h before re-enable PSR2 in intel_psr_work(). DPCD 2008h shows 0x2 (PSR active - display from RFB) sometimes.
Seems problem occurred when source re-enable PSR2 but sink still at PSR2 active state. TCON is not able to recognize video data. And corrupt display shows on eDP panel. Abnormal display is recoverable after modeset.
Looks like my change to wait PSR2 state idle adding more delay here to give more times for TCON back to normal state. Read DPCD 2008h to confirm sink's PSR2 status before re-enable PSR2 in intel_psr_work().
It will be 0x4 (Sink device Transition to PSR inactive - capture and display; timing re-sync) always. Then we can't replicate corrupt display issue anymore.
In my opinion, confirm DPCD 2008h moved to 0x4 before re-enable PSR2 may help this customer issue. What do you think?
Best regards,
Shawn
Quoted 124 lines
Quoted 124 lines
Add this change to wait PSR idle state in
intel_psr_invalidate()andpsr_force_hw_tracking_exit(). This symptom is not able to replicate anymore.Fixes b2fc2252ce41 (drm/i915/psr: Always wait for idle state whendisabling PSR).
Cc Manasi Navare <[email protected]>Cc Jani Nikula <[email protected]>Cc Ville Syrjala <[email protected]>Cc José Roberto de Souza <[email protected]>Cc Cooper Chiou <[email protected]>Cc Khaled Almahallawy <[email protected]>Signed-off-by Lee Shawn C <[email protected]>--- drivers/gpu/drm/i915/display/intel_psr.c | 43 ++++++++++++++---------- 1 file changed, 26 insertions(+), 17 deletions(-)drivers/gpu/drm/i915/display/intel_psr.c +15
-0@@ -1036,6 +1036,25 @@ void intel_psr_enable(struct intel_dp *intel_dp,mutex_unlock (&dev_priv->psr.lock); } +static void intel_psr_wait_idle (struct drm_i915_private *dev_priv) { +i915_reg_t psr_status; +u32 psr_status_mask; + +if (dev_priv->psr.psr2_enabled) { +psr_status =EDP_PSR2_STATUS (dev_priv->psr.transcoder); +psr_status_mask =EDP_PSR2_STATUS_STATE_MASK ; }else { psr_status = +EDP_PSR_STATUS (dev_priv->psr.transcoder); +psr_status_mask =EDP_PSR_STATUS_STATE_MASK ; } + +/* Wait till PSR is idle */ +if (intel_de_wait_for_clear (dev_priv, psr_status, + psr_status_mask,2000 )) +drm_err (&dev_priv->drm,"Timed out waiting PSR idle state\n" ); } +static void intel_psr_exit (struct drm_i915_private *dev_priv) {u32 val;@@ -1076,8 +1095,6 @@ static void intel_psr_exit(struct
drm_i915_private*dev_priv) static voidintel_psr_disable_locked(struct intel_dp *intel_dp){ structdrm_i915_private*dev_priv=dp_to_i915(intel_dp); -i915_reg_tpsr_status;drivers/gpu/drm/i915/display/intel_psr.c +1
-11-u32 psr_status_mask;lockdep_assert_held (&dev_priv->psr.lock);@@ -1088,19 +1105,7 @@ static void intel_psr_disable_locked(struct intel_dp *intel_dp) dev_priv->psr.psr2_enabled ? "2" : "1");intel_psr_exit (dev_priv); - -if (dev_priv->psr.psr2_enabled) { -psr_status =EDP_PSR2_STATUS (dev_priv->psr.transcoder); -psr_status_mask = EDP_PSR2_STATUS_STATE_MASK; -} else { -psr_status =EDP_PSR_STATUS (dev_priv->psr.transcoder); -psr_status_mask = EDP_PSR_STATUS_STATE_MASK; -} - -/* Wait till PSR is idle */ -if (intel_de_wait_for_clear (dev_priv, psr_status, - psr_status_mask,2000 )) -drm_err (&dev_priv->drm,"Timed out waiting PSR idle state\n" ); +intel_psr_wait_idle (dev_priv);/* WA 1408330847 */ if (dev_priv->psr.psr2_sel_fetch_enabled && @@ -1158,12 +1163,14 @@static void
psr_force_hw_tracking_exit(struct drm_i915_private *dev_priv)
* pipe.
*/
intel_de_write(dev_priv, CURSURFLIVE(dev_priv->psr.pipe), 0); -elsedrivers/gpu/drm/i915/display/intel_psr.c +3
-1+else {/* * A write to CURSURFLIVE do not cause HW tracking to exit PSR * on older gens so doing the manual exit instead. */ intel_psr_exit (dev_priv); +intel_psr_wait_idle (dev_priv); +} } void intel_psr2_program_plane_sel_fetch(struct intel_plane *plane, @@ -1593,8 +1600,10 @@ void intel_psr_invalidate(struct drm_i915_private
*dev_priv,frontbuffer_bits&=INTEL_FRONTBUFFER_ALL_MASK(dev_priv->psr.pipe);
dev_priv->psr.busy_frontbuffer_bits|=frontbuffer_bits;drivers/gpu/drm/i915/display/intel_psr.c +3
-1-if (frontbuffer_bits) +if (frontbuffer_bits) {intel_psr_exit (dev_priv); +intel_psr_wait_idle (dev_priv); +}
Quoted 2 lines
Quoted 2 lines
mutex_unlock(&dev_priv->psr.lock);
}
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 35 lines · Lee Shawn C
Quoted 8 lines · Jose
Quoted 7 lines · Lee Shawn C
Driver should refer to commit '
b2fc2252ce41("drm/i915/psr:
Always wait for idle state when disabling PSR")' to wait for idle state when turn PSR off. But it did not follow previous method. Driver just callintel_psr_exit()inintel_psr_invalidate()andpsr_force_hw_tracking_exit(). Then leave the function right away.Quoted 9 lines
Quoted 4 lines
After PSR disabled, we found some user space applications would enabled PSR again immediately. That caused particular TCON to get into incorrect state machine and can't recognize video data from source properly.
How? I don't see how this is possible this change is only adding delay between userspace calls.
Take a look at
intel_psr_work(), PSR will only be enabled again when idle.Thanks for clarification! Per our finding, the problem was found on specific TCON support PSR2. Below is our observation on customer board.
After psr exit called at
intel_psr_invalidate(),PSR2_STATUS(0x6f940, bit 31:28) report0x3sometimes. Which means source PSR state still active. Then we check sink's DPCD 2008h before re-enable PSR2 inintel_psr_work(). DPCD 2008h shows0x2(PSR active - display from RFB) sometimes.Seems problem occurred when source re-enable PSR2 but sink still at PSR2 active state. TCON is not able to recognize video data. And corrupt display shows on eDP panel. Abnormal display is recoverable after modeset.
Looks like my change to wait PSR2 state idle adding more delay here to give more times for TCON back to normal state. Read DPCD 2008h to confirm sink's PSR2 status before re-enable PSR2 in
intel_psr_work().
It will be0x4(Sink device Transition to PSR inactive - capture and display; timing re-sync) always. Then we can't replicate corrupt display issue anymore.
Quoted 6 lines
In my opinion, confirm DPCD 2008h moved to
0x4before re-enable PSR2 may help this customer issue. What do you think?Best regards,
Shawn
Per previous comment, it is a little complicated from source to align sink's PSR state. Even source PSR2 state already idle. But sink PSR2 state still at "active" sometimes.
Here is another idea. How about to disable/re-enable sink's PSR2 just like driver did for source as well? Sink would back to normal display mode after PSR disabled. Then we can enable PSR again in intel_psr_work() before driver try to turn source PSR on.
Best regards,
Shawn
Quoted 125 lines
Quoted 125 lines
Quoted 125 lines
Add this change to wait PSR idle state in
intel_psr_invalidate()andpsr_force_hw_tracking_exit(). This symptom is not able to replicate anymore.Fixes b2fc2252ce41 (drm/i915/psr: Always wait for idle state whendisabling PSR).
Cc Manasi Navare <[email protected]>Cc Jani Nikula <[email protected]>Cc Ville Syrjala <[email protected]>Cc José Roberto de Souza <[email protected]>Cc Cooper Chiou <[email protected]>Cc Khaled Almahallawy <[email protected]>Signed-off-by Lee Shawn C <[email protected]>--- drivers/gpu/drm/i915/display/intel_psr.c | 43 ++++++++++++++---------- 1 file changed, 26 insertions(+), 17 deletions(-)drivers/gpu/drm/i915/display/intel_psr.c +15
-0@@ -1036,6 +1036,25 @@ void intel_psr_enable(struct intel_dp *intel_dp,mutex_unlock (&dev_priv->psr.lock); } +static void intel_psr_wait_idle (struct drm_i915_private *dev_priv) { +i915_reg_t psr_status; +u32 psr_status_mask; + +if (dev_priv->psr.psr2_enabled) { +psr_status =EDP_PSR2_STATUS (dev_priv->psr.transcoder); +psr_status_mask =EDP_PSR2_STATUS_STATE_MASK ; }else { psr_status = +EDP_PSR_STATUS (dev_priv->psr.transcoder); +psr_status_mask =EDP_PSR_STATUS_STATE_MASK ; } + +/* Wait till PSR is idle */ +if (intel_de_wait_for_clear (dev_priv, psr_status, + psr_status_mask,2000 )) +drm_err (&dev_priv->drm,"Timed out waiting PSR idle state\n" ); } +static void intel_psr_exit (struct drm_i915_private *dev_priv) {u32 val;@@ -1076,8 +1095,6 @@ static void intel_psr_exit(struct
drm_i915_private*dev_priv) static voidintel_psr_disable_locked(struct intel_dp *intel_dp){ structdrm_i915_private*dev_priv=dp_to_i915(intel_dp); -i915_reg_tpsr_status;drivers/gpu/drm/i915/display/intel_psr.c +1
-11-u32 psr_status_mask;lockdep_assert_held (&dev_priv->psr.lock);@@ -1088,19 +1105,7 @@ static void intel_psr_disable_locked(struct intel_dp *intel_dp) dev_priv->psr.psr2_enabled ? "2" : "1");intel_psr_exit (dev_priv); - -if (dev_priv->psr.psr2_enabled) { -psr_status =EDP_PSR2_STATUS (dev_priv->psr.transcoder); -psr_status_mask = EDP_PSR2_STATUS_STATE_MASK; -} else { -psr_status = EDP_PSR_STATUS(dev_priv->psr.transcoder); -psr_status_mask = EDP_PSR_STATUS_STATE_MASK; -} - -/* Wait till PSR is idle */ -if (intel_de_wait_for_clear (dev_priv, psr_status, - psr_status_mask,2000 )) -drm_err (&dev_priv->drm,"Timed out waiting PSR idle state\n" ); +intel_psr_wait_idle (dev_priv);/* WA 1408330847 */ if (dev_priv->psr.psr2_sel_fetch_enabled && @@ -1158,12 +1163,14 @@static void
psr_force_hw_tracking_exit(struct drm_i915_private *dev_priv)
* pipe.
*/
intel_de_write(dev_priv, CURSURFLIVE(dev_priv->psr.pipe), 0); -elsedrivers/gpu/drm/i915/display/intel_psr.c +3
-0+else {/* * A write to CURSURFLIVE do not cause HW tracking to exit PSR * on older gens so doing the manual exit instead. */ intel_psr_exit (dev_priv); +intel_psr_wait_idle (dev_priv); +} } void intel_psr2_program_plane_sel_fetch(struct intel_plane *plane,@@
-1593,8 +1600,10 @@ void intel_psr_invalidate(structdrm_i915_private*dev_priv,frontbuffer_bits&=INTEL_FRONTBUFFER_ALL_MASK(dev_priv->psr.pipe);
dev_priv->psr.busy_frontbuffer_bits|=frontbuffer_bits;drivers/gpu/drm/i915/display/intel_psr.c +3
-1-if (frontbuffer_bits) +if (frontbuffer_bits) {intel_psr_exit (dev_priv); +intel_psr_wait_idle (dev_priv); +}
Quoted 3 lines
Quoted 2 lines
Quoted 2 lines
mutex_unlock(&dev_priv->psr.lock);
}
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 43 lines · Shawn C
Quoted 35 lines · Lee Shawn C
Quoted 8 lines · Jose
Quoted 7 lines · Lee Shawn C
Driver should refer to commit '
b2fc2252ce41("drm/i915/psr:
Always wait for idle state when disabling PSR")' to wait for idle state when turn PSR off. But it did not follow previous method. Driver just callintel_psr_exit()inintel_psr_invalidate()andpsr_force_hw_tracking_exit(). Then leave the function right away.Quoted 9 lines
Quoted 4 lines
After PSR disabled, we found some user space applications would enabled PSR again immediately. That caused particular TCON to get into incorrect state machine and can't recognize video data from source properly.
How? I don't see how this is possible this change is only adding delay between userspace calls.
Take a look at
intel_psr_work(), PSR will only be enabled again when idle.Thanks for clarification! Per our finding, the problem was found on specific TCON support PSR2. Below is our observation on customer board.
After psr exit called at
intel_psr_invalidate(),PSR2_STATUS(0x6f940, bit 31:28) report0x3sometimes. Which means source PSR state still active. Then we check sink's DPCD 2008h before re-enable PSR2 inintel_psr_work(). DPCD 2008h shows0x2(PSR active - display from RFB) sometimes.Seems problem occurred when source re-enable PSR2 but sink still at PSR2 active state. TCON is not able to recognize video data. And corrupt display shows on eDP panel. Abnormal display is recoverable after modeset.
Looks like my change to wait PSR2 state idle adding more delay here to give more times for TCON back to normal state. Read DPCD 2008h to confirm sink's PSR2 status before re-enable PSR2 in
intel_psr_work().
It will be0x4(Sink device Transition to PSR inactive - capture and display; timing re-sync) always. Then we can't replicate corrupt display issue anymore.Quoted 6 lines
In my opinion, confirm DPCD 2008h moved to
0x4before re-enable PSR2 may help this customer issue. What do you think?Best regards,
Shawn
Quoted 5 lines
Per previous comment, it is a little complicated from source to align sink's PSR state. Even source PSR2 state already idle. But sink PSR2 state still at "active" sometimes.
Here is another idea. How about to disable/re-enable sink's PSR2 just like driver did for source as well? Sink would back to normal display mode after PSR disabled. Then we can enable PSR again inintel_psr_work()before driver try to turn source PSR on.
Source HW already sends in SDP, PSR entry and exit notifications by it self.
This looks like a panel specific problem, we can't add a global workaround for it.
Also do the disable and enable would involve even more changes in the code and more time with PSR disable, losing some power savings. This code is to handle frontbuffer modifications, modern user spaces should not hit this case, I'm wondering what your costumer is using.
Anyways, give a try with: https://patchwork.freedesktop.org/series/82351/
It is working around a issue that we are seeing in multiple panels 4K, until root caused we are going to use this workaround. Planing to merge it in a couple of hours.
Quoted 133 lines
Best regards,
ShawnQuoted 128 lines
Quoted 127 lines
Quoted 127 lines
Add this change to wait PSR idle state in
intel_psr_invalidate()andpsr_force_hw_tracking_exit(). This symptom is not able to replicate anymore.Fixes b2fc2252ce41 (drm/i915/psr: Always wait for idle state whendisabling PSR).
Cc Manasi Navare <[email protected]>Cc Jani Nikula <[email protected]>Cc Ville Syrjala <[email protected]>Cc José Roberto de Souza <[email protected]>Cc Cooper Chiou <[email protected]>Cc Khaled Almahallawy <[email protected]>Signed-off-by Lee Shawn C <[email protected]>---
drivers/gpu/drm/i915/display/intel_psr.c | 43
++++++++++++++----------1 file changed, 26 insertions(+), 17 deletions(-)drivers/gpu/drm/i915/display/intel_psr.c +15
-0@@ -1036,6 +1036,25 @@ void intel_psr_enable(struct intel_dp *intel_dp,mutex_unlock (&dev_priv->psr.lock); } +static void intel_psr_wait_idle (struct drm_i915_private *dev_priv) { +i915_reg_t psr_status; +u32 psr_status_mask; + +if (dev_priv->psr.psr2_enabled) { +psr_status =EDP_PSR2_STATUS (dev_priv->psr.transcoder); +psr_status_mask =EDP_PSR2_STATUS_STATE_MASK ; }else { psr_status = +EDP_PSR_STATUS (dev_priv->psr.transcoder); +psr_status_mask =EDP_PSR_STATUS_STATE_MASK ; } + +/* Wait till PSR is idle */ +if (intel_de_wait_for_clear (dev_priv, psr_status, + psr_status_mask,2000 )) +drm_err (&dev_priv->drm,"Timed out waiting PSR idle state\n" ); } +static void
intel_psr_exit(struct drm_i915_private *dev_priv){ u32 val;drivers/gpu/drm/i915/display/intel_psr.c +0
-0@@ -1076,8 +1095,6 @@ static void intel_psr_exit(struct
drm_i915_private*dev_priv) static voidintel_psr_disable_locked(struct intel_dp *intel_dp){ structdrm_i915_private*dev_priv=dp_to_i915(intel_dp); -i915_reg_tpsr_status;
-u32psr_status_mask;lockdep_assert_held(&dev_priv->psr.lock);
drivers/gpu/drm/i915/display/intel_psr.c +1
-10@@ -1088,19 +1105,7 @@ static void intel_psr_disable_locked(struct intel_dp *intel_dp) dev_priv->psr.psr2_enabled ? "2" : "1"); intel_psr_exit(dev_priv); - -if (dev_priv->psr.psr2_enabled) { -psr_status =EDP_PSR2_STATUS (dev_priv->psr.transcoder); -psr_status_mask = EDP_PSR2_STATUS_STATE_MASK; -} else { -psr_status = EDP_PSR_STATUS(dev_priv->psr.transcoder); -psr_status_mask = EDP_PSR_STATUS_STATE_MASK; -} - -/* Wait till PSR is idle */ -if (intel_de_wait_for_clear (dev_priv, psr_status, - psr_status_mask,2000 )) -drm_err (&dev_priv->drm,"Timed out waiting PSR idle state\n" ); +intel_psr_wait_idle (dev_priv);/* WA 1408330847 */
if (dev_priv->psr.psr2_sel_fetch_enabled&& @@ -1158,12 +1163,14 @@ static voidpsr_force_hw_tracking_exit(struct drm_i915_private *dev_priv)
* pipe.
*/
intel_de_write(dev_priv,CURSURFLIVE(dev_priv->psr.pipe), 0); -else +else {
/*
* A write to CURSURFLIVE do not cause HW tracking to exit PSR
* on older gens so doing the manual exit instead.
*/
intel_psr_exit(dev_priv);drivers/gpu/drm/i915/display/intel_psr.c +2
-0+intel_psr_wait_idle (dev_priv); +}}
void intel_psr2_program_plane_sel_fetch(struct
intel_plane*plane, @@
-1593,8 +1600,10 @@ void intel_psr_invalidate(structdrm_i915_private*dev_priv,frontbuffer_bits&=INTEL_FRONTBUFFER_ALL_MASK(dev_priv->psr.pipe);dev_priv->psr.busy_frontbuffer_bits|=frontbuffer_bits;drivers/gpu/drm/i915/display/intel_psr.c +1
-1-if (frontbuffer_bits) +if (frontbuffer_bits) {intel_psr_exit(dev_priv);
drivers/gpu/drm/i915/display/intel_psr.c +2
-0+intel_psr_wait_idle (dev_priv); +}mutex_unlock(&dev_priv->psr.lock);
}
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 231 lines · Jose
Quoted 59 lines · Shawn C
Quoted 50 lines · Lee Shawn C
Quoted 18 lines · Jose
Quoted 9 lines · Lee Shawn C
Driver should refer to commit '
b2fc2252ce41("drm/i915/psr:
Always wait for idle state when disabling PSR")' to wait for idle
state when turn PSR off. But it did not follow previous method.
Driver just callintel_psr_exit()inintel_psr_invalidate()andpsr_force_hw_tracking_exit(). Then leave the function right away.Quoted 7 lines
After PSR disabled, we found some user space applications would
enabled PSR again immediately. That caused particular TCON to get
into incorrect state machine and can't recognize video data from
source properly.Quoted 6 lines
How? I don't see how this is possible this change is only adding delay between userspace calls.
Take a look at
intel_psr_work(), PSR will only be enabled again when idle.Thanks for clarification! Per our finding, the problem was found on specific TCON support PSR2.
Below is our observation on customer board.After psr exit called at
intel_psr_invalidate(),PSR2_STATUS(0x6f940, bit 31:28) report0x3sometimes.
Which means source PSR state still active. Then we check sink's DPCD 2008h before re-enable PSR2 inintel_psr_work(). DPCD 2008h shows0x2(PSR active - display from RFB) sometimes.Seems problem occurred when source re-enable PSR2 but sink still at PSR2 active state.
TCON is not able to recognize video data. And corrupt display shows on eDP panel.
Abnormal display is recoverable after modeset.Looks like my change to wait PSR2 state idle adding more delay here to give more times for TCON back to normal state. Read DPCD 2008h to confirm sink's PSR2 status before re-enable PSR2 in
intel_psr_work().
It will be0x4(Sink device Transition to PSR inactive - capture and display; timing re-sync) always.
Then we can't replicate corrupt display issue anymore.Quoted 7 lines
In my opinion, confirm DPCD 2008h moved to
0x4before re-enable PSR2 may help this customer issue.
What do you think?Best regards,
ShawnQuoted 9 lines
Per previous comment, it is a little complicated from source to align sink's PSR state.
Even source PSR2 state already idle. But sink PSR2 state still at "active" sometimes.
Here is another idea. How about to disable/re-enable sink's PSR2 just like driver did for source as well?
Sink would back to normal display mode after PSR disabled. Then we can enable PSR again inintel_psr_work()
before driver try to turn source PSR on.Source HW already sends in SDP, PSR entry and exit notifications by it self.
This looks like a panel specific problem, we can't add a global workaround for it.
Also do the disable and enable would involve even more changes in the code and more time with PSR disable, losing some power savings. This code is to handle frontbuffer modifications, modern user spaces should not hit this case, I'm wondering what your costumer is using.Anyways, give a try with:
https://patchwork.freedesktop.org/series/82351/
It is working around a issue that we are seeing in multiple panels 4K, until root caused we are going to use this workaround. Planing to merge it in a
couple of hours.Quoted 145 lines
Best regards,
ShawnQuoted 142 lines
Quoted 142 lines
Quoted 142 lines
Add this change to wait PSR idle state in
intel_psr_invalidate()andpsr_force_hw_tracking_exit(). This symptom is not able to replicate
anymore.Fixes b2fc2252ce41 (drm/i915/psr: Always wait for idle statewhen
disabling PSR).Cc Manasi Navare <[email protected]>Cc Jani Nikula <[email protected]>Cc Ville Syrjala <[email protected]>Cc José Roberto de Souza <[email protected]>Cc Cooper Chiou <[email protected]>Cc Khaled Almahallawy <[email protected]>Signed-off-by Lee Shawn C <[email protected]>--- drivers/gpu/drm/i915/display/intel_psr.c | 43 ++++++++++++++---------- 1 file changed, 26 insertions(+), 17 deletions(-)drivers/gpu/drm/i915/display/intel_psr.c +1
-0@@ -1036,6 +1036,25 @@ void intel_psr_enable(struct intel_dp *intel_dp,mutex_unlock (&dev_priv->psr.lock); } +static void intel_psr_wait_idle(struct drm_i915_private
*dev_priv) {drivers/gpu/drm/i915/display/intel_psr.c +6
-0+i915_reg_t psr_status; +u32 psr_status_mask; + +if (dev_priv->psr.psr2_enabled) { +psr_status =EDP_PSR2_STATUS (dev_priv->psr.transcoder); +psr_status_mask =EDP_PSR2_STATUS_STATE_MASK ; }else {
psr_status=drivers/gpu/drm/i915/display/intel_psr.c +7
-0+EDP_PSR_STATUS (dev_priv->psr.transcoder); +psr_status_mask =EDP_PSR_STATUS_STATE_MASK ; } + +/* Wait till PSR is idle */ +if (intel_de_wait_for_clear (dev_priv, psr_status, + psr_status_mask,2000 )) +drm_err(&dev_priv->drm, "Timed out waiting PSR idlestate\n"); }
+
static void intel_psr_exit(structdrm_i915_private*dev_priv) {
u32 val;drivers/gpu/drm/i915/display/intel_psr.c +0
-0@@ -1076,8 +1095,6 @@ static void intel_psr_exit(struct
drm_i915_private*dev_priv) static voidintel_psr_disable_locked(struct intel_dp *intel_dp){ structdrm_i915_private*dev_priv=dp_to_i915(intel_dp); -i915_reg_tpsr_status;drivers/gpu/drm/i915/display/intel_psr.c +0
-6-u32 psr_status_mask;lockdep_assert_held (&dev_priv->psr.lock);@@ -1088,19 +1105,7 @@ static void intel_psr_disable_locked(struct intel_dp *intel_dp) dev_priv->psr.psr2_enabled ? "2" : "1");intel_psr_exit (dev_priv); - -if (dev_priv->psr.psr2_enabled) { -psr_status =EDP_PSR2_STATUS (dev_priv->psr.transcoder); -psr_status_mask = EDP_PSR2_STATUS_STATE_MASK; -} else { -psr_status=
EDP_PSR_STATUS(dev_priv->psr.transcoder);drivers/gpu/drm/i915/display/intel_psr.c +0
-6-psr_status_mask = EDP_PSR_STATUS_STATE_MASK; -} - -/* Wait till PSR is idle */ -if (intel_de_wait_for_clear (dev_priv, psr_status, - psr_status_mask,2000 )) -drm_err(&dev_priv->drm, "Timed out waiting PSR idlestate\n");
+intel_psr_wait_idle(dev_priv);/* WA 1408330847 */
if (dev_priv->psr.psr2_sel_fetch_enabled&& @@ -1158,12
+1163,14 @@
static voidpsr_force_hw_tracking_exit(struct drm_i915_private *dev_priv)
* pipe.
*/
intel_de_write(dev_priv,CURSURFLIVE(dev_priv->psr.pipe),
0); -else
+else {
/*
* A write to CURSURFLIVE do not cause HW tracking to exit
PSR
* on older gens so doing the manual exit instead. */
intel_psr_exit(dev_priv);drivers/gpu/drm/i915/display/intel_psr.c +2
-0+intel_psr_wait_idle (dev_priv); +} } void intel_psr2_program_plane_sel_fetch(struct intel_plane*plane,
@@
-1593,8 +1600,10 @@ void intel_psr_invalidate(structdrm_i915_private*dev_priv,frontbuffer_bits&=INTEL_FRONTBUFFER_ALL_MASK(dev_priv->psr.pipe);
dev_priv->psr.busy_frontbuffer_bits|=frontbuffer_bits;drivers/gpu/drm/i915/display/intel_psr.c +3
-1-if (frontbuffer_bits) +if (frontbuffer_bits) {intel_psr_exit (dev_priv); +intel_psr_wait_idle (dev_priv); +}
Quoted 3 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
mutex_unlock(&dev_priv->psr.lock);
}
Hi Shawn,
I agree with Jose's opinion.
If the patch mitigates your PSR2 Panel issues, it might be a workaround hotfix.
But we need to clarify which device raises the issue between sink (specific tcon) and source (gen9). After then we can suggest the proper solution.
And please check the last vsc sdp which is sent from source, and sink's psr state machine state.
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: wait PSR state back to idle when turn PSR off
In reply to Lee Shawn C== Series Details ==
== Series Details ==
Series: drm/i915: wait PSR state back to idle when turn PSR off
URL : https://patchwork.freedesktop.org/series/82920/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9176_full -> Patchwork_18754_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18754_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_18754_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18754_full:
### IGT changes ###
#### Possible regressions ####
* igt@prime_vgem@coherency-blt:
- shard-hsw: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-hsw7/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-hsw2/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_18754_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_whisper@basic-contexts:
- shard-glk: [PASS][3] -> [DMESG-WARN][4] ([i915#118] / [i915#95]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-glk1/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-glk6/igt@[email protected]
* igt@i915_suspend@debugfs-reader:
- shard-kbl: [PASS][5] -> [INCOMPLETE][6] ([i915#155])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-kbl1/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-kbl4/igt@[email protected]
* igt@kms_big_fb@y-tiled-8bpp-rotate-180:
- shard-kbl: [PASS][7] -> [DMESG-WARN][8] ([i915#1982])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-kbl1/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-kbl4/igt@[email protected]
* igt@kms_big_fb@yf-tiled-32bpp-rotate-270:
- shard-apl: [PASS][9] -> [DMESG-WARN][10] ([i915#1635] / [i915#1982]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-apl4/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-apl4/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen:
- shard-skl: [PASS][11] -> [FAIL][12] ([i915#54])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-skl5/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-skl2/igt@[email protected]
* igt@kms_cursor_edge_walk@pipe-b-128x128-top-edge:
- shard-glk: [PASS][13] -> [DMESG-WARN][14] ([i915#1982])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-glk1/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-glk6/igt@[email protected]
* igt@kms_cursor_edge_walk@pipe-b-256x256-right-edge:
- shard-skl: [PASS][15] -> [DMESG-WARN][16] ([i915#1982]) +5 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-skl5/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-skl2/igt@[email protected]
* igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy:
- shard-glk: [PASS][17] -> [FAIL][18] ([i915#72])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-glk5/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-glk5/igt@[email protected]
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size:
- shard-hsw: [PASS][19] -> [FAIL][20] ([i915#2370])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-hsw8/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-hsw8/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2:
- shard-glk: [PASS][21] -> [FAIL][22] ([i915#79])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-glk4/igt@kms_flip@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-glk9/igt@kms_flip@[email protected]
* igt@kms_flip_tiling@flip-to-yf-tiled:
- shard-skl: [PASS][23] -> [FAIL][24] ([i915#167])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-skl5/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-skl2/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-rte:
- shard-tglb: [PASS][25] -> [DMESG-WARN][26] ([i915#1982]) +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-tglb1/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-tglb3/igt@[email protected]
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [PASS][27] -> [FAIL][28] ([i915#1188]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-skl5/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-skl2/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][29] -> [FAIL][30] ([fdo#108145] / [i915#265]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-skl5/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-skl2/igt@[email protected]
* igt@kms_psr2_su@page_flip:
- shard-iclb: [PASS][31] -> [SKIP][32] ([fdo#109642] / [fdo#111068])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-iclb2/igt@kms_psr2_su@page_flip.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-iclb5/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [PASS][33] -> [SKIP][34] ([fdo#109441]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-iclb5/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@perf@polling:
- shard-hsw: [PASS][35] -> [SKIP][36] ([fdo#109271])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-hsw7/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-hsw2/igt@[email protected]
* igt@perf@polling-parameterized:
- shard-tglb: [PASS][37] -> [FAIL][38] ([i915#1542])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-tglb1/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-tglb3/igt@[email protected]
#### Possible fixes ####
* igt@device_reset@unbind-reset-rebind:
- shard-iclb: [DMESG-WARN][39] ([i915#1982]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-iclb6/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-iclb1/igt@[email protected]
* igt@gem_eio@in-flight-contexts-10ms:
- shard-skl: [INCOMPLETE][41] ([i915#1909]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-skl1/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-skl4/igt@[email protected]
* igt@gem_exec_flush@basic-wb-prw-default:
- shard-skl: [DMESG-WARN][43] ([i915#1982]) -> [PASS][44] +9 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-skl4/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-skl6/igt@[email protected]
* igt@gem_exec_reloc@basic-many-active@rcs0:
- shard-snb: [FAIL][45] ([i915#2389]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-snb4/igt@gem_exec_reloc@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-snb5/igt@gem_exec_reloc@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-128x128-onscreen:
- shard-skl: [FAIL][47] ([i915#54]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-skl9/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-skl10/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [FAIL][49] ([i915#2346]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_draw_crc@draw-method-xrgb8888-render-xtiled:
- shard-snb: [FAIL][51] ([i915#54]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-snb7/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-snb2/igt@[email protected]
* igt@kms_flip@2x-plain-flip-ts-check@bc-vga1-hdmi-a1:
- shard-hsw: [INCOMPLETE][53] -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-hsw2/igt@kms_flip@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-hsw8/igt@kms_flip@[email protected]
* igt@kms_flip@blocking-wf_vblank@a-edp1:
- shard-tglb: [DMESG-WARN][55] ([i915#1982]) -> [PASS][56] +2 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-tglb7/igt@kms_flip@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-tglb8/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1:
- shard-skl: [FAIL][57] ([i915#2122]) -> [PASS][58] +2 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-skl3/igt@kms_flip@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-skl4/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-modesetfrombusy:
- shard-snb: [FAIL][59] ([i915#2546]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-snb7/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-snb2/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][61] ([fdo#108145] / [i915#265]) -> [PASS][62] +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-skl9/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-skl10/igt@[email protected]
* igt@kms_plane_cursor@pipe-a-primary-size-256:
- shard-glk: [DMESG-WARN][63] ([i915#1982]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-glk2/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-glk3/igt@[email protected]
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][65] ([fdo#109441]) -> [PASS][66] +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-iclb5/igt@kms_psr@psr2_cursor_render.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
* igt@kms_universal_plane@universal-plane-gen9-features-pipe-a:
- shard-apl: [DMESG-WARN][67] ([i915#1635] / [i915#1982]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-apl3/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-apl2/igt@[email protected]
#### Warnings ####
* igt@core_hotunplug@hotrebind-lateclose:
- shard-hsw: [FAIL][69] -> [WARN][70] ([i915#2283])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-hsw7/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-hsw2/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-suspend:
- shard-tglb: [DMESG-WARN][71] ([i915#2411]) -> [DMESG-WARN][72] ([i915#1982] / [i915#2411])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-tglb3/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-tglb1/igt@[email protected]
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-tglb: [INCOMPLETE][73] ([i915#2411] / [i915#456]) -> [DMESG-WARN][74] ([i915#2411])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-tglb1/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-tglb6/igt@[email protected]
* igt@kms_setmode@basic:
- shard-skl: [FAIL][75] ([i915#31]) -> [DMESG-FAIL][76] ([i915#1982] / [i915#31])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9176/shard-skl5/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/shard-skl2/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#167]: https://gitlab.freedesktop.org/drm/intel/issues/167
[i915#1909]: https://gitlab.freedesktop.org/drm/intel/issues/1909
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2283]: https://gitlab.freedesktop.org/drm/intel/issues/2283
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2370]: https://gitlab.freedesktop.org/drm/intel/issues/2370
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9176 -> Patchwork_18754
CI-20190529: 20190529
CI_DRM_9176: e3d4f747f53899164788f2008a16c82d236b762a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5822: b4bcf05cb9839037128905deda7146434155cc41 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18754: 57f806dd4a6ee5165de688c2135fee878b3da06a @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18754/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx