btf_encoder: ignore zero-sized ELF symbols
Andrii Nakryiko
maintainerPATCH 1/1 btf_encoder: ignore zero-sized ELF symbols
It's legal for ELF symbol to have size 0, if it's size is unknown or unspecified. Instead of erroring out, just ignore such symbols, as they can't be a valid per-CPU variable anyways.
Signed-off-by Andrii Nakryiko <[email protected]>
--- btf_encoder.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)
btf_encoder.c +4 -8
@@ -287,6 +287,10 @@ static int find_all_percpu_vars(struct btf_elf *btfe)if (!addr)continue ; + size =elf_sym__size (&sym); +if (!size) +continue ;/* ignore zero-sized symbols */ + sym_name =elf_sym__name (&sym, btfe->symtab);if (!btf_name_valid (sym_name)) { dump_invalid_symbol("Found symbol of invalid name when encoding btf",
@@ -295,14 +299,6 @@ static int find_all_percpu_vars(struct btf_elf *btfe)continue ;return -1 ; } - size =elf_sym__size (&sym); -if (!size) { -dump_invalid_symbol ("Found symbol of zero size when encoding btf" , - sym_name, btf_elf__verbose, btf_elf__force); -if (btf_elf__force) -continue ; -return -1 ; - }if (btf_elf__verbose)printf ("Found per-CPU symbol '%s' at address 0x%lx\n" , sym_name, addr);
Signature · 1 line
2.24.1
Quoted 5 lines · Andrii Nakryiko
It's legal for ELF symbol to have size 0, if it's size is unknown or unspecified. Instead of erroring out, just ignore such symbols, as they can't be a valid per-CPU variable anyways.
Signed-off-by Andrii Nakryiko <[email protected]>
Tested-by Jiri Slaby <[email protected]>
Quoted 35 lines
--- btf_encoder.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)btf_encoder.c +4
-8@@ -287,6 +287,10 @@ static int find_all_percpu_vars(struct btf_elf *btfe)if (!addr)continue ; + size =elf_sym__size (&sym); +if (!size) +continue ;/* ignore zero-sized symbols */ + sym_name =elf_sym__name (&sym, btfe->symtab);if (!btf_name_valid (sym_name)) { dump_invalid_symbol("Found symbol of invalid name when encoding btf",@@ -295,14 +299,6 @@ static int find_all_percpu_vars(struct btf_elf *btfe)continue ;return -1 ; } - size =elf_sym__size (&sym); -if (!size) { -dump_invalid_symbol ("Found symbol of zero size when encoding btf" , - sym_name, btf_elf__verbose, btf_elf__force); -if (btf_elf__force) -continue ; -return -1 ; - }if (btf_elf__verbose)printf ("Found per-CPU symbol '%s' at address 0x%lx\n" , sym_name, addr);
Signature · 2 lines
js suse labs
Arnaldo Carvalho de Melo
AppliedEm Thu, Oct 22, 2020 at 07:19:32AM +0200, Jiri Slaby escreveu:
Quoted 8 lines · Andrii Nakryiko
Quoted 5 lines
It's legal for ELF symbol to have size 0, if it's size is unknown or unspecified. Instead of erroring out, just ignore such symbols, as they can't be a valid per-CPU variable anyways.
Signed-off-by Andrii Nakryiko <[email protected]>Tested-by Jiri Slaby <[email protected]>
thanks applied
Quoted 38 lines
Quoted 33 lines
--- btf_encoder.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)btf_encoder.c +4
-8@@ -287,6 +287,10 @@ static int find_all_percpu_vars(struct btf_elf *btfe)if (!addr)continue ; + size =elf_sym__size (&sym); +if (!size) +continue ;/* ignore zero-sized symbols */ + sym_name =elf_sym__name (&sym, btfe->symtab);if (!btf_name_valid (sym_name)) { dump_invalid_symbol("Found symbol of invalid name when encoding btf",@@ -295,14 +299,6 @@ static int find_all_percpu_vars(struct btf_elf *btfe)continue ;return -1 ; } - size =elf_sym__size (&sym); -if (!size) { -dump_invalid_symbol ("Found symbol of zero size when encoding btf" , - sym_name, btf_elf__verbose, btf_elf__force); -if (btf_elf__force) -continue ; -return -1 ; - }if (btf_elf__verbose)printf ("Found per-CPU symbol '%s' at address 0x%lx\n" , sym_name, addr);Signature · 2 lines
js suse labs
Signature · 1 line
- Arnaldo