Skip to contentSkip to conversation

dt-bindings: thermal: mediatek: make resets property optional

PATCH Applied Fabien Parent 5 participants 10 messages Oct 21, 2020 – Nov 24, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 dt-bindings: thermal: mediatek: make resets property optional

MT8516 Thermal IP does not support reset. Make the resets property optional in order to be able to support MT8516 SoC.

---
 Documentation/devicetree/bindings/thermal/mediatek-thermal.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt +1 -1
index 1e249c42fae0..2d20f6b0dca0 100644
@@ -20,12 +20,12 @@ Required properties:
                        clocks are:
 		       "therm":	 Main clock needed for register access
 		       "auxadc": The AUXADC clock
-- resets: Reference to the reset controller controlling the thermal controller.
 - mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
 - mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
 - #thermal-sensor-cells : Should be 0. See Documentation/devicetree/bindings/thermal/thermal-sensor.yaml for a description.
 
 Optional properties:
+- resets: Reference to the reset controller controlling the thermal controller.
 - nvmem-cells: A phandle to the calibration data provided by a nvmem device. If
                unspecified default values shall be used.
 - nvmem-cell-names: Should be "calibration-data"
Signature · 1 line
2.28.0
#1 lore raw

PATCH 2/3 dt-bindings: thermal: mediatek: add documentation for MT8516 SoC

Add binding documentation for the MediaTek MT8516 SoC. The SoC thermal IP is similar to MT2701.

---
 Documentation/devicetree/bindings/thermal/mediatek-thermal.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt +1 -0
index 2d20f6b0dca0..5c7e7bdd029a 100644
@@ -14,6 +14,7 @@ Required properties:
   - "mediatek,mt2712-thermal" : For MT2712 family of SoCs
   - "mediatek,mt7622-thermal" : For MT7622 SoC
   - "mediatek,mt8183-thermal" : For MT8183 family of SoCs
+  - "mediatek,mt8516-thermal", "mediatek,mt2701-thermal : For MT8516 family of SoCs
 - reg: Address range of the thermal controller
 - interrupts: IRQ for the thermal controller
 - clocks, clock-names: Clocks needed for the thermal controller. required
Signature · 1 line
2.28.0
maintainer Acked-by on v1 2/3
#2 lore raw

Re: [PATCH 2/3] dt-bindings: thermal: mediatek: add documentation for MT8516 SoC

Quoted 8 lines · Fabien Parent

Add binding documentation for the MediaTek MT8516 SoC. The SoC thermal IP is similar to MT2701.

---
 Documentation/devicetree/bindings/thermal/mediatek-thermal.txt | 1 +
 1 file changed, 1 insertion(+)
#3 lore raw

[thermal: thermal/next] dt-bindings: thermal: mediatek: add documentation for MT8516 SoC

In reply to Fabien Parent
The following commit has been merged into the thermal/next branch of thermal:

The following commit has been merged into the thermal/next branch of thermal:

Commit-ID:     c707f973df1706020f4a4669b5f1932e90c0f29c
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//c707f973df1706020f4a4669b5f1932e90c0f29c
Author:        Fabien Parent <[email protected]>
AuthorDate:    Wed, 21 Oct 2020 18:42:30 +02:00
Committer:     Daniel Lezcano <[email protected]>
CommitterDate: Tue, 27 Oct 2020 11:18:54 +01:00

dt-bindings: thermal: mediatek: add documentation for MT8516 SoC

Add binding documentation for the MediaTek MT8516 SoC. The SoC thermal IP is similar to MT2701.

---
 Documentation/devicetree/bindings/thermal/mediatek-thermal.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt +1 -0
index 2d20f6b..5c7e7bd 100644
@@ -14,6 +14,7 @@ Required properties:
   - "mediatek,mt2712-thermal" : For MT2712 family of SoCs
   - "mediatek,mt7622-thermal" : For MT7622 SoC
   - "mediatek,mt8183-thermal" : For MT8183 family of SoCs
+  - "mediatek,mt8516-thermal", "mediatek,mt2701-thermal : For MT8516 family of SoCs
 - reg: Address range of the thermal controller
 - interrupts: IRQ for the thermal controller
 - clocks, clock-names: Clocks needed for the thermal controller. required
#4 lore raw

PATCH 3/3 thermal: mtk_thermal: make device_reset optional

In reply to Fabien Parent

MT8516 does not support thermal reset. Use device_reset_optional instead of device_reset.

---
 drivers/thermal/mtk_thermal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/mtk_thermal.c +1 -1
index 0bd7aa564bc2..149c6d7fd5a0 100644
@@ -1052,7 +1052,7 @@ static int mtk_thermal_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
-	ret = device_reset(&pdev->dev);
+	ret = device_reset_optional(&pdev->dev);
 	if (ret)
 		return ret;
 
Signature · 1 line
2.28.0
maintainer Reviewed-by on v1 3/3
#5 lore raw

Re: [PATCH 3/3] thermal: mtk_thermal: make device_reset optional

Quoted 4 lines · Fabien Parent

MT8516 does not support thermal reset. Use device_reset_optional instead of device_reset.

Quoted 18 lines
---
  drivers/thermal/mtk_thermal.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/mtk_thermal.c +1 -1
index 0bd7aa564bc2..149c6d7fd5a0 100644
@@ -1052,7 +1052,7 @@ static int mtk_thermal_probe(struct platform_device *pdev)
  		return -EINVAL;
  	}
 
-	ret = device_reset(&pdev->dev);
+	ret = device_reset_optional(&pdev->dev);
  	if (ret)
  		return ret;
 
#6 lore raw

[thermal: thermal/next] thermal: mtk_thermal: make device_reset optional

In reply to Fabien Parent
The following commit has been merged into the thermal/next branch of thermal:

The following commit has been merged into the thermal/next branch of thermal:

Commit-ID:     703456ba76e9449b5ade6597c04a90ee3421cd94
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//703456ba76e9449b5ade6597c04a90ee3421cd94
Author:        Fabien Parent <[email protected]>
AuthorDate:    Wed, 21 Oct 2020 18:42:31 +02:00
Committer:     Daniel Lezcano <[email protected]>
CommitterDate: Tue, 27 Oct 2020 11:19:18 +01:00

thermal: mtk_thermal: make device_reset optional

MT8516 does not support thermal reset. Use device_reset_optional instead of device_reset.

---
 drivers/thermal/mtk_thermal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/mtk_thermal.c +1 -1
index 0bd7aa5..149c6d7 100644
@@ -1052,7 +1052,7 @@ static int mtk_thermal_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
-	ret = device_reset(&pdev->dev);
+	ret = device_reset_optional(&pdev->dev);
 	if (ret)
 		return ret;
 
#8 lore raw
In reply to Fabien Parent
Quoted 5 lines · Fabien Parent

MT8516 Thermal IP does not support reset. Make the resets property optional in order to be able to support MT8516 SoC.

---

Applied, thanks

Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
#9 lore raw
In reply to Fabien Parent
The following commit has been merged into the thermal/next branch of thermal:

The following commit has been merged into the thermal/next branch of thermal:

Commit-ID:     07df39d03c34bd7baf4c26e41a5dd92ec56e9081
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//07df39d03c34bd7baf4c26e41a5dd92ec56e9081
Author:        Fabien Parent <[email protected]>
AuthorDate:    Wed, 21 Oct 2020 18:42:29 +02:00
Committer:     Daniel Lezcano <[email protected]>
CommitterDate: Tue, 27 Oct 2020 11:18:29 +01:00

dt-bindings: thermal: mediatek: make resets property optional

MT8516 Thermal IP does not support reset. Make the resets property optional in order to be able to support MT8516 SoC.

---
 Documentation/devicetree/bindings/thermal/mediatek-thermal.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt +1 -1
index 1e249c4..2d20f6b 100644
@@ -20,12 +20,12 @@ Required properties:
                        clocks are:
 		       "therm":	 Main clock needed for register access
 		       "auxadc": The AUXADC clock
-- resets: Reference to the reset controller controlling the thermal controller.
 - mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
 - mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
 - #thermal-sensor-cells : Should be 0. See Documentation/devicetree/bindings/thermal/thermal-sensor.yaml for a description.
 
 Optional properties:
+- resets: Reference to the reset controller controlling the thermal controller.
 - nvmem-cells: A phandle to the calibration data provided by a nvmem device. If
                unspecified default values shall be used.
 - nvmem-cell-names: Should be "calibration-data"