nvme-tcp: avoid repeated request completion
PATCH v2 5/5 nvme-tcp: avoid repeated request completion
From: Sagi Grimberg <[email protected]>
The request may be executed asynchronously, and rq->state may be changed to IDLE. To avoid repeated request completion, only MQ_RQ_COMPLETE of rq->state is checked in nvme_tcp_complete_timed_out. It is not safe, so need adding check IDLE for rq->state.
Signed-off-by Sagi Grimberg <[email protected]>
Signed-off-by Chao Leng <[email protected]>
--- drivers/nvme/host/tcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/tcp.c +1 -1
@@ -2169,7 +2169,7 @@ static void nvme_tcp_complete_timed_out(struct request *rq)struct nvme_ctrl *ctrl = &req->queue->ctrl->ctrl;nvme_tcp_stop_queue (ctrl,nvme_tcp_queue_id (req->queue)); -if (!blk_mq_request_completed (rq)) { +if (blk_mq_request_started (rq) && !blk_mq_request_completed (rq)) {nvme_req (rq)->status =NVME_SC_HOST_ABORTED_CMD ;blk_mq_complete_request (rq); }
Signature · 7 lines
2.16.4 _______________________________________________ Linux-nvme mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-nvme