hwmon: (pmbus/max20730) delete some dead code
Subsystems (2)
PATCH 1/1 hwmon: (pmbus/max20730) delete some dead code
The debugfs_create_dir() function never returns NULL. Normal users are not supposed to check the return value so the correct fix is just to delete this check.
In the case where the debugfs_create_dir() fails, the function returns NULL. The other debugfs function check for NULL directory and handle it.
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/hwmon/pmbus/max20730.c | 2 -- 1 file changed, 2 deletions(-)
drivers/hwmon/pmbus/max20730.c +0 -2
@@ -328,8 +328,6 @@ static int max20730_init_debugfs(struct i2c_client *client,return -ENOENT ; max20730_dir =debugfs_create_dir (client->name, debugfs); -if (!max20730_dir) -return -ENOENT ;for (i =0 ; i <MAX20730_DEBUGFS_NUM_ENTRIES ; ++i) psu->debugfs_entries[i] = i;
Signature · 1 line
2.28.0
Quoted 9 lines · Dan Carpenter
The
debugfs_create_dir()function never returns NULL. Normal users are not supposed to check the return value so the correct fix is just to delete this check.In the case where the
debugfs_create_dir()fails, the function returns NULL. The other debugfs function check for NULL directory and handle it.Signed-off-by Dan Carpenter <[email protected]>
Applied.
Thanks,
Guenter
Quoted 17 lines
--- drivers/hwmon/pmbus/max20730.c | 2 -- 1 file changed, 2 deletions(-)drivers/hwmon/pmbus/max20730.c +0
-2@@ -328,8 +328,6 @@ static int max20730_init_debugfs(struct i2c_client *client,return -ENOENT ; max20730_dir =debugfs_create_dir (client->name, debugfs); -if (!max20730_dir) -return -ENOENT ;for (i =0 ; i <MAX20730_DEBUGFS_NUM_ENTRIES ; ++i) psu->debugfs_entries[i] = i;