Skip to contentSkip to conversation

doc/guides: fix reference to x32 architecture

PATCH In review David Marchand 2 participants 3 messages Oct 22, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 doc/guides: fix reference to x32 architecture

There is no CONFIG_RTE_ARCH_X86_64_32.
The original intention was probably to refer to x32.

Fixes 36032e46be40 ("doc: add coding style")
---
 doc/guides/contributing/design.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
doc/guides/contributing/design.rst +1 -1
index 5fe7f63942..54dad08846 100644
@@ -47,7 +47,7 @@ Per Architecture Sources
 The following config options can be used:
 
 * ``CONFIG_RTE_ARCH`` is a string that contains the name of the architecture.
-* ``CONFIG_RTE_ARCH_I686``, ``CONFIG_RTE_ARCH_X86_64``, ``CONFIG_RTE_ARCH_X86_64_32`` or ``CONFIG_RTE_ARCH_PPC_64`` are defined only if we are building for those architectures.
+* ``CONFIG_RTE_ARCH_I686``, ``CONFIG_RTE_ARCH_X86_64``, ``CONFIG_RTE_ARCH_X86_X32`` or ``CONFIG_RTE_ARCH_PPC_64`` are defined only if we are building for those architectures.
 
 Per Execution Environment Sources
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signature · 1 line
2.23.0
#1 lore raw
Quoted 16 lines · David Marchand

There is no CONFIG_RTE_ARCH_X86_64_32.
The original intention was probably to refer to x32.

Fixes 36032e46be40 ("doc: add coding style")
---
 doc/guides/contributing/design.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
doc/guides/contributing/design.rst +0 -0
index 5fe7f63942..54dad08846 100644

doc/guides/contributing/design.rst Per Architecture Sources · line 51

Quoted 6 lines
doc/guides/contributing/design.rst +1 -1
@@ -47,7 +47,7 @@ Per Architecture Sources
 The following config options can be used:
 
 * ``CONFIG_RTE_ARCH`` is a string that contains the name of the architecture.
-* ``CONFIG_RTE_ARCH_I686``, ``CONFIG_RTE_ARCH_X86_64``, ``CONFIG_RTE_ARCH_X86_64_32`` or ``CONFIG_RTE_ARCH_PPC_64`` are defined only if we are building for those architectures.
+* ``CONFIG_RTE_ARCH_I686``, ``CONFIG_RTE_ARCH_X86_64``, ``CONFIG_RTE_ARCH_X86_X32`` or ``CONFIG_RTE_ARCH_PPC_64`` are defined only if we are building for those architectures.
 

With make gone, I don't believe that there is an RTE_ARCH_X86_X32 now either.

#2 lore raw
Quoted 7 lines · Bruce Richardson
Quoted 7 lines
doc/guides/contributing/design.rst +0 -0
index 5fe7f63942..54dad08846 100644
@@ -47,7 +47,7 @@ Per Architecture Sources
 The following config options can be used:
 
Quoted 7 lines

doc/guides/contributing/design.rst Per Architecture Sources · line 51

Quoted 4 lines
doc/guides/contributing/design.rst +1 -1
 * ``CONFIG_RTE_ARCH`` is a string that contains the name of the architecture.
-* ``CONFIG_RTE_ARCH_I686``, ``CONFIG_RTE_ARCH_X86_64``, ``CONFIG_RTE_ARCH_X86_64_32`` or ``CONFIG_RTE_ARCH_PPC_64`` are defined only if we are building for those architectures.
+* ``CONFIG_RTE_ARCH_I686``, ``CONFIG_RTE_ARCH_X86_64``, ``CONFIG_RTE_ARCH_X86_X32`` or ``CONFIG_RTE_ARCH_PPC_64`` are defined only if we are building for those architectures.
 

With make gone, I don't believe that there is an RTE_ARCH_X86_X32 now either.

As Thomas pointed offlist, this should go with Ciara series anyway. I'll drop this patch.

Signature · 1 line
David Marchand