Skip to contentSkip to conversation

mm: fix the sync buffered read to the old way

RFC PATCH In review Hao Xu 2 participants 3 messages Oct 22, 2020

Subsystems (3)
lore
Share & tools
lore

Hao Xu

author
#0 lore raw

RFC PATCH 1/1 mm: fix the sync buffered read to the old way

The commit 324bcf54c449 changed the code path of async buffered reads to go with the page_cache_sync_readahead() way when readahead is disabled, meanwhile the sync buffered reads are forced to do IO in the above way as well, which makes it go to a more complex code path.

Fixes 324bcf54c449 ("mm: use limited read-ahead to satisfy read")

---

Hi Jens,
I see it from the commit 324bcf54c449 ("mm: use limited read-ahead to satisfy read") that we have forced normal sync buffered reads go with the page_cache_sync_readahead() when readahead is disabled. I'm not sure if this is what you expected. Here I changed the sync buffered reads to go with the old code path(a_ops->readpage()), and tested the performance of them, the results of IOPS and cpu time are similar. I need your opinion on this.

 mm/filemap.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
mm/filemap.c +8 -3
index e4101b5bfa82..0b2a0f633c01 100644
@@ -2224,9 +2224,14 @@ ssize_t generic_file_buffered_read(struct kiocb *iocb,
 		if (!page) {
 			if (iocb->ki_flags & IOCB_NOIO)
 				goto would_block;
-			page_cache_sync_readahead(mapping,
-					ra, filp,
-					index, last_index - index);
+			/*
+			 * when readahead is disabled and IOCB_WAITQ isn't set
+			 * we should go with the readpage() way.
+			 */
+			if (ra->ra_pages || (iocb->ki_flags & IOCB_WAITQ))
+				page_cache_sync_readahead(mapping,
+						ra, filp,
+						index, last_index - index);
 			page = find_get_page(mapping, index);
 			if (unlikely(page == NULL))
 				goto no_cached_page;
Signature · 1 line
1.8.3.1
maintainer
#1 lore raw
Quoted 4 lines · Hao Xu

The commit 324bcf54c449 changed the code path of async buffered reads to go with the page_cache_sync_readahead() way when readahead is disabled, meanwhile the sync buffered reads are forced to do IO in the above way as well, which makes it go to a more complex code path.

But ->readpage is (increasingly) synchronous while readahead should be used to start async I/Os. I'm pretty sure Jens meant to do exactly what he did.

author
#2 lore raw
Quoted 9 lines · Matthew Wilcox
Quoted 4 lines · Hao Xu

The commit 324bcf54c449 changed the code path of async buffered reads to go with the page_cache_sync_readahead() way when readahead is disabled, meanwhile the sync buffered reads are forced to do IO in the above way as well, which makes it go to a more complex code path.

But ->readpage is (increasingly) synchronous while readahead should be used to start async I/Os. I'm pretty sure Jens meant to do exactly what he did.

Yes, we should start async I/Os with readahead, but why should we do the sync I/O like syscall read() in this way too when ra->ra_pages is 0?

Quoted 1 line