Skip to contentSkip to conversation

fix description patches from 'Add DM support for omap PWM backlight' series

PATCH New Dario Binacchi 2 participants 5 messages Oct 11, 2020 – Oct 23, 2020 Generic include/asm header files

lore
Share & tools
lore
#0 lore raw

cover fix description patches from 'Add DM support for omap PWM backlight' series

As suggested by Grygorii Strashko I have removed these patches from the 'Add DM support for omap PWM backlight' series and grouped them into this one. The patches have already been reviewed by Simon Glass.

Dario Binacchi (2):
dm: core: improve uclass_get_device_by_phandle_id() description
gpio: fix gpio_request_by_name() description

 include/asm-generic/gpio.h | 2 +-
 include/dm/uclass.h        | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/2 dm: core: improve uclass_get_device_by_phandle_id() description

Complete the devp parameter description.

---

 include/dm/uclass.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/dm/uclass.h +2 -1
index 67ff7466c8..7188304304 100644
@@ -224,7 +224,8 @@ int uclass_get_device_by_ofnode(enum uclass_id id, ofnode node,
  *
  * @id: uclass ID to look up
  * @phandle_id: the phandle id to look up
- * @devp: Returns pointer to device (there is only one for each node)
+ * @devp: Returns pointer to device (there is only one for each node). NULL if
+ *	there is no such device.
  * @return 0 if OK, -ENODEV if there is no device match the phandle, other
  *	-ve on error
  */
Signature · 1 line
2.17.1
#2 lore raw

PATCH 1/2 dm: core: improve uclass_get_device_by_phandle_id() description

Quoted 4 lines · Dario Binacchi

Complete the devp parameter description.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201022/19f8463e/attachment.sig>
#3 lore raw

PATCH 2/2 gpio: fix gpio_request_by_name() description

In reply to Dario Binacchi

Replace 'dev->dev' with '@desc->dev' in the gpio_request_by_name function desc parameter description.

---

 include/asm-generic/gpio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/asm-generic/gpio.h +1 -1
index 3ae1894a98..82294cbdc5 100644
@@ -496,7 +496,7 @@ int gpio_claim_vector(const int *gpio_num_array, const char *fmt);
  * @list_name:	Name of GPIO list (e.g. "board-id-gpios")
  * @index:	Index number of the GPIO in that list use request (0=first)
  * @desc:	Returns GPIO description information. If there is no such
- *		GPIO, dev->dev will be NULL.
+ *		GPIO, @desc->dev will be NULL.
  * @flags:	Indicates the GPIO input/output settings (GPIOD_...)
  * @return 0 if OK, -ENOENT if the GPIO does not exist, -EINVAL if there is
  * something wrong with the list, or other -ve for another error (e.g.
Signature · 1 line
2.17.1
#4 lore raw

PATCH 2/2 gpio: fix gpio_request_by_name() description

Quoted 5 lines · Dario Binacchi

Replace 'dev->dev' with '@desc->dev' in the gpio_request_by_name function desc parameter description.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201022/53e9432b/attachment.sig>