drm/amdgpu: Fix size calculation when init onchip memory
Subsystems (2)
PATCH 1/1 drm/amdgpu: Fix size calculation when init onchip memory
Size is page count here.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +2 -2
@@ -65,11 +65,11 @@static int amdgpu_ttm_init_on_chip (struct amdgpu_device *adev,unsigned int type, -uint64_t size) +uint64_t size_in_page) {return ttm_range_man_init (&adev->mman.bdev, type,TTM_PL_FLAG_UNCACHED ,TTM_PL_FLAG_UNCACHED , - false, size >>PAGE_SHIFT ); + false, size_in_page); }/**
Signature · 6 lines
2.25.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Christian König
maintainerAm 23.10.20 um 07:41 schrieb xinhui pan:
Quoted 3 lines
Size is page count here.
Signed-off-by xinhui pan <[email protected]>
Ah yes that one again. At some point we really need to clean that up.
Patch is Reviewed-by: Christian König <[email protected]>
Quoted 12 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +0
-0@@ -65,11 +65,11 @@ static int amdgpu_ttm_init_on_chip(struct amdgpu_device *adev, unsigned int type,
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c line 75
Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +2
-2- uint64_t size) + uint64_t size_in_page) {return ttm_range_man_init (&adev->mman.bdev, type,TTM_PL_FLAG_UNCACHED ,TTM_PL_FLAG_UNCACHED , - false, size >>PAGE_SHIFT ); + false, size_in_page); }/**
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 19 lines · Christian König
Am 23.10.20 um 07:41 schrieb xinhui pan:
Quoted 3 lines
Size is page count here.
Signed-off-by xinhui pan <[email protected]>Ah yes that one again. At some point we really need to clean that up.
Patch is Reviewed-by: Christian König <[email protected]>
Quoted 10 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +0
-0@@ -65,11 +65,11 @@
Quoted 9 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c line 72
Quoted 9 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +2
-2static int amdgpu_ttm_init_on_chip (struct amdgpu_device *adev,unsigned int type, -uint64_t size) +uint64_t size_in_page) {return ttm_range_man_init (&adev->mman.bdev, type,TTM_PL_FLAG_UNCACHED ,TTM_PL_FLAG_UNCACHED , - false, size >>PAGE_SHIFT ); + false, size_in_page);
Why don't we call this "page_count" or "num_pages"? "size_in_page" is really confusing and not something people say and use in English.
Regards,
Luben
Quoted 9 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c line 75
Quoted 3 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +0
-0}/** _______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Cluben.tuikov%40amd.com%7C868c9232cb924441c02308d8772307e4%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637390339646490801%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=H5r9C%2Bj3zVEsGSDNUlxl1%2Bg7lytcsczO7KpSymIv%2F0E%3D&reserved=0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Christian König
maintainerAm 24.10.20 um 01:19 schrieb Luben Tuikov:
Quoted 19 lines · Christian König
Quoted 18 lines
Am 23.10.20 um 07:41 schrieb xinhui pan:
Quoted 3 lines
Size is page count here.
Signed-off-by xinhui pan <[email protected]>Ah yes that one again. At some point we really need to clean that up.
Patch is Reviewed-by: Christian König <[email protected]>
Quoted 10 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +0
-0@@ -65,11 +65,11 @@
Quoted 12 lines
Quoted 9 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c line 72
Quoted 9 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +2
-2static int amdgpu_ttm_init_on_chip (struct amdgpu_device *adev,unsigned int type, -uint64_t size) +uint64_t size_in_page) {return ttm_range_man_init (&adev->mman.bdev, type,TTM_PL_FLAG_UNCACHED ,TTM_PL_FLAG_UNCACHED , - false, size >>PAGE_SHIFT ); + false, size_in_page);Why don't we call this "
page_count" or "num_pages"? "size_in_page" is really confusing and not something people say and use in English.
Thinking more about it it would even better if we just stick with size, cause this is a size in arbitrary units (and NOT pages!).
It's just TTM which misinterprets that as number of pages which is something Dave and I are trying to fix right now.
Regards,
Christian.
Quoted 12 lines
Regards,
LubenQuoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c line 75
Quoted 3 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +0
-0}/** _______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Cluben.tuikov%40amd.com%7C868c9232cb924441c02308d8772307e4%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637390339646490801%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=H5r9C%2Bj3zVEsGSDNUlxl1%2Bg7lytcsczO7KpSymIv%2F0E%3D&reserved=0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx