Skip to contentSkip to conversation

Revert "drm/amdgpu: IP discovery table is not ready yet for VG"

PATCH In review Xiaomeng Hou 2 participants 2 messages Oct 23, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "drm/amdgpu: IP discovery table is not ready yet for VG"

This reverts commit ba502322c9f216552485cea967aeb8adbaf03a02.

IP discovery table has been verified on vangogh.

---
 drivers/gpu/drm/amd/amdgpu/nv.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/nv.c +0 -4
index 72435e0eb8b9..30ec826c8760 100644
@@ -449,10 +449,6 @@ static int nv_reg_base_init(struct amdgpu_device *adev)
 {
 	int r;
 
-	/* IP discovery table is not available yet */
-	if (adev->asic_type == CHIP_VANGOGH)
-		goto legacy_init;
-
 	if (amdgpu_discovery) {
 		r = amdgpu_discovery_reg_base_init(adev);
 		if (r) {
Signature · 6 lines
2.17.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
#1 lore raw
Quoted 1 line · Xiaomeng (Matthew)

This reverts commit ba502322c9f216552485cea967aeb8adbaf03a02.

I suggest you didn't highlight to revert a patch. Becasue previous commit was good before, because it's the gap that firmware/sbios support.

Just modify the subject as "drm/amdgpu: enable IP discovery for vangogh", that's enough.

With that fixed, patch is Reviewed-by: Huang Rui <[email protected]>

Quoted 26 lines

IP discovery table has been verified on vangogh.

---
 drivers/gpu/drm/amd/amdgpu/nv.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/nv.c +0 -4
index 72435e0eb8b9..30ec826c8760 100644
@@ -449,10 +449,6 @@ static int nv_reg_base_init(struct amdgpu_device *adev)
 {
 	int r;
 
-	/* IP discovery table is not available yet */
-	if (adev->asic_type == CHIP_VANGOGH)
-		goto legacy_init;
-
 	if (amdgpu_discovery) {
 		r = amdgpu_discovery_reg_base_init(adev);
 		if (r) {
Signature · 1 line
2.17.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx