Skip to contentSkip to conversation

arm64: dts: meson: odroid-n2 plus: fix vddcpu_a pwm

PATCH Applied Jerome Brunet 3 participants 3 messages Oct 23, 2020

Subsystems (2)
lore
Share & tools
lore

Jerome Brunet

author reviewer
#0 lore raw

PATCH 1/1 arm64: dts: meson: odroid-n2 plus: fix vddcpu_a pwm

On the odroid N2 plus, cpufreq is not available due to an error on the cpu regulators. vddcpu a and b get the same PWM. The one provided to vddcpu A is incorrect. Because vddcpu B PWM is busy the regulator cannot register:

Quoted 1 line

pwm-regulator regulator-vddcpu-b: Failed to get PWM: -16

Like on the odroid n2, use PWM A out of GPIOE_2 for vddcpu A to fix the problem

Fixes 98d24896ee11 ("arm64: dts: meson: add support for the ODROID-N2+")
---
 arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts +1 -1
index 5de2815ba99d..ce1198ad34e4 100644
@@ -19,7 +19,7 @@ &vddcpu_a {
 	regulator-min-microvolt = <680000>;
 	regulator-max-microvolt = <1040000>;
 
-	pwms = <&pwm_AO_cd 1 1500 0>;
+	pwms = <&pwm_ab 0 1500 0>;
 };
 
 &vddcpu_b {
Signature · 1 line
2.25.4
Acked-by on v1 1/1
#1 lore raw
Quoted 21 lines · Jerome Brunet

On the odroid N2 plus, cpufreq is not available due to an error on the cpu regulators. vddcpu a and b get the same PWM. The one provided to vddcpu A is incorrect. Because vddcpu B PWM is busy the regulator cannot register:

Quoted 1 line

pwm-regulator regulator-vddcpu-b: Failed to get PWM: -16

Like on the odroid n2, use PWM A out of GPIOE_2 for vddcpu A to fix the problem

Fixes 98d24896ee11 ("arm64: dts: meson: add support for the ODROID-N2+")
---
 arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts +0 -0
index 5de2815ba99d..ce1198ad34e4 100644

arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts &vddcpu_a { · line 25

Quoted 8 lines
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts +1 -1
@@ -19,7 +19,7 @@ &vddcpu_a {
 	regulator-min-microvolt = <680000>;
 	regulator-max-microvolt = <1040000>;
 
-	pwms = <&pwm_AO_cd 1 1500 0>;
+	pwms = <&pwm_ab 0 1500 0>;
 };
 
 &vddcpu_b {

Nice catch, thanks

maintainer Applied
#2 lore raw
In reply to Jerome Brunet
Quoted 8 lines · Jerome Brunet

On the odroid N2 plus, cpufreq is not available due to an error on the cpu regulators. vddcpu a and b get the same PWM. The one provided to vddcpu A is incorrect. Because vddcpu B PWM is busy the regulator cannot register:

Quoted 1 line

pwm-regulator regulator-vddcpu-b: Failed to get PWM: -16

Like on the odroid n2, use PWM A out of GPIOE_2 for vddcpu A to fix the problem

Applied, thanks!

[1/1] arm64: dts: meson: odroid-n2 plus: fix vddcpu_a pwm
(no commit info)

Best regards,

Signature · 1 line
Kevin Hilman <[email protected]>