Skip to contentSkip to conversation

ASoC: Intel: Enable coredump in kconfig

PATCH In review Gustaw Lewandowski 2 participants 2 messages Oct 23, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: Intel: Enable coredump in kconfig

From: Piotr Maziarz <[email protected]>

WANT_DEV_COREDUMP flag is needed here if this driver is only one using dev_coredump feature.

---
 sound/soc/intel/Kconfig | 1 +
 1 file changed, 1 insertion(+)
sound/soc/intel/Kconfig +1 -0
index a5b446d5af19..c215156e2e18 100644
@@ -4,6 +4,7 @@ config SND_SOC_INTEL_SST_TOPLEVEL
 	default y
 	depends on X86 || COMPILE_TEST
 	select SND_SOC_INTEL_MACH
+	select WANT_DEV_COREDUMP
 	help
 	  Intel ASoC SST Platform Drivers. If you have a Intel machine that
 	  has an audio controller with a DSP and I2S or DMIC port, then
Signature · 1 line
2.29.0
#1 lore raw
Quoted 16 lines · Gustaw Lewandowski

From: Piotr Maziarz <[email protected]>

WANT_DEV_COREDUMP flag is needed here if this driver is only one using dev_coredump feature.

---
  sound/soc/intel/Kconfig | 1 +
  1 file changed, 1 insertion(+)
sound/soc/intel/Kconfig +0 -0
index a5b446d5af19..c215156e2e18 100644

sound/soc/intel/Kconfig config SND_SOC_INTEL_SST_TOPLEVEL · line 10

Quoted 7 lines
sound/soc/intel/Kconfig +1 -0
@@ -4,6 +4,7 @@ config SND_SOC_INTEL_SST_TOPLEVEL
  	default y
  	depends on X86 || COMPILE_TEST
  	select SND_SOC_INTEL_MACH
+	select WANT_DEV_COREDUMP
  	help
  	  Intel ASoC SST Platform Drivers. If you have a Intel machine that
  	  has an audio controller with a DSP and I2S or DMIC port, then

to the best of my knowledge the only user of device coredump is:

intel/catpt/dsp.c: dev_coredumpv(cdev->dev, dump, dump_size, GFP_KERNEL);

so shouldn't this change be added to catpt only?