common/qat: add missing kmod dependency
PATCH 1/1 common/qat: add missing kmod dependency
Dependency on kmod needed to manage crypto devices is missing in qat crypto pmd.
--- drivers/common/qat/qat_device.c | 1 + 1 file changed, 1 insertion(+)
drivers/common/qat/qat_device.c +1 -0
@@ -423,3 +423,4 @@ qat_comp_dev_destroy(struct qat_pci_device *qat_pci_dev __rte_unused)RTE_PMD_REGISTER_PCI (QAT_PCI_NAME , rte_qat_pmd);RTE_PMD_REGISTER_PCI_TABLE (QAT_PCI_NAME , pci_id_qat_map); +RTE_PMD_REGISTER_KMOD_DEP (QAT_PCI_NAME ,"* igb_uio | uio_pci_generic | vfio-pci" );
Signature · 1 line
2.20.1
Salut Didier,
Quoted 6 lines · Didier Pallard
Dependency on kmod needed to manage crypto devices is missing in qat crypto pmd.
Fixes 0880c40113ef ("drivers: advertise kmod dependencies in pmdinfo")
The Fixes: tag goes first, then Cc:, then empty line.
Quoted 15 lines
Signed-off-by Didier Pallard <[email protected]>--- drivers/common/qat/qat_device.c | 1 + 1 file changed, 1 insertion(+)drivers/common/qat/qat_device.c +1
-1@@ -423,3 +423,4 @@ qat_comp_dev_destroy(struct qat_pci_device *qat_pci_dev __rte_unused)RTE_PMD_REGISTER_PCI (QAT_PCI_NAME , rte_qat_pmd);RTE_PMD_REGISTER_PCI_TABLE (QAT_PCI_NAME , pci_id_qat_map); +RTE_PMD_REGISTER_KMOD_DEP (QAT_PCI_NAME ,"* igb_uio | uio_pci_generic | vfio-pci" ); --
Quoted 2 lines
2.20.1
There are some other drivers that have the issue.
If there is a volunteer, we have other drivers with the same issue (but probably worth double checking):
$ git grep -l 'drv_flags = RTE_PCI_DRV_NEED_MAPPING' drivers/ |xargs
dirname |sort -u|while read dir; do dir=${dir%%/base}; git grep -q
RTE_PMD_REGISTER_KMOD_DEP $dir || echo $dir; done
drivers/baseband/acc100
drivers/baseband/fpga_5gnr_fec
drivers/baseband/fpga_lte_fec
drivers/common/qat # done
drivers/event/octeontx
drivers/event/skeleton
drivers/mempool/octeontx
drivers/net/avp
drivers/net/hinic
drivers/net/octeontx
drivers/regex/octeontx2Signature · 1 line
David Marchand
Trahe, Fiona
Acked-byQuoted 15 lines
-----Original Message-----
From: David Marchand <[email protected]>
Sent: Friday, October 23, 2020 5:32 PM
To: Didier Pallard <[email protected]>
Cc: dev <[email protected]>; dpdk stable <[email protected]>; Griffin, John <[email protected]>; Trahe, Fiona <[email protected]>; Jain, Deepak K <[email protected]>; Olivier Matz <[email protected]>; Adrien Mazarguil <[email protected]>
Subject: Re: [dpdk-stable] [PATCH] common/qat: add missing kmod dependencySalut Didier,
Quoted 1 line · Didier Pallard
Quoted 10 lines
Quoted 5 lines
Dependency on kmod needed to manage crypto devices is missing in qat crypto pmd.
Fixes 0880c40113ef ("drivers: advertise kmod dependencies in pmdinfo")The Fixes: tag goes first, then Cc:, then empty line.
Quoted 1 line
Signed-off-by Didier Pallard <[email protected]>
Thanks!
Akhil Goyal
AppliedQuoted 8 lines
Subject: [dpdk-dev] [PATCH] common/qat: add missing kmod dependency
Dependency on kmod needed to manage crypto devices is missing in qat crypto pmd.
Fixes 0880c40113ef ("drivers: advertise kmod dependencies in pmdinfo")Signed-off-by Didier Pallard <[email protected]>
Applied to dpdk-next-crypto
Thanks/