Skip to contentSkip to conversation

rfkill: stop execution when rfkill device cannot be opened

PATCH New Sami Kerola 1 participant 1 message Oct 23, 2020 Util-Linux package

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rfkill: stop execution when rfkill device cannot be opened

Without this two error messages are printed when rfkill device cannot be opened.

    $ rfkill
    rfkill: cannot open /dev/rfkill: No such file or directory
    rfkill: cannot read /dev/rfkill: Bad file descriptor
---
 sys-utils/rfkill.c | 4 ++++
 1 file changed, 4 insertions(+)
sys-utils/rfkill.c +4 -0
index b00bf753e..73fb4bab4 100644
@@ -420,6 +420,8 @@ static int rfkill_list_old(const char *param)
 	}
 
 	fd = rfkill_ro_open(1);
+	if (fd < 0)
+		return -errno;
 
 	while (1) {
 		rc = rfkill_read_event(fd, &event);
@@ -492,6 +494,8 @@ static int rfkill_list_fill(struct control const *ctrl, const char *param)
 	}
 
 	fd = rfkill_ro_open(1);
+	if (fd < 0)
+		return -errno;
 
 	while (1) {
 		rc = rfkill_read_event(fd, &event);
Signature · 1 line
2.29.0