agp: amd64: remove unneeded initialization
PATCH 1/1 agp: amd64: remove unneeded initialization
make clang-analyzer on x86_64 defconfig caught my attention with:
drivers/char/agp/amd64-agp.c:336:2: warning: \
Value stored to 'i' is never read [clang-analyzer-deadcode.DeadStores]
i = 0;
^Remove this unneeded initialization to make clang-analyzer happy.
Commit a32073bffc65 ("x86_64: Clean and enhance up K8 northbridge access code") refactored cache_nbs() and introduced this unneeded dead-store initialization.
As compilers will detect this unneeded assignment and optimize this anyway, the resulting binary is identical before and after this change.
No functional change. No change in binary code.
Signed-off-by Lukas Bulwahn <[email protected]>
--- drivers/char/agp/amd64-agp.c | 1 - 1 file changed, 1 deletion(-)
drivers/char/agp/amd64-agp.c +0 -1
@@ -333,7 +333,6 @@ static int cache_nbs(struct pci_dev *pdev, u32 cap_ptr)if (!amd_nb_has_feature (AMD_NB_GART ))return -ENODEV ; - i =0 ;for (i =0 ; i <amd_nb_num (); i++) {struct pci_dev *dev =node_to_amd_nb (i)->misc;if (fix_northbridge (dev, pdev, cap_ptr) <0 ) {
Signature · 1 line
2.17.1