Skip to contentSkip to conversation

lib: print_freq() should output kHz not KHz

PATCH New Heinrich Schuchardt 2 participants 4 messages Oct 22, 2020 – Oct 24, 2020 Library code

lore
Share & tools
lore
#0 lore raw

cover lib: print_freq() should output kHz not KHz

Correct print_freq() for output of kHz. Provide unit tests for print_freq() and print_size().

v2:
add missing test/lib/test_print.c

Heinrich Schuchardt (2):
lib: print_freq() should output kHz not KHz
test: unit tests for print_freq(), print_size()

 include/display_options.h |  2 +-
 lib/display_options.c     |  2 +-
 test/lib/Makefile         |  1 +
 test/lib/test_print.c     | 71 +++++++++++++++++++++++++++++++++++++++
 4 files changed, 74 insertions(+), 2 deletions(-)
 create mode 100644 test/lib/test_print.c

--
2.28.0

#1 lore raw

PATCH 1/2 lib: print_freq() should output kHz not KHz

In the International System of Units (SI) the prefix kilo is abbreviated as 'k' not 'K'. 'K' is the symbol for Kelvin.

---
v2:
no change

---
 include/display_options.h | 2 +-
 lib/display_options.c     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
include/display_options.h +1 -1
index a0dabca2b8..049688e39e 100644
@@ -24,7 +24,7 @@ void print_size(uint64_t size, const char *suffix);
 /**
  * print_freq() - Print a frequency with a suffix
  *
- * Print frequencies as "x.xx GHz", "xxx KHz", etc as needed; allow for
+ * Print frequencies as "x.xx GHz", "xxx kHz", etc as needed; allow for
  * optional trailing string (like "\n")
  *
  * @freq:	Frequency to print in Hz
lib/display_options.c +1 -1
index ea9977cc18..b2025eeb5c 100644
@@ -54,7 +54,7 @@ void print_freq(uint64_t freq, const char *s)
 {
 	unsigned long m = 0;
 	uint32_t f;
-	static const char names[] = {'G', 'M', 'K'};
+	static const char names[] = {'G', 'M', 'k'};
 	unsigned long d = 1e9;
 	char c = 0;
 	unsigned int i;

--
2.28.0

#2 lore raw

PATCH 2/2 test: unit tests for print_freq(), print_size()

In reply to Heinrich Schuchardt

Provide unit tests for functions print_freq() and print_size().

---
v2:
add missing add missing test/lib/test_print.c

---
 test/lib/Makefile     |  1 +
 test/lib/test_print.c | 71 +++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 72 insertions(+)
 create mode 100644 test/lib/test_print.c
test/lib/Makefile +1 -0
index 22236f8587..15cd512506 100644
@@ -7,6 +7,7 @@ obj-$(CONFIG_EFI_LOADER) += efi_device_path.o
 obj-$(CONFIG_EFI_SECURE_BOOT) += efi_image_region.o
 obj-y += hexdump.o
 obj-y += lmb.o
+obj-y += test_print.o
 obj-$(CONFIG_SSCANF) += sscanf.o
 obj-y += string.o
 obj-$(CONFIG_ERRNO_STR) += test_errno_str.o
test/lib/test_print.c new file +71 -0

71 lines not on this page · raw message

--
2.28.0

#3 lore raw

PATCH 2/2 test: unit tests for print_freq(), print_size()

Quoted 3 lines · Heinrich Schuchardt

Provide unit tests for functions print_freq() and print_size().

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201024/ad73a117/attachment.sig>