Skip to contentSkip to conversation

staging: most: fix empty /* line in block comments

PATCH In review Amarjargal Gundjalam 2 participants 3 messages Oct 24, 2020 – Oct 26, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: most: fix empty /* line in block comments

fix the following warning generated by checkpatch:
networking block comments don't use an empty /* line, use /* Comment.

---
 drivers/staging/most/net/net.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/staging/most/net/net.c +2 -4
index b6fecb06a0e6..bc0aefe804b6 100644
@@ -171,8 +171,7 @@ static int most_nd_set_mac_address(struct net_device *dev, void *p)
 		(dev->dev_addr[0] == 0 && dev->dev_addr[1] == 0 &&
 		 dev->dev_addr[2] == 0 && dev->dev_addr[3] == 0);
 
-	/*
-	 * Set default MTU for the given packet type.
+	/* Set default MTU for the given packet type.
 	 * It is still possible to change MTU using ip tools afterwards.
 	 */
 	dev->mtu = nd->is_mamac ? MAMAC_DATA_LEN : ETH_DATA_LEN;
@@ -388,8 +387,7 @@ static int comp_disconnect_channel(struct most_interface *iface,
 		ch->linked = false;
 		spin_unlock_irqrestore(&list_lock, flags);
 
-		/*
-		 * do not call most_stop_channel() here, because channels are
+		/* do not call most_stop_channel() here, because channels are
 		 * going to be closed in ndo_stop() after unregister_netdev()
 		 */
 		unregister_netdev(nd->dev);
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 13 lines · Amarjargal Gundjalam

fix the following warning generated by checkpatch:
networking block comments don't use an empty /* line, use /* Comment.

---
 drivers/staging/most/net/net.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/staging/most/net/net.c +0 -0
index b6fecb06a0e6..bc0aefe804b6 100644

drivers/staging/most/net/net.c static int most_nd_set_mac_address(struct net_device *dev, void *p) · line 174

Quoted 6 lines
drivers/staging/most/net/net.c +1 -2
@@ -171,8 +171,7 @@ static int most_nd_set_mac_address(struct net_device *dev, void *p)
 		(dev->dev_addr[0] == 0 && dev->dev_addr[1] == 0 &&
 		 dev->dev_addr[2] == 0 && dev->dev_addr[3] == 0);
 
-	/*
-	 * Set default MTU for the given packet type.
+	/* Set default MTU for the given packet type.

This is a networking driver, so no, the comment style is correct, sorry for the confusion.

greg k-h

#2 lore raw
Quoted 28 lines · Greg KH
Quoted 15 lines · Amarjargal Gundjalam

fix the following warning generated by checkpatch:
networking block comments don't use an empty /* line, use /* Comment.

---
 drivers/staging/most/net/net.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/staging/most/net/net.c +0 -0
index b6fecb06a0e6..bc0aefe804b6 100644

drivers/staging/most/net/net.c static int most_nd_set_mac_address(struct · line 175

Quoted 7 lines
drivers/staging/most/net/net.c +1 -2
@@ -171,8 +171,7 @@ static int most_nd_set_mac_address(struct
 net_device *dev, void *p)
 		(dev->dev_addr[0] == 0 && dev->dev_addr[1] == 0 &&
 		 dev->dev_addr[2] == 0 && dev->dev_addr[3] == 0);
 
-	/*
-	 * Set default MTU for the given packet type.
+	/* Set default MTU for the given packet type.

This is a networking driver, so no, the comment style is correct, sorry
for the confusion.

Quoted 1 line

greg k-h

Oh ok. Got it.