ARM: dts: sun7i: pcduino3-nano: enable RGMII RX/TX delay on PHY
Subsystems (2)
PATCH 1/1 ARM: dts: sun7i: pcduino3-nano: enable RGMII RX/TX delay on PHY
The RX/TX delays for the Ethernet PHY on the Linksprite pcDuino 3 Nano are configured in hardware, using resistors that are populated to pull the RTL8211E's RXDLY/TXDLY pins low or high as needed.
phy-mode should be set to rgmii-id to reflect this. Previously it was set to rgmii, which used to work but now results in the delays being disabled again as a result of the bugfix in commit bbc4d71d6354 ("net:
phy: realtek: fix rtl8211e rx/tx delay config").
Tested on two pcDuino 3 Nano boards purchased in 2015. Without this fix, Ethernet works unreliably on one board and doesn't work at all on the other.
--- arch/arm/boot/dts/sun7i-a20-pcduino3-nano.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/sun7i-a20-pcduino3-nano.dts +2 -2
@@ -1,5 +1,5 @@ /* - * Copyright 2015 Adam Sampson <[email protected]> + * Copyright 2015-2020 Adam Sampson <[email protected]> * * This file is dual-licensed: you can use it either under the terms * of the GPL or the X11 license, at your option. Note that this dual
@@ -115,7 +115,7 @@ &gmac { pinctrl-names = "default"; pinctrl-0 = <&gmac_rgmii_pins>; phy-handle = <&phy1>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; status = "okay"; };
Signature · 7 lines
2.29.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 9 lines · Adam Sampson
The RX/TX delays for the Ethernet PHY on the Linksprite pcDuino 3 Nano are configured in hardware, using resistors that are populated to pull the RTL8211E's RXDLY/TXDLY pins low or high as needed.
phy-mode should be set to rgmii-id to reflect this. Previously it was set to rgmii, which used to work but now results in the delays being disabled again as a result of the bugfix in commit
bbc4d71d6354("net:
phy: realtek: fix rtl8211e rx/tx delay config").
Quoted 6 lines
Tested on two pcDuino 3 Nano boards purchased in 2015. Without this fix, Ethernet works unreliably on one board and doesn't work at all on the other.
Fixes 061035d456c9 ("ARM: dts: sun7i: Add dts file for pcDuino 3 Nano board")Signed-off-by Adam Sampson <[email protected]>
Andrew
Quoted 11 lines · Andrew Lunn
Quoted 9 lines · Adam Sampson
The RX/TX delays for the Ethernet PHY on the Linksprite pcDuino 3 Nano are configured in hardware, using resistors that are populated to pull the RTL8211E's RXDLY/TXDLY pins low or high as needed.
phy-mode should be set to rgmii-id to reflect this. Previously it was set to rgmii, which used to work but now results in the delays being disabled again as a result of the bugfix in commit
bbc4d71d6354("net:
phy: realtek: fix rtl8211e rx/tx delay config").
Quoted 8 lines
Quoted 6 lines
Tested on two pcDuino 3 Nano boards purchased in 2015. Without this fix, Ethernet works unreliably on one board and doesn't work at all on the other.
Fixes 061035d456c9 ("ARM: dts: sun7i: Add dts file for pcDuino 3 Nano board")Signed-off-by Adam Sampson <[email protected]>Reviewed-by Andrew Lunn <[email protected]>
Looks like none of the maintainers were listed in the recipients.
Hi,
Quoted 16 lines · Chen-Yu Tsai
Quoted 15 lines · Andrew Lunn
Quoted 13 lines · Adam Sampson
The RX/TX delays for the Ethernet PHY on the Linksprite pcDuino 3 Nano are configured in hardware, using resistors that are populated to pull the RTL8211E's RXDLY/TXDLY pins low or high as needed.
phy-mode should be set to rgmii-id to reflect this. Previously it was set to rgmii, which used to work but now results in the delays being disabled again as a result of the bugfix in commit
bbc4d71d6354("net:
phy: realtek: fix rtl8211e rx/tx delay config").Tested on two pcDuino 3 Nano boards purchased in 2015. Without this fix, Ethernet works unreliably on one board and doesn't work at all on the other.
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
Fixes 061035d456c9 ("ARM: dts: sun7i: Add dts file for pcDuino 3 Nano board")Signed-off-by Adam Sampson <[email protected]>Reviewed-by Andrew Lunn <[email protected]>Looks like none of the maintainers were listed in the recipients.
Acked-by Chen-Yu Tsai <[email protected]>
Adam, can you resend that patch?
Maxime