package/kodi: bump version to 18.9-Leia
PATCH 1/1 package/kodi: bump version to 18.9-Leia
--- package/kodi-jsonschemabuilder/kodi-jsonschemabuilder.mk | 2 +- package/kodi-texturepacker/kodi-texturepacker.mk | 2 +- package/kodi/kodi.hash | 2 +- package/kodi/kodi.mk | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
package/kodi-jsonschemabuilder/kodi-jsonschemabuilder.mk +1 -1
@@ -6,7 +6,7 @@ # Not possible to directly refer to kodi variables, because of # first/second expansion trickery... -KODI_JSONSCHEMABUILDER_VERSION = 18.8-Leia +KODI_JSONSCHEMABUILDER_VERSION = 18.9-Leia KODI_JSONSCHEMABUILDER_SITE = $(call github,xbmc,xbmc,$(KODI_JSONSCHEMABUILDER_VERSION)) KODI_JSONSCHEMABUILDER_SOURCE = kodi-$(KODI_JSONSCHEMABUILDER_VERSION).tar.gz KODI_JSONSCHEMABUILDER_DL_SUBDIR = kodi
package/kodi-texturepacker/kodi-texturepacker.mk +1 -1
@@ -6,7 +6,7 @@ # Not possible to directly refer to kodi variables, because of # first/second expansion trickery... -KODI_TEXTUREPACKER_VERSION = 18.8-Leia +KODI_TEXTUREPACKER_VERSION = 18.9-Leia KODI_TEXTUREPACKER_SITE = $(call github,xbmc,xbmc,$(KODI_TEXTUREPACKER_VERSION)) KODI_TEXTUREPACKER_SOURCE = kodi-$(KODI_TEXTUREPACKER_VERSION).tar.gz KODI_TEXTUREPACKER_DL_SUBDIR = kodi
package/kodi/kodi.hash +1 -1
@@ -1,5 +1,5 @@ # Locally computed -sha256 6deb28f725880b1ab6c5920b55ef1190a79b0684ffb30b6e13b199d23a0af296 kodi-18.8-Leia.tar.gz +sha256 bdf8afa9356b1f815de9984801d3e0d2b46a719e747895b75528f20995c59d2b kodi-18.9-Leia.tar.gz sha256 e11e7594af35f36ab2711252c3d6bb106908f26605498aef4a9be2d7bc001db2 kodi-ffmpeg-4.0.4-Leia-18.4.tar.gz sha256 38816f8373e243bc5950449b4f3b18938c4e1c59348e3411e23f31db4072e40d kodi-libdvdcss-1.4.2-Leia-Beta-5.tar.gz sha256 071e414e61b795f2ff9015b21a85fc009dde967f27780d23092643916538a57a kodi-libdvdnav-6.0.0-Leia-Alpha-3.tar.gz
package/kodi/kodi.mk +1 -1
@@ -6,7 +6,7 @@ # When updating the version, please also update kodi-jsonschemabuilder # and kodi-texturepacker -KODI_VERSION = 18.8-Leia +KODI_VERSION = 18.9-Leia KODI_SITE = $(call github,xbmc,xbmc,$(KODI_VERSION)) KODI_LICENSE = GPL-2.0 KODI_LICENSE_FILES = LICENSE.md
Signature · 1 line
2.27.0
PATCH 1/1 package/kodi: bump version to 18.9-Leia
Quoted 4 lines · On Sun, 25 Oct 2020 12:49:59 +0100 Bernd Kuhls <[email protected]> wrote:
Signed-off-by Bernd Kuhls <[email protected]>--- package/kodi-jsonschemabuilder/kodi-jsonschemabuilder.mk | 2 +- package/kodi-texturepacker/kodi-texturepacker.mk | 2 +-
You are changing the version of those packages, without updating their hash files. This doesn't seem right.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/kodi: bump version to 18.9-Leia
Am Sun, 25 Oct 2020 15:53:38 +0100 schrieb Thomas Petazzoni:
Quoted 5 lines
Quoted 2 lines
package/kodi-jsonschemabuilder/kodi-jsonschemabuilder.mk | 2 +- package/kodi-texturepacker/kodi-texturepacker.mk | 2 +-You are changing the version of those packages, without updating their hash files. This doesn't seem right.
Hi Thomas,
both .hash files are links to ../kodi/kodi.hash
Regards, Bernd
PATCH 1/1 package/kodi: bump version to 18.9-Leia
Quoted 1 line · On Sun, 25 Oct 2020 16:02:39 +0100 Bernd Kuhls <[email protected]> wrote:
both .hash files are links to ../kodi/kodi.hash
Ah, yes, indeed, sorry about missing that. I've applied now.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/kodi: bump version to 18.9-Leia
In reply to Bernd KuhlsHello Bernd,
Quoted 7 lines · On Sun, 25 Oct 2020 12:49:59 +0100 Bernd Kuhls <[email protected]> wrote:
Signed-off-by Bernd Kuhls <[email protected]>--- package/kodi-jsonschemabuilder/kodi-jsonschemabuilder.mk | 2 +- package/kodi-texturepacker/kodi-texturepacker.mk | 2 +- package/kodi/kodi.hash | 2 +- package/kodi/kodi.mk | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
Applied to master, thanks. Do you know why we have separate kodi-texturepacker/kodi-jsconschemabuilder packages instead of having a host-kodi package that would just build those two tools out of the Kodi code base ?
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/kodi: bump version to 18.9-Leia
Thomas, All,
On 2020-10-26 22:05 +0100, Thomas Petazzoni spake thusly:
Quoted 11 lines
Quoted 7 lines · On Sun, 25 Oct 2020 12:49:59 +0100 Bernd Kuhls <[email protected]> wrote:
Signed-off-by Bernd Kuhls <[email protected]>--- package/kodi-jsonschemabuilder/kodi-jsonschemabuilder.mk | 2 +- package/kodi-texturepacker/kodi-texturepacker.mk | 2 +- package/kodi/kodi.hash | 2 +- package/kodi/kodi.mk | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
Quoted 4 lines
Applied to master, thanks. Do you know why we have separate kodi-texturepacker/kodi-jsconschemabuilder packages instead of having a host-kodi package that would just build those two tools out of the Kodi code base ?
I guess there is a bit of "historical reasons" behind it.
However, there is a good technical reason: our package infrastructure can only build in one FOO_SUBDIR per pacakge, but here we have two:
- tools/depends/native/JsonSchemaBuilder/
- tools/depends/native/TexturePacker/
Regards,
Yann E. MORIN.
Quoted 11 lines
Best regards,
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 package/kodi: bump version to 18.9-Leia
Quoted 7 lines · On Mon, 26 Oct 2020 22:23:52 +0100 "Yann E. MORIN" <[email protected]>…
I guess there is a bit of "historical reasons" behind it.
However, there is a good technical reason: our package infrastructure can only build in one
FOO_SUBDIRper pacakge, but here we have two:-
tools/depends/native/JsonSchemaBuilder/
-tools/depends/native/TexturePacker/
Indeed. After a quick look, I thought this could be solved simply with a custom BUILD_CMDS that invokes make in those two folders. But it's more complicated: we would need a custom configure cmd that also calls CMake in those two folders.
So, meh: what we have today is probably reasonable.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com