Skip to contentSkip to conversation

net/mlx4: fix glue library name

PATCH In review Ali Alnubani 4 participants 9 messages Oct 26, 2020 – Nov 2, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/mlx4: fix glue library name

The MLX4 library wasn't being successfully initialized with -Dibverbs_link=dlopen because it expected a shared object file with a different name.

Fixes a20b2c01a7a1 ("build: standardize component names and defines")
---
 drivers/net/mlx4/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/mlx4/meson.build +1 -1
index 404006515..c22a88875 100644
@@ -10,7 +10,7 @@ endif
 
 static_ibverbs = (get_option('ibverbs_link') == 'static')
 dlopen_ibverbs = (get_option('ibverbs_link') == 'dlopen')
-LIB_GLUE_BASE = 'librte_pmd_mlx4_glue.so'
+LIB_GLUE_BASE = 'librte_net_mlx4_glue.so'
 LIB_GLUE_VERSION = '18.02.0'
 LIB_GLUE = LIB_GLUE_BASE + '.' + LIB_GLUE_VERSION
 if dlopen_ibverbs
Signature · 1 line
2.28.0
#1 lore raw

PATCH 1/1 common/mlx5: fix glue library name

The MLX5 glue library wasn't following the standard 'librte_<class>_<name>.so' naming.

Fixes a20b2c01a7a1 ("build: standardize component names and defines")
---
 drivers/common/mlx5/linux/meson.build | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/common/mlx5/linux/meson.build +2 -2
index 9ef8e181d..0d437f8fb 100644
@@ -5,7 +5,7 @@ includes += include_directories('.')
 
 static_ibverbs = (get_option('ibverbs_link') == 'static')
 dlopen_ibverbs = (get_option('ibverbs_link') == 'dlopen')
-LIB_GLUE_BASE = 'librte_pmd_mlx5_glue.so'
+LIB_GLUE_BASE = 'librte_common_mlx5_glue.so'
 LIB_GLUE_VERSION = '20.02.0'
 LIB_GLUE = LIB_GLUE_BASE + '.' + LIB_GLUE_VERSION
 if dlopen_ibverbs
@@ -195,7 +195,7 @@ configure_file(output : 'mlx5_autoconf.h', configuration : config)
 # Build Glue Library
 if dlopen_ibverbs
 	dlopen_name = 'mlx5_glue'
-	dlopen_lib_name = 'rte_pmd_@0@'.format(dlopen_name)
+	dlopen_lib_name = 'rte_common_' + dlopen_name
 	dlopen_so_version = LIB_GLUE_VERSION
 	dlopen_sources = files('mlx5_glue.c')
 	dlopen_install_dir = [ eal_pmd_path + '-glue' ]
Signature · 1 line
2.28.0
#3 lore raw

Re: [dpdk-dev] [PATCH] common/mlx5: fix glue library name

In reply to Ali Alnubani

Hi,

Quoted 24 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Ali Alnubani
Sent: Monday, October 26, 2020 11:21 AM
To: [email protected]
Cc: [email protected]
Subject: [dpdk-dev] [PATCH] common/mlx5: fix glue library name

The MLX5 glue library wasn't following the standard 'librte_<class>_<name>.so' naming.

Fixes a20b2c01a7a1 ("build: standardize component names and defines")
---
 drivers/common/mlx5/linux/meson.build | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/common/mlx5/linux/meson.build +0 -0
index 9ef8e181d..0d437f8fb 100644
@@ -5,7 +5,7 @@ includes += include_directories('.')
Quoted 1 line

2.28.0

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

#5 lore raw
In reply to Ali Alnubani

Hi,

Quoted 11 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Ali Alnubani
Sent: Monday, October 26, 2020 11:21 AM
To: [email protected]
Cc: [email protected]
Subject: [dpdk-dev] [PATCH] net/mlx4: fix glue library name

The MLX4 library wasn't being successfully initialized with -Dibverbs_link=dlopen because it expected a shared object file with a different name.

Quoted 8 lines
Fixes a20b2c01a7a1 ("build: standardize component names and defines")
---
 drivers/net/mlx4/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

#6 lore raw
In reply to Ali Alnubani
Quoted 4 lines · Ali Alnubani

The MLX4 library wasn't being successfully initialized with -Dibverbs_link=dlopen because it expected a shared object file with a different name.

The mlx4 glue library name seems changed in the patch pointed by Fixes line, but mlx5 library name is still using old syntax: 'librte_pmd_mlx5_glue.so', can you please fix that too in a separate patch?

Quoted 22 lines
Fixes a20b2c01a7a1 ("build: standardize component names and defines")
---
  drivers/net/mlx4/meson.build | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/mlx4/meson.build +1 -1
index 404006515..c22a88875 100644
@@ -10,7 +10,7 @@ endif
 
  static_ibverbs = (get_option('ibverbs_link') == 'static')
  dlopen_ibverbs = (get_option('ibverbs_link') == 'dlopen')
-LIB_GLUE_BASE = 'librte_pmd_mlx4_glue.so'
+LIB_GLUE_BASE = 'librte_net_mlx4_glue.so'
  LIB_GLUE_VERSION = '18.02.0'
  LIB_GLUE = LIB_GLUE_BASE + '.' + LIB_GLUE_VERSION
  if dlopen_ibverbs
#7 lore raw
Quoted 8 lines · Ferruh Yigit
Quoted 4 lines · Ali Alnubani

The MLX4 library wasn't being successfully initialized with -Dibverbs_link=dlopen because it expected a shared object file with a different name.

The mlx4 glue library name seems changed in the patch pointed by Fixes line, but mlx5 library name is still using old syntax: 'librte_pmd_mlx5_glue.so', can you please fix that too in a separate patch?

I should be a little more patient, the fix is already in the same thread ;) Thanks.

https://patches.dpdk.org/patch/82174/

Quoted 22 lines
Quoted 21 lines
Fixes a20b2c01a7a1 ("build: standardize component names and defines")

---
  drivers/net/mlx4/meson.build | 2 +-

  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/mlx4/meson.build +1 -1
index 404006515..c22a88875 100644
@@ -10,7 +10,7 @@ endif
   static_ibverbs = (get_option('ibverbs_link') == 'static')
   dlopen_ibverbs = (get_option('ibverbs_link') == 'dlopen')
-LIB_GLUE_BASE = 'librte_pmd_mlx4_glue.so'
+LIB_GLUE_BASE = 'librte_net_mlx4_glue.so'

  LIB_GLUE_VERSION = '18.02.0'
  LIB_GLUE = LIB_GLUE_BASE + '.' + LIB_GLUE_VERSION if dlopen_ibverbs

#8 lore raw
In reply to Ferruh Yigit

Hi Ferruh,

Quoted 15 lines

-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Monday, November 2, 2020 3:01 PM
To: Ali Alnubani <[email protected]>; Slava Ovsiienko <[email protected]>
Cc: [email protected]; [email protected]; Matan Azrad <[email protected]>; Shahaf Shuler <[email protected]>
Subject: Re: [dpdk-dev] [PATCH] net/mlx4: fix glue library name

Quoted 4 lines · Ali Alnubani

The MLX4 library wasn't being successfully initialized with -Dibverbs_link=dlopen because it expected a shared object file with a different name.

Quoted 5 lines

The mlx4 glue library name seems changed in the patch pointed by Fixes line, but
mlx5 library name is still using old syntax: 'librte_pmd_mlx5_glue.so', can you please fix that too in a separate patch?

This was done in http://patches.dpdk.org/patch/82174/. Is it what you meant?

Thanks,
Ali