Skip to contentSkip to conversation

staging: rtl8192e, rtl8192u: use correct notation to define pointer

PATCH In review Muhammad Usama Anjum 4 participants 5 messages Oct 26, 2020 – Feb 4, 2021 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8192e, rtl8192u: use correct notation to define pointer

Use pointer notation instead of using array notation as info_element is a pointer not array.

Warnings from sparse:
drivers/staging/rtl8192u/ieee80211/ieee80211.h:1013:51: warning: array of flexible structures drivers/staging/rtl8192u/ieee80211/ieee80211.h:985:51: warning: array of flexible structures drivers/staging/rtl8192u/ieee80211/ieee80211.h:963:51: warning: array of flexible structures drivers/staging/rtl8192u/ieee80211/ieee80211.h:996:51: warning: array of flexible structures drivers/staging/rtl8192u/ieee80211/ieee80211.h:974:51: warning: array of flexible structures

drivers/staging/rtl8192e/rtllib.h:832:48: warning: array of flexible structures drivers/staging/rtl8192e/rtllib.h:851:48: warning: array of flexible structures drivers/staging/rtl8192e/rtllib.h:805:48: warning: array of flexible structures drivers/staging/rtl8192e/rtllib.h:843:48: warning: array of flexible structures drivers/staging/rtl8192e/rtllib.h:821:48: warning: array of flexible structures

---
 drivers/staging/rtl8192e/rtllib.h              | 10 +++++-----
 drivers/staging/rtl8192u/ieee80211/ieee80211.h | 12 ++++++------
 2 files changed, 11 insertions(+), 11 deletions(-)
drivers/staging/rtl8192e/rtllib.h +5 -5
index b84f00b8d18b..1dab9c3d08a8 100644
@@ -802,7 +802,7 @@ struct rtllib_authentication {
 	__le16 transaction;
 	__le16 status;
 	/*challenge*/
-	struct rtllib_info_element info_element[];
+	struct rtllib_info_element *info_element;
 } __packed;
 
 struct rtllib_disauth {
@@ -818,7 +818,7 @@ struct rtllib_disassoc {
 struct rtllib_probe_request {
 	struct rtllib_hdr_3addr header;
 	/* SSID, supported rates */
-	struct rtllib_info_element info_element[];
+	struct rtllib_info_element *info_element;
 } __packed;
 
 struct rtllib_probe_response {
@@ -829,7 +829,7 @@ struct rtllib_probe_response {
 	/* SSID, supported rates, FH params, DS params,
 	 * CF params, IBSS params, TIM (if beacon), RSN
 	 */
-	struct rtllib_info_element info_element[];
+	struct rtllib_info_element *info_element;
 } __packed;
 
 /* Alias beacon for probe_response */
@@ -840,7 +840,7 @@ struct rtllib_assoc_request_frame {
 	__le16 capability;
 	__le16 listen_interval;
 	/* SSID, supported rates, RSN */
-	struct rtllib_info_element info_element[];
+	struct rtllib_info_element *info_element;
 } __packed;
 
 struct rtllib_assoc_response_frame {
@@ -848,7 +848,7 @@ struct rtllib_assoc_response_frame {
 	__le16 capability;
 	__le16 status;
 	__le16 aid;
-	struct rtllib_info_element info_element[]; /* supported rates */
+	struct rtllib_info_element *info_element; /* supported rates */
 } __packed;
 
 struct rtllib_txb {
drivers/staging/rtl8192u/ieee80211/ieee80211.h +6 -6
index 39f4ddd86796..37b240dd0b1f 100644
@@ -960,7 +960,7 @@ struct ieee80211_authentication {
 	__le16 transaction;
 	__le16 status;
 	/*challenge*/
-	struct ieee80211_info_element info_element[];
+	struct ieee80211_info_element *info_element;
 } __packed;
 
 struct ieee80211_disassoc {
@@ -971,7 +971,7 @@ struct ieee80211_disassoc {
 struct ieee80211_probe_request {
 	struct rtl_80211_hdr_3addr header;
 	/* SSID, supported rates */
-	struct ieee80211_info_element info_element[];
+	struct ieee80211_info_element *info_element;
 } __packed;
 
 struct ieee80211_probe_response {
@@ -982,7 +982,7 @@ struct ieee80211_probe_response {
 	/* SSID, supported rates, FH params, DS params,
 	 * CF params, IBSS params, TIM (if beacon), RSN
 	 */
-	struct ieee80211_info_element info_element[];
+	struct ieee80211_info_element *info_element;
 } __packed;
 
 /* Alias beacon for probe_response */
@@ -993,7 +993,7 @@ struct ieee80211_assoc_request_frame {
 	__le16 capability;
 	__le16 listen_interval;
 	/* SSID, supported rates, RSN */
-	struct ieee80211_info_element info_element[];
+	struct ieee80211_info_element *info_element;
 } __packed;
 
 struct ieee80211_reassoc_request_frame {
@@ -1002,7 +1002,7 @@ struct ieee80211_reassoc_request_frame {
 	__le16 listen_interval;
 	u8 current_ap[ETH_ALEN];
 	/* SSID, supported rates, RSN */
-	struct ieee80211_info_element info_element[];
+	struct ieee80211_info_element *info_element;
 } __packed;
 
 struct ieee80211_assoc_response_frame {
@@ -1010,7 +1010,7 @@ struct ieee80211_assoc_response_frame {
 	__le16 capability;
 	__le16 status;
 	__le16 aid;
-	struct ieee80211_info_element info_element[]; /* supported rates */
+	struct ieee80211_info_element *info_element; /* supported rates */
 } __packed;
 
 struct ieee80211_txb {
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 27 lines · Muhammad Usama Anjum

Use pointer notation instead of using array notation as info_element is a pointer not array.

Warnings from sparse:
drivers/staging/rtl8192u/ieee80211/ieee80211.h:1013:51: warning: array of flexible structures drivers/staging/rtl8192u/ieee80211/ieee80211.h:985:51: warning: array of flexible structures drivers/staging/rtl8192u/ieee80211/ieee80211.h:963:51: warning: array of flexible structures drivers/staging/rtl8192u/ieee80211/ieee80211.h:996:51: warning: array of flexible structures drivers/staging/rtl8192u/ieee80211/ieee80211.h:974:51: warning: array of flexible structures

drivers/staging/rtl8192e/rtllib.h:832:48: warning: array of flexible structures drivers/staging/rtl8192e/rtllib.h:851:48: warning: array of flexible structures drivers/staging/rtl8192e/rtllib.h:805:48: warning: array of flexible structures drivers/staging/rtl8192e/rtllib.h:843:48: warning: array of flexible structures drivers/staging/rtl8192e/rtllib.h:821:48: warning: array of flexible structures

---
 drivers/staging/rtl8192e/rtllib.h              | 10 +++++-----
 drivers/staging/rtl8192u/ieee80211/ieee80211.h | 12 ++++++------
 2 files changed, 11 insertions(+), 11 deletions(-)
drivers/staging/rtl8192e/rtllib.h +0 -0
index b84f00b8d18b..1dab9c3d08a8 100644

drivers/staging/rtl8192e/rtllib.h struct rtllib_authentication { · line 806

Quoted 6 lines
drivers/staging/rtl8192e/rtllib.h +1 -1
@@ -802,7 +802,7 @@ struct rtllib_authentication {
 	__le16 transaction;
 	__le16 status;
 	/*challenge*/
-	struct rtllib_info_element info_element[];
+	struct rtllib_info_element *info_element;
 } __packed;

Are you sure these changes are correct? This isn't just a list of structures after this at the end of the structure?

Please look at commit 5979afa2c4d1 ("staging: Replace zero-length array with flexible-array member") which made most of these flexible arrays.

This is not a pointer, it really is an array, I think sparse is really wrong here, be careful.

thanks,

greg k-h

#2 lore raw
Quoted 23 lines · Greg KH
Quoted 22 lines · Muhammad Usama Anjum

Use pointer notation instead of using array notation as info_element is a pointer not array.

Warnings from sparse:
drivers/staging/rtl8192u/ieee80211/ieee80211.h:1013:51: warning: array of flexible structures drivers/staging/rtl8192u/ieee80211/ieee80211.h:985:51: warning: array of flexible structures drivers/staging/rtl8192u/ieee80211/ieee80211.h:963:51: warning: array of flexible structures drivers/staging/rtl8192u/ieee80211/ieee80211.h:996:51: warning: array of flexible structures drivers/staging/rtl8192u/ieee80211/ieee80211.h:974:51: warning: array of flexible structures

drivers/staging/rtl8192e/rtllib.h:832:48: warning: array of flexible structures drivers/staging/rtl8192e/rtllib.h:851:48: warning: array of flexible structures drivers/staging/rtl8192e/rtllib.h:805:48: warning: array of flexible structures drivers/staging/rtl8192e/rtllib.h:843:48: warning: array of flexible structures drivers/staging/rtl8192e/rtllib.h:821:48: warning: array of flexible structures

---
 drivers/staging/rtl8192e/rtllib.h              | 10 +++++-----
 drivers/staging/rtl8192u/ieee80211/ieee80211.h | 12 ++++++------
 2 files changed, 11 insertions(+), 11 deletions(-)
Quoted 14 lines

drivers/staging/rtl8192e/rtllib.h struct rtllib_authentication { · line 806

Quoted 11 lines
drivers/staging/rtl8192e/rtllib.h +1 -1
index b84f00b8d18b..1dab9c3d08a8 100644
@@ -802,7 +802,7 @@ struct rtllib_authentication {
 	__le16 transaction;
 	__le16 status;
 	/*challenge*/
-	struct rtllib_info_element info_element[];
+	struct rtllib_info_element *info_element;
 } __packed;

Are you sure these changes are correct? This isn't just a list of structures after this at the end of the structure?

Definitely the patch will break things at runtime. I was surprised that it compiles, but it does.

Quoted 6 lines

Please look at commit 5979afa2c4d1 ("staging: Replace zero-length array with flexible-array member") which made most of these flexible arrays.

This is not a pointer, it really is an array, I think sparse is really wrong here, be careful.

It's an interesting warning message. Sparse is correct that the code looks strange. If there were ever two or more elements in the array then the code would break. But since the code only uses a max of one element then it's fine.

I guess the question is does this warning ever catch bugs in real life? It seems like that the kind of bug which would be caught in testing so static analysis is not going to be useful.

regards,
dan carpenter

#3 lore raw
In reply to Greg KH
Quoted 9 lines · Greg KH

Are you sure these changes are correct? This isn't just a list of structures after this at the end of the structure?

Please look at commit 5979afa2c4d1 ("staging: Replace zero-length array with flexible-array member") which made most of these flexible arrays.

This is not a pointer, it really is an array, I think sparse is really wrong here, be careful.

Sparse's warning is not about changing the definition of this member
as if it was the argument of a function. It's about how can you use
an array of structure when this structure has a flexible member.
It's a recent warning, added purposely to catch this.
See https://lore.kernel.org/r/CAHk-=wgJZ05ap8VQdzWDWJVWVtZiOYTc6cnNB8gNeQzEnfm-tw@mail.gmail.com

-- Luc

#4 lore raw
Quoted 3 lines

Sparse's warning is not about changing the definition of this member as if it was the argument of a function. It's about how can you use an array of structure when this structure has a flexible member.

We have the following structures in drivers/staging/rtl8192e. (I've simplified them for showing here.)

struct rtllib_hdr_3addr {
	int a;	
	int payload[];
};
struct rtllib_info_element {
	int len;
	int data[];
};
struct rtllib_probe_request {
	struct rtllib_hdr_3addr header;
	struct rtllib_info_element info_element[];
};
static void func(struct rtllib_probe_request *ptr) {
	ptr->header.a = 1;
}

Running sparse gives:
sparse -Wflexible-array-array flexible_array.c flexible_array.c:13:48: warning: array of flexible structures

There are several such structures in rtl8192e and rtl8192u. I've been trying to fix one of them. But it seems like more knowledge is required to refactor the driver.

Thanks,
Usama