Skip to contentSkip to conversation

Patch "drm/radeon: Prefer lower feedback dividers" has been added to the 5.9-stable tree

DISCUSSION Kai-Heng Feng 2 participants 2 messages Oct 26, 2020 1 message not in the archive Stable branch

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hi Sasha,

Quoted 9 lines · Sasha Levin

This is a note to let you know that I've just added the patch titled

drm/radeon: Prefer lower feedback dividers

to the 5.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

Quoted 6 lines

The filename of the patch is:
drm-radeon-prefer-lower-feedback-dividers.patch
and it can be found in the queue-5.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Please drop this patch because it causes some regression.

Kai-Heng

Quoted 41 lines

commit 3fa04dfbb55a95e7c6075d0644f64bcb6e7f4ef8

Author: Kai-Heng Feng <[email protected]>
Date:   Wed Aug 26 01:33:48 2020 +0800

drm/radeon: Prefer lower feedback dividers

[ Upstream commit 5150dd85bdfa08143cacf1b4249121651bed3c35 ]

Commit 2e26ccb119bd ("drm/radeon: prefer lower reference dividers") fixed screen flicker for HP Compaq nx9420 but breaks other laptops like Asus X50SL.

Turns out we also need to favor lower feedback dividers.

Users confirmed this change fixes the regression and doesn't regress the original fix.

drivers/gpu/drm/radeon/radeon_display.c +1 -1
index e0ae911ef427d..7b69d6dfe44a3 100644
@@ -933,7 +933,7 @@ static void avivo_get_fb_ref_div(unsigned nom, unsigned den, unsigned post_div,
 
 	/* get matching reference and feedback divider */
 	*ref_div = min(max(den/post_div, 1u), ref_div_max);
-	*fb_div = DIV_ROUND_CLOSEST(nom * *ref_div * post_div, den);
+	*fb_div = max(nom * *ref_div * post_div / den, 1u);
 
 	/* limit fb divider to its maximum */
 	if (*fb_div > fb_div_max) {
maintainer
#2 lore raw
Quoted 11 lines · Kai-Heng Feng

Hi Sasha,

Quoted 9 lines · Sasha Levin

This is a note to let you know that I've just added the patch titled

drm/radeon: Prefer lower feedback dividers

to the 5.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

Quoted 8 lines
Quoted 6 lines

The filename of the patch is:
drm-radeon-prefer-lower-feedback-dividers.patch
and it can be found in the queue-5.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Please drop this patch because it causes some regression.

Will do, thanks!

Signature · 2 lines
Thanks,
Sasha