hwmon: pmbus: shrink code and remove pmbus_do_remove()
Subsystems (4)
PATCH 1/1 hwmon: pmbus: shrink code and remove pmbus_do_remove()
From: Bartosz Golaszewski <[email protected]>
The only action currently performed in pmbus_do_remove() is removing the debugfs hierarchy. We can schedule a devm action at probe time and remove pmbus_do_remove() entirely from all pmbus drivers.
Signed-off-by Bartosz Golaszewski <[email protected]>
--- drivers/hwmon/pmbus/adm1266.c | 1 - drivers/hwmon/pmbus/adm1275.c | 1 - drivers/hwmon/pmbus/bel-pfe.c | 1 - drivers/hwmon/pmbus/ibm-cffps.c | 1 - drivers/hwmon/pmbus/inspur-ipsps.c | 1 - drivers/hwmon/pmbus/ir35221.c | 1 - drivers/hwmon/pmbus/ir38064.c | 1 - drivers/hwmon/pmbus/irps5401.c | 1 - drivers/hwmon/pmbus/isl68137.c | 1 - drivers/hwmon/pmbus/lm25066.c | 1 - drivers/hwmon/pmbus/ltc2978.c | 1 - drivers/hwmon/pmbus/ltc3815.c | 1 - drivers/hwmon/pmbus/max16064.c | 1 - drivers/hwmon/pmbus/max16601.c | 1 - drivers/hwmon/pmbus/max20730.c | 1 - drivers/hwmon/pmbus/max20751.c | 1 - drivers/hwmon/pmbus/max31785.c | 1 - drivers/hwmon/pmbus/max34440.c | 1 - drivers/hwmon/pmbus/max8688.c | 1 - drivers/hwmon/pmbus/mp2975.c | 1 - drivers/hwmon/pmbus/pmbus.c | 1 - drivers/hwmon/pmbus/pmbus.h | 1 - drivers/hwmon/pmbus/pmbus_core.c | 20 +++++++++----------- drivers/hwmon/pmbus/pxe1610.c | 1 - drivers/hwmon/pmbus/tps40422.c | 1 - drivers/hwmon/pmbus/tps53679.c | 1 - drivers/hwmon/pmbus/ucd9000.c | 1 - drivers/hwmon/pmbus/ucd9200.c | 1 - drivers/hwmon/pmbus/xdpe12284.c | 1 - drivers/hwmon/pmbus/zl6100.c | 1 - 30 files changed, 9 insertions(+), 40 deletions(-)
drivers/hwmon/pmbus/adm1266.c +0 -1
@@ -502,7 +502,6 @@ static struct i2c_driver adm1266_driver = { .of_match_table = adm1266_of_match, }, .probe_new = adm1266_probe, - .remove = pmbus_do_remove, .id_table = adm1266_id, };
drivers/hwmon/pmbus/adm1275.c +0 -1
@@ -797,7 +797,6 @@ static struct i2c_driver adm1275_driver = { .name = "adm1275", }, .probe_new = adm1275_probe, - .remove = pmbus_do_remove, .id_table = adm1275_id, };
drivers/hwmon/pmbus/bel-pfe.c +0 -1
@@ -121,7 +121,6 @@ static struct i2c_driver pfe_pmbus_driver = { .name = "bel-pfe", }, .probe_new = pfe_pmbus_probe, - .remove = pmbus_do_remove, .id_table = pfe_device_id, };
drivers/hwmon/pmbus/ibm-cffps.c +0 -1
@@ -617,7 +617,6 @@ static struct i2c_driver ibm_cffps_driver = { .of_match_table = ibm_cffps_of_match, }, .probe_new = ibm_cffps_probe, - .remove = pmbus_do_remove, .id_table = ibm_cffps_id, };
drivers/hwmon/pmbus/inspur-ipsps.c +0 -1
@@ -216,7 +216,6 @@ static struct i2c_driver ipsps_driver = { .of_match_table = of_match_ptr(ipsps_of_match), }, .probe_new = ipsps_probe, - .remove = pmbus_do_remove, .id_table = ipsps_id, };
drivers/hwmon/pmbus/ir35221.c +0 -1
@@ -137,7 +137,6 @@ static struct i2c_driver ir35221_driver = { .name = "ir35221", }, .probe_new = ir35221_probe, - .remove = pmbus_do_remove, .id_table = ir35221_id, };
drivers/hwmon/pmbus/ir38064.c +0 -1
@@ -53,7 +53,6 @@ static struct i2c_driver ir38064_driver = { .name = "ir38064", }, .probe_new = ir38064_probe, - .remove = pmbus_do_remove, .id_table = ir38064_id, };
drivers/hwmon/pmbus/irps5401.c +0 -1
@@ -55,7 +55,6 @@ static struct i2c_driver irps5401_driver = { .name = "irps5401", }, .probe_new = irps5401_probe, - .remove = pmbus_do_remove, .id_table = irps5401_id, };
drivers/hwmon/pmbus/isl68137.c +0 -1
@@ -324,7 +324,6 @@ static struct i2c_driver isl68137_driver = { .name = "isl68137", }, .probe_new = isl68137_probe, - .remove = pmbus_do_remove, .id_table = raa_dmpvr_id, };
drivers/hwmon/pmbus/lm25066.c +0 -1
@@ -508,7 +508,6 @@ static struct i2c_driver lm25066_driver = { .name = "lm25066", }, .probe_new = lm25066_probe, - .remove = pmbus_do_remove, .id_table = lm25066_id, };
drivers/hwmon/pmbus/ltc2978.c +0 -1
@@ -875,7 +875,6 @@ static struct i2c_driver ltc2978_driver = { .of_match_table = of_match_ptr(ltc2978_of_match), }, .probe_new = ltc2978_probe, - .remove = pmbus_do_remove, .id_table = ltc2978_id, };
drivers/hwmon/pmbus/ltc3815.c +0 -1
@@ -200,7 +200,6 @@ static struct i2c_driver ltc3815_driver = { .name = "ltc3815", }, .probe_new = ltc3815_probe, - .remove = pmbus_do_remove, .id_table = ltc3815_id, };
drivers/hwmon/pmbus/max16064.c +0 -1
@@ -103,7 +103,6 @@ static struct i2c_driver max16064_driver = { .name = "max16064", }, .probe_new = max16064_probe, - .remove = pmbus_do_remove, .id_table = max16064_id, };
drivers/hwmon/pmbus/max16601.c +0 -1
@@ -302,7 +302,6 @@ static struct i2c_driver max16601_driver = { .name = "max16601", }, .probe_new = max16601_probe, - .remove = pmbus_do_remove, .id_table = max16601_id, };
drivers/hwmon/pmbus/max20730.c +0 -1
@@ -779,7 +779,6 @@ static struct i2c_driver max20730_driver = { .of_match_table = max20730_of_match, }, .probe_new = max20730_probe, - .remove = pmbus_do_remove, .id_table = max20730_id, };
drivers/hwmon/pmbus/max20751.c +0 -1
@@ -43,7 +43,6 @@ static struct i2c_driver max20751_driver = { .name = "max20751", }, .probe_new = max20751_probe, - .remove = pmbus_do_remove, .id_table = max20751_id, };
drivers/hwmon/pmbus/max31785.c +0 -1
@@ -390,7 +390,6 @@ static struct i2c_driver max31785_driver = { .of_match_table = max31785_of_match, }, .probe_new = max31785_probe, - .remove = pmbus_do_remove, .id_table = max31785_id, };
drivers/hwmon/pmbus/max34440.c +0 -1
@@ -521,7 +521,6 @@ static struct i2c_driver max34440_driver = { .name = "max34440", }, .probe_new = max34440_probe, - .remove = pmbus_do_remove, .id_table = max34440_id, };
drivers/hwmon/pmbus/max8688.c +0 -1
@@ -183,7 +183,6 @@ static struct i2c_driver max8688_driver = { .name = "max8688", }, .probe_new = max8688_probe, - .remove = pmbus_do_remove, .id_table = max8688_id, };
drivers/hwmon/pmbus/mp2975.c +0 -1
@@ -758,7 +758,6 @@ static struct i2c_driver mp2975_driver = { .of_match_table = of_match_ptr(mp2975_of_match), }, .probe_new = mp2975_probe, - .remove = pmbus_do_remove, .id_table = mp2975_id, };
drivers/hwmon/pmbus/pmbus.c +0 -1
@@ -238,7 +238,6 @@ static struct i2c_driver pmbus_driver = { .name = "pmbus", }, .probe_new = pmbus_probe, - .remove = pmbus_do_remove, .id_table = pmbus_id, };
drivers/hwmon/pmbus/pmbus.h +0 -1
@@ -490,7 +490,6 @@ void pmbus_clear_faults(struct i2c_client *client);bool pmbus_check_byte_register (struct i2c_client *client,int page,int reg);bool pmbus_check_word_register (struct i2c_client *client,int page,int reg);int pmbus_do_probe (struct i2c_client *client,struct pmbus_driver_info *info); -int pmbus_do_remove (struct i2c_client *client);const struct pmbus_driver_info *pmbus_get_driver_info (struct i2c_client *client); int pmbus_get_fan_rate_device(struct i2c_client *client, int page, int id,
drivers/hwmon/pmbus/pmbus_core.c +9 -11
@@ -2388,6 +2388,13 @@ static int pmbus_debugfs_set_pec(void *data, u64 val)DEFINE_DEBUGFS_ATTRIBUTE (pmbus_debugfs_ops_pec, pmbus_debugfs_get_pec, pmbus_debugfs_set_pec,"%llu\n" ); +static void pmbus_remove_debugfs (void *data) +{ +struct dentry *entry = data; + +debugfs_remove_recursive (entry); +} +static int pmbus_init_debugfs (struct i2c_client *client,struct pmbus_data *data) {
@@ -2523,7 +2530,8 @@ static int pmbus_init_debugfs(struct i2c_client *client, } } -return 0 ; +return devm_add_action_or_reset (data->dev, + pmbus_remove_debugfs, data->debugfs); }#else static int pmbus_init_debugfs(struct i2c_client *client,
@@ -2610,16 +2618,6 @@ int pmbus_do_probe(struct i2c_client *client, struct pmbus_driver_info *info) }EXPORT_SYMBOL_GPL (pmbus_do_probe); -int pmbus_do_remove (struct i2c_client *client) -{ -struct pmbus_data *data =i2c_get_clientdata (client); - -debugfs_remove_recursive (data->debugfs); - -return 0 ; -} -EXPORT_SYMBOL_GPL (pmbus_do_remove); -struct dentry *pmbus_get_debugfs_dir (struct i2c_client *client) {struct pmbus_data *data =i2c_get_clientdata (client);
drivers/hwmon/pmbus/pxe1610.c +0 -1
@@ -131,7 +131,6 @@ static struct i2c_driver pxe1610_driver = { .name = "pxe1610", }, .probe_new = pxe1610_probe, - .remove = pmbus_do_remove, .id_table = pxe1610_id, };
drivers/hwmon/pmbus/tps40422.c +0 -1
@@ -43,7 +43,6 @@ static struct i2c_driver tps40422_driver = { .name = "tps40422", }, .probe_new = tps40422_probe, - .remove = pmbus_do_remove, .id_table = tps40422_id, };
drivers/hwmon/pmbus/tps53679.c +0 -1
@@ -251,7 +251,6 @@ static struct i2c_driver tps53679_driver = { .of_match_table = of_match_ptr(tps53679_of_match), }, .probe_new = tps53679_probe, - .remove = pmbus_do_remove, .id_table = tps53679_id, };
drivers/hwmon/pmbus/ucd9000.c +0 -1
@@ -621,7 +621,6 @@ static struct i2c_driver ucd9000_driver = { .of_match_table = of_match_ptr(ucd9000_of_match), }, .probe_new = ucd9000_probe, - .remove = pmbus_do_remove, .id_table = ucd9000_id, };
drivers/hwmon/pmbus/ucd9200.c +0 -1
@@ -201,7 +201,6 @@ static struct i2c_driver ucd9200_driver = { .of_match_table = of_match_ptr(ucd9200_of_match), }, .probe_new = ucd9200_probe, - .remove = pmbus_do_remove, .id_table = ucd9200_id, };
drivers/hwmon/pmbus/xdpe12284.c +0 -1
@@ -160,7 +160,6 @@ static struct i2c_driver xdpe122_driver = { .of_match_table = of_match_ptr(xdpe122_of_match), }, .probe_new = xdpe122_probe, - .remove = pmbus_do_remove, .id_table = xdpe122_id, };
drivers/hwmon/pmbus/zl6100.c +0 -1
@@ -396,7 +396,6 @@ static struct i2c_driver zl6100_driver = { .name = "zl6100", }, .probe_new = zl6100_probe, - .remove = pmbus_do_remove, .id_table = zl6100_id, };
Signature · 1 line
2.29.1
Quoted 7 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
The only action currently performed in
pmbus_do_remove()is removing the debugfs hierarchy. We can schedule a devm action at probe time and removepmbus_do_remove()entirely from all pmbus drivers.Signed-off-by Bartosz Golaszewski <[email protected]>
Applied.
Thanks,
Guenter
Quoted 426 lines
--- drivers/hwmon/pmbus/adm1266.c | 1 - drivers/hwmon/pmbus/adm1275.c | 1 - drivers/hwmon/pmbus/bel-pfe.c | 1 - drivers/hwmon/pmbus/ibm-cffps.c | 1 - drivers/hwmon/pmbus/inspur-ipsps.c | 1 - drivers/hwmon/pmbus/ir35221.c | 1 - drivers/hwmon/pmbus/ir38064.c | 1 - drivers/hwmon/pmbus/irps5401.c | 1 - drivers/hwmon/pmbus/isl68137.c | 1 - drivers/hwmon/pmbus/lm25066.c | 1 - drivers/hwmon/pmbus/ltc2978.c | 1 - drivers/hwmon/pmbus/ltc3815.c | 1 - drivers/hwmon/pmbus/max16064.c | 1 - drivers/hwmon/pmbus/max16601.c | 1 - drivers/hwmon/pmbus/max20730.c | 1 - drivers/hwmon/pmbus/max20751.c | 1 - drivers/hwmon/pmbus/max31785.c | 1 - drivers/hwmon/pmbus/max34440.c | 1 - drivers/hwmon/pmbus/max8688.c | 1 - drivers/hwmon/pmbus/mp2975.c | 1 - drivers/hwmon/pmbus/pmbus.c | 1 - drivers/hwmon/pmbus/pmbus.h | 1 - drivers/hwmon/pmbus/pmbus_core.c | 20 +++++++++----------- drivers/hwmon/pmbus/pxe1610.c | 1 - drivers/hwmon/pmbus/tps40422.c | 1 - drivers/hwmon/pmbus/tps53679.c | 1 - drivers/hwmon/pmbus/ucd9000.c | 1 - drivers/hwmon/pmbus/ucd9200.c | 1 - drivers/hwmon/pmbus/xdpe12284.c | 1 - drivers/hwmon/pmbus/zl6100.c | 1 - 30 files changed, 9 insertions(+), 40 deletions(-)drivers/hwmon/pmbus/adm1266.c +0
-1@@ -502,7 +502,6 @@ static struct i2c_driver adm1266_driver = { .of_match_table = adm1266_of_match, }, .probe_new = adm1266_probe, - .remove = pmbus_do_remove, .id_table = adm1266_id, };drivers/hwmon/pmbus/adm1275.c +0
-1@@ -797,7 +797,6 @@ static struct i2c_driver adm1275_driver = { .name = "adm1275", }, .probe_new = adm1275_probe, - .remove = pmbus_do_remove, .id_table = adm1275_id, };drivers/hwmon/pmbus/bel-pfe.c +0
-1@@ -121,7 +121,6 @@ static struct i2c_driver pfe_pmbus_driver = { .name = "bel-pfe", }, .probe_new = pfe_pmbus_probe, - .remove = pmbus_do_remove, .id_table = pfe_device_id, };drivers/hwmon/pmbus/ibm-cffps.c +0
-1@@ -617,7 +617,6 @@ static struct i2c_driver ibm_cffps_driver = { .of_match_table = ibm_cffps_of_match, }, .probe_new = ibm_cffps_probe, - .remove = pmbus_do_remove, .id_table = ibm_cffps_id, };drivers/hwmon/pmbus/inspur-ipsps.c +0
-1@@ -216,7 +216,6 @@ static struct i2c_driver ipsps_driver = { .of_match_table = of_match_ptr(ipsps_of_match), }, .probe_new = ipsps_probe, - .remove = pmbus_do_remove, .id_table = ipsps_id, };drivers/hwmon/pmbus/ir35221.c +0
-1@@ -137,7 +137,6 @@ static struct i2c_driver ir35221_driver = { .name = "ir35221", }, .probe_new = ir35221_probe, - .remove = pmbus_do_remove, .id_table = ir35221_id, };drivers/hwmon/pmbus/ir38064.c +0
-1@@ -53,7 +53,6 @@ static struct i2c_driver ir38064_driver = { .name = "ir38064", }, .probe_new = ir38064_probe, - .remove = pmbus_do_remove, .id_table = ir38064_id, };drivers/hwmon/pmbus/irps5401.c +0
-1@@ -55,7 +55,6 @@ static struct i2c_driver irps5401_driver = { .name = "irps5401", }, .probe_new = irps5401_probe, - .remove = pmbus_do_remove, .id_table = irps5401_id, };drivers/hwmon/pmbus/isl68137.c +0
-1@@ -324,7 +324,6 @@ static struct i2c_driver isl68137_driver = { .name = "isl68137", }, .probe_new = isl68137_probe, - .remove = pmbus_do_remove, .id_table = raa_dmpvr_id, };drivers/hwmon/pmbus/lm25066.c +0
-1@@ -508,7 +508,6 @@ static struct i2c_driver lm25066_driver = { .name = "lm25066", }, .probe_new = lm25066_probe, - .remove = pmbus_do_remove, .id_table = lm25066_id, };drivers/hwmon/pmbus/ltc2978.c +0
-1@@ -875,7 +875,6 @@ static struct i2c_driver ltc2978_driver = { .of_match_table = of_match_ptr(ltc2978_of_match), }, .probe_new = ltc2978_probe, - .remove = pmbus_do_remove, .id_table = ltc2978_id, };drivers/hwmon/pmbus/ltc3815.c +0
-1@@ -200,7 +200,6 @@ static struct i2c_driver ltc3815_driver = { .name = "ltc3815", }, .probe_new = ltc3815_probe, - .remove = pmbus_do_remove, .id_table = ltc3815_id, };drivers/hwmon/pmbus/max16064.c +0
-1@@ -103,7 +103,6 @@ static struct i2c_driver max16064_driver = { .name = "max16064", }, .probe_new = max16064_probe, - .remove = pmbus_do_remove, .id_table = max16064_id, };drivers/hwmon/pmbus/max16601.c +0
-1@@ -302,7 +302,6 @@ static struct i2c_driver max16601_driver = { .name = "max16601", }, .probe_new = max16601_probe, - .remove = pmbus_do_remove, .id_table = max16601_id, };drivers/hwmon/pmbus/max20730.c +0
-1@@ -779,7 +779,6 @@ static struct i2c_driver max20730_driver = { .of_match_table = max20730_of_match, }, .probe_new = max20730_probe, - .remove = pmbus_do_remove, .id_table = max20730_id, };drivers/hwmon/pmbus/max20751.c +0
-1@@ -43,7 +43,6 @@ static struct i2c_driver max20751_driver = { .name = "max20751", }, .probe_new = max20751_probe, - .remove = pmbus_do_remove, .id_table = max20751_id, };drivers/hwmon/pmbus/max31785.c +0
-1@@ -390,7 +390,6 @@ static struct i2c_driver max31785_driver = { .of_match_table = max31785_of_match, }, .probe_new = max31785_probe, - .remove = pmbus_do_remove, .id_table = max31785_id, };drivers/hwmon/pmbus/max34440.c +0
-1@@ -521,7 +521,6 @@ static struct i2c_driver max34440_driver = { .name = "max34440", }, .probe_new = max34440_probe, - .remove = pmbus_do_remove, .id_table = max34440_id, };drivers/hwmon/pmbus/max8688.c +0
-1@@ -183,7 +183,6 @@ static struct i2c_driver max8688_driver = { .name = "max8688", }, .probe_new = max8688_probe, - .remove = pmbus_do_remove, .id_table = max8688_id, };drivers/hwmon/pmbus/mp2975.c +0
-1@@ -758,7 +758,6 @@ static struct i2c_driver mp2975_driver = { .of_match_table = of_match_ptr(mp2975_of_match), }, .probe_new = mp2975_probe, - .remove = pmbus_do_remove, .id_table = mp2975_id, };drivers/hwmon/pmbus/pmbus.c +0
-1@@ -238,7 +238,6 @@ static struct i2c_driver pmbus_driver = { .name = "pmbus", }, .probe_new = pmbus_probe, - .remove = pmbus_do_remove, .id_table = pmbus_id, };drivers/hwmon/pmbus/pmbus.h +0
-1@@ -490,7 +490,6 @@ void pmbus_clear_faults(struct i2c_client *client);bool pmbus_check_byte_register (struct i2c_client *client,int page,int reg);bool pmbus_check_word_register (struct i2c_client *client,int page,int reg);int pmbus_do_probe (struct i2c_client *client,struct pmbus_driver_info *info); -int pmbus_do_remove (struct i2c_client *client);const struct pmbus_driver_info *pmbus_get_driver_info (struct i2c_client *client); int pmbus_get_fan_rate_device(struct i2c_client *client, int page, int id,drivers/hwmon/pmbus/pmbus_core.c +9
-11@@ -2388,6 +2388,13 @@ static int pmbus_debugfs_set_pec(void *data, u64 val)DEFINE_DEBUGFS_ATTRIBUTE (pmbus_debugfs_ops_pec, pmbus_debugfs_get_pec, pmbus_debugfs_set_pec,"%llu\n" ); +static void pmbus_remove_debugfs (void *data) +{ +struct dentry *entry = data; + +debugfs_remove_recursive (entry); +} +static int pmbus_init_debugfs (struct i2c_client *client,struct pmbus_data *data) {@@ -2523,7 +2530,8 @@ static int pmbus_init_debugfs(struct i2c_client *client, } } -return 0 ; +return devm_add_action_or_reset (data->dev, + pmbus_remove_debugfs, data->debugfs); }#else static int pmbus_init_debugfs(struct i2c_client *client,@@ -2610,16 +2618,6 @@ int pmbus_do_probe(struct i2c_client *client, struct pmbus_driver_info *info) }EXPORT_SYMBOL_GPL (pmbus_do_probe); -int pmbus_do_remove (struct i2c_client *client) -{ -struct pmbus_data *data =i2c_get_clientdata (client); - -debugfs_remove_recursive (data->debugfs); - -return 0 ; -} -EXPORT_SYMBOL_GPL (pmbus_do_remove); -struct dentry *pmbus_get_debugfs_dir (struct i2c_client *client) {struct pmbus_data *data =i2c_get_clientdata (client);drivers/hwmon/pmbus/pxe1610.c +0
-1@@ -131,7 +131,6 @@ static struct i2c_driver pxe1610_driver = { .name = "pxe1610", }, .probe_new = pxe1610_probe, - .remove = pmbus_do_remove, .id_table = pxe1610_id, };drivers/hwmon/pmbus/tps40422.c +0
-1@@ -43,7 +43,6 @@ static struct i2c_driver tps40422_driver = { .name = "tps40422", }, .probe_new = tps40422_probe, - .remove = pmbus_do_remove, .id_table = tps40422_id, };drivers/hwmon/pmbus/tps53679.c +0
-1@@ -251,7 +251,6 @@ static struct i2c_driver tps53679_driver = { .of_match_table = of_match_ptr(tps53679_of_match), }, .probe_new = tps53679_probe, - .remove = pmbus_do_remove, .id_table = tps53679_id, };drivers/hwmon/pmbus/ucd9000.c +0
-1@@ -621,7 +621,6 @@ static struct i2c_driver ucd9000_driver = { .of_match_table = of_match_ptr(ucd9000_of_match), }, .probe_new = ucd9000_probe, - .remove = pmbus_do_remove, .id_table = ucd9000_id, };drivers/hwmon/pmbus/ucd9200.c +0
-1@@ -201,7 +201,6 @@ static struct i2c_driver ucd9200_driver = { .of_match_table = of_match_ptr(ucd9200_of_match), }, .probe_new = ucd9200_probe, - .remove = pmbus_do_remove, .id_table = ucd9200_id, };drivers/hwmon/pmbus/xdpe12284.c +0
-1@@ -160,7 +160,6 @@ static struct i2c_driver xdpe122_driver = { .of_match_table = of_match_ptr(xdpe122_of_match), }, .probe_new = xdpe122_probe, - .remove = pmbus_do_remove, .id_table = xdpe122_id, };drivers/hwmon/pmbus/zl6100.c +0
-1@@ -396,7 +396,6 @@ static struct i2c_driver zl6100_driver = { .name = "zl6100", }, .probe_new = zl6100_probe, - .remove = pmbus_do_remove, .id_table = zl6100_id, };