Skip to contentSkip to conversation

net: phylink: disable BMCR_ISOLATE in phylink_mii_c22_pcs_config

PATCH Applied Robert Hancock 2 participants 2 messages Oct 26, 2020 – Oct 29, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: phylink: disable BMCR_ISOLATE in phylink_mii_c22_pcs_config

The Xilinx PCS/PMA PHY requires that BMCR_ISOLATE be disabled for proper operation in 1000BaseX mode. It should be safe to ensure this bit is disabled in phylink_mii_c22_pcs_config in all cases.

---

Resubmit tagged for net-next.

 drivers/net/phy/phylink.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/phy/phylink.c +2 -1
index fe2296fdda19..5d8c015bc9f2 100644
@@ -2515,9 +2515,10 @@ int phylink_mii_c22_pcs_config(struct mdio_device *pcs, unsigned int mode,
 
 	changed = ret > 0;
 
+	/* Ensure ISOLATE bit is disabled */
 	bmcr = mode == MLO_AN_INBAND ? BMCR_ANENABLE : 0;
 	ret = mdiobus_modify(pcs->bus, pcs->addr, MII_BMCR,
-			     BMCR_ANENABLE, bmcr);
+			     BMCR_ANENABLE | BMCR_ISOLATE, bmcr);
 	if (ret < 0)
 		return ret;
 
Signature · 1 line
2.18.4
maintainer Applied
#1 lore raw
Quoted 9 lines · On Mon, 26 Oct 2020 11:58:02 -0600 Robert Hancock wrote:

The Xilinx PCS/PMA PHY requires that BMCR_ISOLATE be disabled for proper operation in 1000BaseX mode. It should be safe to ensure this bit is disabled in phylink_mii_c22_pcs_config in all cases.

---

Resubmit tagged for net-next.

Applied, thank you!