net/mlx5: fix wrong assignment of allow_multi_pkt_send_wqe
PATCH 1/1 net/mlx5: fix wrong assignment of allow_multi_pkt_send_wqe
Fix wrong assignment of allow_multi_pkt_send_wqe in mlx5_devx_cmd_create_sq.
The incorrect assignment was introduced in the initial mlx5_devx_cmd_create_sq implementation.
sq_attr->flush_in_error_en is
mistakenly assigned to both allow_multi_pkt_send_wqe and flush_in_error_en, it was detected during Windows PMD development.
The fix is simply assigning the right value in mlx5_devx_cmd_create_sq to sq_attr->allow_multi_pkt_send_wqe
--- drivers/common/mlx5/mlx5_devx_cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/common/mlx5/mlx5_devx_cmds.c +1 -1
@@ -1246,7 +1246,7 @@ mlx5_devx_cmd_create_sq(void *ctx,MLX5_SET (sqc, sq_ctx, fre, sq_attr->fre);MLX5_SET (sqc, sq_ctx, flush_in_error_en, sq_attr->flush_in_error_en);MLX5_SET (sqc, sq_ctx, allow_multi_pkt_send_wqe, - sq_attr->flush_in_error_en); + sq_attr->allow_multi_pkt_send_wqe);MLX5_SET (sqc, sq_ctx, min_wqe_inline_mode, sq_attr->min_wqe_inline_mode);MLX5_SET (sqc, sq_ctx, state, sq_attr->state);
Signature · 1 line
2.16.1.windows.4
Hi,
Quoted 22 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Tal Shnaiderman
Sent: Monday, October 26, 2020 8:18 PM
To: [email protected]
Cc: NBU-Contact-Thomas Monjalon <[email protected]>; Matan Azrad <[email protected]>; Shahaf Shuler <[email protected]>; Slava Ovsiienko <[email protected]>; [email protected]
Subject: [dpdk-dev] [PATCH] net/mlx5: fix wrong assignment ofallow_multi_pkt_send_wqeFix wrong assignment of
allow_multi_pkt_send_wqeinmlx5_devx_cmd_create_sq.
The incorrect assignment was introduced in the initialmlx5_devx_cmd_create_sqimplementation.
sq_attr->flush_in_error_enis
mistakenly assigned to bothallow_multi_pkt_send_wqeandflush_in_error_en, it was detected during Windows PMD development.The fix is simply assigning the right value in
mlx5_devx_cmd_create_sqtosq_attr->allow_multi_pkt_send_wqe
Quoted 9 lines
Fixes ae18a1ae9692 ("net/mlx5: support Tx hairpin queues")Signed-off-by Tal Shnaiderman <[email protected]>Acked-by Matan Azrad <[email protected]>--- drivers/common/mlx5/mlx5_devx_cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh