Skip to contentSkip to conversation

net/mlx5: fix wrong assignment of allow_multi_pkt_send_wqe

PATCH In review Tal Shnaiderman 2 participants 2 messages Oct 26, 2020 – Nov 1, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/mlx5: fix wrong assignment of allow_multi_pkt_send_wqe

Fix wrong assignment of allow_multi_pkt_send_wqe in mlx5_devx_cmd_create_sq.
The incorrect assignment was introduced in the initial mlx5_devx_cmd_create_sq implementation.

sq_attr->flush_in_error_en is
mistakenly assigned to both allow_multi_pkt_send_wqe and flush_in_error_en, it was detected during Windows PMD development.

The fix is simply assigning the right value in mlx5_devx_cmd_create_sq to sq_attr->allow_multi_pkt_send_wqe

Fixes ae18a1ae9692 ("net/mlx5: support Tx hairpin queues")
---
 drivers/common/mlx5/mlx5_devx_cmds.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/common/mlx5/mlx5_devx_cmds.c +1 -1
index fd4e3f2d48..55aaba1980 100644
@@ -1246,7 +1246,7 @@ mlx5_devx_cmd_create_sq(void *ctx,
 	MLX5_SET(sqc, sq_ctx, fre, sq_attr->fre);
 	MLX5_SET(sqc, sq_ctx, flush_in_error_en, sq_attr->flush_in_error_en);
 	MLX5_SET(sqc, sq_ctx, allow_multi_pkt_send_wqe,
-		 sq_attr->flush_in_error_en);
+		 sq_attr->allow_multi_pkt_send_wqe);
 	MLX5_SET(sqc, sq_ctx, min_wqe_inline_mode,
 		 sq_attr->min_wqe_inline_mode);
 	MLX5_SET(sqc, sq_ctx, state, sq_attr->state);
Signature · 1 line
2.16.1.windows.4
#1 lore raw

Hi,

Quoted 22 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Tal Shnaiderman
Sent: Monday, October 26, 2020 8:18 PM
To: [email protected]
Cc: NBU-Contact-Thomas Monjalon <[email protected]>; Matan Azrad <[email protected]>; Shahaf Shuler <[email protected]>; Slava Ovsiienko <[email protected]>; [email protected]
Subject: [dpdk-dev] [PATCH] net/mlx5: fix wrong assignment of allow_multi_pkt_send_wqe

Fix wrong assignment of allow_multi_pkt_send_wqe in mlx5_devx_cmd_create_sq.
The incorrect assignment was introduced in the initial mlx5_devx_cmd_create_sq implementation.

sq_attr->flush_in_error_en is
mistakenly assigned to both allow_multi_pkt_send_wqe and flush_in_error_en, it was detected during Windows PMD development.

The fix is simply assigning the right value in mlx5_devx_cmd_create_sq to sq_attr->allow_multi_pkt_send_wqe

Quoted 9 lines
Fixes ae18a1ae9692 ("net/mlx5: support Tx hairpin queues")
---
 drivers/common/mlx5/mlx5_devx_cmds.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh