Skip to contentSkip to conversation

arm: sunxi: disable obsolete VIDEO config

PATCH New Anatolij Gustschin 6 participants 53 messages Oct 18, 2020 – Oct 30, 2020 1 message not in the archive

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: sunxi: disable obsolete VIDEO config

DM_VIDEO conversion deadline has passed, disable VIDEO config option by default. Boards should convert to DM_VIDEO if they need video console support.

---
 arch/arm/mach-sunxi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-sunxi/Kconfig +1 -1
index be0822bfb7..f672bb8b4e 100644
@@ -760,7 +760,7 @@ config VIDEO_SUNXI
 	depends on !MACH_SUN50I_H6
 	select VIDEO
 	imply VIDEO_DT_SIMPLEFB
-	default y
+	default n
 	---help---
 	Say Y here to add support for using a cfb console on the HDMI, LCD
 	or VGA output found on most sunxi devices. See doc/README.video for
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 at91sam9: disable obsolete VIDEO config

DM_VIDEO conversion deadline has passed, disable VIDEO config.

---
 configs/at91sam9261ek_dataflash_cs0_defconfig | 2 +-
 configs/at91sam9261ek_dataflash_cs3_defconfig | 2 +-
 configs/at91sam9261ek_nandflash_defconfig     | 2 +-
 configs/at91sam9263ek_dataflash_cs0_defconfig | 2 +-
 configs/at91sam9263ek_dataflash_defconfig     | 2 +-
 configs/at91sam9263ek_nandflash_defconfig     | 2 +-
 configs/at91sam9263ek_norflash_boot_defconfig | 2 +-
 configs/at91sam9263ek_norflash_defconfig      | 2 +-
 configs/at91sam9g10ek_dataflash_cs0_defconfig | 2 +-
 configs/at91sam9g10ek_dataflash_cs3_defconfig | 2 +-
 configs/at91sam9g10ek_nandflash_defconfig     | 2 +-
 configs/at91sam9m10g45ek_mmc_defconfig        | 2 +-
 configs/at91sam9m10g45ek_nandflash_defconfig  | 2 +-
 configs/at91sam9rlek_dataflash_defconfig      | 2 +-
 configs/at91sam9rlek_mmc_defconfig            | 2 +-
 configs/at91sam9rlek_nandflash_defconfig      | 2 +-
 16 files changed, 16 insertions(+), 16 deletions(-)
configs/at91sam9261ek_dataflash_cs0_defconfig +1 -1
index 422b8aed2a..9d4e5b51d0 100644
@@ -59,4 +59,4 @@ CONFIG_TIMER=y
 CONFIG_ATMEL_PIT_TIMER=y
 CONFIG_USB=y
 CONFIG_USB_STORAGE=y
-CONFIG_LCD=y
+# CONFIG_LCD is not set
configs/at91sam9261ek_dataflash_cs3_defconfig +1 -1
index 4494970153..3a0bb10624 100644
@@ -59,4 +59,4 @@ CONFIG_TIMER=y
 CONFIG_ATMEL_PIT_TIMER=y
 CONFIG_USB=y
 CONFIG_USB_STORAGE=y
-CONFIG_LCD=y
+# CONFIG_LCD is not set
configs/at91sam9261ek_nandflash_defconfig +1 -1
index 2381199f60..abdf2236a8 100644
@@ -56,4 +56,4 @@ CONFIG_TIMER=y
 CONFIG_ATMEL_PIT_TIMER=y
 CONFIG_USB=y
 CONFIG_USB_STORAGE=y
-CONFIG_LCD=y
+# CONFIG_LCD is not set
configs/at91sam9263ek_dataflash_cs0_defconfig +1 -1
index b458aece4b..564b781a20 100644
@@ -67,4 +67,4 @@ CONFIG_ATMEL_PIT_TIMER=y
 CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
-CONFIG_LCD=y
+# CONFIG_LCD is not set
configs/at91sam9263ek_dataflash_defconfig +1 -1
index b458aece4b..564b781a20 100644
@@ -67,4 +67,4 @@ CONFIG_ATMEL_PIT_TIMER=y
 CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
-CONFIG_LCD=y
+# CONFIG_LCD is not set
configs/at91sam9263ek_nandflash_defconfig +1 -1
index a7a372d766..32b2fffff8 100644
@@ -64,4 +64,4 @@ CONFIG_ATMEL_PIT_TIMER=y
 CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
-CONFIG_LCD=y
+# CONFIG_LCD is not set
configs/at91sam9263ek_norflash_boot_defconfig +1 -1
index 7aea097f47..2955b058ad 100644
@@ -67,4 +67,4 @@ CONFIG_ATMEL_PIT_TIMER=y
 CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
-CONFIG_LCD=y
+# CONFIG_LCD is not set
configs/at91sam9263ek_norflash_defconfig +1 -1
index 7f4de534f8..56355f6a6a 100644
@@ -67,4 +67,4 @@ CONFIG_ATMEL_PIT_TIMER=y
 CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
-CONFIG_LCD=y
+# CONFIG_LCD is not set
configs/at91sam9g10ek_dataflash_cs0_defconfig +1 -1
index 3e5632cddd..a5a493d1dd 100644
@@ -57,4 +57,4 @@ CONFIG_SPI=y
 CONFIG_DM_SPI=y
 CONFIG_USB=y
 CONFIG_USB_STORAGE=y
-CONFIG_LCD=y
+# CONFIG_LCD is not set
configs/at91sam9g10ek_dataflash_cs3_defconfig +1 -1
index 31ce87e4f8..85c4c50440 100644
@@ -57,4 +57,4 @@ CONFIG_SPI=y
 CONFIG_DM_SPI=y
 CONFIG_USB=y
 CONFIG_USB_STORAGE=y
-CONFIG_LCD=y
+# CONFIG_LCD is not set
configs/at91sam9g10ek_nandflash_defconfig +1 -1
index bf820d7dd9..609b9eb4e2 100644
@@ -54,4 +54,4 @@ CONFIG_SPI=y
 CONFIG_DM_SPI=y
 CONFIG_USB=y
 CONFIG_USB_STORAGE=y
-CONFIG_LCD=y
+# CONFIG_LCD is not set
configs/at91sam9m10g45ek_mmc_defconfig +1 -1
index 81812697e0..2885e12bc9 100644
@@ -58,4 +58,4 @@ CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_STORAGE=y
-CONFIG_LCD=y
+# CONFIG_LCD is not set
configs/at91sam9m10g45ek_nandflash_defconfig +1 -1
index 636cab1ecb..f89bf1e185 100644
@@ -58,4 +58,4 @@ CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_STORAGE=y
-CONFIG_LCD=y
+# CONFIG_LCD is not set
configs/at91sam9rlek_dataflash_defconfig +1 -1
index 9f314b3933..f037a8df38 100644
@@ -60,4 +60,4 @@ CONFIG_SPI=y
 CONFIG_DM_SPI=y
 CONFIG_TIMER=y
 CONFIG_ATMEL_PIT_TIMER=y
-CONFIG_LCD=y
+# CONFIG_LCD is not set
configs/at91sam9rlek_mmc_defconfig +1 -1
index 9b22c55139..34773508d2 100644
@@ -56,4 +56,4 @@ CONFIG_SPI=y
 CONFIG_DM_SPI=y
 CONFIG_TIMER=y
 CONFIG_ATMEL_PIT_TIMER=y
-CONFIG_LCD=y
+# CONFIG_LCD is not set
configs/at91sam9rlek_nandflash_defconfig +1 -1
index 38c18f9791..ad8fcdf13e 100644
@@ -57,4 +57,4 @@ CONFIG_SPI=y
 CONFIG_DM_SPI=y
 CONFIG_TIMER=y
 CONFIG_ATMEL_PIT_TIMER=y
-CONFIG_LCD=y
+# CONFIG_LCD is not set
Signature · 1 line
2.17.1
#2 lore raw

PATCH 1/1 at91sam9: disable obsolete VIDEO config

Quoted 13 lines · On Sun, 18 Oct 2020 21:18:16 +0200 Anatolij Gustschin agust at denx.de wrote:

DM_VIDEO conversion deadline has passed, disable VIDEO config.

---
 configs/at91sam9261ek_dataflash_cs0_defconfig | 2 +-
 configs/at91sam9261ek_dataflash_cs3_defconfig | 2 +-
 configs/at91sam9261ek_nandflash_defconfig     | 2 +-
 configs/at91sam9263ek_dataflash_cs0_defconfig | 2 +-
 configs/at91sam9263ek_dataflash_defconfig     | 2 +-
 configs/at91sam9263ek_nandflash_defconfig     | 2 +-
 configs/at91sam9263ek_norflash_boot_defconfig | 2 +-
 configs/at91sam9263ek_norflash_defconfig      | 2 +-
 configs/at91sam9g10ek_dataflash_cs0_defconfig | 2 +-
Quoted 8 lines
 configs/at91sam9g10ek_dataflash_cs3_defconfig | 2 +-
 configs/at91sam9g10ek_nandflash_defconfig     | 2 +-
 configs/at91sam9m10g45ek_mmc_defconfig        | 2 +-
 configs/at91sam9m10g45ek_nandflash_defconfig  | 2 +-
 configs/at91sam9rlek_dataflash_defconfig      | 2 +-
 configs/at91sam9rlek_mmc_defconfig            | 2 +-
 configs/at91sam9rlek_nandflash_defconfig      | 2 +-
 16 files changed, 16 insertions(+), 16 deletions(-)

Applied to u-boot-video/master.

#3 lore raw

PATCH 1/1 at91sam9n12ek: disable obsolete VIDEO config

In reply to Anatolij Gustschin

DM_VIDEO conversion deadline has passed, disable VIDEO config. Boards should convert to DM_VIDEO if they need video console support.

---
 configs/at91sam9n12ek_mmc_defconfig       | 2 +-
 configs/at91sam9n12ek_nandflash_defconfig | 2 +-
 configs/at91sam9n12ek_spiflash_defconfig  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
configs/at91sam9n12ek_mmc_defconfig +1 -1
index 23be41edb0..15a43355d9 100644
@@ -62,4 +62,4 @@ CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_ATMEL_HLCD=y
-CONFIG_LCD=y
+# CONFIG_LCD is not set
configs/at91sam9n12ek_nandflash_defconfig +1 -1
index 35c1b4ac31..5f3c25611f 100644
@@ -63,4 +63,4 @@ CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_ATMEL_HLCD=y
-CONFIG_LCD=y
+# CONFIG_LCD is not set
configs/at91sam9n12ek_spiflash_defconfig +1 -1
index aea633d5dc..65c8926547 100644
@@ -64,4 +64,4 @@ CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_ATMEL_HLCD=y
-CONFIG_LCD=y
+# CONFIG_LCD is not set
Signature · 1 line
2.17.1
#4 lore raw

PATCH 1/1 at91sam9n12ek: disable obsolete VIDEO config

Quoted 11 lines · On Sun, 18 Oct 2020 21:18:17 +0200 Anatolij Gustschin agust at denx.de wrote:

DM_VIDEO conversion deadline has passed, disable VIDEO config. Boards should convert to DM_VIDEO if they need video console support.

---
 configs/at91sam9n12ek_mmc_defconfig       | 2 +-
 configs/at91sam9n12ek_nandflash_defconfig | 2 +-
 configs/at91sam9n12ek_spiflash_defconfig  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Applied to u-boot-video/master.

#5 lore raw

PATCH 1/1 eb_cpu5282: fix CONFIG_DM_VIDEO build warnings

In reply to Anatolij Gustschin

Remove CONFIG_VIDEO dependency to fix board removal warnings.

---
 board/BuS/eb_cpu5282/eb_cpu5282.c     | 7 +++----
 common/stdio.c                        | 4 +++-
 configs/eb_cpu5282_defconfig          | 3 +--
 configs/eb_cpu5282_internal_defconfig | 3 +--
 drivers/video/Kconfig                 | 7 +++++++
 include/configs/eb_cpu5282.h          | 4 ----
 scripts/config_whitelist.txt          | 1 -
 7 files changed, 15 insertions(+), 14 deletions(-)
board/BuS/eb_cpu5282/eb_cpu5282.c +3 -4
index 1d05e40c20..f5e4de3c41 100644
@@ -20,7 +20,7 @@
 
 DECLARE_GLOBAL_DATA_PTR;
 
-#ifdef CONFIG_VIDEO
+#if IS_ENABLED(CONFIG_VIDEO_VCXK)
 unsigned long display_width;
 unsigned long display_height;
 #endif
@@ -183,8 +183,7 @@ void __led_set(led_id_t mask, int state)
 		MCFGPTA_GPTPORT &= ~(1 << 3);
 }
 
-#if defined(CONFIG_VIDEO)
-
+#if IS_ENABLED(CONFIG_VIDEO_VCXK)
 int drv_video_init(void)
 {
 	char *s;
@@ -225,7 +224,7 @@ int drv_video_init(void)
 
 /*---------------------------------------------------------------------------*/
 
-#ifdef CONFIG_VIDEO
+#if IS_ENABLED(CONFIG_VIDEO_VCXK)
 int do_brightness(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
 {
 	int rcode = 0;
common/stdio.c +3 -1
index 84c36a735c..a15f30804b 100644
@@ -356,7 +356,9 @@ int stdio_add_devices(void)
 	} else {
 		if (IS_ENABLED(CONFIG_LCD))
 			drv_lcd_init();
-		if (IS_ENABLED(CONFIG_VIDEO) || IS_ENABLED(CONFIG_CFB_CONSOLE))
+		if (IS_ENABLED(CONFIG_VIDEO) ||
+		    IS_ENABLED(CONFIG_CFB_CONSOLE) ||
+		    IS_ENABLED(CONFIG_VIDEO_VCXK))
 			drv_video_init();
 	}
 
configs/eb_cpu5282_defconfig +1 -2
index bc0f72f44a..1f89342cb5 100644
@@ -32,6 +32,5 @@ CONFIG_SYS_FLASH_CFI=y
 CONFIG_DM_ETH=y
 CONFIG_MCFFEC=y
 CONFIG_MII=y
-CONFIG_VIDEO=y
-# CONFIG_CFB_CONSOLE is not set
+CONFIG_VIDEO_VCXK=y
 CONFIG_SPLASH_SCREEN=y
configs/eb_cpu5282_internal_defconfig +1 -2
index 72e34ba3b4..ad7b7d56bc 100644
@@ -31,6 +31,5 @@ CONFIG_SYS_FLASH_CFI=y
 CONFIG_DM_ETH=y
 CONFIG_MCFFEC=y
 CONFIG_MII=y
-CONFIG_VIDEO=y
-# CONFIG_CFB_CONSOLE is not set
+CONFIG_VIDEO_VCXK=y
 CONFIG_SPLASH_SCREEN=y
drivers/video/Kconfig +7 -0
index b1cb745d59..2f3bb4b085 100644
@@ -972,4 +972,11 @@ config BMP_32BPP
 	help
 	  Support display of bitmaps file with 32-bit-per-pixel.
 
+config VIDEO_VCXK
+	bool "Enable VCXK video controller driver support"
+	default n
+	help
+	  This enables VCXK driver which can be used with VC2K, VC4K
+	  and VC8K devices on various boards from BuS Elektronik GmbH.
+
 endmenu
include/configs/eb_cpu5282.h +0 -4
index db92bbd49a..ab9daa4074 100644
@@ -212,9 +212,6 @@
  * VIDEO configuration
  */
 
-#ifdef CONFIG_VIDEO
-#define CONFIG_VIDEO_VCXK			1
-
 #define CONFIG_SYS_VCXK_DEFAULT_LINEALIGN	2
 #define	CONFIG_SYS_VCXK_DOUBLEBUFFERED		1
 #define CONFIG_SYS_VCXK_BASE			CONFIG_SYS_CS2_BASE
@@ -235,6 +232,5 @@
 #define CONFIG_SYS_VCXK_INVERT_DDR		MCFGPIO_DDRE
 #define CONFIG_SYS_VCXK_INVERT_PIN		MCFGPIO_PORT2
 
-#endif /* CONFIG_VIDEO */
 #endif	/* _CONFIG_M5282EVB_H */
 /*---------------------------------------------------------------------*/
scripts/config_whitelist.txt +0 -1
index dc4f0b050c..3af200bb17 100644
@@ -4069,7 +4069,6 @@ CONFIG_VIDEO_MB862xx_ACCEL
 CONFIG_VIDEO_MXS
 CONFIG_VIDEO_MXS_MODE_SYSTEM
 CONFIG_VIDEO_STD_TIMINGS
-CONFIG_VIDEO_VCXK
 CONFIG_VID_FLS_ENV
 CONFIG_VM86
 CONFIG_VOIPAC_LCD
Signature · 1 line
2.17.1
#6 lore raw

PATCH 1/1 eb_cpu5282: fix CONFIG_DM_VIDEO build warnings

Quoted 4 lines · On Sun, 18 Oct 2020 21:18:18 +0200 Anatolij Gustschin agust at denx.de wrote:

Remove CONFIG_VIDEO dependency to fix board removal warnings.

Quoted 9 lines
---
 board/BuS/eb_cpu5282/eb_cpu5282.c     | 7 +++----
 common/stdio.c                        | 4 +++-
 configs/eb_cpu5282_defconfig          | 3 +--
 configs/eb_cpu5282_internal_defconfig | 3 +--
 drivers/video/Kconfig                 | 7 +++++++
 include/configs/eb_cpu5282.h          | 4 ----
 scripts/config_whitelist.txt          | 1 -
 7 files changed, 15 insertions(+), 14 deletions(-)

Applied to u-boot-video/master.

#7 lore raw

PATCH 1/1 imx: mx6sxsabresd: disable obsolete VIDEO config

In reply to Anatolij Gustschin

DM_VIDEO conversion deadline has passed, disable VIDEO config.

---
 configs/mx6sxsabresd_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configs/mx6sxsabresd_defconfig +1 -1
index 584e79572a..a33ec49ed4 100644
@@ -73,7 +73,7 @@ CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_HOST_ETHER=y
 CONFIG_USB_ETHER_ASIX=y
-CONFIG_VIDEO=y
+# CONFIG_VIDEO is not set
 CONFIG_SPLASH_SCREEN=y
 CONFIG_SPLASH_SCREEN_ALIGN=y
 CONFIG_VIDEO_BMP_RLE8=y
Signature · 1 line
2.17.1
#8 lore raw

PATCH 1/1 imx: mx6sxsabresd: disable obsolete VIDEO config

Quoted 6 lines · On Sun, 18 Oct 2020 21:18:19 +0200 Anatolij Gustschin agust at denx.de wrote:

DM_VIDEO conversion deadline has passed, disable VIDEO config.

---
 configs/mx6sxsabresd_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to u-boot-video/master.

#9 lore raw

PATCH 1/1 imx: mx7dsabresd: disable obsolete VIDEO config

In reply to Anatolij Gustschin

DM_VIDEO conversion deadline has passed, disable VIDEO config.

---
 configs/mx7dsabresd_defconfig      | 2 +-
 configs/mx7dsabresd_qspi_defconfig | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
configs/mx7dsabresd_defconfig +1 -1
index 9e2e24982f..9b4bbf3024 100644
@@ -84,7 +84,7 @@ CONFIG_CI_UDC=y
 CONFIG_USB_GADGET_DOWNLOAD=y
 CONFIG_USB_HOST_ETHER=y
 CONFIG_USB_ETHER_ASIX=y
-CONFIG_VIDEO=y
+# CONFIG_VIDEO is not set
 CONFIG_SPLASH_SCREEN=y
 CONFIG_SPLASH_SCREEN_ALIGN=y
 CONFIG_VIDEO_BMP_RLE8=y
configs/mx7dsabresd_qspi_defconfig +1 -1
index 7f73956aeb..fa5deb8e6c 100644
@@ -91,7 +91,7 @@ CONFIG_CI_UDC=y
 CONFIG_USB_GADGET_DOWNLOAD=y
 CONFIG_USB_HOST_ETHER=y
 CONFIG_USB_ETHER_ASIX=y
-CONFIG_VIDEO=y
+# CONFIG_VIDEO is not set
 CONFIG_SPLASH_SCREEN=y
 CONFIG_SPLASH_SCREEN_ALIGN=y
 CONFIG_VIDEO_BMP_RLE8=y
Signature · 1 line
2.17.1
#10 lore raw

PATCH 1/1 imx: mx7dsabresd: disable obsolete VIDEO config

Quoted 7 lines · On Sun, 18 Oct 2020 21:18:20 +0200 Anatolij Gustschin agust at denx.de wrote:

DM_VIDEO conversion deadline has passed, disable VIDEO config.

---
 configs/mx7dsabresd_defconfig      | 2 +-
 configs/mx7dsabresd_qspi_defconfig | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Applied to u-boot-video/master.

#11 lore raw

PATCH 1/1 ls1021aqds: disable obsolete VIDEO config

In reply to Anatolij Gustschin

DM_VIDEO conversion deadline has passed, disable VIDEO config.

---
 configs/ls1021aqds_ddr4_nor_defconfig        | 4 ++--
 configs/ls1021aqds_ddr4_nor_lpuart_defconfig | 4 ++--
 configs/ls1021aqds_nand_defconfig            | 4 ++--
 configs/ls1021aqds_nor_SECURE_BOOT_defconfig | 4 ++--
 configs/ls1021aqds_nor_defconfig             | 4 ++--
 configs/ls1021aqds_nor_lpuart_defconfig      | 4 ++--
 configs/ls1021aqds_qspi_defconfig            | 4 ++--
 configs/ls1021aqds_sdcard_ifc_defconfig      | 4 ++--
 configs/ls1021aqds_sdcard_qspi_defconfig     | 4 ++--
 9 files changed, 18 insertions(+), 18 deletions(-)
configs/ls1021aqds_ddr4_nor_defconfig +2 -2
index 6687fc2630..b6ac5232b7 100644
@@ -70,6 +70,6 @@ CONFIG_DM_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
 CONFIG_USB_STORAGE=y
-CONFIG_VIDEO_FSL_DCU_FB=y
-CONFIG_VIDEO=y
+# CONFIG_VIDEO_FSL_DCU_FB is not set
+# CONFIG_VIDEO is not set
 # CONFIG_VIDEO_SW_CURSOR is not set
configs/ls1021aqds_ddr4_nor_lpuart_defconfig +2 -2
index 555d4e9843..1bb657df3b 100644
@@ -70,6 +70,6 @@ CONFIG_DM_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
 CONFIG_USB_STORAGE=y
-CONFIG_VIDEO_FSL_DCU_FB=y
-CONFIG_VIDEO=y
+# CONFIG_VIDEO_FSL_DCU_FB is not set
+# CONFIG_VIDEO is not set
 # CONFIG_VIDEO_SW_CURSOR is not set
configs/ls1021aqds_nand_defconfig +2 -2
index 9478ed52a6..f0d49bad29 100644
@@ -85,6 +85,6 @@ CONFIG_DM_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
 CONFIG_USB_STORAGE=y
-CONFIG_VIDEO_FSL_DCU_FB=y
-CONFIG_VIDEO=y
+# CONFIG_VIDEO_FSL_DCU_FB is not set
+# CONFIG_VIDEO is not set
 # CONFIG_VIDEO_SW_CURSOR is not set
configs/ls1021aqds_nor_SECURE_BOOT_defconfig +2 -2
index c5e93dac60..0ba4124585 100644
@@ -67,8 +67,8 @@ CONFIG_DM_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
 CONFIG_USB_STORAGE=y
-CONFIG_VIDEO_FSL_DCU_FB=y
-CONFIG_VIDEO=y
+# CONFIG_VIDEO_FSL_DCU_FB is not set
+# CONFIG_VIDEO is not set
 # CONFIG_VIDEO_SW_CURSOR is not set
 CONFIG_RSA=y
 CONFIG_SPL_RSA=y
configs/ls1021aqds_nor_defconfig +2 -2
index 10060a10ac..da2a7617c8 100644
@@ -71,6 +71,6 @@ CONFIG_DM_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
 CONFIG_USB_STORAGE=y
-CONFIG_VIDEO_FSL_DCU_FB=y
-CONFIG_VIDEO=y
+# CONFIG_VIDEO_FSL_DCU_FB is not set
+# CONFIG_VIDEO is not set
 # CONFIG_VIDEO_SW_CURSOR is not set
configs/ls1021aqds_nor_lpuart_defconfig +2 -2
index 3dc0baafe3..d3d8fcb633 100644
@@ -71,6 +71,6 @@ CONFIG_DM_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
 CONFIG_USB_STORAGE=y
-CONFIG_VIDEO_FSL_DCU_FB=y
-CONFIG_VIDEO=y
+# CONFIG_VIDEO_FSL_DCU_FB is not set
+# CONFIG_VIDEO is not set
 # CONFIG_VIDEO_SW_CURSOR is not set
configs/ls1021aqds_qspi_defconfig +2 -2
index db5b571ea2..08b9ec2c08 100644
@@ -70,6 +70,6 @@ CONFIG_DM_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
 CONFIG_USB_STORAGE=y
-CONFIG_VIDEO_FSL_DCU_FB=y
-CONFIG_VIDEO=y
+# CONFIG_VIDEO_FSL_DCU_FB is not set
+# CONFIG_VIDEO is not set
 # CONFIG_VIDEO_SW_CURSOR is not set
configs/ls1021aqds_sdcard_ifc_defconfig +2 -2
index 0d0fa68e83..ef194dfc82 100644
@@ -84,6 +84,6 @@ CONFIG_DM_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
 CONFIG_USB_STORAGE=y
-CONFIG_VIDEO_FSL_DCU_FB=y
-CONFIG_VIDEO=y
+# CONFIG_VIDEO_FSL_DCU_FB is not set
+# CONFIG_VIDEO is not set
 # CONFIG_VIDEO_SW_CURSOR is not set
configs/ls1021aqds_sdcard_qspi_defconfig +2 -2
index c322ee8ca4..e64cb38699 100644
@@ -82,6 +82,6 @@ CONFIG_DM_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
 CONFIG_USB_STORAGE=y
-CONFIG_VIDEO_FSL_DCU_FB=y
-CONFIG_VIDEO=y
+# CONFIG_VIDEO_FSL_DCU_FB is not set
+# CONFIG_VIDEO is not set
 # CONFIG_VIDEO_SW_CURSOR is not set
Signature · 1 line
2.17.1
#12 lore raw

PATCH 1/1 ls1021aqds: disable obsolete VIDEO config

Quoted 4 lines · On Sun, 18 Oct 2020 21:18:21 +0200 Anatolij Gustschin agust at denx.de wrote:

DM_VIDEO conversion deadline has passed, disable VIDEO config.

Quoted 11 lines
---
 configs/ls1021aqds_ddr4_nor_defconfig        | 4 ++--
 configs/ls1021aqds_ddr4_nor_lpuart_defconfig | 4 ++--
 configs/ls1021aqds_nand_defconfig            | 4 ++--
 configs/ls1021aqds_nor_SECURE_BOOT_defconfig | 4 ++--
 configs/ls1021aqds_nor_defconfig             | 4 ++--
 configs/ls1021aqds_nor_lpuart_defconfig      | 4 ++--
 configs/ls1021aqds_qspi_defconfig            | 4 ++--
 configs/ls1021aqds_sdcard_ifc_defconfig      | 4 ++--
 configs/ls1021aqds_sdcard_qspi_defconfig     | 4 ++--
 9 files changed, 18 insertions(+), 18 deletions(-)

Applied to u-boot-video/master.

#13 lore raw

PATCH 1/1 ls1021atwr: disable obsolete VIDEO config

In reply to Anatolij Gustschin

DM_VIDEO conversion deadline has passed, disable VIDEO config.

---
 configs/ls1021atwr_nor_SECURE_BOOT_defconfig        | 4 ++--
 configs/ls1021atwr_nor_defconfig                    | 4 ++--
 configs/ls1021atwr_nor_lpuart_defconfig             | 4 ++--
 configs/ls1021atwr_qspi_defconfig                   | 4 ++--
 configs/ls1021atwr_sdcard_ifc_SECURE_BOOT_defconfig | 4 ++--
 configs/ls1021atwr_sdcard_ifc_defconfig             | 4 ++--
 configs/ls1021atwr_sdcard_qspi_defconfig            | 4 ++--
 7 files changed, 14 insertions(+), 14 deletions(-)
configs/ls1021atwr_nor_SECURE_BOOT_defconfig +2 -2
index d62dcfa751..df99a75228 100644
@@ -61,8 +61,8 @@ CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
-CONFIG_VIDEO_FSL_DCU_FB=y
-CONFIG_VIDEO=y
+# CONFIG_VIDEO_FSL_DCU_FB is not set
+# CONFIG_VIDEO is not set
 # CONFIG_VIDEO_SW_CURSOR is not set
 CONFIG_RSA=y
 CONFIG_SPL_RSA=y
configs/ls1021atwr_nor_defconfig +2 -2
index f49a882e0a..a71f7b3ba7 100644
@@ -65,6 +65,6 @@ CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
-CONFIG_VIDEO_FSL_DCU_FB=y
-CONFIG_VIDEO=y
+# CONFIG_VIDEO_FSL_DCU_FB is not set
+# CONFIG_VIDEO is not set
 # CONFIG_VIDEO_SW_CURSOR is not set
configs/ls1021atwr_nor_lpuart_defconfig +2 -2
index e75c7b43d2..d24b3682ed 100644
@@ -66,6 +66,6 @@ CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
-CONFIG_VIDEO_FSL_DCU_FB=y
-CONFIG_VIDEO=y
+# CONFIG_VIDEO_FSL_DCU_FB is not set
+# CONFIG_VIDEO is not set
 # CONFIG_VIDEO_SW_CURSOR is not set
configs/ls1021atwr_qspi_defconfig +2 -2
index 767c364b3e..2b117304df 100644
@@ -68,6 +68,6 @@ CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
-CONFIG_VIDEO_FSL_DCU_FB=y
-CONFIG_VIDEO=y
+# CONFIG_VIDEO_FSL_DCU_FB is not set
+# CONFIG_VIDEO is not set
 # CONFIG_VIDEO_SW_CURSOR is not set
configs/ls1021atwr_sdcard_ifc_SECURE_BOOT_defconfig +2 -2
index 5b3ac2a348..70154bca0d 100644
@@ -75,8 +75,8 @@ CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
-CONFIG_VIDEO_FSL_DCU_FB=y
-CONFIG_VIDEO=y
+# CONFIG_VIDEO_FSL_DCU_FB is not set
+# CONFIG_VIDEO is not set
 # CONFIG_VIDEO_SW_CURSOR is not set
 CONFIG_RSA=y
 CONFIG_SPL_RSA=y
configs/ls1021atwr_sdcard_ifc_defconfig +2 -2
index 5cc0b90aa7..af2b5aafac 100644
@@ -78,6 +78,6 @@ CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
-CONFIG_VIDEO_FSL_DCU_FB=y
-CONFIG_VIDEO=y
+# CONFIG_VIDEO_FSL_DCU_FB is not set
+# CONFIG_VIDEO is not set
 # CONFIG_VIDEO_SW_CURSOR is not set
configs/ls1021atwr_sdcard_qspi_defconfig +2 -2
index e3e64f9790..dd80eb4a60 100644
@@ -79,6 +79,6 @@ CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
-CONFIG_VIDEO_FSL_DCU_FB=y
-CONFIG_VIDEO=y
+# CONFIG_VIDEO_FSL_DCU_FB is not set
+# CONFIG_VIDEO is not set
 # CONFIG_VIDEO_SW_CURSOR is not set
Signature · 1 line
2.17.1
#14 lore raw

PATCH 1/1 ls1021atwr: disable obsolete VIDEO config

Quoted 12 lines · On Sun, 18 Oct 2020 21:18:22 +0200 Anatolij Gustschin agust at denx.de wrote:

DM_VIDEO conversion deadline has passed, disable VIDEO config.

---
 configs/ls1021atwr_nor_SECURE_BOOT_defconfig        | 4 ++--
 configs/ls1021atwr_nor_defconfig                    | 4 ++--
 configs/ls1021atwr_nor_lpuart_defconfig             | 4 ++--
 configs/ls1021atwr_qspi_defconfig                   | 4 ++--
 configs/ls1021atwr_sdcard_ifc_SECURE_BOOT_defconfig | 4 ++--
 configs/ls1021atwr_sdcard_ifc_defconfig             | 4 ++--
 configs/ls1021atwr_sdcard_qspi_defconfig            | 4 ++--
 7 files changed, 14 insertions(+), 14 deletions(-)

Applied to u-boot-video/master.

#15 lore raw

PATCH 1/1 mx23evk: disable obsolete VIDEO config

In reply to Anatolij Gustschin

DM_VIDEO conversion deadline has passed, disable VIDEO config.

---
 configs/mx23evk_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configs/mx23evk_defconfig +1 -1
index a5f7cc7f97..73d7e9b358 100644
@@ -37,7 +37,7 @@ CONFIG_CONS_INDEX=0
 CONFIG_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_STORAGE=y
-CONFIG_VIDEO=y
+# CONFIG_VIDEO is not set
 CONFIG_SPLASH_SCREEN=y
 CONFIG_VIDEO_BMP_GZIP=y
 CONFIG_VIDEO_BMP_RLE8=y
Signature · 1 line
2.17.1
#16 lore raw

PATCH 1/1 mx23evk: disable obsolete VIDEO config

Quoted 7 lines · On Sun, 18 Oct 2020 21:18:23 +0200 Anatolij Gustschin agust at denx.de wrote:

DM_VIDEO conversion deadline has passed, disable VIDEO config.

---
 configs/mx23evk_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to u-boot-video/master.

#17 lore raw

PATCH 1/1 nokia_rx51: disable obsolete VIDEO config

In reply to Anatolij Gustschin

DM_VIDEO conversion deadline has passed, disable VIDEO config.

---
 configs/nokia_rx51_defconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
configs/nokia_rx51_defconfig +2 -2
index e249dff774..3310bc7ae9 100644
@@ -54,8 +54,8 @@ CONFIG_USB_MUSB_HCD=y
 CONFIG_USB_MUSB_UDC=y
 CONFIG_USB_OMAP3=y
 CONFIG_TWL4030_USB=y
-CONFIG_VIDEO=y
-CONFIG_CFB_CONSOLE_ANSI=y
+# CONFIG_VIDEO is not set
+# CONFIG_CFB_CONSOLE_ANSI is not set
 # CONFIG_VGA_AS_SINGLE_DEVICE is not set
 CONFIG_SPLASH_SCREEN=y
 # CONFIG_GZIP is not set
Signature · 1 line
2.17.1
#18 lore raw

PATCH 1/1 nokia_rx51: disable obsolete VIDEO config

Quoted 13 lines · On Sunday 18 October 2020 21:18:24 Anatolij Gustschin wrote:

DM_VIDEO conversion deadline has passed, disable VIDEO config.

---
 configs/nokia_rx51_defconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
configs/nokia_rx51_defconfig +0 -0
index e249dff774..3310bc7ae9 100644

configs/nokia_rx51_defconfig CONFIG_USB_MUSB_HCD=y · line 58

Quoted 5 lines
configs/nokia_rx51_defconfig +0 -2
@@ -54,8 +54,8 @@ CONFIG_USB_MUSB_HCD=y
 CONFIG_USB_MUSB_UDC=y
 CONFIG_USB_OMAP3=y
 CONFIG_TWL4030_USB=y
-CONFIG_VIDEO=y
-CONFIG_CFB_CONSOLE_ANSI=y

Please, do not disable CONFIG_CFB_CONSOLE_ANSI, it will make debugging on real Nokia N900 very hard...

Quoted 8 lines
configs/nokia_rx51_defconfig +2 -0
+# CONFIG_VIDEO is not set
+# CONFIG_CFB_CONSOLE_ANSI is not set
 # CONFIG_VGA_AS_SINGLE_DEVICE is not set
 CONFIG_SPLASH_SCREEN=y
 # CONFIG_GZIP is not set
Signature · 1 line
2.17.1
#19 lore raw

PATCH 1/1 nokia_rx51: disable obsolete VIDEO config

Quoted 5 lines · On Sun, 18 Oct 2020 22:41:30 +0200 Pali Roh?r pali at kernel.org wrote:

configs/nokia_rx51_defconfig CONFIG_USB_MUSB_HCD=y · line 58

Quoted 2 lines
configs/nokia_rx51_defconfig +0 -2
-CONFIG_VIDEO=y
-CONFIG_CFB_CONSOLE_ANSI=y  

Please, do not disable CONFIG_CFB_CONSOLE_ANSI, it will make debugging on real Nokia N900 very hard...

the patch completely disables video console support, so there is no use for CONFIG_CFB_CONSOLE_ANSI. The reason is that it has not been converted to DM_VIDEO. The conversion deadline was 2019.07 an nobody cared to do it, so I'm going to apply the patch for v2021.01. If you need video console support, then please convert to DM_VIDEO.

Thanks,
Anatolij

#20 lore raw

PATCH 1/1 nokia_rx51: disable obsolete VIDEO config

Quoted 1 line · On Sunday 18 October 2020 22:54:41 Anatolij Gustschin wrote:

If you need video console support, then please convert to DM_VIDEO.

Ok, but I'm waiting until other N900 issues are fixed. There are pending patches which needs to be reviewed and merged.

Without video console support it is hard and probably impossible to debug on real N900.

So do not disable video console support, it would make fixing and testing N900 stuff just more complicated.

#21 lore raw

PATCH 1/1 nokia_rx51: disable obsolete VIDEO config

Quoted 5 lines · Pali Roh?r
Quoted 1 line · On Sunday 18 October 2020 22:54:41 Anatolij Gustschin wrote:

If you need video console support, then please convert to DM_VIDEO.

Ok, but I'm waiting until other N900 issues are fixed. There are pending patches which needs to be reviewed and merged.

Can you please list which? And is that all of them or are there other issues still?

Quoted 5 lines

Without video console support it is hard and probably impossible to debug on real N900.

So do not disable video console support, it would make fixing and testing N900 stuff just more complicated.

Then please see about converting the video driver, on top of the other patches. Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201018/f1e51367/attachment.sig>
#22 lore raw

PATCH 1/1 nokia_rx51: disable obsolete VIDEO config

Hello!

Quoted 8 lines · On Sunday 18 October 2020 21:17:43 Tom Rini wrote:
Quoted 5 lines · Pali Roh?r
Quoted 1 line · On Sunday 18 October 2020 22:54:41 Anatolij Gustschin wrote:

If you need video console support, then please convert to DM_VIDEO.

Ok, but I'm waiting until other N900 issues are fixed. There are pending patches which needs to be reviewed and merged.

Can you please list which?

U-Boot is crashing and board is automatically rebooted:

https://lists.denx.de/pipermail/u-boot/2020-August/422968.html

Last email in that thread:

https://lists.denx.de/pipermail/u-boot/2020-September/427704.html

Quoted 2 lines

And is that all of them or are there other
issues still?

Except above, there is another issue with i2c, details are here:

https://lists.denx.de/pipermail/u-boot/2020-April/408526.html

(but even without fixing this issue U-Boot works and can boot kernel, just it is slower)

Quoted 11 lines
Quoted 5 lines

Without video console support it is hard and probably impossible to debug on real N900.

So do not disable video console support, it would make fixing and testing N900 stuff just more complicated.

Then please see about converting the video driver, on top of the other patches. Thanks!

Signature · 1 line
Tom
#23 lore raw

PATCH 1/1 nokia_rx51: disable obsolete VIDEO config

Quoted 12 lines · Pali Roh?r

Hello!

Quoted 8 lines · On Sunday 18 October 2020 21:17:43 Tom Rini wrote:
Quoted 5 lines · Pali Roh?r
Quoted 1 line · On Sunday 18 October 2020 22:54:41 Anatolij Gustschin wrote:

If you need video console support, then please convert to DM_VIDEO.

Ok, but I'm waiting until other N900 issues are fixed. There are pending patches which needs to be reviewed and merged.

Can you please list which?

Quoted 7 lines

U-Boot is crashing and board is automatically rebooted:

https://lists.denx.de/pipermail/u-boot/2020-August/422968.html

Last email in that thread:

https://lists.denx.de/pipermail/u-boot/2020-September/427704.html

So there's the unresolved MMC issue, but you can work-around that it sounded like?

Quoted 18 lines
Quoted 2 lines

And is that all of them or are there other
issues still?

Except above, there is another issue with i2c, details are here:

https://lists.denx.de/pipermail/u-boot/2020-April/408526.html

(but even without fixing this issue U-Boot works and can boot kernel, just it is slower)

Quoted 8 lines
Quoted 5 lines

Without video console support it is hard and probably impossible to debug on real N900.

So do not disable video console support, it would make fixing and testing N900 stuff just more complicated.

Then please see about converting the video driver, on top of the other patches. Thanks!

So, perhaps another way to look at this (and the rest of the series) is, Anatolij, what needs updating for these platforms? Is it that no DM conversion has been done for them, or not enabling CONFIG_DM_VIDEO? It looks like for the nokia_rx51 there's no CONFIG_DM conversion done at
all yet, which is the bigger problem. But what about sunxi? Is there
some video specific conversions that need to happen, or just enabling different options once DM is enabled? Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201020/575f09e5/attachment.sig>
#24 lore raw

PATCH 1/1 nokia_rx51: disable obsolete VIDEO config

On Tue, 20 Oct 2020 10:17:07 -0400
Tom Rini trini at konsulko.com wrote:
...

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines

Without video console support it is hard and probably impossible to debug on real N900.

So do not disable video console support, it would make fixing and testing N900 stuff just more complicated.

Quoted 6 lines
Quoted 2 lines
Quoted 2 lines

Then please see about converting the video driver, on top of the other patches. Thanks!

So, perhaps another way to look at this (and the rest of the series) is, Anatolij, what needs updating for these platforms? Is it that no DM conversion has been done for them, or not enabling CONFIG_DM_VIDEO?

for at91sam9, ls1021aqds, ls1021atwr, mx6sxsabresd, mx7dsabresd and many sunxi boards DM_VIDEO conversion is missing.

nokia_rx51 has DM disabled, so this is a bigger problem. And CONFIG_VIDEO can be disabled for nokia_rx51 if we remove CFB_CONSOLE CONFIG_VIDEO dependency in Kconfig, it seems. This board doesn't use display controller driver, it just configures fixed frame buffer address for CFB_CONSOLE.

No DM yet: mx23evk, sansa_fuze_plus, xfi3

Quoted 4 lines

It looks like for the nokia_rx51 there's no CONFIG_DM conversion done at
all yet, which is the bigger problem. But what about sunxi? Is there
some video specific conversions that need to happen, or just enabling different options once DM is enabled? Thanks!

for many sunxi variants DM_VIDEO conversion is missing. Jagan did a patch [1], but there are some simplefb related issues with it.

[1] http://patchwork.ozlabs.org/project/uboot/patch/20200617202437.301108-4-jagan at amarulasolutions.com

--
Anatolij

#25 lore raw

PATCH 1/1 nokia_rx51: disable obsolete VIDEO config

In reply to Tom Rini
Quoted 15 lines · On Tuesday 20 October 2020 10:17:07 Tom Rini wrote:
Quoted 14 lines · Pali Roh?r

Hello!

Quoted 8 lines · On Sunday 18 October 2020 21:17:43 Tom Rini wrote:
Quoted 5 lines · Pali Roh?r
Quoted 1 line · On Sunday 18 October 2020 22:54:41 Anatolij Gustschin wrote:

If you need video console support, then please convert to DM_VIDEO.

Ok, but I'm waiting until other N900 issues are fixed. There are pending patches which needs to be reviewed and merged.

Can you please list which?

U-Boot is crashing and board is automatically rebooted:

Quoted 8 lines
Quoted 5 lines

https://lists.denx.de/pipermail/u-boot/2020-August/422968.html

Last email in that thread:

https://lists.denx.de/pipermail/u-boot/2020-September/427704.html

So there's the unresolved MMC issue, but you can work-around that it sounded like?

Yes, there is mmc issue, I have found which commit caused it and because nobody was able to debug / understand what is happening I have sent revert patch, which fixes that issue, until somebody solve issue in original patch.

But I do not see any progress on either applying revert patch or fixing original patch.

And I do not like to have custom patch in my local branch (and periodically rebasing it) as it just another layer of complication.

Could we move somehow in this issue?

#26 lore raw

PATCH 1/1 nokia_rx51: disable obsolete VIDEO config

Quoted 30 lines · Pali Roh?r
Quoted 15 lines · On Tuesday 20 October 2020 10:17:07 Tom Rini wrote:
Quoted 14 lines · Pali Roh?r

Hello!

Quoted 8 lines · On Sunday 18 October 2020 21:17:43 Tom Rini wrote:
Quoted 5 lines · Pali Roh?r
Quoted 1 line · On Sunday 18 October 2020 22:54:41 Anatolij Gustschin wrote:

If you need video console support, then please convert to DM_VIDEO.

Ok, but I'm waiting until other N900 issues are fixed. There are pending patches which needs to be reviewed and merged.

Can you please list which?

U-Boot is crashing and board is automatically rebooted:

Quoted 8 lines
Quoted 5 lines

https://lists.denx.de/pipermail/u-boot/2020-August/422968.html

Last email in that thread:

https://lists.denx.de/pipermail/u-boot/2020-September/427704.html

So there's the unresolved MMC issue, but you can work-around that it sounded like?

Yes, there is mmc issue, I have found which commit caused it and because nobody was able to debug / understand what is happening I have sent revert patch, which fixes that issue, until somebody solve issue in original patch.

Quoted 7 lines

But I do not see any progress on either applying revert patch or fixing original patch.

And I do not like to have custom patch in my local branch (and periodically rebasing it) as it just another layer of complication.

Could we move somehow in this issue?

No, it's probably stuck until you can fix the problem or otherwise add a "quirk" for your platform. What does Linux do in this case?

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201021/ccaa32bf/attachment.sig>
#27 lore raw

PATCH 1/1 nokia_rx51: disable obsolete VIDEO config

Quoted 34 lines · On Wednesday 21 October 2020 08:47:02 Tom Rini wrote:
Quoted 33 lines · Pali Roh?r
Quoted 15 lines · On Tuesday 20 October 2020 10:17:07 Tom Rini wrote:
Quoted 14 lines · Pali Roh?r

Hello!

Quoted 8 lines · On Sunday 18 October 2020 21:17:43 Tom Rini wrote:
Quoted 5 lines · Pali Roh?r
Quoted 1 line · On Sunday 18 October 2020 22:54:41 Anatolij Gustschin wrote:

If you need video console support, then please convert to DM_VIDEO.

Ok, but I'm waiting until other N900 issues are fixed. There are pending patches which needs to be reviewed and merged.

Can you please list which?

U-Boot is crashing and board is automatically rebooted:

Quoted 8 lines
Quoted 5 lines

https://lists.denx.de/pipermail/u-boot/2020-August/422968.html

Last email in that thread:

https://lists.denx.de/pipermail/u-boot/2020-September/427704.html

So there's the unresolved MMC issue, but you can work-around that it sounded like?

Yes, there is mmc issue, I have found which commit caused it and because nobody was able to debug / understand what is happening I have sent revert patch, which fixes that issue, until somebody solve issue in original patch.

But I do not see any progress on either applying revert patch or fixing original patch.

Quoted 7 lines
Quoted 4 lines

And I do not like to have custom patch in my local branch (and periodically rebasing it) as it just another layer of complication.

Could we move somehow in this issue?

No, it's probably stuck until you can fix the problem or otherwise add a "quirk" for your platform. What does Linux do in this case?

Well, I provided all requested information, just I'm lacking any new response from developers / maintainers of particular code.

I have already identified problematic place / commit and I have already sent revert patch which fixing this issue.

Tom, what else do you need?

I see the main issue now that nobody reviewed / merged patch and nobody responded to emails which I have sent more then 2 months ago.

A message that is not in the archive (sent off-list or not yet received): [email protected]

#29 lore raw

PATCH 1/1 nokia_rx51: disable obsolete VIDEO config

Quoted 39 lines · Merlijn Wajer

Hi,

Quoted 4 lines · Pali Roh?r
Quoted 3 lines · On Wednesday 21 October 2020 08:47:02 Tom Rini wrote:
Quoted 2 lines · Pali Roh?r
Quoted 1 line · On Tuesday 20 October 2020 10:17:07 Tom Rini wrote:

On Tue, Oct 20, 2020 at 11:30:51AM +0200, Pali Roh?r wrote:

<snip>

Quoted 19 lines
Quoted 8 lines
Quoted 8 lines

Yes, there is mmc issue, I have found which commit caused it and because nobody was able to debug / understand what is happening I have sent revert patch, which fixes that issue, until somebody solve issue in original patch.

But I do not see any progress on either applying revert patch or fixing original patch.

Quoted 7 lines
Quoted 4 lines

And I do not like to have custom patch in my local branch (and periodically rebasing it) as it just another layer of complication.

Could we move somehow in this issue?

No, it's probably stuck until you can fix the problem or otherwise add a "quirk" for your platform. What does Linux do in this case?

Well, I provided all requested information, just I'm lacking any new response from developers / maintainers of particular code.

Quoted 7 lines

I have already identified problematic place / commit and I have already sent revert patch which fixing this issue.

Tom, what else do you need?

I see the main issue now that nobody reviewed / merged patch and nobody responded to emails which I have sent more then 2 months ago.

I would like to add my voice for reverting the patches that break the support, and work from that point to improve support and eventually migrate to DT.

Quoted 6 lines

Maemo Leste has a lot of Nokia N900 users, and this is blocking us from moving to mainline u-boot. Is it possible to get the opinion of the original patch authors on this?

I am set up with a serial module on the Nokia N900, so I can help provide specific debug info.

Let me add in the TI folks that might be able to look in to any of this today. But the next problem is that the rx51 needs to be converted to use DM in U-Boot. It's throwing up a ton of "you need to convert to X by <some release in 2019> or this board may be removed" warnings at build. I really really want to see some of this start to be addressed.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201024/451396d9/attachment.sig>
#30 lore raw

PATCH 1/1 nokia_rx51: disable obsolete VIDEO config

Quoted 5 lines · On Saturday 24 October 2020 08:19:31 Tom Rini wrote:

Let me add in the TI folks that might be able to look in to any of this today. But the next problem is that the rx51 needs to be converted to use DM in U-Boot. It's throwing up a ton of "you need to convert to X by <some release in 2019> or this board may be removed" warnings at build. I really really want to see some of this start to be addressed.

Well, I do not see any warnings at build, I'm building U-Boot by command:

$ make nokia_rx51_defconfig && make SOURCE_DATE_EPOCH=0 ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- u-boot.bin

Maybe I'm doing something wrong that I do not see it? Or is there any other way to "list all issues for N900" which needs to be addressed?

Anyway, I'm looking at DM and as the first step I will do conversion of code to CONFIG_DM_I2C. It is OK for you? Maybe it brings some light to non-working second i2c bus.

I hope that TI (or other) developers look at that mmc issue as this is blocking all N900 users.

#31 lore raw

PATCH 1/1 nokia_rx51: disable obsolete VIDEO config

Quoted 10 lines · Pali Roh?r
Quoted 5 lines · On Saturday 24 October 2020 08:19:31 Tom Rini wrote:

Let me add in the TI folks that might be able to look in to any of this today. But the next problem is that the rx51 needs to be converted to use DM in U-Boot. It's throwing up a ton of "you need to convert to X by <some release in 2019> or this board may be removed" warnings at build. I really really want to see some of this start to be addressed.

Well, I do not see any warnings at build, I'm building U-Boot by command:

$ make nokia_rx51_defconfig && make SOURCE_DATE_EPOCH=0 ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- u-boot.bin

Note that ARCH=arm is meaningless in U-Boot.

Quoted 2 lines

Maybe I'm doing something wrong that I do not see it? Or is there any other way to "list all issues for N900" which needs to be addressed?

Yes, the "all" target.

Quoted 6 lines

Anyway, I'm looking at DM and as the first step I will do conversion of code to CONFIG_DM_I2C. It is OK for you? Maybe it brings some light to non-working second i2c bus.

I hope that TI (or other) developers look at that mmc issue as this is blocking all N900 users.

Maybe converting to DM_MMC will also clear up or shed more light on the problem you have there as well.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201025/2764bd23/attachment.sig>
#32 lore raw

PATCH 1/1 nokia_rx51: disable obsolete VIDEO config

Quoted 10 lines · On Sunday 25 October 2020 19:55:28 Tom Rini wrote:
Quoted 9 lines · Pali Roh?r
Quoted 5 lines · On Saturday 24 October 2020 08:19:31 Tom Rini wrote:

Let me add in the TI folks that might be able to look in to any of this today. But the next problem is that the rx51 needs to be converted to use DM in U-Boot. It's throwing up a ton of "you need to convert to X by <some release in 2019> or this board may be removed" warnings at build. I really really want to see some of this start to be addressed.

Well, I do not see any warnings at build, I'm building U-Boot by command:

Quoted 8 lines
Quoted 1 line
$ make nokia_rx51_defconfig && make SOURCE_DATE_EPOCH=0 ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- u-boot.bin

Note that ARCH=arm is meaningless in U-Boot.

Quoted 2 lines

Maybe I'm doing something wrong that I do not see it? Or is there any other way to "list all issues for N900" which needs to be addressed?

Yes, the "all" target.

Ok, now I see them! I used in all my scripts only u-boot.bin target (as I needed only this one binary), so basically all warnings were perfectly hidden also in past and I did not know about it...

Maybe there are more people who do not know about these warnings? What about printing them as part of u-boot.bin target?

Quoted 12 lines
Quoted 6 lines

Anyway, I'm looking at DM and as the first step I will do conversion of code to CONFIG_DM_I2C. It is OK for you? Maybe it brings some light to non-working second i2c bus.

I hope that TI (or other) developers look at that mmc issue as this is blocking all N900 users.

Maybe converting to DM_MMC will also clear up or shed more light on the problem you have there as well.

Signature · 1 line
Tom
#33 lore raw

PATCH 1/1 nokia_rx51: disable obsolete VIDEO config

Quoted 18 lines · Pali Roh?r
Quoted 17 lines · On Sunday 25 October 2020 19:55:28 Tom Rini wrote:
Quoted 10 lines · Pali Roh?r
Quoted 5 lines · On Saturday 24 October 2020 08:19:31 Tom Rini wrote:

Let me add in the TI folks that might be able to look in to any of this today. But the next problem is that the rx51 needs to be converted to use DM in U-Boot. It's throwing up a ton of "you need to convert to X by <some release in 2019> or this board may be removed" warnings at build. I really really want to see some of this start to be addressed.

Well, I do not see any warnings at build, I'm building U-Boot by command:

$ make nokia_rx51_defconfig && make SOURCE_DATE_EPOCH=0 ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- u-boot.bin

Note that ARCH=arm is meaningless in U-Boot.

Quoted 2 lines

Maybe I'm doing something wrong that I do not see it? Or is there any other way to "list all issues for N900" which needs to be addressed?

Quoted 8 lines
Quoted 1 line

Yes, the "all" target.

Ok, now I see them! I used in all my scripts only u-boot.bin target (as I needed only this one binary), so basically all warnings were perfectly hidden also in past and I did not know about it...

Maybe there are more people who do not know about these warnings? What about printing them as part of u-boot.bin target?

I was wondering about that too, but I'm not sure.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201025/c32dcb6d/attachment-0001.sig>
#34 lore raw

PATCH 1/1 nokia_rx51: disable obsolete VIDEO config

In reply to Pali Rohár

On Mon, 26 Oct 2020 00:04:54 +0100
Pali Roh?r pali at kernel.org wrote:
...

Quoted 2 lines

Maybe I'm doing something wrong that I do not see it? Or is there any other way to "list all issues for N900" which needs to be addressed?

$ ./tools/buildman/buildman nokia_rx51
Building current source for 1 boards (1 thread, 12 jobs per thread)
       arm:  w+   nokia_rx51                
+===================== WARNING ======================
+This board does not use CONFIG_DM. CONFIG_DM will be
+compulsory starting with the v2020.01 release.
+Failure to update may result in board removal.
+See doc/driver-model/migration.rst for more info.
+====================================================
+This board does not use CONFIG_DM_MMC. Please update
+the board to use CONFIG_DM_MMC before the v2019.04 release.
+Failure to update by the deadline may result in board removal.
+This board does not use CONFIG_DM_USB. Please update
+the board to use CONFIG_DM_USB before the v2019.07 release.
+This board does not use CONFIG_DM_VIDEO Please update
+the board to use CONFIG_DM_VIDEO before the v2019.07 release.
+This board does not use CONFIG_WDT (DM watchdog support).
+Please update the board to use CONFIG_WDT before the
+v2019.10 release.
    0    1    0 /1              nokia_rx51
Completed: 1 total built, duration 0:00:04, rate 0.25

--
Anatolij

#35 lore raw

PATCH 1/1 nokia_rx51: disable obsolete VIDEO config

In reply to Tom Rini
Quoted 44 lines · Tom Rini
Quoted 43 lines · Merlijn Wajer

Hi,

Quoted 4 lines · Pali Roh?r
Quoted 3 lines · On Wednesday 21 October 2020 08:47:02 Tom Rini wrote:
Quoted 2 lines · Pali Roh?r
Quoted 1 line · On Tuesday 20 October 2020 10:17:07 Tom Rini wrote:

On Tue, Oct 20, 2020 at 11:30:51AM +0200, Pali Roh?r wrote:

<snip>

Quoted 19 lines
Quoted 8 lines
Quoted 8 lines

Yes, there is mmc issue, I have found which commit caused it and because nobody was able to debug / understand what is happening I have sent revert patch, which fixes that issue, until somebody solve issue in original patch.

But I do not see any progress on either applying revert patch or fixing original patch.

Quoted 7 lines
Quoted 4 lines

And I do not like to have custom patch in my local branch (and periodically rebasing it) as it just another layer of complication.

Could we move somehow in this issue?

No, it's probably stuck until you can fix the problem or otherwise add a "quirk" for your platform. What does Linux do in this case?

Well, I provided all requested information, just I'm lacking any new response from developers / maintainers of particular code.

Quoted 7 lines

I have already identified problematic place / commit and I have already sent revert patch which fixing this issue.

Tom, what else do you need?

I see the main issue now that nobody reviewed / merged patch and nobody responded to emails which I have sent more then 2 months ago.

I would like to add my voice for reverting the patches that break the support, and work from that point to improve support and eventually migrate to DT.

Maemo Leste has a lot of Nokia N900 users, and this is blocking us from moving to mainline u-boot. Is it possible to get the opinion of the original patch authors on this?

Quoted 8 lines
Quoted 2 lines

I am set up with a serial module on the Nokia N900, so I can help provide specific debug info.

Let me add in the TI folks that might be able to look in to any of this today. But the next problem is that the rx51 needs to be converted to use DM in U-Boot. It's throwing up a ton of "you need to convert to X by <some release in 2019> or this board may be removed" warnings at build. I really really want to see some of this start to be addressed.

IIUC, the breakage is happening in non-DM code. I don't think non-DM code is maintained anymore for mmc. As Tom suggested we should start using DM for Nokia RX51

Thanks and regards,
Lokesh

Quoted 1 line
#36 lore raw

PATCH 1/1 nokia_rx51: disable obsolete VIDEO config

Quoted 48 lines · On Thursday 29 October 2020 14:06:30 Lokesh Vutla wrote:
Quoted 47 lines · Tom Rini
Quoted 45 lines · Merlijn Wajer

Hi,

Quoted 4 lines · Pali Roh?r
Quoted 3 lines · On Wednesday 21 October 2020 08:47:02 Tom Rini wrote:
Quoted 2 lines · Pali Roh?r
Quoted 1 line · On Tuesday 20 October 2020 10:17:07 Tom Rini wrote:

On Tue, Oct 20, 2020 at 11:30:51AM +0200, Pali Roh?r wrote:

<snip>

Quoted 19 lines
Quoted 8 lines
Quoted 8 lines

Yes, there is mmc issue, I have found which commit caused it and because nobody was able to debug / understand what is happening I have sent revert patch, which fixes that issue, until somebody solve issue in original patch.

But I do not see any progress on either applying revert patch or fixing original patch.

Quoted 7 lines
Quoted 4 lines

And I do not like to have custom patch in my local branch (and periodically rebasing it) as it just another layer of complication.

Could we move somehow in this issue?

No, it's probably stuck until you can fix the problem or otherwise add a "quirk" for your platform. What does Linux do in this case?

Well, I provided all requested information, just I'm lacking any new response from developers / maintainers of particular code.

Quoted 7 lines

I have already identified problematic place / commit and I have already sent revert patch which fixing this issue.

Tom, what else do you need?

I see the main issue now that nobody reviewed / merged patch and nobody responded to emails which I have sent more then 2 months ago.

I would like to add my voice for reverting the patches that break the support, and work from that point to improve support and eventually migrate to DT.

Maemo Leste has a lot of Nokia N900 users, and this is blocking us from moving to mainline u-boot. Is it possible to get the opinion of the original patch authors on this?

I am set up with a serial module on the Nokia N900, so I can help provide specific debug info.

Quoted 8 lines
Quoted 5 lines

Let me add in the TI folks that might be able to look in to any of this today. But the next problem is that the rx51 needs to be converted to use DM in U-Boot. It's throwing up a ton of "you need to convert to X by <some release in 2019> or this board may be removed" warnings at build. I really really want to see some of this start to be addressed.

IIUC, the breakage is happening in non-DM code.

No, this code is not non-DM specific. It is used also for DM builds.

#37 lore raw

PATCH v2 1/1 nokia_rx51: disable obsolete VIDEO config

In reply to Anatolij Gustschin

Disable VIDEO config to fix DM_VIDEO conversion
deadline warning.

---

Changes in v2:
- select CFB_CONSOLE instead of VIDEO to let video console support enabled

 configs/nokia_rx51_defconfig | 2 +-
 drivers/video/Kconfig        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
configs/nokia_rx51_defconfig +1 -1
index e249dff774..b0a58e5253 100644
@@ -54,7 +54,7 @@ CONFIG_USB_MUSB_HCD=y
 CONFIG_USB_MUSB_UDC=y
 CONFIG_USB_OMAP3=y
 CONFIG_TWL4030_USB=y
-CONFIG_VIDEO=y
+CONFIG_CFB_CONSOLE=y
 CONFIG_CFB_CONSOLE_ANSI=y
 # CONFIG_VGA_AS_SINGLE_DEVICE is not set
 CONFIG_SPLASH_SCREEN=y
drivers/video/Kconfig +1 -1
index 2f3bb4b085..998271b9b6 100644
@@ -665,7 +665,7 @@ config VIDEO
 
 config CFB_CONSOLE
 	bool "Enable colour frame buffer console"
-	depends on VIDEO
+	depends on VIDEO || ARCH_OMAP2PLUS
 	default y if VIDEO
 	help
 	  Enables the colour frame buffer driver. This supports colour
Signature · 1 line
2.17.1
#38 lore raw

PATCH v2 1/1 nokia_rx51: disable obsolete VIDEO config

Quoted 7 lines · On Mon, 26 Oct 2020 19:58:20 +0100 Anatolij Gustschin agust at denx.de wrote:

Disable VIDEO config to fix DM_VIDEO conversion
deadline warning.

---

Quoted 7 lines

Changes in v2:
- select CFB_CONSOLE instead of VIDEO to let video console support enabled

 configs/nokia_rx51_defconfig | 2 +-
 drivers/video/Kconfig        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Applied to u-boot-video/master.

#39 lore raw

PATCH v2 1/1 nokia_rx51: disable obsolete VIDEO config

In reply to Anatolij Gustschin
Quoted 20 lines · On Monday 26 October 2020 19:58:20 Anatolij Gustschin wrote:

Disable VIDEO config to fix DM_VIDEO conversion
deadline warning.

---

Changes in v2:
- select CFB_CONSOLE instead of VIDEO to let video console support enabled

 configs/nokia_rx51_defconfig | 2 +-
 drivers/video/Kconfig        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
configs/nokia_rx51_defconfig +0 -0
index e249dff774..b0a58e5253 100644

configs/nokia_rx51_defconfig CONFIG_USB_MUSB_HCD=y · line 60

Quoted 8 lines
configs/nokia_rx51_defconfig +1 -1
@@ -54,7 +54,7 @@ CONFIG_USB_MUSB_HCD=y
 CONFIG_USB_MUSB_UDC=y
 CONFIG_USB_OMAP3=y
 CONFIG_TWL4030_USB=y
-CONFIG_VIDEO=y
+CONFIG_CFB_CONSOLE=y
 CONFIG_CFB_CONSOLE_ANSI=y
 # CONFIG_VGA_AS_SINGLE_DEVICE is not set
 CONFIG_SPLASH_SCREEN=y

Hello! This change is disabling CONFIG_CONSOLE_MUX option.

Could you please do not disable it? It is needed for debugging via qemu:
https://gitlab.denx.de/u-boot/u-boot/-/commit/07693ccb1574adecb9e87756339442955aeaf346

Here is difference of .config file without (.old) and with your patch:

.config renamed from .config.old +3 -6
@@ -322,8 +322,8 @@ CONFIG_SPL_LOGLEVEL=4
 CONFIG_TPL_LOGLEVEL=4
 # CONFIG_SILENT_CONSOLE is not set
 # CONFIG_PRE_CONSOLE_BUFFER is not set
-CONFIG_CONSOLE_MUX=y
-CONFIG_SYS_CONSOLE_IS_IN_ENV=y
+# CONFIG_CONSOLE_MUX is not set
+# CONFIG_SYS_CONSOLE_IS_IN_ENV is not set
 # CONFIG_SYS_CONSOLE_OVERWRITE_ROUTINE is not set
 # CONFIG_SYS_CONSOLE_ENV_OVERWRITE is not set
 # CONFIG_SYS_CONSOLE_INFO_QUIET is not set
@@ -532,7 +532,6 @@ CONFIG_CMD_SOURCE=y
 #
 # Misc commands
 #
-# CONFIG_CMD_BMP is not set
 # CONFIG_CMD_BSP is not set
 # CONFIG_CMD_CACHE is not set
 # CONFIG_CMD_CONITRACE is not set
@@ -1074,16 +1073,14 @@ CONFIG_TWL4030_USB=y
 # CONFIG_VIDEO_VESA is not set
 # CONFIG_VIDEO_LCD_ANX9804 is not set
 # CONFIG_VIDEO_LCD_SSD2828 is not set
-# CONFIG_VIDEO_LCD_HITACHI_TX18D42VM is not set
 # CONFIG_VIDEO_MVEBU is not set
 # CONFIG_VIDEO_OMAP3 is not set
 # CONFIG_I2C_EDID is not set
 # CONFIG_DISPLAY is not set
 # CONFIG_ATMEL_HLCD is not set
 # CONFIG_AM335X_LCD is not set
-# CONFIG_VIDEO_FSL_DCU_FB is not set
 # CONFIG_VIDEO_BRIDGE is not set
-CONFIG_VIDEO=y
+# CONFIG_VIDEO is not set
 CONFIG_CFB_CONSOLE=y
 CONFIG_CFB_CONSOLE_ANSI=y
 # CONFIG_VGA_AS_SINGLE_DEVICE is not set
Quoted 16 lines
drivers/video/Kconfig +1 -1
index 2f3bb4b085..998271b9b6 100644
@@ -665,7 +665,7 @@ config VIDEO
 
 config CFB_CONSOLE
 	bool "Enable colour frame buffer console"
-	depends on VIDEO
+	depends on VIDEO || ARCH_OMAP2PLUS
 	default y if VIDEO
 	help
 	  Enables the colour frame buffer driver. This supports colour
Signature · 1 line
2.17.1
#40 lore raw

PATCH v2 1/1 nokia_rx51: disable obsolete VIDEO config

On Tue, 27 Oct 2020 00:51:29 +0100
Pali Roh?r pali at kernel.org wrote:
...

Quoted 4 lines

Hello! This change is disabling CONFIG_CONSOLE_MUX option.

Could you please do not disable it? It is needed for debugging via qemu:
https://gitlab.denx.de/u-boot/u-boot/-/commit/07693ccb1574adecb9e87756339442955aeaf346

This was auto-selected by CONFIG_VIDEO, so now we have to enable it explicitly. I'll send a patch.

--
Anatolij

#41 lore raw

PATCH v2 1/1 nokia_rx51: disable obsolete VIDEO config

Quoted 10 lines · On Tuesday 27 October 2020 08:17:13 Anatolij Gustschin wrote:

On Tue, 27 Oct 2020 00:51:29 +0100
Pali Roh?r pali at kernel.org wrote:
...

Quoted 4 lines

Hello! This change is disabling CONFIG_CONSOLE_MUX option.

Could you please do not disable it? It is needed for debugging via qemu:
https://gitlab.denx.de/u-boot/u-boot/-/commit/07693ccb1574adecb9e87756339442955aeaf346

This was auto-selected by CONFIG_VIDEO, so now we have to enable it explicitly. I'll send a patch.

I have already did in above mentioned patch...

#42 lore raw

PATCH v2 1/1 nokia_rx51: disable obsolete VIDEO config

On Tue, 27 Oct 2020 09:42:50 +0100
Pali Roh?r pali at kernel.org wrote:
...

Quoted 4 lines
Quoted 2 lines

This was auto-selected by CONFIG_VIDEO, so now we have to enable it explicitly. I'll send a patch.

I have already did in above mentioned patch...

yes, but it was dropped in commit 585da32f4ced since it was auto- selected with CONFIG_VIDEO defined.

--
Anatolij

#43 lore raw

PATCH 1/1 picosam9g45: disable obsolete VIDEO config

In reply to Anatolij Gustschin

DM_VIDEO conversion deadline has passed, disable VIDEO config.

---
 configs/picosam9g45_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configs/picosam9g45_defconfig +1 -1
index 5ffbee8e41..081c2a9b8e 100644
@@ -44,7 +44,7 @@ CONFIG_ATMEL_USART=y
 CONFIG_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_STORAGE=y
-CONFIG_LCD=y
+# CONFIG_LCD is not set
 CONFIG_WDT=y
 CONFIG_WDT_AT91=y
 CONFIG_OF_LIBFDT=y
Signature · 1 line
2.17.1
#44 lore raw

PATCH 1/1 picosam9g45: disable obsolete VIDEO config

Quoted 7 lines · On Sun, 18 Oct 2020 21:18:25 +0200 Anatolij Gustschin agust at denx.de wrote:

DM_VIDEO conversion deadline has passed, disable VIDEO config.

---
 configs/picosam9g45_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to u-boot-video/master.

#45 lore raw

PATCH 1/1 sansa_fuze_plus: disable obsolete VIDEO config

In reply to Anatolij Gustschin

DM_VIDEO conversion deadline has passed, disable VIDEO config.

---
 configs/sansa_fuze_plus_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configs/sansa_fuze_plus_defconfig +1 -1
index 0c3296046f..7a41f990bf 100644
@@ -44,5 +44,5 @@ CONFIG_USB_GADGET=y
 CONFIG_CI_UDC=y
 CONFIG_USB_ETHER=y
 CONFIG_USB_ETH_CDC=y
-CONFIG_VIDEO=y
+# CONFIG_VIDEO is not set
 CONFIG_OF_LIBFDT=y
Signature · 1 line
2.17.1
#46 lore raw

PATCH 1/1 sansa_fuze_plus: disable obsolete VIDEO config

Quoted 7 lines · On Sun, 18 Oct 2020 21:18:26 +0200 Anatolij Gustschin agust at denx.de wrote:

DM_VIDEO conversion deadline has passed, disable VIDEO config.

---
 configs/sansa_fuze_plus_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to u-boot-video/master.

#47 lore raw

PATCH 1/1 xfi3: disable obsolete VIDEO config

In reply to Anatolij Gustschin

DM_VIDEO conversion deadline has passed, disable VIDEO config.

---
 configs/xfi3_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configs/xfi3_defconfig +1 -1
index a943354903..9d895f87e6 100644
@@ -41,5 +41,5 @@ CONFIG_USB_GADGET=y
 CONFIG_CI_UDC=y
 CONFIG_USB_ETHER=y
 CONFIG_USB_ETH_CDC=y
-CONFIG_VIDEO=y
+# CONFIG_VIDEO is not set
 CONFIG_OF_LIBFDT=y
Signature · 1 line
2.17.1
#48 lore raw

PATCH 1/1 xfi3: disable obsolete VIDEO config

Quoted 7 lines · On Sun, 18 Oct 2020 21:18:27 +0200 Anatolij Gustschin agust at denx.de wrote:

DM_VIDEO conversion deadline has passed, disable VIDEO config.

---
 configs/xfi3_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to u-boot-video/master.

#49 lore raw

PATCH 1/1 arm: sunxi: disable obsolete VIDEO config

In reply to Anatolij Gustschin
Quoted 16 lines · Anatolij Gustschin

DM_VIDEO conversion deadline has passed, disable VIDEO config option by default. Boards should convert to DM_VIDEO if they need video console support.

---
 arch/arm/mach-sunxi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-sunxi/Kconfig +0 -0
index be0822bfb7..f672bb8b4e 100644

arch/arm/mach-sunxi/Kconfig config VIDEO_SUNXI · line 763

Quoted 5 lines
arch/arm/mach-sunxi/Kconfig +1 -1
@@ -760,7 +760,7 @@ config VIDEO_SUNXI
 	depends on !MACH_SUN50I_H6
 	select VIDEO
 	imply VIDEO_DT_SIMPLEFB
-	default y
+	default n

default n is the default with Kconfig iirc

Otherwise, I can't say that I agree with the forced conversion strategy to the DM in general. We're struggling to keep U-Boot working from one release to the other, so adding pressure to convert drivers feels a bit too much.

I can see where you're coming from though, so I guess that's a reluctantly-acked-by ? :)

Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201019/438fe163/attachment.sig>

#50 lore raw

PATCH 1/1 arm: sunxi: disable obsolete VIDEO config

Quoted 25 lines · Maxime Ripard
Quoted 16 lines · Anatolij Gustschin

DM_VIDEO conversion deadline has passed, disable VIDEO config option by default. Boards should convert to DM_VIDEO if they need video console support.

---
 arch/arm/mach-sunxi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-sunxi/Kconfig +0 -0
index be0822bfb7..f672bb8b4e 100644

arch/arm/mach-sunxi/Kconfig config VIDEO_SUNXI · line 763

Quoted 5 lines
arch/arm/mach-sunxi/Kconfig +1 -1
@@ -760,7 +760,7 @@ config VIDEO_SUNXI
 	depends on !MACH_SUN50I_H6
 	select VIDEO
 	imply VIDEO_DT_SIMPLEFB
-	default y
+	default n

default n is the default with Kconfig iirc

Quoted 7 lines

Otherwise, I can't say that I agree with the forced conversion strategy to the DM in general. We're struggling to keep U-Boot working from one release to the other, so adding pressure to convert drivers feels a bit too much.

I can see where you're coming from though, so I guess that's a reluctantly-acked-by ? :)

Can you please elaborate on your struggles? The only thing right now keeping me from having some sunxi target in my HW CI loop is I didn't have anything that wasn't leaking in power via UART, even, seemingly. Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201019/bdeaa92f/attachment.sig>
#51 lore raw

PATCH 1/1 arm: sunxi: disable obsolete VIDEO config

Quoted 31 lines · Tom Rini
Quoted 30 lines · Maxime Ripard
Quoted 16 lines · Anatolij Gustschin

DM_VIDEO conversion deadline has passed, disable VIDEO config option by default. Boards should convert to DM_VIDEO if they need video console support.

---
 arch/arm/mach-sunxi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-sunxi/Kconfig +0 -0
index be0822bfb7..f672bb8b4e 100644

arch/arm/mach-sunxi/Kconfig config VIDEO_SUNXI · line 763

Quoted 5 lines
arch/arm/mach-sunxi/Kconfig +1 -1
@@ -760,7 +760,7 @@ config VIDEO_SUNXI
 	depends on !MACH_SUN50I_H6
 	select VIDEO
 	imply VIDEO_DT_SIMPLEFB
-	default y
+	default n

default n is the default with Kconfig iirc

Otherwise, I can't say that I agree with the forced conversion strategy to the DM in general. We're struggling to keep U-Boot working from one release to the other, so adding pressure to convert drivers feels a bit too much.

Quoted 4 lines
Quoted 2 lines

I can see where you're coming from though, so I guess that's a reluctantly-acked-by ? :)

Can you please elaborate on your struggles?

I'm sure that the fact that we don't have a lot of time is part of that reason really, but it seems that the forced (or at least strongly encouraged) conversion to Kconfig and the device model created a lot of reworks that in turn created some regressions.

Even though they are to be expected in every patch, it looks to me that the forced conversion encouraged people to create patches that were not properly tested on every platform. So we ended up with more patches, and a higher probability of breakage.

For example, I've recently discovered that since at least 2020.01 we have a regression in our musb setup, where we used to be able to just use a USB gadget right away, but it looks like now we have to use usb reset. I haven't had the time to look into why yet.

Some boards also have lost ethernet for a while too because it turns out that the generic PHY reset bindings aren't supported by the the designware net driver and when we changed for those bindings, and then sync'd the DTS between linux and u-boot, then the PHY wasn't reset properly anymore (I do have a patch for that one though).

It feels like almost every release is broken in some new way, and it's hard to just keep up.

Ultimately, I think that this is mostly due to us not having enough time to test and debug each release. If someone with some knowledge of Allwinner SoCs was willing to step up and take over my seat, then I'd be more than happy to help with the transition.

Quoted 3 lines

The only thing right now keeping me from having some sunxi target in my HW CI loop is I didn't have anything that wasn't leaking in power via UART, even, seemingly. Thanks!

Yeah, the older one especially are pretty bad for that. Which one do you have?

Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201027/99054b38/attachment.sig>

#52 lore raw

PATCH 1/1 arm: sunxi: disable obsolete VIDEO config

In reply to Anatolij Gustschin
Quoted 17 lines · Anatolij Gustschin

DM_VIDEO conversion deadline has passed, disable VIDEO config option by default. Boards should convert to DM_VIDEO if they need video console support.

---
 arch/arm/mach-sunxi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-sunxi/Kconfig +0 -0
index be0822bfb7..f672bb8b4e 100644

arch/arm/mach-sunxi/Kconfig config VIDEO_SUNXI · line 763

Quoted 5 lines
arch/arm/mach-sunxi/Kconfig +1 -1
@@ -760,7 +760,7 @@ config VIDEO_SUNXI
        depends on !MACH_SUN50I_H6
        select VIDEO
        imply VIDEO_DT_SIMPLEFB
-       default y
+       default n

Any possibility to wait for the last RC? I have patched before[1] for DM_VIDEO, now need some time to refine it.

https://patchwork.ozlabs.org/project/uboot/cover/20200617202437.301108-1-jagan at amarulasolutions.com/

Jagan.

#53 lore raw

PATCH 1/1 arm: sunxi: disable obsolete VIDEO config

On Thu, 22 Oct 2020 00:34:06 +0530
Jagan Teki jagan at amarulasolutions.com wrote:
...

Quoted 2 lines

Any possibility to wait for the last RC? I have patched before[1] for DM_VIDEO, now need some time to refine it.

we can wait, it would be good to get it done in v2020.01.

--
Anatolij